From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 References: <51491585-16fb-93b1-bb1a-09e89683f2f0@cogentembedded.com> <1ef39615-fc82-dc2a-05eb-7b1aed7afa98@cogentembedded.com> In-Reply-To: <1ef39615-fc82-dc2a-05eb-7b1aed7afa98@cogentembedded.com> From: Geert Uytterhoeven Date: Mon, 8 Oct 2018 18:40:45 +0200 Message-ID: Subject: Re: [PATCH] arm64: dts: renesas: r8a77970: add thermal support Content-Type: text/plain; charset="UTF-8" To: Sergei Shtylyov Cc: Simon Horman , Rob Herring , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Magnus Damm , Mark Rutland List-ID: Hi Sergei, On Mon, Oct 8, 2018 at 6:35 PM Sergei Shtylyov wrote: > On 10/08/2018 11:12 AM, Geert Uytterhoeven wrote: > >> Describe THS/CIVM in the R8A77970 device trees. > >> Based on the original (and large) patches by Vladimir Barinov. > >> > >> Signed-off-by: Vladimir Barinov > >> Signed-off-by: Sergei Shtylyov > >> > >> --- > >> This patch is against the 'renesas-devel-20181004-v4.19-rc6' tag of Simon > >> Horman's 'renesas.git' repo. > >> > >> The thermal driver/bindings patches have been posted yesterday... > >> > >> arch/arm64/boot/dts/renesas/r8a77970.dtsi | 32 ++++++++++++++++++++++++++++++ > >> 1 file changed, 32 insertions(+) > >> > >> Index: renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi > >> =================================================================== > >> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970.dtsi > >> +++ renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi > >> @@ -300,6 +300,19 @@ > >> #power-domain-cells = <1>; > >> }; > >> > >> + thermal: thermal@e6190000 { > >> + compatible = "renesas,thermal-r8a77970"; > >> + reg = <0 0xe6190000 0 0x14 > > > > 0x14 was appropriate for R-Mobile APE6... > > Copy&paste is to blame here, I guess... I'll fix to 0x10. OK. > >> + 0 0xe6190100 0 0x38>; > > > > What about the CIVM status register? DT describes hardware, not driver > > limitations. > > I wasn't sure whether to put it into a separate "reg" tuple (which would confuse > the driver) or not. After looking into the manual again, I'm going to extend the > 2nd "reg" tuple... The CIVM Status Register indicates the chip internal voltage. As such it's not a per-channel property, and IMHO doesn't belong in the second tuple (e.g. R-Mobile APE6 has 3 channels). Perhaps extending the bindings to handle more reg tuples, possibly using reg-names? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds