From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F938C47078 for ; Fri, 21 May 2021 15:04:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56349613AF for ; Fri, 21 May 2021 15:04:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237275AbhEUPGD (ORCPT ); Fri, 21 May 2021 11:06:03 -0400 Received: from mail-vs1-f42.google.com ([209.85.217.42]:33330 "EHLO mail-vs1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232206AbhEUPF5 (ORCPT ); Fri, 21 May 2021 11:05:57 -0400 Received: by mail-vs1-f42.google.com with SMTP id f11so10532033vst.0; Fri, 21 May 2021 08:04:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PXuG7KOO5W95jEf2lKiMIqjS8B2a0VXsDtOORCzbLU4=; b=W1fsRgNXKReewuM5WHUHe/BmicWBng6XOGSGubvctnyErALZMnYzzOe1v1GPSP+tM1 NebFjvzRLPJVK+LtlEvtrNaPsKnM0U0NDQ7dHdXQE4YUmVoJaIvMHPam/IiAmu+JKK1l C7UVaoht9AKLLKB3lV8CjbDc8TtA3Kexo9LBXq+JYVJXxpd/OnkXIt9sRq7X+GXmx+fy h0Tcaiv/yyGqCmi6kL+o58Jd0WOBVXhiNV0pmO38Sd8kqy2lgFz7LAwA35qgbdVIHItR AmQJs870NahPXzhh/DtOJlsI7GoAb7FdFIJY4xVswUZW8KcNilxsL0SM+bIyOwjkQw0r MVkg== X-Gm-Message-State: AOAM533BP2sE9aP9fgWlyJgjBKmUS4sQG3DDRApQmRrYHs2HXrekWiV6 puQclfbdRPAKNkqyIESqX6jGNomdmbjjZgN5ZNo= X-Google-Smtp-Source: ABdhPJxLCsyebn71tdhuirdA3IxpgHUG0Q3VXGlmAMZm5PbspFWdB+sXj9tCZwpMGlNMbRxZQmyKcXIv6nlgRtRprhs= X-Received: by 2002:a05:6102:392:: with SMTP id m18mr11126386vsq.40.1621609473060; Fri, 21 May 2021 08:04:33 -0700 (PDT) MIME-Version: 1.0 References: <20210514192218.13022-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210514192218.13022-12-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <20210514192218.13022-12-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Geert Uytterhoeven Date: Fri, 21 May 2021 17:04:21 +0200 Message-ID: Subject: Re: [PATCH 11/16] dt-bindings: clock: renesas: Document RZ/G2L SoC CPG driver To: Lad Prabhakar Cc: Rob Herring , Magnus Damm , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Catalin Marinas , Will Deacon , Jiri Slaby , Philipp Zabel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux-Renesas , linux-clk , "open list:SERIAL DRIVERS" , Linux ARM , Biju Das , Prabhakar Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Prabhakar, On Fri, May 14, 2021 at 9:23 PM Lad Prabhakar wrote: > Document the device tree bindings of the Renesas RZ/G2L SoC clock > driver in Documentation/devicetree/bindings/clock/renesas,rzg2l-cpg.yaml. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Biju Das Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/renesas,rzg2l-cpg.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/clock/renesas,rzg2l-cpg.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Renesas RZ/G2L Clock Pulse Generator / Module Stop and Software Reset (Module Standby Mode > + > +maintainers: > + - Geert Uytterhoeven > + > +description: | > + On Renesas RZ/G2L SoC, the CPG (Clock Pulse Generator) and MSTP > + (Module Stop and Software Reset) share the same register block. > + > + They provide the following functionalities: > + - The CPG block generates various core clocks, > + - The MSTP block provides two functions: > + 1. Module Stop, providing a Clock Domain to control the clock supply > + to individual SoC devices, > + 2. Reset Control, to perform a software reset of individual SoC devices. > + > +properties: > + compatible: > + const: renesas,r9a07g044l-cpg # RZ/G2L renesas,r9a07g044-cpg? I believe it's the same block on RZ/G2L ('044l) and RZ/G2LC ('044c). > + '#clock-cells': > + description: | > + - For CPG core clocks, the two clock specifier cells must be "CPG_CORE" > + and a core clock reference, as defined in > + > + - For module clocks, the two clock specifier cells must be "CPG_MOD" and > + a module number, as defined in the datasheet. Also in ? > + const: 2 > + > + '#power-domain-cells': > + description: > + SoC devices that are part of the CPG/MSTP Clock Domain and can be > + power-managed through Module Stop should refer to the CPG device node > + in their "power-domains" property, as documented by the generic PM Domain > + bindings in Documentation/devicetree/bindings/power/power-domain.yaml. > + const: 0 > + > + '#reset-cells': > + description: > + The single reset specifier cell must be the module number, as defined in > + the datasheet. Also in ? > + const: 1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92391C47076 for ; Fri, 21 May 2021 15:06:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 161C7613CB for ; Fri, 21 May 2021 15:06:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 161C7613CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5LX6uOfcG3c+FgmIDozNwCBEXX2k+c3kr4zqg0wF5w0=; b=GFijEgRQIok+BI2nIzBS8oDCV0 x8yMTrhZjKuc90KLNguD7+vynvihcUh81RU8mB/twXJUlmtBCdbJr46X0Nspy1ittRFFc61zEvQx5 17gld+h46WWVxHIiYoY7r0yWKHda0u5GmA4mtZb6R5BFcSWSnISVmNNY/M3ZOr8goRfGw3aFZ7NEH 9lnMKvLSIrDpZJwmBtE6tc2efjNrXivxU7qcsQzgcpLhLsuu9RFj3lCOHkRTL6Vl3eknYisXmcvxw 6cJEoCezRwQ41508UMbSltNQJTTUv0s7nG1WfxNsBwTL5lR1r4FfBBFhE5VWyRfnqqzryKZxp31Ar oGBOaj5A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk6hc-005tFo-8b; Fri, 21 May 2021 15:04:40 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk6hZ-005tDa-9X for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 15:04:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PXuG7KOO5W95jEf2lKiMIqjS8B2a0VXsDtOORCzbLU4=; b=CFTFjYuKgBnWVlLe0V98ifs/mD cfoDweCdD0PtLLCliSJRIsuE8RVFZ6sRCfTGY2NkQsRIk5cyFVwCLEmYb2xy6WECdUiei5GROfb5f 6thGgbQc3/raeTsMoEkbLjXGMwDqvjrDDzo0uL+y5ejpApABwnDrR0cTfz7BpyVVhH1zNPYRiR1Z2 7frFoekngs7yOFFz8cuXPf3deMkpS3JVHNmEbS6w08aGtF5j6lCYM0vaMCugGKfXGfMjCjrGnxcs6 aRQ18gMlQZFjoSxWfwmM2U07GPX3hMqYKP2CziBsmVh5qNYtsIaEeJ4H/Ouyr2ZSJ7tv6zom6pZrH h8RoOOwQ==; Received: from mail-vs1-f43.google.com ([209.85.217.43]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk6hW-00HDXY-J4 for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 15:04:36 +0000 Received: by mail-vs1-f43.google.com with SMTP id f9so4039478vsp.6 for ; Fri, 21 May 2021 08:04:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PXuG7KOO5W95jEf2lKiMIqjS8B2a0VXsDtOORCzbLU4=; b=F6oPuP+E7rJJYAiwnP6PfUPToZJ3y8T8b17o7dH3ObFqvs5AvlSUEszWM0QMvHnWa1 Daa2pVhB5fwhN2LCdlJHTDiCKM8vSX0gwNV6p3n1gC0GdEc1YFlqcduAFQJZ246f2exJ UxYFris3QqTHRNutnHsIS1oXxTeDx2bIZ2U0lrYlF6wfzZ/9lE9cWX5SndJ/c8Q/vBAt 2imDdoOu8l7hYmfLEBd0ZTbP9UdHnkL1bnjflGqrelrwwnQa6zlgoPEINN771LV7xYhN VzoeFOh3Jw+lF0vzxqWnHEuCi8jh2T4s+KBhrG7qE3CUDmmtsael3gFuHRHVmF9miPa2 LBmw== X-Gm-Message-State: AOAM533MsR3n3YN/9mhn85MfLuWXeYABJEpbtYXsXBvh0C7h1oyhzUY9 I6UHis0BtnPvdGY2j8qXDozz85/41Ohc2yMogDg= X-Google-Smtp-Source: ABdhPJxLCsyebn71tdhuirdA3IxpgHUG0Q3VXGlmAMZm5PbspFWdB+sXj9tCZwpMGlNMbRxZQmyKcXIv6nlgRtRprhs= X-Received: by 2002:a05:6102:392:: with SMTP id m18mr11126386vsq.40.1621609473060; Fri, 21 May 2021 08:04:33 -0700 (PDT) MIME-Version: 1.0 References: <20210514192218.13022-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210514192218.13022-12-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <20210514192218.13022-12-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Geert Uytterhoeven Date: Fri, 21 May 2021 17:04:21 +0200 Message-ID: Subject: Re: [PATCH 11/16] dt-bindings: clock: renesas: Document RZ/G2L SoC CPG driver To: Lad Prabhakar Cc: Rob Herring , Magnus Damm , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Catalin Marinas , Will Deacon , Jiri Slaby , Philipp Zabel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux-Renesas , linux-clk , "open list:SERIAL DRIVERS" , Linux ARM , Biju Das , Prabhakar X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_080434_647485_FF45744E X-CRM114-Status: GOOD ( 28.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Prabhakar, On Fri, May 14, 2021 at 9:23 PM Lad Prabhakar wrote: > Document the device tree bindings of the Renesas RZ/G2L SoC clock > driver in Documentation/devicetree/bindings/clock/renesas,rzg2l-cpg.yaml. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Biju Das Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/renesas,rzg2l-cpg.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/clock/renesas,rzg2l-cpg.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Renesas RZ/G2L Clock Pulse Generator / Module Stop and Software Reset (Module Standby Mode > + > +maintainers: > + - Geert Uytterhoeven > + > +description: | > + On Renesas RZ/G2L SoC, the CPG (Clock Pulse Generator) and MSTP > + (Module Stop and Software Reset) share the same register block. > + > + They provide the following functionalities: > + - The CPG block generates various core clocks, > + - The MSTP block provides two functions: > + 1. Module Stop, providing a Clock Domain to control the clock supply > + to individual SoC devices, > + 2. Reset Control, to perform a software reset of individual SoC devices. > + > +properties: > + compatible: > + const: renesas,r9a07g044l-cpg # RZ/G2L renesas,r9a07g044-cpg? I believe it's the same block on RZ/G2L ('044l) and RZ/G2LC ('044c). > + '#clock-cells': > + description: | > + - For CPG core clocks, the two clock specifier cells must be "CPG_CORE" > + and a core clock reference, as defined in > + > + - For module clocks, the two clock specifier cells must be "CPG_MOD" and > + a module number, as defined in the datasheet. Also in ? > + const: 2 > + > + '#power-domain-cells': > + description: > + SoC devices that are part of the CPG/MSTP Clock Domain and can be > + power-managed through Module Stop should refer to the CPG device node > + in their "power-domains" property, as documented by the generic PM Domain > + bindings in Documentation/devicetree/bindings/power/power-domain.yaml. > + const: 0 > + > + '#reset-cells': > + description: > + The single reset specifier cell must be the module number, as defined in > + the datasheet. Also in ? > + const: 1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel