From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F26DC433E6 for ; Mon, 22 Mar 2021 15:06:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E642619B9 for ; Mon, 22 Mar 2021 15:06:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231562AbhCVPFr (ORCPT ); Mon, 22 Mar 2021 11:05:47 -0400 Received: from mail-ua1-f53.google.com ([209.85.222.53]:39750 "EHLO mail-ua1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231440AbhCVPFU (ORCPT ); Mon, 22 Mar 2021 11:05:20 -0400 Received: by mail-ua1-f53.google.com with SMTP id x8so5636144ual.6; Mon, 22 Mar 2021 08:05:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QKcelu+NmBcULRnt/75BGuY/1w8xytannxFSZVcT4b8=; b=llZv96kktIHOjydl5JKy5J7X51A5MZAfTFYcE5gFCr7w/DL63KuWPDv/0Umj6vzCKm XPcsXX4UjBfu2ojyJeU1qsi3e5jq6/oRfWiUJwC/EmVT8RkPPHhPzEcJ6mUM5OrWFs8r IDMxuqoQCh46TY07DYfFTGIoeQh2vOgfUXRd9en/7bY6DPXzIldE5ZcycgIc8qIlKdZs 6PdgEs17lqNIdj0C4glClTNki80e6PqIPU9LDopbwl9X+5iJP2jZTruwKT5/1PoZfSGP GNWEgXF8+l6BkBfTNYhHFhR60Mj4Q7UHxvGVZaXabdaaj73B/MmnUzeXvJev5OW4zDgO MQQA== X-Gm-Message-State: AOAM530tnN6KVmvpCh8NMR9ekq7Tz+eDvYIWYc6+GB9wGatvgUwedPeH 8J0IlWfAHaVxs0QnHRoHpjSTxNgnz+jNHJ0/Sy60r6eC X-Google-Smtp-Source: ABdhPJz0b1s1oTOxCucwqAxWp5R67A8XGklstumBCcjoVt+uAGLhQvuzSA30ih2KS6v8elIzwhSfkW8ymWhFpvRQgjg= X-Received: by 2002:ab0:30b3:: with SMTP id b19mr307821uam.58.1616425518872; Mon, 22 Mar 2021 08:05:18 -0700 (PDT) MIME-Version: 1.0 References: <20210322105307.1291840-1-arnd@kernel.org> In-Reply-To: <20210322105307.1291840-1-arnd@kernel.org> From: Geert Uytterhoeven Date: Mon, 22 Mar 2021 16:05:07 +0100 Message-ID: Subject: Re: [PATCH 1/2] fbdev: omapfb: avoid -Wempty-body warning To: Arnd Bergmann Cc: DRI Development , Linux Fbdev development list , Arnd Bergmann , "open list:TI ETHERNET SWITCH DRIVER (CPSW)" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 22, 2021 at 11:54 AM Arnd Bergmann wrote: > From: Arnd Bergmann > > Building with 'make W=1' shows a few harmless warnings: > > drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_calc_addr': > drivers/video/fbdev/omap2/omapfb/omapfb-main.c:823:56: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 823 | var->xoffset, var->yoffset, offset); > | ^ > drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c: In function 'omapfb_ioctl': > drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c:911:45: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 911 | DBG("ioctl failed: %d\n", r); > > Avoid these by using no_printk(), which adds format string checking as > well. > > Signed-off-by: Arnd Bergmann Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39388C433C1 for ; Mon, 22 Mar 2021 15:05:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D71AF61983 for ; Mon, 22 Mar 2021 15:05:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D71AF61983 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 021396E4B7; Mon, 22 Mar 2021 15:05:21 +0000 (UTC) Received: from mail-ua1-f48.google.com (mail-ua1-f48.google.com [209.85.222.48]) by gabe.freedesktop.org (Postfix) with ESMTPS id B98DB6E4B7 for ; Mon, 22 Mar 2021 15:05:19 +0000 (UTC) Received: by mail-ua1-f48.google.com with SMTP id j4so5644872uan.1 for ; Mon, 22 Mar 2021 08:05:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QKcelu+NmBcULRnt/75BGuY/1w8xytannxFSZVcT4b8=; b=PcqAgCne6TZyKz/KykoWAiO5PUYZMQCgMQ5qlHy73PieNt4pCbWLilN8w3d6oDGtXm tOUVjNrH0Z/OEfyHZIY1i10b2xIN0YpV5MBHy+iw36aafpHlue45sx0VUx03VJw6H60c q0BuGzSJCvTAeAYHj8uTVlYSCJBuD/CmJn3hZivFFQ2yRYdWd0sZEra1Km7odP0QW7Kd DcVMX61qXYlq/Cxz1tc7QYyeyIzqbUxn7lXUsJcJERm+Yoku5hpIY9wvtVRmjycJ1GnJ 6wUcYlAKs+H8xpiqWoDTAkuxjeyWF/9fjgqIvvQbjDRg2sprKjkkbe9Jo0ZiPqvzGUs3 JG4g== X-Gm-Message-State: AOAM530yM5/N6J6knNxm4CAEC8T4vL8VxliTxw0gZDs6Jz2XFgh0rAJZ eFzrNJX3w/8RP9iYFMU0iYPX7Xp8YY4m3WZl4Uo= X-Google-Smtp-Source: ABdhPJz0b1s1oTOxCucwqAxWp5R67A8XGklstumBCcjoVt+uAGLhQvuzSA30ih2KS6v8elIzwhSfkW8ymWhFpvRQgjg= X-Received: by 2002:ab0:30b3:: with SMTP id b19mr307821uam.58.1616425518872; Mon, 22 Mar 2021 08:05:18 -0700 (PDT) MIME-Version: 1.0 References: <20210322105307.1291840-1-arnd@kernel.org> In-Reply-To: <20210322105307.1291840-1-arnd@kernel.org> From: Geert Uytterhoeven Date: Mon, 22 Mar 2021 16:05:07 +0100 Message-ID: Subject: Re: [PATCH 1/2] fbdev: omapfb: avoid -Wempty-body warning To: Arnd Bergmann X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Fbdev development list , "open list:TI ETHERNET SWITCH DRIVER \(CPSW\)" , Arnd Bergmann , DRI Development , Linux Kernel Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Mar 22, 2021 at 11:54 AM Arnd Bergmann wrote: > From: Arnd Bergmann > > Building with 'make W=1' shows a few harmless warnings: > > drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_calc_addr': > drivers/video/fbdev/omap2/omapfb/omapfb-main.c:823:56: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 823 | var->xoffset, var->yoffset, offset); > | ^ > drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c: In function 'omapfb_ioctl': > drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c:911:45: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 911 | DBG("ioctl failed: %d\n", r); > > Avoid these by using no_printk(), which adds format string checking as > well. > > Signed-off-by: Arnd Bergmann Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel