All of lore.kernel.org
 help / color / mirror / Atom feed
* b4 not finding explicitly specified patch
@ 2021-01-21 10:05 Geert Uytterhoeven
  2021-05-20 22:06 ` Konstantin Ryabitsev
  0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-01-21 10:05 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: users, tools

Hi Konstantin,

$ b4 am 20210121082248.883253-1-saravanak@google.com -P_
Looking up https://lore.kernel.org/r/20210121082248.883253-1-saravanak%40google.com
Grabbing thread from lore.kernel.org/lkml
Analyzing 63 messages in the thread
---
Specified msgid is not present in the series, cannot cherrypick
$

Without "-P_", it downloads a series not containing the patch I want.

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: b4 not finding explicitly specified patch
  2021-01-21 10:05 b4 not finding explicitly specified patch Geert Uytterhoeven
@ 2021-05-20 22:06 ` Konstantin Ryabitsev
  2021-05-21  7:06   ` Geert Uytterhoeven
  0 siblings, 1 reply; 6+ messages in thread
From: Konstantin Ryabitsev @ 2021-05-20 22:06 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: users, tools

On Thu, Jan 21, 2021 at 11:05:51AM +0100, Geert Uytterhoeven wrote:
> Hi Konstantin,
> 
> $ b4 am 20210121082248.883253-1-saravanak@google.com -P_
> Looking up https://lore.kernel.org/r/20210121082248.883253-1-saravanak%40google.com
> Grabbing thread from lore.kernel.org/lkml
> Analyzing 63 messages in the thread
> ---
> Specified msgid is not present in the series, cannot cherrypick
> $
> 
> Without "-P_", it downloads a series not containing the patch I want.

Well, only 5 months later, but I do have a fix for this in the current
0.7-dev:

    $ b4 am -o/tmp 20210121082248.883253-1-saravanak@google.com -P_
    Looking up https://lore.kernel.org/r/20210121082248.883253-1-saravanak%40google.com
    Analyzing 5 messages in the thread
    Checking attestation on all messages, may take a moment...
    ---
      ✓ [PATCH v1] driver: core: Make fw_devlink=on more forgiving
      ---
      ✓ Signed: DKIM/google.com
    ---
    Total patches: 1 (cherrypicked: <20210121082248.883253-1-saravanak@google.com>)
    ---
     Link: https://lore.kernel.org/r/20210121082248.883253-1-saravanak@google.com
     Base: not found
           git am /tmp/20210121_saravanak_driver_core_make_fw_devlink_on_more_forgiving.mbx

Best regards,
-K

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: b4 not finding explicitly specified patch
  2021-05-20 22:06 ` Konstantin Ryabitsev
@ 2021-05-21  7:06   ` Geert Uytterhoeven
  2021-05-21 12:28     ` Konstantin Ryabitsev
  0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-05-21  7:06 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: users, tools

Hi Konstantin,

On Fri, May 21, 2021 at 12:06 AM Konstantin Ryabitsev
<konstantin@linuxfoundation.org> wrote:
> On Thu, Jan 21, 2021 at 11:05:51AM +0100, Geert Uytterhoeven wrote:
> > $ b4 am 20210121082248.883253-1-saravanak@google.com -P_
> > Looking up https://lore.kernel.org/r/20210121082248.883253-1-saravanak%40google.com
> > Grabbing thread from lore.kernel.org/lkml
> > Analyzing 63 messages in the thread
> > ---
> > Specified msgid is not present in the series, cannot cherrypick
> > $
> >
> > Without "-P_", it downloads a series not containing the patch I want.
>
> Well, only 5 months later, but I do have a fix for this in the current

Off-by-one error: 4 months ;-)

> 0.7-dev:
>
>     $ b4 am -o/tmp 20210121082248.883253-1-saravanak@google.com -P_
>     Looking up https://lore.kernel.org/r/20210121082248.883253-1-saravanak%40google.com
>     Analyzing 5 messages in the thread
>     Checking attestation on all messages, may take a moment...
>     ---
>       ✓ [PATCH v1] driver: core: Make fw_devlink=on more forgiving
>       ---
>       ✓ Signed: DKIM/google.com
>     ---
>     Total patches: 1 (cherrypicked: <20210121082248.883253-1-saravanak@google.com>)
>     ---
>      Link: https://lore.kernel.org/r/20210121082248.883253-1-saravanak@google.com
>      Base: not found
>            git am /tmp/20210121_saravanak_driver_core_make_fw_devlink_on_more_forgiving.mbx

Thanks, confirmed!

Note that without "-P_", it still downloads the series not containing the patch
I specified.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: b4 not finding explicitly specified patch
  2021-05-21  7:06   ` Geert Uytterhoeven
@ 2021-05-21 12:28     ` Konstantin Ryabitsev
  2021-05-21 13:18       ` Geert Uytterhoeven
  0 siblings, 1 reply; 6+ messages in thread
From: Konstantin Ryabitsev @ 2021-05-21 12:28 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: users, tools

On Fri, May 21, 2021 at 09:06:20AM +0200, Geert Uytterhoeven wrote:
> > Well, only 5 months later, but I do have a fix for this in the current
> 
> Off-by-one error: 4 months ;-)

Oh, I'm using a special "Pandemic Perceptive Timekeeping" where for each
elapsed 4 weeks you add an extra one. :)

> Note that without "-P_", it still downloads the series not containing the patch
> I specified.

I'm not sure if I can fix that, because that thread is a bit wonky. You will
notice that we have:

[PATCH v1 0/5]
...
[PATCH v1 5/5]
 \- Re: [PATCH v1 5/5]
  \- [TEST PATCH v1]

b4 is really built around retrieving series, and here we can't figure out
where in the series [TEST PATCH v1] belongs. I *believe* the intent here is to
replace [PATCH v1 5/5], but it doesn't have any counters on it, so we end up
ignoring it because we already have a [PATCH v1 1/5].

I'm not sure what the *proper* way to deal with this case is -- at least in
the absence of -P that specifies "I want *that* exact msgid".

-K

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: b4 not finding explicitly specified patch
  2021-05-21 12:28     ` Konstantin Ryabitsev
@ 2021-05-21 13:18       ` Geert Uytterhoeven
  2021-06-07  7:30         ` Geert Uytterhoeven
  0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-05-21 13:18 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: users, tools

Hi Konstantin,

On Fri, May 21, 2021 at 2:28 PM Konstantin Ryabitsev
<konstantin@linuxfoundation.org> wrote:
> On Fri, May 21, 2021 at 09:06:20AM +0200, Geert Uytterhoeven wrote:
> > Note that without "-P_", it still downloads the series not containing the patch
> > I specified.
>
> I'm not sure if I can fix that, because that thread is a bit wonky. You will
> notice that we have:
>
> [PATCH v1 0/5]
> ...
> [PATCH v1 5/5]
>  \- Re: [PATCH v1 5/5]
>   \- [TEST PATCH v1]
>
> b4 is really built around retrieving series, and here we can't figure out
> where in the series [TEST PATCH v1] belongs. I *believe* the intent here is to
> replace [PATCH v1 5/5], but it doesn't have any counters on it, so we end up
> ignoring it because we already have a [PATCH v1 1/5].

Yeah, it's a weird case ;-)

> I'm not sure what the *proper* way to deal with this case is -- at least in
> the absence of -P that specifies "I want *that* exact msgid".

Fair enough. Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: b4 not finding explicitly specified patch
  2021-05-21 13:18       ` Geert Uytterhoeven
@ 2021-06-07  7:30         ` Geert Uytterhoeven
  0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-06-07  7:30 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: users, tools

Hi Konstantin,

On Fri, May 21, 2021 at 3:18 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Fri, May 21, 2021 at 2:28 PM Konstantin Ryabitsev
> <konstantin@linuxfoundation.org> wrote:
> > On Fri, May 21, 2021 at 09:06:20AM +0200, Geert Uytterhoeven wrote:
> > > Note that without "-P_", it still downloads the series not containing the patch
> > > I specified.
> >
> > I'm not sure if I can fix that, because that thread is a bit wonky. You will
> > notice that we have:
> >
> > [PATCH v1 0/5]
> > ...
> > [PATCH v1 5/5]
> >  \- Re: [PATCH v1 5/5]
> >   \- [TEST PATCH v1]
> >
> > b4 is really built around retrieving series, and here we can't figure out
> > where in the series [TEST PATCH v1] belongs. I *believe* the intent here is to
> > replace [PATCH v1 5/5], but it doesn't have any counters on it, so we end up
> > ignoring it because we already have a [PATCH v1 1/5].
>
> Yeah, it's a weird case ;-)

Just ran into another weird case:

$ b4 am 1622957313-321-1-git-send-email-schmitzmic@gmail.com
Looking up https://lore.kernel.org/r/1622957313-321-1-git-send-email-schmitzmic%40gmail.com
Analyzing 28 messages in the thread
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH RFC 1/2] m68k: io_mm.h: conditionalize ISA address
translation on Atari
  ✓ [PATCH RFC 2/2] m68k: setup_mm.c: set isa_sex for Atari if
ATARI_ROM_ISA not used
  ---
  ✓ Signed: DKIM/gmail.com
---
Total patches: 2
---
Cover: ./20210602_schmitzmic_fix_m68k_multiplatform_isa_support.cover
 Link: https://lore.kernel.org/r/1622611267-15825-1-git-send-email-schmitzmic@gmail.com
 Base: not found (applies clean to current tree)
       git am ./20210602_schmitzmic_fix_m68k_multiplatform_isa_support.mbx

No, that's the RFC.

$ b4 am -P_ 1622957313-321-1-git-send-email-schmitzmic@gmail.com
Looking up https://lore.kernel.org/r/1622957313-321-1-git-send-email-schmitzmic%40gmail.com
Analyzing 1 messages in the thread
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH] m68k: Fix multiplatform ISA support
  ---
  ✓ Signed: DKIM/gmail.com
---
Total patches: 1 (cherrypicked:
<1622957313-321-1-git-send-email-schmitzmic@gmail.com>)
---
 Link: https://lore.kernel.org/r/1622957313-321-1-git-send-email-schmitzmic@gmail.com
 Base: not found (applies clean to current tree)
       git am ./20210606_schmitzmic_m68k_fix_multiplatform_isa_support.mbx

Yeah, that's the one I want.

At least the chain "RFC" -> implicit v1 -> "v2" -> "v3" ... is less fuzzy
than "[PATCH v1 5/5]" -> "[TEST PATCH v1]"...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-06-07  7:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21 10:05 b4 not finding explicitly specified patch Geert Uytterhoeven
2021-05-20 22:06 ` Konstantin Ryabitsev
2021-05-21  7:06   ` Geert Uytterhoeven
2021-05-21 12:28     ` Konstantin Ryabitsev
2021-05-21 13:18       ` Geert Uytterhoeven
2021-06-07  7:30         ` Geert Uytterhoeven

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.