From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C495AC04E87 for ; Thu, 16 May 2019 07:27:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A18EB2082E for ; Thu, 16 May 2019 07:27:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726429AbfEPH1Q convert rfc822-to-8bit (ORCPT ); Thu, 16 May 2019 03:27:16 -0400 Received: from mail-vs1-f68.google.com ([209.85.217.68]:44015 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726374AbfEPH1P (ORCPT ); Thu, 16 May 2019 03:27:15 -0400 Received: by mail-vs1-f68.google.com with SMTP id d128so1643161vsc.10; Thu, 16 May 2019 00:27:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9OpkOibxcuUC8ReVyp3/fOxgiTH87FuWtzKvQfGNZec=; b=YbjVpalzAh1gJUQOux8ciYRk8oqdA2DTbasYJAk9cmY6icHLq3Og1SI1YGCHQ8Ar1a NJdS0a9fDp2wVhWmvfSdvqQsz1/9XEvj+3/+bdQIyCjZ+Xx/5Nhvf8o+SphcpQYsTIxa XJjpt+v1RjPz/5uS4f0bUqxCtC71NmjlkzsYvlyAAMc06PvJ4aYPUvCbmS8GWcvKkntE iefwOo6oNjCzXbKXRylx8eI0xlYmq30NrDEqJpkhjPmmKHVYOI7cA6+/XUK7y/dVsC2h 3dXIAWiHlDLYs2fqAw5TIbz/jevRP/q8TFDRt+/xA7Yyqe1FKOIgRdpcM32g6UteLynR cWYA== X-Gm-Message-State: APjAAAUt1ZeN58N+Rp2J9A1JHbhipgOfDOuV7BCXktm8MNv5mjtap861 TRQofPPUIiLYJdlfvBhWzY0l29WxLl12X3O83dqW6g== X-Google-Smtp-Source: APXvYqyPBe8baPwp7AFQGQj6lmoBR0FjJx/EhTHHX1Tsyra0T+wmFbXh0KtUKv8B0cN9sviRYwH1NEwWYJzbCa0W680= X-Received: by 2002:a67:fdd4:: with SMTP id l20mr18226421vsq.63.1557991634833; Thu, 16 May 2019 00:27:14 -0700 (PDT) MIME-Version: 1.0 References: <20190516011417.10590-1-niklas.soderlund+renesas@ragnatech.se> <20190516011417.10590-3-niklas.soderlund+renesas@ragnatech.se> In-Reply-To: <20190516011417.10590-3-niklas.soderlund+renesas@ragnatech.se> From: Geert Uytterhoeven Date: Thu, 16 May 2019 09:27:03 +0200 Message-ID: Subject: Re: [PATCH v2 2/8] rcar-vin: Remove unneeded calls to pm_runtime_{enable,disable} To: =?UTF-8?Q?Niklas_S=C3=B6derlund?= Cc: Laurent Pinchart , Ulrich Hecht , Linux Media Mailing List , Linux-Renesas , Ulrich Hecht Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Niklas, On Thu, May 16, 2019 at 3:49 AM Niklas Söderlund wrote: > Runtime PM is already enabled unconditionally when the driver is probed > and disabled when it's removed. There is no point in doing it again for > Gen2 when opening and closing the video device. > > Signed-off-by: Niklas Söderlund > Reviewed-by: Ulrich Hecht > --- > drivers/media/platform/rcar-vin/rcar-v4l2.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rcar-vin/rcar-v4l2.c > index b821ea01786eb1ff..0841f1a0bfd7ba3a 100644 > --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c > +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c > @@ -797,8 +797,6 @@ static int rvin_initialize_device(struct file *file) > if (ret < 0) > return ret; > > - pm_runtime_enable(&vin->vdev.dev); Ah, this already (partly) answers my question on patch 1/8. > - > /* > * Try to configure with default parameters. Notice: this is the > * very first open, so, we cannot race against other calls, Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds