From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D880FC83004 for ; Wed, 29 Apr 2020 07:34:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8CE1206D9 for ; Wed, 29 Apr 2020 07:34:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726561AbgD2HeQ (ORCPT ); Wed, 29 Apr 2020 03:34:16 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:38954 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726386AbgD2HeP (ORCPT ); Wed, 29 Apr 2020 03:34:15 -0400 Received: by mail-oi1-f196.google.com with SMTP id m10so971865oie.6 for ; Wed, 29 Apr 2020 00:34:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SyWquW6C3h9yYRPnL8ZX6mVqONgOMsOlS/nbLkzCvR8=; b=eIGPu6UV9Tbb+4TcvxcWa0Zp6/mfTk5mm2Z5UxNX7hIJr0nrwAIGwdMFfGKb9HFADs 7Km/pe5z9Km01z5Uzm10FMg87h5D/9sBMxNkvtwKj+BVbE1R8J8yBCrYBycNoCeq4IlF YRYIm4Hvl1voRmQLkwKuX+R9lA7e+eZeFK0iG/xo3QMpSFmcjFfisBH5WeSJcXJ1BQI2 FoQAnSeWimeflK4CpJe5eya1Si2Tx8Oc9Nd0AsQxLyPiFX6avDVuiHLNJLGPKES7avFt aWd0msyFizbivHXDTxpxrxxJTp+rn141Fhp9gzZYcMGfjzeNY0i0kyWkDbzDdAdMfrWR sXVw== X-Gm-Message-State: AGi0PuYDnt8tZ0dPJ/0kJhHtP69Ab5NsPmoC9g8SzGZGaQB0Z7D/LJFo 3BQR4OG8sAnlNUSs9FqUCMfw4SyYovewUMPyvPE= X-Google-Smtp-Source: APiQypJAsZR6cJVnPhd52DhYQokiZWeX1PxL/6m2Vvtp1dgHuL2QQU2M5utJVEIEaKuPsXF6mplj99rnUrUZngmlKtw= X-Received: by 2002:aca:d50f:: with SMTP id m15mr810760oig.54.1588145654121; Wed, 29 Apr 2020 00:34:14 -0700 (PDT) MIME-Version: 1.0 References: <20200428194449.22615-1-willy@infradead.org> <20200428194449.22615-3-willy@infradead.org> In-Reply-To: <20200428194449.22615-3-willy@infradead.org> From: Geert Uytterhoeven Date: Wed, 29 Apr 2020 09:34:02 +0200 Message-ID: Subject: Re: [PATCH 2/7] mm: Move pt_mm within struct page To: Matthew Wilcox Cc: Linux MM , Linux Kernel Mailing List , Linux ARM , Will Deacon , Catalin Marinas , Russell King , linux-m68k Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthew, On Tue, Apr 28, 2020 at 9:44 PM Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > Instead of a per-arch word within struct page, use a formerly reserved > word. This word is shared with page->mapping, so it must be cleared > before being freed as it is checked in free_pages(). > > Signed-off-by: Matthew Wilcox (Oracle) Thanks for your patch! > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -149,11 +149,8 @@ struct page { > pgtable_t pmd_huge_pte; > }; > }; > - unsigned long _pt_pad_2; /* mapping */ > - union { > - struct mm_struct *pt_mm; /* x86 pgds only */ > - atomic_t pt_frag_refcount; /* powerpc */ > - }; > + struct mm_struct *pt_mm; > + atomic_t pt_frag_refcount; /* powerpc */ So here is now an implicit hole on 64-bit platforms, right? Do we have any where alignof(long) != 8? > #if ALLOC_SPLIT_PTLOCKS > spinlock_t *ptl; > #else Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73989C83007 for ; Wed, 29 Apr 2020 07:34:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4197D206D9 for ; Wed, 29 Apr 2020 07:34:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4197D206D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B58848E0005; Wed, 29 Apr 2020 03:34:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B09718E0001; Wed, 29 Apr 2020 03:34:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1F028E0005; Wed, 29 Apr 2020 03:34:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0095.hostedemail.com [216.40.44.95]) by kanga.kvack.org (Postfix) with ESMTP id 86CC78E0001 for ; Wed, 29 Apr 2020 03:34:15 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4D43F2C1F for ; Wed, 29 Apr 2020 07:34:15 +0000 (UTC) X-FDA: 76760079270.17.quiet85_5f50201388140 X-HE-Tag: quiet85_5f50201388140 X-Filterd-Recvd-Size: 3831 Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Apr 2020 07:34:14 +0000 (UTC) Received: by mail-oi1-f194.google.com with SMTP id 19so961930oiy.8 for ; Wed, 29 Apr 2020 00:34:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SyWquW6C3h9yYRPnL8ZX6mVqONgOMsOlS/nbLkzCvR8=; b=UZpJJDI25I7EY5xSY5NEfNLYMO4IJekeniGj2yD6E7YjpH3coz82dzLtUCi6ebWHVX J89O6+jvuTn0iwfFBoUk93hEo6+z/FtgFhF4tDEDfyMmjcLyW1CCMXZLrZumwn/+CpwQ l6jXf3thHd30d2O0NHdoJM5gaLDJTXNWCsPv6PI++CdHUa3zZT6SDvSKi80Pl23hZn71 wjkKmQLlQfz58bmqweSAJwRcRCwySIHlb931Mbxuo1pW3PEwo8R7pFdbsLBHA+PAdQul 8AiwEHesmH8VH5a3T4FikP9074lf5E6K3uuEo8geTZjRiWhOoZWlxHxn1F4gSjK5Uqqg l/Sw== X-Gm-Message-State: AGi0PuaPxWTtOzrFsK0cfTYWwUcYjlVuXPDM7WISwqoz9MlJusKTJQwa Afi1AHwGDU3qvngoewaYblipyhgcOZogCf/P420= X-Google-Smtp-Source: APiQypJAsZR6cJVnPhd52DhYQokiZWeX1PxL/6m2Vvtp1dgHuL2QQU2M5utJVEIEaKuPsXF6mplj99rnUrUZngmlKtw= X-Received: by 2002:aca:d50f:: with SMTP id m15mr810760oig.54.1588145654121; Wed, 29 Apr 2020 00:34:14 -0700 (PDT) MIME-Version: 1.0 References: <20200428194449.22615-1-willy@infradead.org> <20200428194449.22615-3-willy@infradead.org> In-Reply-To: <20200428194449.22615-3-willy@infradead.org> From: Geert Uytterhoeven Date: Wed, 29 Apr 2020 09:34:02 +0200 Message-ID: Subject: Re: [PATCH 2/7] mm: Move pt_mm within struct page To: Matthew Wilcox Cc: Linux MM , Linux Kernel Mailing List , Linux ARM , Will Deacon , Catalin Marinas , Russell King , linux-m68k Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Matthew, On Tue, Apr 28, 2020 at 9:44 PM Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > Instead of a per-arch word within struct page, use a formerly reserved > word. This word is shared with page->mapping, so it must be cleared > before being freed as it is checked in free_pages(). > > Signed-off-by: Matthew Wilcox (Oracle) Thanks for your patch! > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -149,11 +149,8 @@ struct page { > pgtable_t pmd_huge_pte; > }; > }; > - unsigned long _pt_pad_2; /* mapping */ > - union { > - struct mm_struct *pt_mm; /* x86 pgds only */ > - atomic_t pt_frag_refcount; /* powerpc */ > - }; > + struct mm_struct *pt_mm; > + atomic_t pt_frag_refcount; /* powerpc */ So here is now an implicit hole on 64-bit platforms, right? Do we have any where alignof(long) != 8? > #if ALLOC_SPLIT_PTLOCKS > spinlock_t *ptl; > #else Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02C1FC83004 for ; Wed, 29 Apr 2020 07:34:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2F5D206D9 for ; Wed, 29 Apr 2020 07:34:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Rm1U79ty" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2F5D206D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=re6ejZ4jIsX0VxdP+JWwZh0qW4ap9RABHlLgUYWwE+g=; b=Rm1U79tyHenEzJ JcBkL34Gi/DWVD/iMIsDoyR5kXk/YxoqOECxVx1evWnP54vyxt8ayVqXytM6vDHd2AqJ5XTq25FUr R72Xkgq+QOh6Ap2APpIF1TxQ2eY/N9XSNc4UVBqJu5TOo8rsixn+aPSdL/Fg6oI+wLKSpN2ztdbkH cKh424fD1IoXdGoep5E5Gr6BkrCk54CIX4mo6MJX+aSBvyYMg8YwXGofqhngfclB/kglXtezX6Hex q9Q/AZ1VZXENX0zfh4F6kCDM28rbvt61RBTZbnXqkf6y6gunRUpv/sS9xPc4IgEYAamJ9bpGXQEA4 BMNi3ksRSzXAtQkm0dqg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jThEX-0005Uk-Og; Wed, 29 Apr 2020 07:34:17 +0000 Received: from mail-oi1-f194.google.com ([209.85.167.194]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jThEV-0005UI-FV for linux-arm-kernel@lists.infradead.org; Wed, 29 Apr 2020 07:34:16 +0000 Received: by mail-oi1-f194.google.com with SMTP id o24so1005260oic.0 for ; Wed, 29 Apr 2020 00:34:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SyWquW6C3h9yYRPnL8ZX6mVqONgOMsOlS/nbLkzCvR8=; b=G43x0pC2rscikVO4hLFX5ftthJl0XQGlYA/g448dwPMmySAvOQx3ji04bAQjUkGERE Fo3bJon/ZKCNZggTrR5y1P1fnRW4vgwJnGB+wv4tU3G6Q+OLtdCmPT7n/C8N9v6E7NTm +dQlc8dPMBvOmVZp7zjSgsonHcvtuLXi5PB4Ow/Kh1x4KcLdmRdlCIsOHnhnuV+XYaZG WPyTyk/QHNoNlsTp7Rj0qD7Xu0UzoVqBxVhGbjURBPey1BxLRTIMhGm02JLLBr3Ql8Es 1FRMWWzLhP8h6tT+eF3icYbBwh3yn0ucq/aF8p980HjydFK7zZULyZgqfMK26RZWNl0v 4wuw== X-Gm-Message-State: AGi0Pub4fvkPVYeMUcpHQtZRuXbMeaUQsOtxCUxZWvfAnc8/HfHy608G MOHaNSBmJO3zNd3moAy+jM//016PTS1GnwaRcMNvWQ== X-Google-Smtp-Source: APiQypJAsZR6cJVnPhd52DhYQokiZWeX1PxL/6m2Vvtp1dgHuL2QQU2M5utJVEIEaKuPsXF6mplj99rnUrUZngmlKtw= X-Received: by 2002:aca:d50f:: with SMTP id m15mr810760oig.54.1588145654121; Wed, 29 Apr 2020 00:34:14 -0700 (PDT) MIME-Version: 1.0 References: <20200428194449.22615-1-willy@infradead.org> <20200428194449.22615-3-willy@infradead.org> In-Reply-To: <20200428194449.22615-3-willy@infradead.org> From: Geert Uytterhoeven Date: Wed, 29 Apr 2020 09:34:02 +0200 Message-ID: Subject: Re: [PATCH 2/7] mm: Move pt_mm within struct page To: Matthew Wilcox X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200429_003415_517456_259220B4 X-CRM114-Status: GOOD ( 14.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Russell King , Linux Kernel Mailing List , Linux MM , linux-m68k , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Matthew, On Tue, Apr 28, 2020 at 9:44 PM Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > Instead of a per-arch word within struct page, use a formerly reserved > word. This word is shared with page->mapping, so it must be cleared > before being freed as it is checked in free_pages(). > > Signed-off-by: Matthew Wilcox (Oracle) Thanks for your patch! > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -149,11 +149,8 @@ struct page { > pgtable_t pmd_huge_pte; > }; > }; > - unsigned long _pt_pad_2; /* mapping */ > - union { > - struct mm_struct *pt_mm; /* x86 pgds only */ > - atomic_t pt_frag_refcount; /* powerpc */ > - }; > + struct mm_struct *pt_mm; > + atomic_t pt_frag_refcount; /* powerpc */ So here is now an implicit hole on 64-bit platforms, right? Do we have any where alignof(long) != 8? > #if ALLOC_SPLIT_PTLOCKS > spinlock_t *ptl; > #else Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel