From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65FEAC4320E for ; Tue, 31 Aug 2021 15:55:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B3E260F46 for ; Tue, 31 Aug 2021 15:55:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239448AbhHaP4C (ORCPT ); Tue, 31 Aug 2021 11:56:02 -0400 Received: from mail-vs1-f49.google.com ([209.85.217.49]:43756 "EHLO mail-vs1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238994AbhHaP4B (ORCPT ); Tue, 31 Aug 2021 11:56:01 -0400 Received: by mail-vs1-f49.google.com with SMTP id m19so13648863vsj.10 for ; Tue, 31 Aug 2021 08:55:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rXAig6svknWENNxhE5MWFDZ85DSokchu1E/IR78sJuc=; b=gBPL4dgySVCLJIvh2wTzQzJga4T3HNlaBo5OWe9oyrVTgUMFqakrgw+yVpeotfo7Y0 eT+Z9WDCiFxsD/4PSqkqkRm0V5GO9gEuqOxpIFb4HDqMphnVQ+5SL+ehCaxzDH2N2LVZ 5zvkzTMeJGyn99GinfX8XDHZQd+zMcoRBJwtaWLvcfPynsbvxFa8XiBykOr0eW2YJ526 m/S/N04ZQZUvRWjytyrv+lEakUHHkIk6i6rCc7kS8j04CcC4h3rZRg+7toLWdEYxTE40 wVeaHoPjM9cimhe0LKrcxw1vC96CkNCB1FoXzd+ppS3CvkY+8AjVXr98O4272TrhFJOe SOWA== X-Gm-Message-State: AOAM531OFXSZQmWyn+4HskCjBBKYIpgatCFQSd4kSx5JLQlM6RO+yRBT 3YqC2XovQCCOA227ifZQ+YJfAjo7PxJjD7xOqMc6zpgd X-Google-Smtp-Source: ABdhPJwd3g3qcsq1rJfE/U29ijK2E1/xXlt4GtyR/vrF5Gnlkgm76LK5kuxADxvS2KbERjJuC/N8lbT7cr8u52dbA/o= X-Received: by 2002:a67:3349:: with SMTP id z70mr18508950vsz.7.1630425305956; Tue, 31 Aug 2021 08:55:05 -0700 (PDT) MIME-Version: 1.0 References: <20210831062539.898293-1-imran.f.khan@oracle.com> <20210831062539.898293-2-imran.f.khan@oracle.com> In-Reply-To: <20210831062539.898293-2-imran.f.khan@oracle.com> From: Geert Uytterhoeven Date: Tue, 31 Aug 2021 17:54:54 +0200 Message-ID: Subject: Re: [RFC PATCH 1/2] lib, stackdepot: Add input prompt for STACKDEPOT option. To: Imran Khan Cc: Christoph Lameter , Andrew Morton , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Imran, On Tue, Aug 31, 2021 at 8:28 AM Imran Khan wrote: > So far CONFIG_STACKDEPOT option was being selected by > features that need STACKDEPOT support for their operations, > for example KASAN. > Since next patch makes use of STACKDEPOT to store user tracking > information for slub debugger and since user tracking info may > or may not store stack trace for allocating and freeing contexts, > make STACKDEPOT explicitly configurable. > > Signed-off-by: Imran Khan Thanks for your patch! > --- > lib/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/Kconfig b/lib/Kconfig > index 6a6ae5312fa0..7e4b54f48af7 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -665,8 +665,9 @@ config ARCH_STACKWALK > bool > > config STACKDEPOT > - bool > + def_bool n Why this change? "n" is the default anyway. > select STACKTRACE > + prompt "Enable stackdepot support" > > config STACK_HASH_ORDER > int "stack depot hash size (12 => 4KB, 20 => 1024KB)" Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB36BC432BE for ; Tue, 31 Aug 2021 15:55:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 17A7E61041 for ; Tue, 31 Aug 2021 15:55:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 17A7E61041 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5087A8D000A; Tue, 31 Aug 2021 11:55:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B7D38D0001; Tue, 31 Aug 2021 11:55:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A82F8D000A; Tue, 31 Aug 2021 11:55:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id 26D2A8D0001 for ; Tue, 31 Aug 2021 11:55:07 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D2B4B173C4 for ; Tue, 31 Aug 2021 15:55:06 +0000 (UTC) X-FDA: 78535824612.39.BB34629 Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) by imf21.hostedemail.com (Postfix) with ESMTP id 90D07D027044 for ; Tue, 31 Aug 2021 15:55:06 +0000 (UTC) Received: by mail-vs1-f42.google.com with SMTP id i23so13681460vsj.4 for ; Tue, 31 Aug 2021 08:55:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rXAig6svknWENNxhE5MWFDZ85DSokchu1E/IR78sJuc=; b=gNWb7508LNWwJ8p21G0soaMZNRkTFW3I5oFneokKB7rawbEOS4zuFb4qqKEaqzzVcT 1wcycKRSQq2UE7ytYf7xN+dq4QRUR1qwlavx0lCIclNDaFxKifLwJQL7Vrrhfzxd82Tv kOFmChQurIw2zQP+U1T57Q/uTRKHOzXnKiIcOLmlz+TEbBZoqJKOUHLvOLOTAtpx97kK Lyg5r2DBCevosVwAOd/ooPdSfWblQTYSG3pv0hmIw34DBM4DCcB3+443l+OOUgdiZIpn rCm3sekM9Zud5CMwAoDJiQSN2SsoMDbETdroEZGdAwKrMTbE1dheZfRWksaQ+4DJs27n K4Vw== X-Gm-Message-State: AOAM533ZaAZzfgtfEZPBkZfTIm8LxtZb7qpD2dQt8i+8nHic7+nWQXU8 ee3tD+2rjDFawSv+c8VO/IW0pqve7fowBVhYH4M= X-Google-Smtp-Source: ABdhPJwd3g3qcsq1rJfE/U29ijK2E1/xXlt4GtyR/vrF5Gnlkgm76LK5kuxADxvS2KbERjJuC/N8lbT7cr8u52dbA/o= X-Received: by 2002:a67:3349:: with SMTP id z70mr18508950vsz.7.1630425305956; Tue, 31 Aug 2021 08:55:05 -0700 (PDT) MIME-Version: 1.0 References: <20210831062539.898293-1-imran.f.khan@oracle.com> <20210831062539.898293-2-imran.f.khan@oracle.com> In-Reply-To: <20210831062539.898293-2-imran.f.khan@oracle.com> From: Geert Uytterhoeven Date: Tue, 31 Aug 2021 17:54:54 +0200 Message-ID: Subject: Re: [RFC PATCH 1/2] lib, stackdepot: Add input prompt for STACKDEPOT option. To: Imran Khan Cc: Christoph Lameter , Andrew Morton , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of geertuytterhoeven@gmail.com designates 209.85.217.42 as permitted sender) smtp.mailfrom=geertuytterhoeven@gmail.com; dmarc=none X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 90D07D027044 X-Stat-Signature: akoaxzbkuswe3o983i3fjbhkg4g779pg X-HE-Tag: 1630425306-648199 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Imran, On Tue, Aug 31, 2021 at 8:28 AM Imran Khan wrote: > So far CONFIG_STACKDEPOT option was being selected by > features that need STACKDEPOT support for their operations, > for example KASAN. > Since next patch makes use of STACKDEPOT to store user tracking > information for slub debugger and since user tracking info may > or may not store stack trace for allocating and freeing contexts, > make STACKDEPOT explicitly configurable. > > Signed-off-by: Imran Khan Thanks for your patch! > --- > lib/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/Kconfig b/lib/Kconfig > index 6a6ae5312fa0..7e4b54f48af7 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -665,8 +665,9 @@ config ARCH_STACKWALK > bool > > config STACKDEPOT > - bool > + def_bool n Why this change? "n" is the default anyway. > select STACKTRACE > + prompt "Enable stackdepot support" > > config STACK_HASH_ORDER > int "stack depot hash size (12 => 4KB, 20 => 1024KB)" Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds