From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751916AbeDIMyd (ORCPT ); Mon, 9 Apr 2018 08:54:33 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:46999 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751522AbeDIMyb (ORCPT ); Mon, 9 Apr 2018 08:54:31 -0400 X-Google-Smtp-Source: AIpwx4+nQuGPabZ4m6MPP3kQw25+nu2ANGwcRyx2mfp5S+Mpl/NBdHN0+VzXhhfIMbStwPlFP3QHohB3tFemZ19kXDg= MIME-Version: 1.0 In-Reply-To: References: From: Geert Uytterhoeven Date: Mon, 9 Apr 2018 14:54:30 +0200 X-Google-Sender-Auth: 0Ea0KBS5JrYmayLdlwanrUO24eI Message-ID: Subject: Re: [PATCH 03/12] m68k/mac: Don't remap SWIM MMIO region To: Finn Thain Cc: Laurent Vivier , Jens Axboe , linux-m68k , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Finn, On Sun, Apr 1, 2018 at 3:41 AM, Finn Thain wrote: > For reasons I don't understand, calling ioremap() then iounmap() on > the SWIM MMIO region causes a hang on 68030 (but not on 68040). Michael Schmitz also notices strange things with ioremap() on '030. > There's no need to call ioremap() for the SWIM address range, as it lies > within the usual IO device region at 0x5000 0000, which is already mapped. by head.S, right? > --- a/drivers/block/swim.c > +++ b/drivers/block/swim.c > @@ -911,7 +911,7 @@ static int swim_probe(struct platform_device *dev) > goto out; > } > > - swim_base = ioremap(res->start, resource_size(res)); > + swim_base = (struct swim __iomem *)res->start; I guess you need a __force to please sparse? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds