From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f68.google.com ([209.85.218.68]:34940 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754615AbcILMAx (ORCPT ); Mon, 12 Sep 2016 08:00:53 -0400 MIME-Version: 1.0 In-Reply-To: References: <20160909155238.17852-1-chris.brandt@renesas.com> <20160909155238.17852-3-chris.brandt@renesas.com> From: Geert Uytterhoeven Date: Mon, 12 Sep 2016 14:00:51 +0200 Message-ID: Subject: Re: [PATCH 2/3] mmc: tmio-mmc: add support for 32bit data port To: Chris Brandt Cc: Ulf Hansson , Wolfram Sang , Simon Horman , Linux MMC List , Linux-Renesas Content-Type: text/plain; charset=UTF-8 Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Chris, On Mon, Sep 12, 2016 at 1:56 PM, Chris Brandt wrote: > On 9/11/12016, Geert Uytterhoeven wrote: >> > So would you say sd_ctrl_write16_rep should also be changed to be 'const >> u16 *buf'? >> > >> > Currently it is: >> > static inline void sd_ctrl_write16_rep(struct tmio_mmc_host *host, int >> addr, >> > u16 *buf, int count) >> > { >> > writesw(host->ctl + (addr << host->bus_shift), buf, count); >> >> Ideally it should become const, too. > > I can add another patch at the end of this series that changes it to match sd_ctrl_write32_rep. > > (unless for some reason you think it should be a separate patch that is not associated with this series) Well, it's not really related to this series, so it can be a separate patch. But including it in this series won't hurt much, I guess. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds