From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754823AbdEITBh (ORCPT ); Tue, 9 May 2017 15:01:37 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:34497 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754782AbdEITBe (ORCPT ); Tue, 9 May 2017 15:01:34 -0400 MIME-Version: 1.0 In-Reply-To: <20170509144108.31910-1-mhocko@kernel.org> References: <20170509144108.31910-1-mhocko@kernel.org> From: Geert Uytterhoeven Date: Tue, 9 May 2017 21:01:25 +0200 X-Google-Sender-Auth: CEe165DVTgIAGeaO_jCFQDsw8eE Message-ID: Subject: Re: [PATCH] mm, vmalloc: fix vmalloc users tracking properly To: Michal Hocko Cc: Linus Torvalds , Andrew Morton , Tobias Klauser , Linux MM , LKML , Michal Hocko Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v49J23eD020165 Hi Michal, On Tue, May 9, 2017 at 4:41 PM, Michal Hocko wrote: > From: Michal Hocko > > 1f5307b1e094 ("mm, vmalloc: properly track vmalloc users") has pulled > asm/pgtable.h include dependency to linux/vmalloc.h and that turned out > to be a bad idea for some architectures. E.g. m68k fails with > In file included from arch/m68k/include/asm/pgtable_mm.h:145:0, > from arch/m68k/include/asm/pgtable.h:4, > from include/linux/vmalloc.h:9, > from arch/m68k/kernel/module.c:9: > arch/m68k/include/asm/mcf_pgtable.h: In function 'nocache_page': >>> arch/m68k/include/asm/mcf_pgtable.h:339:43: error: 'init_mm' undeclared (first use in this function) > #define pgd_offset_k(address) pgd_offset(&init_mm, address) > > as spotted by kernel build bot. nios2 fails for other reason > In file included from ./include/asm-generic/io.h:767:0, > from ./arch/nios2/include/asm/io.h:61, > from ./include/linux/io.h:25, > from ./arch/nios2/include/asm/pgtable.h:18, > from ./include/linux/mm.h:70, > from ./include/linux/pid_namespace.h:6, > from ./include/linux/ptrace.h:9, > from ./arch/nios2/include/uapi/asm/elf.h:23, > from ./arch/nios2/include/asm/elf.h:22, > from ./include/linux/elf.h:4, > from ./include/linux/module.h:15, > from init/main.c:16: > ./include/linux/vmalloc.h: In function '__vmalloc_node_flags': > ./include/linux/vmalloc.h:99:40: error: 'PAGE_KERNEL' undeclared (first use in this function); did you mean 'GFP_KERNEL'? > > which is due to the newly added #include , which on nios2 > includes and thus and which > again includes . > > Tweaking that around just turns out a bigger headache than > necessary. This patch reverts 1f5307b1e094 and reimplements the original > fix in a different way. __vmalloc_node_flags can stay static inline > which will cover vmalloc* functions. We only have one external user > (kvmalloc_node) and we can export __vmalloc_node_flags_caller and > provide the caller directly. This is much simpler and it doesn't really > need any games with header files. > > Fixes: 1f5307b1e094 ("mm, vmalloc: properly track vmalloc users") > Signed-off-by: Michal Hocko FWIW, this did fix the following build failure on m68k in linus/master (commit 2868b2513aa732a9 ("Merge tag 'linux-kselftest-4.12-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest"): In file included from arch/m68k/include/asm/pgtable_mm.h:148, from arch/m68k/include/asm/pgtable.h:5, from include/linux/vmalloc.h:10, from arch/m68k/kernel/module.c:10: arch/m68k/include/asm/motorola_pgtable.h: In function ‘pgd_offset’: arch/m68k/include/asm/motorola_pgtable.h:198: error: dereferencing pointer to incomplete type scripts/Makefile.build:294: recipe for target 'arch/m68k/kernel/module.o' failed but given the complaints from 0day on this and future versions, I think it's better not to provide a Tested-by yet. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f72.google.com (mail-it0-f72.google.com [209.85.214.72]) by kanga.kvack.org (Postfix) with ESMTP id DFE0128035A for ; Tue, 9 May 2017 15:01:29 -0400 (EDT) Received: by mail-it0-f72.google.com with SMTP id o5so7027028ith.8 for ; Tue, 09 May 2017 12:01:29 -0700 (PDT) Received: from mail-io0-x242.google.com (mail-io0-x242.google.com. [2607:f8b0:4001:c06::242]) by mx.google.com with ESMTPS id d71si1519669ite.29.2017.05.09.12.01.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 May 2017 12:01:28 -0700 (PDT) Received: by mail-io0-x242.google.com with SMTP id f102so1131641ioi.3 for ; Tue, 09 May 2017 12:01:28 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20170509144108.31910-1-mhocko@kernel.org> References: <20170509144108.31910-1-mhocko@kernel.org> From: Geert Uytterhoeven Date: Tue, 9 May 2017 21:01:25 +0200 Message-ID: Subject: Re: [PATCH] mm, vmalloc: fix vmalloc users tracking properly Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Linus Torvalds , Andrew Morton , Tobias Klauser , Linux MM , LKML , Michal Hocko Hi Michal, On Tue, May 9, 2017 at 4:41 PM, Michal Hocko wrote: > From: Michal Hocko > > 1f5307b1e094 ("mm, vmalloc: properly track vmalloc users") has pulled > asm/pgtable.h include dependency to linux/vmalloc.h and that turned out > to be a bad idea for some architectures. E.g. m68k fails with > In file included from arch/m68k/include/asm/pgtable_mm.h:145:0, > from arch/m68k/include/asm/pgtable.h:4, > from include/linux/vmalloc.h:9, > from arch/m68k/kernel/module.c:9: > arch/m68k/include/asm/mcf_pgtable.h: In function 'nocache_page': >>> arch/m68k/include/asm/mcf_pgtable.h:339:43: error: 'init_mm' undeclared= (first use in this function) > #define pgd_offset_k(address) pgd_offset(&init_mm, address) > > as spotted by kernel build bot. nios2 fails for other reason > In file included from ./include/asm-generic/io.h:767:0, > from ./arch/nios2/include/asm/io.h:61, > from ./include/linux/io.h:25, > from ./arch/nios2/include/asm/pgtable.h:18, > from ./include/linux/mm.h:70, > from ./include/linux/pid_namespace.h:6, > from ./include/linux/ptrace.h:9, > from ./arch/nios2/include/uapi/asm/elf.h:23, > from ./arch/nios2/include/asm/elf.h:22, > from ./include/linux/elf.h:4, > from ./include/linux/module.h:15, > from init/main.c:16: > ./include/linux/vmalloc.h: In function '__vmalloc_node_flags': > ./include/linux/vmalloc.h:99:40: error: 'PAGE_KERNEL' undeclared (first u= se in this function); did you mean 'GFP_KERNEL'? > > which is due to the newly added #include , which on nios2 > includes and thus and which > again includes . > > Tweaking that around just turns out a bigger headache than > necessary. This patch reverts 1f5307b1e094 and reimplements the original > fix in a different way. __vmalloc_node_flags can stay static inline > which will cover vmalloc* functions. We only have one external user > (kvmalloc_node) and we can export __vmalloc_node_flags_caller and > provide the caller directly. This is much simpler and it doesn't really > need any games with header files. > > Fixes: 1f5307b1e094 ("mm, vmalloc: properly track vmalloc users") > Signed-off-by: Michal Hocko FWIW, this did fix the following build failure on m68k in linus/master (commit 2868b2513aa732a9 ("Merge tag 'linux-kselftest-4.12-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest"): In file included from arch/m68k/include/asm/pgtable_mm.h:148, from arch/m68k/include/asm/pgtable.h:5, from include/linux/vmalloc.h:10, from arch/m68k/kernel/module.c:10: arch/m68k/include/asm/motorola_pgtable.h: In function =E2=80=98pgd_offs= et=E2=80=99: arch/m68k/include/asm/motorola_pgtable.h:198: error: dereferencing pointer to incomplete type scripts/Makefile.build:294: recipe for target 'arch/m68k/kernel/module.o' failed but given the complaints from 0day on this and future versions, I think it'= s better not to provide a Tested-by yet. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org