From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f175.google.com ([209.85.220.175]:38835 "EHLO mail-qk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbeCIMdF (ORCPT ); Fri, 9 Mar 2018 07:33:05 -0500 Received: by mail-qk0-f175.google.com with SMTP id s198so3405337qke.5 for ; Fri, 09 Mar 2018 04:33:04 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1518696091-23561-1-git-send-email-ulrich.hecht+renesas@gmail.com> <1518696091-23561-2-git-send-email-ulrich.hecht+renesas@gmail.com> From: Geert Uytterhoeven Date: Fri, 9 Mar 2018 13:33:03 +0100 Message-ID: Subject: Re: [PATCH 1/4] pinctrl: sh-pfc: r8a7796: Add VIN4, VIN5 pins, groups and functions To: Ulrich Hecht Cc: Linux-Renesas , Laurent Pinchart , Kieran Bingham , Sergei Shtylyov , =?UTF-8?Q?Niklas_S=C3=B6derlund?= Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Uli, On Mon, Feb 26, 2018 at 11:18 AM, Geert Uytterhoeven wrote: > On Mon, Feb 26, 2018 at 10:21 AM, Geert Uytterhoeven > wrote: >> On Mon, Feb 26, 2018 at 10:02 AM, Ulrich Hecht >> wrote: >>> On Tue, Feb 20, 2018 at 2:58 PM, Geert Uytterhoeven >>> wrote: >>>> Would there be a use case for vin4_data4 and vin5_data4, or is that >>>> mode only supported on R-Car H2? >>> >>> The docs don't mention it, so I would assume it's not supported. >> >> Thank you, queuing (also for r8a7795 and r8a77995) in sh-pfc-for-v4.17. > > Please send follow-up patches to reduce vin_data duplication. Due to Sergei's submission for r8a77980, my attention was drawn to Tables 26.8.x, which describes which pins are used for each video input format. The newly added tables for data18 are not correct, as they use the VI4_DATA0-17 pins, while data18/rgb666 uses the same pins as data24/rgb888 mode, minus the 2 LSB pins for each channel. The BSP does it right, just like the R-Car Gen2 PFC drivers. As in the mean time this is in pinctrl/for-next, can you please send follow-up patches fixing this bug for R-Car H3, M3-W, and D3? Thanks! P.S. Apparently R-Car Gen2 and Gen3 also support 8-bit YCbCr input data on the DATA8-15 pins, for which we don't have pin groups yet. Niklas: is this mode supported by the VIN driver? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds