From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F38FEB64DD for ; Tue, 4 Jul 2023 08:01:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231152AbjGDIBu convert rfc822-to-8bit (ORCPT ); Tue, 4 Jul 2023 04:01:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230375AbjGDIBr (ORCPT ); Tue, 4 Jul 2023 04:01:47 -0400 Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC1AFBD; Tue, 4 Jul 2023 01:01:46 -0700 (PDT) Received: by mail-yb1-f170.google.com with SMTP id 3f1490d57ef6-c11e2b31b95so5886056276.3; Tue, 04 Jul 2023 01:01:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688457706; x=1691049706; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3VFQbKQ0ZnXtJ93rzqEp4TN1FXtg0VMVDun5sAa3KpE=; b=SDquQbPBWpTbehYAmyvhPCkR1YBjoD2kcCsVDC1WE7hT2TyPqMk0zcpEQ+QrP9/WFP yz149Nsu9rx2RFISvczX1V20aE/nwr7KN13G3nLL3HGBUTiwsLcx/kOJlOUyzYDuKV78 1bGwV9GVD9Y5860FBgqLOq1FAsuh9efwZv84cwlr/Q7GpcB9j4TXoCQwCw6vLjvsKbqd j1wCsqgCJaeQbG8z+Gtw1efA2ECnxL/ndkpzVwjWKKGv1BRotrRUeHgcWSsxtfM9crR/ JB2lLSCBcDsXeMxW39sJ+nlPPzRszb1z+F+/p2zsrKA/NfGGW8Jm7QBxrnFl9q7P9z1r 1FWQ== X-Gm-Message-State: ABy/qLabVOqQAHqTiKIKxYlwGqLfhYkpmgh3GNpsGxmtx978XVCkr+qw E3BtfcOhU/4XcjRuPAZOMLoR5gMqgrPiog== X-Google-Smtp-Source: APBJJlHuE0CyWv1H1OT9oPTvzcdrZ4aBv/ohZ3eDhedacSRBOh5ouERAtTbgDBp9fGCmyX6U/bHOPQ== X-Received: by 2002:a25:9e87:0:b0:bcc:571d:a300 with SMTP id p7-20020a259e87000000b00bcc571da300mr10345771ybq.20.1688457705942; Tue, 04 Jul 2023 01:01:45 -0700 (PDT) Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com. [209.85.219.178]) by smtp.gmail.com with ESMTPSA id a126-20020a254d84000000b00be45a29d440sm4777189ybb.12.2023.07.04.01.01.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jul 2023 01:01:44 -0700 (PDT) Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-c50c797c31bso2558601276.0; Tue, 04 Jul 2023 01:01:44 -0700 (PDT) X-Received: by 2002:a25:6cd4:0:b0:bac:1522:f870 with SMTP id h203-20020a256cd4000000b00bac1522f870mr12173244ybc.52.1688457704084; Tue, 04 Jul 2023 01:01:44 -0700 (PDT) MIME-Version: 1.0 References: <20230703230534.997525-1-javierm@redhat.com> <20230703230534.997525-2-javierm@redhat.com> <87h6qkyuv4.fsf@minerva.mail-host-address-is-not-set> In-Reply-To: <87h6qkyuv4.fsf@minerva.mail-host-address-is-not-set> From: Geert Uytterhoeven Date: Tue, 4 Jul 2023 10:01:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 1/5] video: Add auxiliary display drivers to Graphics support menu To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Thomas Zimmermann , Arnd Bergmann , Greg Kroah-Hartman , Helge Deller , Jacek Lawrynowicz , Nipun Gupta , Oded Gabbay , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javier, On Tue, Jul 4, 2023 at 9:54 AM Javier Martinez Canillas wrote: > Geert Uytterhoeven writes: > > On Tue, Jul 4, 2023 at 1:05 AM Javier Martinez Canillas > > wrote: > >> The drivers in this subsystem are for character-based LCD displays, which > >> can fall into the same category of the DRM/KMS and fbdev drivers that are > >> located under the "Graphics support" menu. Add auxdisplay there as well. > >> > >> Suggested-by: Thomas Zimmermann > >> Signed-off-by: Javier Martinez Canillas > > > > Thanks for your patch! > > > >> --- a/drivers/video/Kconfig > >> +++ b/drivers/video/Kconfig > >> @@ -30,6 +30,8 @@ if HAS_IOMEM > >> config HAVE_FB_ATMEL > >> bool > >> > >> +source "drivers/auxdisplay/Kconfig" > > > > This is inside the "if HAS_IOMEM" section, while there was no > > such limitation before. > > > > Gah, I missed that. Thanks a lot for pointing it out. > > If I move the source outside of the if block, are you OK with this patch? > > I think Thomas is correct and would make sense to put the character-based > drivers next to the DRM and fbdev drivers since all these are for display. Yes, makes sense to me. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CEDBAEB64DA for ; Tue, 4 Jul 2023 08:01:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D68210E2AD; Tue, 4 Jul 2023 08:01:48 +0000 (UTC) Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B63E10E2AD for ; Tue, 4 Jul 2023 08:01:47 +0000 (UTC) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-5703d12ab9aso64639407b3.2 for ; Tue, 04 Jul 2023 01:01:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688457706; x=1691049706; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3VFQbKQ0ZnXtJ93rzqEp4TN1FXtg0VMVDun5sAa3KpE=; b=GA2PB6sCsgL6A/OexsO0HlQZWXkIjc5qkJ0owchvRkp6AoeG9lm8NW39PY2tzkT6zb flRjwhG3BQdsQWhEFfwFDdqsoZzeLjWz0LiTSxsEdCUWz8lEKV4aJ5RSvtQDLhLcI3oF M0LYkIp21XqvvWeOXLQZCzMdL+JtMDdyUGzQkJa6QgFGoW+J7zXhbBe+xraMNOVsKwVc ORi/AaHRzxTm2WBf53a2SMLFZ9w3u70UidfYSRH/8BnHs1UbVpK93iaUqt+IR5koXBWI qT858IRj6pjJXnfj+EzmsY4zlM6UnOzB3DTeTUjHzicYLxxAKrAnC4zgvpT/1M9MXgHa wTQQ== X-Gm-Message-State: ABy/qLa3X+JFTg/9ReQg9kBZYjq9Q5DFU352gvJ8VuXOY4ZNWo9VOUU/ DVQY89RbFJ9159uToPaZdjOz5qenx3t8lQ== X-Google-Smtp-Source: APBJJlHz4OwITx7d82p3ooAvF59vOpiuT5xd3NrceQkldU4FyeAIrgCw9XmrIAS7GM/QRmJt/IIV0g== X-Received: by 2002:a81:a156:0:b0:579:efb4:7d08 with SMTP id y83-20020a81a156000000b00579efb47d08mr7144555ywg.27.1688457705809; Tue, 04 Jul 2023 01:01:45 -0700 (PDT) Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com. [209.85.128.181]) by smtp.gmail.com with ESMTPSA id a2-20020a0dd802000000b0054f9e7fed7asm5547205ywe.137.2023.07.04.01.01.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jul 2023 01:01:44 -0700 (PDT) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-5774098f16eso53263147b3.0 for ; Tue, 04 Jul 2023 01:01:44 -0700 (PDT) X-Received: by 2002:a25:6cd4:0:b0:bac:1522:f870 with SMTP id h203-20020a256cd4000000b00bac1522f870mr12173244ybc.52.1688457704084; Tue, 04 Jul 2023 01:01:44 -0700 (PDT) MIME-Version: 1.0 References: <20230703230534.997525-1-javierm@redhat.com> <20230703230534.997525-2-javierm@redhat.com> <87h6qkyuv4.fsf@minerva.mail-host-address-is-not-set> In-Reply-To: <87h6qkyuv4.fsf@minerva.mail-host-address-is-not-set> From: Geert Uytterhoeven Date: Tue, 4 Jul 2023 10:01:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 1/5] video: Add auxiliary display drivers to Graphics support menu To: Javier Martinez Canillas Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Arnd Bergmann , Nipun Gupta , Greg Kroah-Hartman , Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jacek Lawrynowicz , Thomas Zimmermann , Oded Gabbay Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Javier, On Tue, Jul 4, 2023 at 9:54=E2=80=AFAM Javier Martinez Canillas wrote: > Geert Uytterhoeven writes: > > On Tue, Jul 4, 2023 at 1:05=E2=80=AFAM Javier Martinez Canillas > > wrote: > >> The drivers in this subsystem are for character-based LCD displays, wh= ich > >> can fall into the same category of the DRM/KMS and fbdev drivers that = are > >> located under the "Graphics support" menu. Add auxdisplay there as wel= l. > >> > >> Suggested-by: Thomas Zimmermann > >> Signed-off-by: Javier Martinez Canillas > > > > Thanks for your patch! > > > >> --- a/drivers/video/Kconfig > >> +++ b/drivers/video/Kconfig > >> @@ -30,6 +30,8 @@ if HAS_IOMEM > >> config HAVE_FB_ATMEL > >> bool > >> > >> +source "drivers/auxdisplay/Kconfig" > > > > This is inside the "if HAS_IOMEM" section, while there was no > > such limitation before. > > > > Gah, I missed that. Thanks a lot for pointing it out. > > If I move the source outside of the if block, are you OK with this patch? > > I think Thomas is correct and would make sense to put the character-based > drivers next to the DRM and fbdev drivers since all these are for display= . Yes, makes sense to me. Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds