From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88503C433EF for ; Thu, 14 Apr 2022 09:33:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241830AbiDNJff (ORCPT ); Thu, 14 Apr 2022 05:35:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241821AbiDNJfd (ORCPT ); Thu, 14 Apr 2022 05:35:33 -0400 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A81B70CFE; Thu, 14 Apr 2022 02:33:09 -0700 (PDT) Received: by mail-qv1-f49.google.com with SMTP id x20so3561396qvl.10; Thu, 14 Apr 2022 02:33:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wT+WD+e2d8eELH39rVnQiOaRvZ4T5k/ulSuMocFHoO0=; b=WCb9CrYNMnvknLjmJwx8d833KEzkGJe4PnAHE7TCjTDSf0aCHRfms6+riyfWTZ9IkR W7RjgrAfJb4s0g/8aFg9owovC6epCc5kWjxfMxyP+HXlx6sDS8T+PmNojmA0Y6vlKmxQ Q+Oe89ItNITf0JTsUV2eUuWQ1eCmzK6mfzR7KBWOuya072kjp1L9RrBp0Ol0h57YgmwK m6HFX8bgOWCHhnBMa9MO6mU/ZIcYMSpGaLe4yc6yOy/UI1mB0idMewg+A5i8DhyeSrmW aIvXc7IFfmXEjSDxNn8efhH5PUFf5lHpTlVCMgjyeAWlRsqI9y1gKkQPlJiasL0PXAJh YYNA== X-Gm-Message-State: AOAM533IotIdoaij04ZjaeS+PXsoAJjhc74td0kuQAJbdMPUCQnmJ0kl w8YfLu9VFDmyJEkBprqP+42wL1+o13L26g== X-Google-Smtp-Source: ABdhPJw5tZPsLUiQ2CSgHvWEiXMmwLaJ/6vrs6oVMrssBXG/3CdZRSW6P5v8eqcYZuNQfypJ0J5qLQ== X-Received: by 2002:a05:6214:20e9:b0:441:527f:dffa with SMTP id 9-20020a05621420e900b00441527fdffamr2507246qvk.34.1649928787542; Thu, 14 Apr 2022 02:33:07 -0700 (PDT) Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com. [209.85.128.177]) by smtp.gmail.com with ESMTPSA id 193-20020a3703ca000000b0069bf950dd20sm740384qkd.43.2022.04.14.02.33.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Apr 2022 02:33:07 -0700 (PDT) Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-2ebebe631ccso49265497b3.4; Thu, 14 Apr 2022 02:33:06 -0700 (PDT) X-Received: by 2002:a81:4782:0:b0:2eb:1cb1:5441 with SMTP id u124-20020a814782000000b002eb1cb15441mr1147758ywa.479.1649928786553; Thu, 14 Apr 2022 02:33:06 -0700 (PDT) MIME-Version: 1.0 References: <1649837953-10984-1-git-send-email-baihaowen@meizu.com> <2ed01eb3-ff46-425c-75dc-81729a5c30a8@omp.ru> In-Reply-To: <2ed01eb3-ff46-425c-75dc-81729a5c30a8@omp.ru> From: Geert Uytterhoeven Date: Thu, 14 Apr 2022 11:32:55 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V2] clk: renesas: Fix memory leak of 'cpg' To: Sergey Shtylyov Cc: Haowen Bai , Michael Turquette , Stephen Boyd , Linux-Renesas , linux-clk , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Sergei, On Thu, Apr 14, 2022 at 11:29 AM Sergey Shtylyov wrote: > On 4/13/22 11:19 AM, Haowen Bai wrote: > > Fix this issue by freeing the cpg when exiting the function in the > > error/normal path. > > > > Signed-off-by: Haowen Bai > > --- > > V1->V2: free both cpg&clks. > > > > drivers/clk/renesas/clk-r8a73a4.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > 2 patches with the same name won't do -- you always need to include the chip name > part of the file name in the subject (in this case r8a73a4). Oh, they were for multiple drivers? I hadn't even noticed , as Gmail collapsed them all into the same thread... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds