From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F25DFA372C for ; Fri, 8 Nov 2019 08:37:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F3892178F for ; Fri, 8 Nov 2019 08:37:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730849AbfKHIhJ (ORCPT ); Fri, 8 Nov 2019 03:37:09 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:38724 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726987AbfKHIhI (ORCPT ); Fri, 8 Nov 2019 03:37:08 -0500 Received: by mail-oi1-f196.google.com with SMTP id a14so4563048oid.5; Fri, 08 Nov 2019 00:37:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y06rTA9jyJ3Mxb7FOxzfvb/JyrQ6mJjiIx0NSmTLT3w=; b=AWGAXSm2c0Yspjg8qNfi6qHsKYdT1nOowipVHrrzRIY4GxtI7ot9O1Zfw5uq7Adp4D 7KfRmLixTQMMcHFngqAPbmevJXWNkAFvVp2FGkS/uTgGnJo0jmGk7tLLqX4G/YHHLvGT ibBR54MlIv1+6/lMYCcfxYHazihL/v3mSsfp9o1jEqaBSAZ3sdAgc36l/8UWMZlyN8PX bUsafmAfcbSAcF1YsJwSH+a6wkfcIbcgwEOoJ2aaB/+QRPVOCYNHmREqkROQb8cxTlum jALbQIj5xwQApIVc7L1uH0gCudKUV4DxpiZIUWmmYaOehXsJ8E3KpW5Jb30VK47HvwIm ZIbA== X-Gm-Message-State: APjAAAUSMGdMvDVklv3rjLryuFKYu1rOj0IhzB18+1Psp8NdeXGr7EtS yE2/G58kgV/i2hcCJbqH7LJI+yt+fMKEVFOHUJ0= X-Google-Smtp-Source: APXvYqw443xjtR/GhQGqZswNAQFjWLyPmQgXA4uSDYnc1ZjfU91/njipFK4I8i0EWJx17iUi7lyKc1yYaFBEyegxbZY= X-Received: by 2002:aca:fc92:: with SMTP id a140mr7932910oii.153.1573202227574; Fri, 08 Nov 2019 00:37:07 -0800 (PST) MIME-Version: 1.0 References: <20191106193609.19645-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20191106193609.19645-4-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 8 Nov 2019 09:36:56 +0100 Message-ID: Subject: Re: [PATCH 3/5] PCI: rcar: Add R-Car PCIe endpoint device tree bindings To: "Lad, Prabhakar" Cc: Bjorn Helgaas , Rob Herring , Mark Rutland , Magnus Damm , Kishon Vijay Abraham I , Marek Vasut , Yoshihiro Shimoda , linux-pci , Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , Andrew Murray , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux ARM , Linux-Renesas , Chris Paterson , "Lad, Prabhakar" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Prabhakar, On Thu, Nov 7, 2019 at 11:46 PM Lad, Prabhakar wrote: > On Thu, Nov 7, 2019 at 8:08 PM Geert Uytterhoeven wrote: > > On Thu, Nov 7, 2019 at 10:26 AM Lad, Prabhakar > > wrote: > > > On Thu, Nov 7, 2019 at 8:44 AM Geert Uytterhoeven wrote: > > > > On Wed, Nov 6, 2019 at 8:36 PM Lad Prabhakar wrote: > > > > > From: "Lad, Prabhakar" > > > > > > > > > > This patch adds the bindings for the R-Car PCIe endpoint driver. > > > > > > > > > > Signed-off-by: Lad, Prabhakar > > > > > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/pci/rcar-pci-ep.txt > > > > > +- reg: Five register ranges as listed in the reg-names property > > > > > +- reg-names: Must include the following names > > > > > + - "apb-base" > > > > > + - "memory0" > > > > > + - "memory1" > > > > > + - "memory2" > > > > > + - "memory3" > > > > > > > > What is the purpose of the last 4 regions? > > > > Can they be chosen by the driver, at runtime? > > > > > > > no the driver cannot choose them at runtime, as these are the only > > > PCIE memory(0/1/2/3) ranges > > > in the AXI address space where host memory can be mapped. > > > > Are they fixed by the PCIe hardware, i.e. could they be looked up by the > > driver based on the compatible value? > > > yes they are fixed by the PCIe hardware and could be looked up by the driver > based on the compatible value. Thanks, so we don't need to describe them in DT. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65E6BFA372C for ; Fri, 8 Nov 2019 08:37:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 355352178F for ; Fri, 8 Nov 2019 08:37:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UhyeCfs7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 355352178F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uj07q/tINmjI5VpCMUX7MVthIUk/Mr0t+pazfKCHYH4=; b=UhyeCfs7HYj4U9 dD8zZDUQbeUiknxaaj1G6PlhcBxuNps6kxGARvbPLxTutryUKyxy9dzNO2ShUu3X+eVFVHIZB6Woq W6CfZzkgy5JUQGDf47erCRV4jdEis47e8u2T8j1fY1d42Zh7O/OgYudKHXxrlU7XUfs8D6rImzL/R NOPrGJTUv5VDt9SyltnUxUZWHIBv7BjcVrGWxviwsh7c6kxKubIs7IjeFnesJOkheuuaZKzTO04gB sJ2uv9xCxsPX7J+mNXCvF3grZGA8V5EIUKpoT+If1MhVDKw6eHKRiGXGH3NeekzzX8uN/icTVRJxc YrWNN2YHf8Ox89RnHL3w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSzlY-0001OW-NX; Fri, 08 Nov 2019 08:37:12 +0000 Received: from mail-oi1-f196.google.com ([209.85.167.196]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSzlU-0001Ng-MQ for linux-arm-kernel@lists.infradead.org; Fri, 08 Nov 2019 08:37:10 +0000 Received: by mail-oi1-f196.google.com with SMTP id j7so4576681oib.3 for ; Fri, 08 Nov 2019 00:37:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y06rTA9jyJ3Mxb7FOxzfvb/JyrQ6mJjiIx0NSmTLT3w=; b=Eu5NHHlTTJqYyjT1yY59TsIqqSkmv2aPqiS5Gsnv3sooW3/7TPjebq35hroS6laAPF T4b7ry3Juz19KggYlQHAwHYF1/2mHxBwCQ7rCMKqVfccICj/TdHVT1Watbi7tqPb3eS6 cI7BhFvJXOqE40M+T66pufAt9EljjIwrezlEn9XVqHCuhbbSP5oC3yqfXCC3NfH/Ojkt hfr3ajurbrDIwW5rIjBnmoXYmBRpw8QacNGEJVdAHEyUPPtxdGJBMX3ROcC4XxpO9uTP J+Mko4yrXvYRr/Ax+Omn1DX31JdTZnkvrmHnbAnAWGJq7ZfsicDprahasV34bAdRSCYh I1nQ== X-Gm-Message-State: APjAAAVpiOga+aN0lGh+1d0S5GFTfEzENnS1utlaR13G7aRa59M0KmRr SmOl4Ypco8tRGztBAdR8cZbpV4c6WMkf7RodeqU= X-Google-Smtp-Source: APXvYqw443xjtR/GhQGqZswNAQFjWLyPmQgXA4uSDYnc1ZjfU91/njipFK4I8i0EWJx17iUi7lyKc1yYaFBEyegxbZY= X-Received: by 2002:aca:fc92:: with SMTP id a140mr7932910oii.153.1573202227574; Fri, 08 Nov 2019 00:37:07 -0800 (PST) MIME-Version: 1.0 References: <20191106193609.19645-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20191106193609.19645-4-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 8 Nov 2019 09:36:56 +0100 Message-ID: Subject: Re: [PATCH 3/5] PCI: rcar: Add R-Car PCIe endpoint device tree bindings To: "Lad, Prabhakar" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191108_003708_732207_03A6C1D5 X-CRM114-Status: GOOD ( 19.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Chris Paterson , Lorenzo Pieralisi , "Lad, Prabhakar" , Arnd Bergmann , Greg Kroah-Hartman , linux-pci , Yoshihiro Shimoda , Magnus Damm , Linux Kernel Mailing List , Kishon Vijay Abraham I , Linux-Renesas , Rob Herring , Catalin Marinas , Bjorn Helgaas , Andrew Murray , Will Deacon , Linux ARM , Marek Vasut Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Prabhakar, On Thu, Nov 7, 2019 at 11:46 PM Lad, Prabhakar wrote: > On Thu, Nov 7, 2019 at 8:08 PM Geert Uytterhoeven wrote: > > On Thu, Nov 7, 2019 at 10:26 AM Lad, Prabhakar > > wrote: > > > On Thu, Nov 7, 2019 at 8:44 AM Geert Uytterhoeven wrote: > > > > On Wed, Nov 6, 2019 at 8:36 PM Lad Prabhakar wrote: > > > > > From: "Lad, Prabhakar" > > > > > > > > > > This patch adds the bindings for the R-Car PCIe endpoint driver. > > > > > > > > > > Signed-off-by: Lad, Prabhakar > > > > > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/pci/rcar-pci-ep.txt > > > > > +- reg: Five register ranges as listed in the reg-names property > > > > > +- reg-names: Must include the following names > > > > > + - "apb-base" > > > > > + - "memory0" > > > > > + - "memory1" > > > > > + - "memory2" > > > > > + - "memory3" > > > > > > > > What is the purpose of the last 4 regions? > > > > Can they be chosen by the driver, at runtime? > > > > > > > no the driver cannot choose them at runtime, as these are the only > > > PCIE memory(0/1/2/3) ranges > > > in the AXI address space where host memory can be mapped. > > > > Are they fixed by the PCIe hardware, i.e. could they be looked up by the > > driver based on the compatible value? > > > yes they are fixed by the PCIe hardware and could be looked up by the driver > based on the compatible value. Thanks, so we don't need to describe them in DT. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel