From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48291C433E0 for ; Wed, 27 Jan 2021 08:53:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EAC220754 for ; Wed, 27 Jan 2021 08:53:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233003AbhA0Iwl (ORCPT ); Wed, 27 Jan 2021 03:52:41 -0500 Received: from mail-ot1-f43.google.com ([209.85.210.43]:39104 "EHLO mail-ot1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231281AbhA0ItA (ORCPT ); Wed, 27 Jan 2021 03:49:00 -0500 Received: by mail-ot1-f43.google.com with SMTP id i30so962577ota.6; Wed, 27 Jan 2021 00:48:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gAKk6Yt/rmV2RLudc2xk6PS0Y1a3qymlWcwiHDkjBr8=; b=m0f2FdGzYRFd9t1J4fdfTXTSeSpkoQmTJbZEaTWfATGjzqmGYGiD77CN5NxQaLvwHX iXXeD1I3TXUeXWUp3Ilkc+bFbryLbqXfwl22yPA8LVwUnwcizLJ/EQ8JHNxqJQJKd3VX QAAi73n47tA/oGr5cs4cv2wej7b+u1oE5aMlFgPIQt7bslDSfE4c6PDt8RUBOLzLy/u0 n8X3epoaA+qv9pqCV7En0VE31OHulTnjUVT0oHCYD4F2OmWXnGicMyOAVSrn1wuu7wK8 DW/hDrSvoVJG55QEJmZOdOeZw1hY7gbWQLpbegmRJ4kalwxaeceiXH9SUIKjnKUdxJYM QD9A== X-Gm-Message-State: AOAM532SuEdMYWS7fapyyK8gVUO2GHAyZs8YJRTcrVDXtgHkGAchBReu D/yW2kV0sh/8mLJEpo+sqrWFpyuBeH4HIlqPK+Q= X-Google-Smtp-Source: ABdhPJySkivwQpGFAZ+Grur9SYXrqqzDLD2UjmL030BacL3j7AyYhWe0zsuxjg9LQwAaq9rS0JKApCeVs56Z0mGYjzQ= X-Received: by 2002:a05:6830:15cc:: with SMTP id j12mr6928590otr.145.1611737299392; Wed, 27 Jan 2021 00:48:19 -0800 (PST) MIME-Version: 1.0 References: <1611711140-68260-1-git-send-email-zhangxuezhi3@gmail.com> <20210127054523.GA2696@kadam> <20210127141927.00004472@gmail.com> <20210127064916.GD2696@kadam> In-Reply-To: <20210127064916.GD2696@kadam> From: Geert Uytterhoeven Date: Wed, 27 Jan 2021 09:48:08 +0100 Message-ID: Subject: Re: [PATCH v5] fbtft: add tearing signal detect To: Dan Carpenter , carlis Cc: driverdevel , Linux Fbdev development list , mh12gx2825@gmail.com, Greg KH , oliver.graute@kococonnector.com, Linux Kernel Mailing List , DRI Development , Stefano Brivio , Colin King , zhangxuezhi1@yulong.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, Carlis, On Wed, Jan 27, 2021 at 9:32 AM Dan Carpenter wrote: > On Wed, Jan 27, 2021 at 02:19:27PM +0800, carlis wrote: > > hi,i will fix it like below: > > par->gpio.te = devm_gpiod_get_index_optional(dev, "te", 0, > > GPIOD_IN); if (IS_ERR(par->gpio.te)) { > > rc = PTR_ERR(par->gpio.te); > > pr_err("Failed to request te gpio: %d\n", rc); > > par->gpio.te = NULL; > > } > > I wish you would just copy and paste the code that I sent you instead, > but this also fixes the crash... While this fixes the crash, it does not propagate the error condition (which may be -EPROBE_DEFER) upstream. Same for devm_request_irq(). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DC8BC433DB for ; Wed, 27 Jan 2021 08:48:25 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD6072054F for ; Wed, 27 Jan 2021 08:48:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD6072054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id ACB9886755; Wed, 27 Jan 2021 08:48:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QIEW-CLoIxd9; Wed, 27 Jan 2021 08:48:21 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id DCF878672B; Wed, 27 Jan 2021 08:48:21 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 132081BF834 for ; Wed, 27 Jan 2021 08:48:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 0EF0286FCA for ; Wed, 27 Jan 2021 08:48:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7BIkLhnlZlNs for ; Wed, 27 Jan 2021 08:48:20 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) by hemlock.osuosl.org (Postfix) with ESMTPS id 1198D86FC9 for ; Wed, 27 Jan 2021 08:48:20 +0000 (UTC) Received: by mail-ot1-f53.google.com with SMTP id d1so932492otl.13 for ; Wed, 27 Jan 2021 00:48:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gAKk6Yt/rmV2RLudc2xk6PS0Y1a3qymlWcwiHDkjBr8=; b=FSqL17fvL1zCuk83UIArahLmfpXuwKcjHLOA1L7lsAZkvSLUTv0g9uqKnE9VZKZLkg gylH2O3tHhXTXyTGo2sJJUuN/lWcqHHmj3O5uvDo8T0qIr3S13dKNuCTXPMsqAK6FXuD oSD3OIbhoPjpTJCy6zftoYXxLgw0KA0QK0t707FCO2CZvMYpmLxCv6bq/qz1vfVJK0LO IOMXuIlsB7t2uXRJD0Q1yL/OIlPumJOYz2fFSQ9hyV70Uf6h8RjsrZlTWEOQJSnsI/1c S3yCSSK7jW+2bOYdUBIfseLO3oQDFAexs6wg3DChR0nDzuwPTb61SAK+GYTTbDqxGDXy 5faw== X-Gm-Message-State: AOAM530v34fFoTv3ZeJ4MrMFPofaKbCNNXGcoATwmUFEwiP0TY3D2POC 7yhqnLUmRdE+ox+2SKIruTx+2pXzPL72Wpg9Zn0= X-Google-Smtp-Source: ABdhPJySkivwQpGFAZ+Grur9SYXrqqzDLD2UjmL030BacL3j7AyYhWe0zsuxjg9LQwAaq9rS0JKApCeVs56Z0mGYjzQ= X-Received: by 2002:a05:6830:15cc:: with SMTP id j12mr6928590otr.145.1611737299392; Wed, 27 Jan 2021 00:48:19 -0800 (PST) MIME-Version: 1.0 References: <1611711140-68260-1-git-send-email-zhangxuezhi3@gmail.com> <20210127054523.GA2696@kadam> <20210127141927.00004472@gmail.com> <20210127064916.GD2696@kadam> In-Reply-To: <20210127064916.GD2696@kadam> From: Geert Uytterhoeven Date: Wed, 27 Jan 2021 09:48:08 +0100 Message-ID: Subject: Re: [PATCH v5] fbtft: add tearing signal detect To: Dan Carpenter , carlis X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: driverdevel , Linux Fbdev development list , mh12gx2825@gmail.com, Greg KH , oliver.graute@kococonnector.com, Linux Kernel Mailing List , DRI Development , Stefano Brivio , Colin King , zhangxuezhi1@yulong.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi Dan, Carlis, On Wed, Jan 27, 2021 at 9:32 AM Dan Carpenter wrote: > On Wed, Jan 27, 2021 at 02:19:27PM +0800, carlis wrote: > > hi,i will fix it like below: > > par->gpio.te = devm_gpiod_get_index_optional(dev, "te", 0, > > GPIOD_IN); if (IS_ERR(par->gpio.te)) { > > rc = PTR_ERR(par->gpio.te); > > pr_err("Failed to request te gpio: %d\n", rc); > > par->gpio.te = NULL; > > } > > I wish you would just copy and paste the code that I sent you instead, > but this also fixes the crash... While this fixes the crash, it does not propagate the error condition (which may be -EPROBE_DEFER) upstream. Same for devm_request_irq(). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87B5CC433E0 for ; Wed, 27 Jan 2021 08:48:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BCBA2054F for ; Wed, 27 Jan 2021 08:48:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BCBA2054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4897189E14; Wed, 27 Jan 2021 08:48:21 +0000 (UTC) Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0BE0889E14 for ; Wed, 27 Jan 2021 08:48:20 +0000 (UTC) Received: by mail-ot1-f48.google.com with SMTP id v1so947461ott.10 for ; Wed, 27 Jan 2021 00:48:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gAKk6Yt/rmV2RLudc2xk6PS0Y1a3qymlWcwiHDkjBr8=; b=hpkECkevJHXSRsK8iq1sXAzKql+SxVJPbPnAJWoochSpZy/ce5KV/X8qE/LiJxPZau ADrXjw7mWcB9FaJGGLl9bnplLdBPeuFt8W0EeoNLh0xmTjCau/iNPWKS+FQbFHesttNG TWavAm7H4njlFVMB0tB25KS9C9UYtEayRwnyLfGWff7VvzFHhRqgogg7++zDy+MMejwL kTOs0jkAsB96A5XSJZjINg3cah5GxBVoZigjHA3NKIBtOBX5CCpUPb7B4oYQOxlnX5SP rZoAABDKpRFnqFCR5kASm1NImJvcjZLlMIlHQW5yYl40PNlyKKCDhfYKTGJHz7p806xD z9nw== X-Gm-Message-State: AOAM530bGyYyubAynsNwxXQVQZe4rlvCAKOzoKxmH7WS0BUIq+PQlSLb 6HRFwt5gkzLKJas2ppXRh0algmGZBYP1oGIJNWk= X-Google-Smtp-Source: ABdhPJySkivwQpGFAZ+Grur9SYXrqqzDLD2UjmL030BacL3j7AyYhWe0zsuxjg9LQwAaq9rS0JKApCeVs56Z0mGYjzQ= X-Received: by 2002:a05:6830:15cc:: with SMTP id j12mr6928590otr.145.1611737299392; Wed, 27 Jan 2021 00:48:19 -0800 (PST) MIME-Version: 1.0 References: <1611711140-68260-1-git-send-email-zhangxuezhi3@gmail.com> <20210127054523.GA2696@kadam> <20210127141927.00004472@gmail.com> <20210127064916.GD2696@kadam> In-Reply-To: <20210127064916.GD2696@kadam> From: Geert Uytterhoeven Date: Wed, 27 Jan 2021 09:48:08 +0100 Message-ID: Subject: Re: [PATCH v5] fbtft: add tearing signal detect To: Dan Carpenter , carlis X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: driverdevel , Linux Fbdev development list , mh12gx2825@gmail.com, Greg KH , oliver.graute@kococonnector.com, Linux Kernel Mailing List , DRI Development , Stefano Brivio , Colin King , zhangxuezhi1@yulong.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Dan, Carlis, On Wed, Jan 27, 2021 at 9:32 AM Dan Carpenter wrote: > On Wed, Jan 27, 2021 at 02:19:27PM +0800, carlis wrote: > > hi,i will fix it like below: > > par->gpio.te = devm_gpiod_get_index_optional(dev, "te", 0, > > GPIOD_IN); if (IS_ERR(par->gpio.te)) { > > rc = PTR_ERR(par->gpio.te); > > pr_err("Failed to request te gpio: %d\n", rc); > > par->gpio.te = NULL; > > } > > I wish you would just copy and paste the code that I sent you instead, > but this also fixes the crash... While this fixes the crash, it does not propagate the error condition (which may be -EPROBE_DEFER) upstream. Same for devm_request_irq(). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel