From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FC7DC54EBE for ; Mon, 16 Jan 2023 10:44:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 34CAD10E3BE; Mon, 16 Jan 2023 10:44:29 +0000 (UTC) Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by gabe.freedesktop.org (Postfix) with ESMTPS id A49CE10E3BE for ; Mon, 16 Jan 2023 10:44:26 +0000 (UTC) Received: by mail-qt1-f179.google.com with SMTP id z9so1623044qtv.5 for ; Mon, 16 Jan 2023 02:44:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oMEZtvQFEJvynFRYn/XTZlOzrmSM7ZI6rZSGm2BSCxc=; b=jkPix+KKa5ccm1009qtT/kLXTi58x/ICSk9q62mu5StsTtPZVZWngRKEAGwp3ZXkmH lTJ8or67bJ8DWxCczecN+8/aHmH8yQtUB3gYSAzyuIM4DQMB0JKEg9lMA6E5DHlsZswu QXoYGva5usJ2C/BBtoxI0H0zV3AY98468RmYAntnpQpr5cBKvY41SBcdNsaBaVvjGHEo 4/ZQvVRFQyw8OvA5OiakYYTPs9SQWBAzVakJcoLWqKGbq9QdTa59KEeUQ1EcSvXU99Js JhAgc0T6mdl6sq6X+LP9OU777gWGqERDGOpl6Glsgp66S0vKq4VjC7pAbsH4rWW57dSG askw== X-Gm-Message-State: AFqh2kpXnQ9YQM4JGYTZi6QdnGifRMEsyHWoisQIootxOWbjR51LPbMv EP1Sc/j/5Bq605lEPKTo+VYTbavesRcQ1g== X-Google-Smtp-Source: AMrXdXtAWqGnD5WfQOGNsShl1DyZCmhjIQSsiM5AOK+NR7DOWbH7DsJi0rTn23fQA+qm9n3yTRyjEA== X-Received: by 2002:ac8:460f:0:b0:3b6:34e5:3640 with SMTP id p15-20020ac8460f000000b003b634e53640mr1992461qtn.56.1673865865556; Mon, 16 Jan 2023 02:44:25 -0800 (PST) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com. [209.85.219.179]) by smtp.gmail.com with ESMTPSA id h6-20020ac81386000000b003a7fef41526sm14332613qtj.77.2023.01.16.02.44.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jan 2023 02:44:25 -0800 (PST) Received: by mail-yb1-f179.google.com with SMTP id l139so29746145ybl.12 for ; Mon, 16 Jan 2023 02:44:25 -0800 (PST) X-Received: by 2002:a25:46c6:0:b0:7b8:a0b8:f7ec with SMTP id t189-20020a2546c6000000b007b8a0b8f7ecmr4722674yba.36.1673865864824; Mon, 16 Jan 2023 02:44:24 -0800 (PST) MIME-Version: 1.0 References: <20220615221410.27459-1-laurent.pinchart@ideasonboard.com> <20220615221410.27459-6-laurent.pinchart@ideasonboard.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 16 Jan 2023 11:44:13 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros To: Laurent Pinchart Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jacopo Mondi , Maxime Coquelin , Hugues Fruchet , Alexandre Torgue , dri-devel@lists.freedesktop.org, Lad Prabhakar , Linux-Renesas , Rob Herring , Sakari Ailus , Eugen Hristev , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Laurent, On Mon, Jan 16, 2023 at 11:38 AM Laurent Pinchart wrote: > On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote: > > On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote: > > > Geert, could you please take this in your tree for v6.3 ? The two > > > patches that the DT changes depend on have been merged in v6.2. > > > > Thank you, I had missed these. > > > > > On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote: > > > > Now that a header exists with macros for the media interface bus-type > > > > values, replace hardcoding numerical constants with the corresponding > > > > macros in the DT sources. > > > > > > > > Signed-off-by: Laurent Pinchart > > > > Reviewed-by: Geert Uytterhoeven > > > > > > --- > > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++---- > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++- > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++- > > > > 3 files changed, 13 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > index 4e58c54cde17..33ac4bd1e63b 100644 > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > @@ -7,6 +7,9 @@ > > > > */ > > > > > > > > /dts-v1/; > > > > + > > > > +#include > > > > + > > > > #include "r8a7742-iwg21d-q7.dts" > > > > > > > > / { > > > > @@ -242,7 +245,7 @@ port { > > > > vin0ep: endpoint { > > > > remote-endpoint = <&cam0ep>; > > > > bus-width = <8>; > > > > - bus-type = <6>; > > > > + bus-type = ; > > > > }; > > > > }; > > > > }; > > > > @@ -273,7 +276,7 @@ port { > > > > vin1ep: endpoint { > > > > remote-endpoint = <&cam1ep>; > > > > bus-width = <8>; > > > > - bus-type = <6>; > > > > + bus-type = ; > > > > }; > > > > }; > > > > }; > > > > @@ -305,7 +308,7 @@ vin2ep: endpoint { > > > > remote-endpoint = <&cam2ep>; > > > > bus-width = <8>; > > > > data-shift = <8>; > > > > - bus-type = <6>; > > > > + bus-type = ; > > > > }; > > > > }; > > > > }; > > > > @@ -335,7 +338,7 @@ port { > > > > vin3ep: endpoint { > > > > remote-endpoint = <&cam3ep>; > > > > bus-width = <8>; > > > > - bus-type = <6>; > > > > + bus-type = ; > > > > }; > > > > }; > > > > }; > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi > > > > index 40cef0b1d1e6..c73160df619d 100644 > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi > > > > @@ -7,6 +7,8 @@ > > > > * Copyright (C) 2020 Renesas Electronics Corp. > > > > */ > > > > > > > > +#include > > > > This .dtsi file is only intended to be included by > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has > > the include. Hence if you don't mind, I would like to drop this part > > while applying and queuing in renesas-devel for v6.3. > > Isn't it better to include headers as needed to avoid depending on > indirect includes ? In general, I agree. In this particular case, (the multiple inclusions of) the r8a7742-iwg21d-q7-dbcm-ov*-single.dtsi files are tied very intimately to r8a7742-iwg21d-q7-dbcm-ca.dts. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24FCAC46467 for ; Mon, 16 Jan 2023 10:45:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230023AbjAPKpT (ORCPT ); Mon, 16 Jan 2023 05:45:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230525AbjAPKo4 (ORCPT ); Mon, 16 Jan 2023 05:44:56 -0500 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F86F1DBBB; Mon, 16 Jan 2023 02:44:27 -0800 (PST) Received: by mail-qt1-f182.google.com with SMTP id x7so14164233qtv.13; Mon, 16 Jan 2023 02:44:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oMEZtvQFEJvynFRYn/XTZlOzrmSM7ZI6rZSGm2BSCxc=; b=L9KZawnImWbIUNnHg+Rm2CmydlH0sonPCxq2s8U0QHF2yLntsghOT/2xiYKnozSJf+ MKlK+WbUVxG7UTxI/JLVfmhkQMBLZ0lGl+vk1gH6g/3CzBLLpaEyiiZ6qLIWyeY94DIn WgVvVmEtK/+FHxuwsMczSRHWHN3mAob5IMMuJSViO3MkIV4qTuzF7IJUIEZKWb6/iOpa 2m+8oI2Ky1yR80umrsI+s3koRLiDFFA1nuwjLDkZMLuX3iX5AWRc0MeprpvuGhim1fxr vhXV6v2PocnjSC/twDsa2e4SR9azRVwvNZgoGv0FsGAYFzbZYF8NgXGy8RMGBu/w4UGl Eq6Q== X-Gm-Message-State: AFqh2kr28BNeLcvmuoQ8iOB8kZTrMrdTBvVZP0Y/Oku91Wri5SNChWoP CqWqRKCQOrbtcbIWB65na4xYyss8HTR+cg== X-Google-Smtp-Source: AMrXdXvNO31u6+uetfHTnMDr90GrgWrweci6oMBESmyS7ivhwiyWX+LBPMGIGRuJ5UjCoCTmBLPvjQ== X-Received: by 2002:ac8:7c8f:0:b0:3ab:67d3:8f59 with SMTP id y15-20020ac87c8f000000b003ab67d38f59mr109384731qtv.59.1673865865961; Mon, 16 Jan 2023 02:44:25 -0800 (PST) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com. [209.85.219.174]) by smtp.gmail.com with ESMTPSA id jr49-20020a05622a803100b003ad373d04b6sm11528563qtb.59.2023.01.16.02.44.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jan 2023 02:44:25 -0800 (PST) Received: by mail-yb1-f174.google.com with SMTP id e130so261009yba.7; Mon, 16 Jan 2023 02:44:25 -0800 (PST) X-Received: by 2002:a25:46c6:0:b0:7b8:a0b8:f7ec with SMTP id t189-20020a2546c6000000b007b8a0b8f7ecmr4722674yba.36.1673865864824; Mon, 16 Jan 2023 02:44:24 -0800 (PST) MIME-Version: 1.0 References: <20220615221410.27459-1-laurent.pinchart@ideasonboard.com> <20220615221410.27459-6-laurent.pinchart@ideasonboard.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 16 Jan 2023 11:44:13 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros To: Laurent Pinchart Cc: devicetree@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Sakari Ailus , Jacopo Mondi , Eugen Hristev , Hugues Fruchet , Maxime Coquelin , Alexandre Torgue , Lad Prabhakar , Fabio Estevam , Shawn Guo , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Laurent, On Mon, Jan 16, 2023 at 11:38 AM Laurent Pinchart wrote: > On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote: > > On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote: > > > Geert, could you please take this in your tree for v6.3 ? The two > > > patches that the DT changes depend on have been merged in v6.2. > > > > Thank you, I had missed these. > > > > > On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote: > > > > Now that a header exists with macros for the media interface bus-type > > > > values, replace hardcoding numerical constants with the corresponding > > > > macros in the DT sources. > > > > > > > > Signed-off-by: Laurent Pinchart > > > > Reviewed-by: Geert Uytterhoeven > > > > > > --- > > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++---- > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++- > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++- > > > > 3 files changed, 13 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > index 4e58c54cde17..33ac4bd1e63b 100644 > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > @@ -7,6 +7,9 @@ > > > > */ > > > > > > > > /dts-v1/; > > > > + > > > > +#include > > > > + > > > > #include "r8a7742-iwg21d-q7.dts" > > > > > > > > / { > > > > @@ -242,7 +245,7 @@ port { > > > > vin0ep: endpoint { > > > > remote-endpoint = <&cam0ep>; > > > > bus-width = <8>; > > > > - bus-type = <6>; > > > > + bus-type = ; > > > > }; > > > > }; > > > > }; > > > > @@ -273,7 +276,7 @@ port { > > > > vin1ep: endpoint { > > > > remote-endpoint = <&cam1ep>; > > > > bus-width = <8>; > > > > - bus-type = <6>; > > > > + bus-type = ; > > > > }; > > > > }; > > > > }; > > > > @@ -305,7 +308,7 @@ vin2ep: endpoint { > > > > remote-endpoint = <&cam2ep>; > > > > bus-width = <8>; > > > > data-shift = <8>; > > > > - bus-type = <6>; > > > > + bus-type = ; > > > > }; > > > > }; > > > > }; > > > > @@ -335,7 +338,7 @@ port { > > > > vin3ep: endpoint { > > > > remote-endpoint = <&cam3ep>; > > > > bus-width = <8>; > > > > - bus-type = <6>; > > > > + bus-type = ; > > > > }; > > > > }; > > > > }; > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi > > > > index 40cef0b1d1e6..c73160df619d 100644 > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi > > > > @@ -7,6 +7,8 @@ > > > > * Copyright (C) 2020 Renesas Electronics Corp. > > > > */ > > > > > > > > +#include > > > > This .dtsi file is only intended to be included by > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has > > the include. Hence if you don't mind, I would like to drop this part > > while applying and queuing in renesas-devel for v6.3. > > Isn't it better to include headers as needed to avoid depending on > indirect includes ? In general, I agree. In this particular case, (the multiple inclusions of) the r8a7742-iwg21d-q7-dbcm-ov*-single.dtsi files are tied very intimately to r8a7742-iwg21d-q7-dbcm-ca.dts. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A959C54EBE for ; Mon, 16 Jan 2023 10:45:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VDhzWVigbOnzgABV29NvNGFVASjC1SN9GxnMz8FXgyY=; b=OjmAFVkAUprBWk r2i0PN8LyCaWGiMoaFT9UQmhaFguFVVGe6noajUIA5tkzuy5qtj3p7z7tGt8GNLdlb1wadEPgOlhy FxZIGEtsigOCkRmQaw3rHrgWcQFUE1NilAUsoBGCf7F0oye3JB5nd4ugnCJry91yAzWaDHdCDUiJs wiAz/6cte/hmhS6Xg2eS7Lk1qRHxbq6GkmJO4saEt2ynlBdip5J2N1rbZtkO6PFtZ3banEiyN7eHT xxNvgmXHGF6V8UrSrpA0RoJ9BtfCwprbb2oY7Bd/FMeWxU1oDYDJ6/8k4rcDa9W1+DIA1NQjDvJqo oAz+Cco4T5QGXdo+WAtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHMyg-009jgs-RB; Mon, 16 Jan 2023 10:44:35 +0000 Received: from mail-qv1-f54.google.com ([209.85.219.54]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHMya-009jeu-Mg for linux-arm-kernel@lists.infradead.org; Mon, 16 Jan 2023 10:44:30 +0000 Received: by mail-qv1-f54.google.com with SMTP id y8so19283991qvn.11 for ; Mon, 16 Jan 2023 02:44:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oMEZtvQFEJvynFRYn/XTZlOzrmSM7ZI6rZSGm2BSCxc=; b=wy9nWIBg0GtY7dhfw5tHJAYnTJlhinbClMAlHytzbG+Fk+CLHpLkvmZtP9DFnQr/3y phco+9oEKUtcqFDrM0PJwYRsnozrGUUNArRLLTq/4fbHsgDAxefPouw/hmJ47vj90Qyo BDeog6VW35VIt7IfdE2vFuplBN2rZGA/6zoeAFsupeJqxyX3fn+1DnJQ0BlBBw7NeluT U/xFMd8LMhh55EX5jk3DQjppdodRB/bQsBhVAs8D0BS7x5VGGYUOXgT9ExUvVXVmvBir rz7Lr1T1bG5Pt7iXZAGzFq6rS9qhJKE+RFPcYf6ob6IGNwuI4FmZi/54lMywDxNqxMED ZXvw== X-Gm-Message-State: AFqh2krNtaSLTl398YOeuU+BXJuf2ZfoEqeNqnjhD9CyDeJt/6K7i1F5 FSomKWQ5J/FkpIHcQaChx4QxYCFkc0LNLg== X-Google-Smtp-Source: AMrXdXsppFq0i4gdbateh28vcrtl6W5NSG87g1AE9F0z4VIV7kPrH4oavWXp54oV5xi0Djpzgg/4dg== X-Received: by 2002:a05:6214:110e:b0:532:1870:b95c with SMTP id e14-20020a056214110e00b005321870b95cmr48992129qvs.17.1673865866220; Mon, 16 Jan 2023 02:44:26 -0800 (PST) Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com. [209.85.219.181]) by smtp.gmail.com with ESMTPSA id u8-20020a05620a430800b006b615cd8c13sm18074006qko.106.2023.01.16.02.44.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jan 2023 02:44:25 -0800 (PST) Received: by mail-yb1-f181.google.com with SMTP id o75so29801846yba.2 for ; Mon, 16 Jan 2023 02:44:25 -0800 (PST) X-Received: by 2002:a25:46c6:0:b0:7b8:a0b8:f7ec with SMTP id t189-20020a2546c6000000b007b8a0b8f7ecmr4722674yba.36.1673865864824; Mon, 16 Jan 2023 02:44:24 -0800 (PST) MIME-Version: 1.0 References: <20220615221410.27459-1-laurent.pinchart@ideasonboard.com> <20220615221410.27459-6-laurent.pinchart@ideasonboard.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 16 Jan 2023 11:44:13 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros To: Laurent Pinchart Cc: devicetree@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Sakari Ailus , Jacopo Mondi , Eugen Hristev , Hugues Fruchet , Maxime Coquelin , Alexandre Torgue , Lad Prabhakar , Fabio Estevam , Shawn Guo , Linux-Renesas X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230116_024428_758412_5AF0FD7B X-CRM114-Status: GOOD ( 36.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laurent, On Mon, Jan 16, 2023 at 11:38 AM Laurent Pinchart wrote: > On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote: > > On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote: > > > Geert, could you please take this in your tree for v6.3 ? The two > > > patches that the DT changes depend on have been merged in v6.2. > > > > Thank you, I had missed these. > > > > > On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote: > > > > Now that a header exists with macros for the media interface bus-type > > > > values, replace hardcoding numerical constants with the corresponding > > > > macros in the DT sources. > > > > > > > > Signed-off-by: Laurent Pinchart > > > > Reviewed-by: Geert Uytterhoeven > > > > > > --- > > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++---- > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++- > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++- > > > > 3 files changed, 13 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > index 4e58c54cde17..33ac4bd1e63b 100644 > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > @@ -7,6 +7,9 @@ > > > > */ > > > > > > > > /dts-v1/; > > > > + > > > > +#include > > > > + > > > > #include "r8a7742-iwg21d-q7.dts" > > > > > > > > / { > > > > @@ -242,7 +245,7 @@ port { > > > > vin0ep: endpoint { > > > > remote-endpoint = <&cam0ep>; > > > > bus-width = <8>; > > > > - bus-type = <6>; > > > > + bus-type = ; > > > > }; > > > > }; > > > > }; > > > > @@ -273,7 +276,7 @@ port { > > > > vin1ep: endpoint { > > > > remote-endpoint = <&cam1ep>; > > > > bus-width = <8>; > > > > - bus-type = <6>; > > > > + bus-type = ; > > > > }; > > > > }; > > > > }; > > > > @@ -305,7 +308,7 @@ vin2ep: endpoint { > > > > remote-endpoint = <&cam2ep>; > > > > bus-width = <8>; > > > > data-shift = <8>; > > > > - bus-type = <6>; > > > > + bus-type = ; > > > > }; > > > > }; > > > > }; > > > > @@ -335,7 +338,7 @@ port { > > > > vin3ep: endpoint { > > > > remote-endpoint = <&cam3ep>; > > > > bus-width = <8>; > > > > - bus-type = <6>; > > > > + bus-type = ; > > > > }; > > > > }; > > > > }; > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi > > > > index 40cef0b1d1e6..c73160df619d 100644 > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi > > > > @@ -7,6 +7,8 @@ > > > > * Copyright (C) 2020 Renesas Electronics Corp. > > > > */ > > > > > > > > +#include > > > > This .dtsi file is only intended to be included by > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has > > the include. Hence if you don't mind, I would like to drop this part > > while applying and queuing in renesas-devel for v6.3. > > Isn't it better to include headers as needed to avoid depending on > indirect includes ? In general, I agree. In this particular case, (the multiple inclusions of) the r8a7742-iwg21d-q7-dbcm-ov*-single.dtsi files are tied very intimately to r8a7742-iwg21d-q7-dbcm-ca.dts. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel