From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Tue, 01 Dec 2015 08:41:49 +0000 Subject: Re: [PATCH 1/4] PCI: rcar-gen2: Add generic compatibility string Message-Id: List-Id: References: <1448954672-27236-1-git-send-email-horms+renesas@verge.net.au> <1448954672-27236-2-git-send-email-horms+renesas@verge.net.au> In-Reply-To: <1448954672-27236-2-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Simon Horman Cc: Bjorn Helgaas , Magnus Damm , linux-pci , Linux-sh list , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" On Tue, Dec 1, 2015 at 8:24 AM, Simon Horman wrote: > Add fallback compatibility string for R-Car Gen 2 Family. > This is in keeping with the fallback scheme being adopted wherever > appropriate for drivers for Renesas SoCs. > > Signed-off-by: Simon Horman > --- > Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt | 11 +++++++++-- > drivers/pci/host/pci-rcar-gen2.c | 1 + > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt > index 891463cb09c2..b19be08a8113 100644 > --- a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt > +++ b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt > @@ -8,7 +8,14 @@ OHCI and EHCI controllers. > Required properties: > - compatible: "renesas,pci-r8a7790" for the R8A7790 SoC; > "renesas,pci-r8a7791" for the R8A7791 SoC; > - "renesas,pci-r8a7794" for the R8A7794 SoC. > + "renesas,pci-r8a7794" for the R8A7794 SoC; > + "renesas,pci-gen2" for a generic R-Car Gen2 compatible device. Shouldn't that be "renesas,pci-rcar-gen" or "renesas,pci-rcar2"? Else you'll be in trouble when Renesas starts focussing on airplanes (R-Plane Gen2), rockets (R-Rocket Gen2), or IoT (R-IoT Gen2). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 1/4] PCI: rcar-gen2: Add generic compatibility string Date: Tue, 1 Dec 2015 09:41:49 +0100 Message-ID: References: <1448954672-27236-1-git-send-email-horms+renesas@verge.net.au> <1448954672-27236-2-git-send-email-horms+renesas@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1448954672-27236-2-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Simon Horman Cc: Bjorn Helgaas , Magnus Damm , linux-pci , Linux-sh list , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Tue, Dec 1, 2015 at 8:24 AM, Simon Horman wrote: > Add fallback compatibility string for R-Car Gen 2 Family. > This is in keeping with the fallback scheme being adopted wherever > appropriate for drivers for Renesas SoCs. > > Signed-off-by: Simon Horman > --- > Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt | 11 +++++++++-- > drivers/pci/host/pci-rcar-gen2.c | 1 + > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt > index 891463cb09c2..b19be08a8113 100644 > --- a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt > +++ b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt > @@ -8,7 +8,14 @@ OHCI and EHCI controllers. > Required properties: > - compatible: "renesas,pci-r8a7790" for the R8A7790 SoC; > "renesas,pci-r8a7791" for the R8A7791 SoC; > - "renesas,pci-r8a7794" for the R8A7794 SoC. > + "renesas,pci-r8a7794" for the R8A7794 SoC; > + "renesas,pci-gen2" for a generic R-Car Gen2 compatible device. Shouldn't that be "renesas,pci-rcar-gen" or "renesas,pci-rcar2"? Else you'll be in trouble when Renesas starts focussing on airplanes (R-Plane Gen2), rockets (R-Rocket Gen2), or IoT (R-IoT Gen2). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f173.google.com ([209.85.214.173]:34418 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755731AbbLAIlu (ORCPT ); Tue, 1 Dec 2015 03:41:50 -0500 MIME-Version: 1.0 In-Reply-To: <1448954672-27236-2-git-send-email-horms+renesas@verge.net.au> References: <1448954672-27236-1-git-send-email-horms+renesas@verge.net.au> <1448954672-27236-2-git-send-email-horms+renesas@verge.net.au> Date: Tue, 1 Dec 2015 09:41:49 +0100 Message-ID: Subject: Re: [PATCH 1/4] PCI: rcar-gen2: Add generic compatibility string From: Geert Uytterhoeven To: Simon Horman Cc: Bjorn Helgaas , Magnus Damm , linux-pci , Linux-sh list , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-pci-owner@vger.kernel.org List-ID: On Tue, Dec 1, 2015 at 8:24 AM, Simon Horman wrote: > Add fallback compatibility string for R-Car Gen 2 Family. > This is in keeping with the fallback scheme being adopted wherever > appropriate for drivers for Renesas SoCs. > > Signed-off-by: Simon Horman > --- > Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt | 11 +++++++++-- > drivers/pci/host/pci-rcar-gen2.c | 1 + > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt > index 891463cb09c2..b19be08a8113 100644 > --- a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt > +++ b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt > @@ -8,7 +8,14 @@ OHCI and EHCI controllers. > Required properties: > - compatible: "renesas,pci-r8a7790" for the R8A7790 SoC; > "renesas,pci-r8a7791" for the R8A7791 SoC; > - "renesas,pci-r8a7794" for the R8A7794 SoC. > + "renesas,pci-r8a7794" for the R8A7794 SoC; > + "renesas,pci-gen2" for a generic R-Car Gen2 compatible device. Shouldn't that be "renesas,pci-rcar-gen" or "renesas,pci-rcar2"? Else you'll be in trouble when Renesas starts focussing on airplanes (R-Plane Gen2), rockets (R-Rocket Gen2), or IoT (R-IoT Gen2). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds