From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5569FC48BDF for ; Thu, 10 Jun 2021 12:22:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BB6C613BC for ; Thu, 10 Jun 2021 12:22:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230329AbhFJMYS (ORCPT ); Thu, 10 Jun 2021 08:24:18 -0400 Received: from mail-ua1-f54.google.com ([209.85.222.54]:42761 "EHLO mail-ua1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230130AbhFJMYR (ORCPT ); Thu, 10 Jun 2021 08:24:17 -0400 Received: by mail-ua1-f54.google.com with SMTP id w5so1194197uaq.9; Thu, 10 Jun 2021 05:22:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GHImRfBQYLoz3d/i2ivFXTZfIrG8e8ycwCeg8K/SaiY=; b=t0g2XOIVo6nyrSlEBemjJI4Ix+9+B1pDNeQbBBRuEKOpES0yAawHiyE3KuTloHZ+R0 tcgSiyraERWjHNrj5RiDwohXet9SUWDALt8ccqHnN/O1RlBk8F429yYupr0Yb/QsFOou +XiW/IwvICslSgD3fMznnD/I2tQM93miV44zWexmvCGWUzY02iDe7TNi5MsFhtlYPRXs od4oEoyRqPTo+1WUwo1z08mugIosvxEIDfAv4kdVFwEDtVZfgodSZg1Mm2s79yoWO2ra xUiUrp+JEi/NodfbTzKhjttlCjPME+bv/m2J1A9zPNN9tYa2CMi/6eWx48toXqddxo2s YKIQ== X-Gm-Message-State: AOAM530Bgd0e7/PZxgU1+AqJEi3B/3127XjmgxrNFLrXImEiqRMDmtSE VSvCF4T9pSljgYR9FAjMkmw+Cx44muf3ma0gu4A= X-Google-Smtp-Source: ABdhPJw8UipGhmaBBsSwyshnKJEMcNPGGI4TUltcMxoq/ilmmyOmBEd8pDYi8K6oMEVXDwhrjC22r0+D7Mf//KWyLuU= X-Received: by 2002:ab0:2a4e:: with SMTP id p14mr3957154uar.2.1623327740301; Thu, 10 Jun 2021 05:22:20 -0700 (PDT) MIME-Version: 1.0 References: <20210609163717.3083-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210609163717.3083-2-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <20210609163717.3083-2-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Geert Uytterhoeven Date: Thu, 10 Jun 2021 14:22:09 +0200 Message-ID: Subject: Re: [PATCH v2 1/3] dt-bindings: power: renesas,rzg2l-sysc: Add DT binding documentation for SYSC controller To: Lad Prabhakar Cc: Rob Herring , Magnus Damm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux-Renesas , Prabhakar , Biju Das Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Prabhakar, On Wed, Jun 9, 2021 at 6:37 PM Lad Prabhakar wrote: > Add DT binding documentation for SYSC controller found on > RZ/G2{L,LC,UL} SoC's. > > SYSC block contains the LSI_DEVID register which is used to retrieve > SoC product information. > > Signed-off-by: Lad Prabhakar Thanks for the update! > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/renesas,rzg2l-sysc.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/power/renesas,rzg2l-sysc.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Renesas RZ/G2L System Controller (SYSC) > + > +maintainers: > + - Geert Uytterhoeven > + > +description: > + The RZ/G2L System Controller (SYSC) performs system control of the LSI and > + supports following functions, > + - External terminal state capture function > + - 34-bit address space access function > + - Low power consumption control > + - WDT stop control > + > +properties: > + compatible: > + enum: > + - renesas,r9a07g044-sysc # RZ/G2{L,LC} > + > + reg: > + maxItems: 1 > + > + interrupts: > + items: > + - description: CA55/CM33 Sleep/Software Standby Mode request interrupt > + - description: CA55 Software Standby Mode release request interrupt > + - description: CM33 Software Standby Mode release request interrupt > + - description: CA55 ACE Asynchronous Bridge Master/Slave interface deny request interrupt > + > + interrupt-names: > + items: > + - const: sys_lpm_int > + - const: sys_ca55stbydone_int > + - const: sys_cm33stbyr_int > + - const: sys_ca55_deny The "sys_" prefixes feel superfluous to me. If you don't mind, I can remove them while applying (also from example and .dtsi). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds