From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Mon, 06 Aug 2018 14:34:34 +0000 Subject: Re: [PATCH/RFC 3/4] Revert "serial: sh-sci: Compute the regshift value for SCI ports" Message-Id: List-Id: References: <20180806140755.24087-1-geert+renesas@glider.be> <20180806140755.24087-4-geert+renesas@glider.be> <2848864.ufBBija138@avalon> In-Reply-To: <2848864.ufBBija138@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Laurent Pinchart Cc: Geert Uytterhoeven , Chris Brandt , Laurent Pinchart , uli@fpond.eu, Yoshinori Sato , Greg KH , Jiri Slaby , Linux-Renesas , Linux-sh list , "open list:SERIAL DRIVERS" Hi Laurent, On Mon, Aug 6, 2018 at 4:16 PM Laurent Pinchart wrote: > On Monday, 6 August 2018 17:07:54 EEST Geert Uytterhoeven wrote: > > This reverts commit dfc80387aefb78161f83732804c6d01c89c24595. > > > > Deriving the proper regshift value from the register block size is > > fragile, as it may have been rounded up. > > > > Furthermore we will need plat_sci_port.regshift again. > > Won't this break bisection ? Shouldn't you squash patches 3 and 4 together ? > > Does this mechanism break anything on non-DT platforms ? If not I'd rather > keep it for them, and only use compat strings for DT platforms, to avoiding > adding back a platform data field. Actually I think the original commit broke SCI on H8/300, as regshift should be zero on that platform. But that was not discovered until recently. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f195.google.com ([209.85.217.195]:42449 "EHLO mail-ua0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728626AbeHFQoK (ORCPT ); Mon, 6 Aug 2018 12:44:10 -0400 MIME-Version: 1.0 References: <20180806140755.24087-1-geert+renesas@glider.be> <20180806140755.24087-4-geert+renesas@glider.be> <2848864.ufBBija138@avalon> In-Reply-To: <2848864.ufBBija138@avalon> From: Geert Uytterhoeven Date: Mon, 6 Aug 2018 16:34:34 +0200 Message-ID: Subject: Re: [PATCH/RFC 3/4] Revert "serial: sh-sci: Compute the regshift value for SCI ports" To: Laurent Pinchart Cc: Geert Uytterhoeven , Chris Brandt , Laurent Pinchart , uli@fpond.eu, Yoshinori Sato , Greg KH , Jiri Slaby , Linux-Renesas , Linux-sh list , "open list:SERIAL DRIVERS" Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Laurent, On Mon, Aug 6, 2018 at 4:16 PM Laurent Pinchart wrote: > On Monday, 6 August 2018 17:07:54 EEST Geert Uytterhoeven wrote: > > This reverts commit dfc80387aefb78161f83732804c6d01c89c24595. > > > > Deriving the proper regshift value from the register block size is > > fragile, as it may have been rounded up. > > > > Furthermore we will need plat_sci_port.regshift again. > > Won't this break bisection ? Shouldn't you squash patches 3 and 4 together ? > > Does this mechanism break anything on non-DT platforms ? If not I'd rather > keep it for them, and only use compat strings for DT platforms, to avoiding > adding back a platform data field. Actually I think the original commit broke SCI on H8/300, as regshift should be zero on that platform. But that was not discovered until recently. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds