Re: [PATCH] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	Akinobu Mita <akinobu.mita@gmail.com>,
	Joe Perches <joe@perches.com>,
	linux-rtc@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed
Date: Tue, 28 Jan 2020 09:59:58 +0100	[thread overview]
Message-ID: <CAMuHMdVMb5TatztfBA5Zo_R6vmM7vBzq=zUyLEhEpa3p6JnyOA@mail.gmail.com> (raw)
In-Reply-To: <20200128085054.GA3398@piout.net>

Hi Alexandre,

On Tue, Jan 28, 2020 at 9:50 AM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
> On 28/01/2020 09:33:28+0100, Geert Uytterhoeven wrote:
> > On Mon, Jan 27, 2020 at 11:45 PM Alexandre Belloni
> > <alexandre.belloni@bootlin.com> wrote:
> > > On 12/01/2020 18:13:49+0100, Geert Uytterhoeven wrote:
> > > > Merely enabling I2C and RTC selects REGMAP_I2C and REGMAP_SPI, even when
> > > > no driver needs it.  While the former can be moduler, the latter cannot,
> > > > and thus becomes built-in.
> > > >
> > > > Fix this by moving the select statements for REGMAP_I2C and REGMAP_SPI
> > > > from the RTC_I2C_AND_SPI helper to the individual drivers that depend on
> > > > it.
> > > >
> > > > Note that the comment for RTC_I2C_AND_SPI refers to SND_SOC_I2C_AND_SPI
> > > > for more information, but the latter does not select REGMAP_{I2C,SPI}
> > > > itself, and defers that to the individual drivers, too.
> > > >
> > > > Fixes: 080481f54ef62121 ("rtc: merge ds3232 and ds3234")
> > > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > ---
> > > > Joe: When merging addresses, scripts/get_maintainer.pl replaces
> > > >      Alexandre's authoritative email address from MAINTAINERS by the
> > > >      obsolete address in the SoB-line of the commit referred to by the
> > > >      Fixes-line.
> > > >
> > > >  drivers/rtc/Kconfig | 8 ++++++--
> > > >  1 file changed, 6 insertions(+), 2 deletions(-)
> > > >
> > > Applied, thanks.
> >
> > According to the reports from kbuild test report, some drivers are still
> > missing some selects, which is exposed by this patch.
> > But perhaps you have already fixed those in your tree?
> >
>
> I did fix a bunch of those in
> https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next&id=578c2b661e2b1b474ea3571a3c3c6d57bae89e8d
>
> kbuild reported that it successfully built a few configuration with that
> patch applied so I'm hoping it is enough.

Great, thanks a lot!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds