From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 517496FE35; Tue, 9 Apr 2024 10:35:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712658919; cv=none; b=XLptXSboDl0U9ck/e6zpOp8+SRvzsiK/eljFyiWTuD+whtLzecvAyKVtKPyud4KSdHO8L7tuiGUJIkuPgrYtdrtPI0WEkpO+UiTTvxECvCPRyBsDeHChkSDv/UCF4bztaT2NGviPvwm2g2cVCAooYwFK6Yf3Q6JD13gntQsxf04= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712658919; c=relaxed/simple; bh=WT9pOkL0o92Z2IOw5J90BU1u8X7lD/ah1Qc4kRSPngc=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=XUiyVhoh2Cei18lvePZ/eSFIhzZWqG4MXgSsgjLAp3FsnWFSoe0U2QCySPz1otlHx+ilFL2i2lX+f56qTB03O0HcRywD0+owIQLS+CJfT2/oWPtBkFes+yIJAl28YLneXDQV2A1PTuJkt/wdOSK40dj50JE1qrZ2yeZGiQ+sXk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-6181b9dc647so16001677b3.1; Tue, 09 Apr 2024 03:35:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712658915; x=1713263715; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nktIVSuXupLDwEe7/K2WYoIkf/M9z2rTr/fahEtJAJk=; b=UjKfGwIbafF0HkcCQAfRKdM3OnF7h9Exm1equnfKExw3tpJo/lbtgdCj6P2zGQ3APB T+M3FC7vYnOhRPk7OdACgrS/f9+MKNnG+N7NEyTkomhGQScJsEPMgLMLqZXi6dNmKqGK n8PVGsIgmSnRqSodQDi2GjXCp9psXxtstseyE06/RmV0F6KO3vYUHCiSwH5lKUHTpKp0 WIk8eMVSKtT6YM6IUkRoikt229ScCXxlmQCyaSk0kVK64hY5jw0qiBSxXDDCytPQAt18 so4GsUMTIjvHvSdtTNaSiJrtXCk6Pb+/naD2InYDu/aOwbbCMkmKYg69rAc0aiKmqrXy kk4g== X-Forwarded-Encrypted: i=1; AJvYcCVjBXYGkmZqdkCAOq3jraJx1FiA+3Vtt7ns/Vfm9IK8i7fwBEuD5iPSb/0Te044bmAl8AzuXqym5nppp5JZx7aNOHSt3SA+vyKi0znpSugrxOPx1XMaS+2b7BnvnTeYK3/9Vcv7TzQKN0BEK6bmTCc= X-Gm-Message-State: AOJu0YxdK8XQ8xoCt3TLxpgkUJt4rdfwmskGmdliJzK34UnhkraibVXB rZYgK/tC6h/eegB8q7xCw6fIkeBujzcju6NCVxegtQSCKNeOoi9Rn/26mqsosjY= X-Google-Smtp-Source: AGHT+IHPoC5vJKiLlcUoz+lVTfQO7/Zgf7xLvVNKf9PcSXUvdvYrwBe6nd580XqrLsmrU6icw3CpVw== X-Received: by 2002:a81:73d7:0:b0:609:f87b:aad3 with SMTP id o206-20020a8173d7000000b00609f87baad3mr10234701ywc.31.1712658915593; Tue, 09 Apr 2024 03:35:15 -0700 (PDT) Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com. [209.85.219.169]) by smtp.gmail.com with ESMTPSA id dc13-20020a05690c0f0d00b0060a046c50f1sm2113349ywb.58.2024.04.09.03.35.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 03:35:15 -0700 (PDT) Received: by mail-yb1-f169.google.com with SMTP id 3f1490d57ef6-dbed0710c74so4743189276.1; Tue, 09 Apr 2024 03:35:15 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUW63mCpHqud79pP+L3YoNRnGlm5rt7uKStvfzAazAtmA4u2+XsmesDFIJWLZY0fJd825Z1OOYPJ1e0HeVyrZIfkSR2dGomK6SmR373qg6mk1qc7jtt+5Qh0kIbIxdEamnB94wcDAED7cNrqM6Jm2o= X-Received: by 2002:a25:bcd1:0:b0:dc2:41de:b744 with SMTP id l17-20020a25bcd1000000b00dc241deb744mr9626198ybm.32.1712658914994; Tue, 09 Apr 2024 03:35:14 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240327-kms-kconfig-helpers-v3-0-eafee11b84b3@kernel.org> <87sezu97id.fsf@intel.com> In-Reply-To: <87sezu97id.fsf@intel.com> From: Geert Uytterhoeven Date: Tue, 9 Apr 2024 12:35:02 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 00/13] drm/display: Convert helpers Kconfig symbols to depends on To: Jani Nikula Cc: Maxime Ripard , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Lucas De Marchi , kernel test robot , linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Jani, On Tue, Apr 9, 2024 at 12:04=E2=80=AFPM Jani Nikula wrote: > On Tue, 09 Apr 2024, Geert Uytterhoeven wrote: > > The user should not need to know which helpers are needed for the drive= r > > he is interested in. When a symbol selects another symbol, it should > > just make sure the dependencies of the target symbol are met. > > It's really not "just make sure". This leads to perpetual illegal > configurations, and duct tape fixes. Select should not be used for > visible symbols or symbols with dependencies [1]. In other words: none of these helpers should be visible... > What we'd need for usability is not more abuse of select, but rather 1) > warnings for selecting symbols with dependencies, and 2) a way to enable Kconfig already warns if dependencies of selected symbols are not met. > a kconfig option with all its dependencies, recursively. This is what we > lack. You cannot force-enable all dependencies of the target symbol, as some of these dependencies may be impossible to meet on the system you are configuring a kernel for. The current proper way is to add these dependencies to the source symbol, which is what we have been doing everywhere else. Another solution may be to teach Kconfig to ignore any symbols that select a symbol with unmet dependencies. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B293C67861 for ; Tue, 9 Apr 2024 10:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N/8yDFJnnBT7dlvlcZMi51nihpaVlZTdx/M8rgX581Q=; b=xncAbH4IsqbUta z7/+SG4XT8SDeAoF1nXszmVulzU2G9G5EfltODjgPAQHk/BpcNcXvhjs+d7+y9RRDyzxtPi7SI4qT 4BeCKxHqbCx+6uPUatO6nANWtwBkN11+ionVxJnU0FO2iQO6WOqSp9VSoXH6ShR05vWBZ0rA+zk1e J93lEITlXms4B7Nrantb/bsqxwrvse+GGBLYgWYcOC804PH6tMXEKdUMjX7gIQA0NvYrgK6SiOcAF 1qH/4R0t5HWqseGCvmznFeK0F+3ewUroCihA9EXsbNR2I9M/5Wd6Nuk9PrWyT8MLqPjpzjEB8NLba uraRWhUogGo+EZ6p+gHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8rg-00000001UJB-2aM3; Tue, 09 Apr 2024 10:38:08 +0000 Received: from mail-yw1-f176.google.com ([209.85.128.176]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8rN-00000001Tym-3Fze for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2024 10:38:01 +0000 Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-61587aa9f4cso54973287b3.3 for ; Tue, 09 Apr 2024 03:35:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712658915; x=1713263715; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nktIVSuXupLDwEe7/K2WYoIkf/M9z2rTr/fahEtJAJk=; b=oBpXHVhOiY8F2RAB9YJ3TCiX8sgE64y0vc7e/aAHUoLAk7QUseCf9194i/5aFLbtOP 48FWQ4gs0Y/yk0Y470vxUku4wTuVGYcPke6cpVtgwqwuEJz9Vx4QDywjegueYDBEoDKG ujFaMlbFCD+M8poDU/4D/F9lbQhOmXz2sXBRpeRnU8BLkTDSOuv3koSJ598K4CZEBWRQ AqPESdSdUK5XzaafyTeHfLX4oibk8zXAZwDor6zRxfcMO3YlGc/jt4KMWcobyCnOw77Q IIe6FydWrS24KbOrDSsE03vRPdsb74EbdeTguOptpU5napsLq9u1FQllmV2NVl9LHGsc icBA== X-Forwarded-Encrypted: i=1; AJvYcCUoPQ9OmumOvCR3Xyonxp+zqR+3VYZS4kB3VV3SUjjT8yfAsmP09VQ9MGI63CPmn3rIEnUvQ2MnhyTkRr33UAJskJyEd2giuIYytU9ygvhUBgUx47M= X-Gm-Message-State: AOJu0Yw28PH99oklWIC8CBJ5KWtyp3Y3yS8oezSJFhUSJJ+AehI2Vt0G lOs1Y48MRuEnwew7Tyi/eCMu6OXGYoDVCUMF7NLazkKaQDs51k1xmOhYZLBu+qs= X-Google-Smtp-Source: AGHT+IF94LJJLwRxUmExTawohrk2dVa7ljIUYB1VnSAQlvXzM7wLpxFC+wBMiC8dfolmtX7edVem6g== X-Received: by 2002:a81:4315:0:b0:618:e5c:f7a with SMTP id q21-20020a814315000000b006180e5c0f7amr5227034ywa.33.1712658915328; Tue, 09 Apr 2024 03:35:15 -0700 (PDT) Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com. [209.85.219.169]) by smtp.gmail.com with ESMTPSA id j18-20020a81ec12000000b006145009cce6sm507122ywm.8.2024.04.09.03.35.15 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 03:35:15 -0700 (PDT) Received: by mail-yb1-f169.google.com with SMTP id 3f1490d57ef6-ddaad2aeab1so4667191276.3 for ; Tue, 09 Apr 2024 03:35:15 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUNUGh/z/Mn5gZGzRzJrlOlrhYsw4jNu+FjayF4q+jR96y1ldoyKjiezW+z913o9WNOoayGp/r8Alu6Zs5tkmXyNMkq27Nu+Mh5lSdPDw9MlWI635E= X-Received: by 2002:a25:bcd1:0:b0:dc2:41de:b744 with SMTP id l17-20020a25bcd1000000b00dc241deb744mr9626198ybm.32.1712658914994; Tue, 09 Apr 2024 03:35:14 -0700 (PDT) MIME-Version: 1.0 References: <20240327-kms-kconfig-helpers-v3-0-eafee11b84b3@kernel.org> <87sezu97id.fsf@intel.com> In-Reply-To: <87sezu97id.fsf@intel.com> From: Geert Uytterhoeven Date: Tue, 9 Apr 2024 12:35:02 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 00/13] drm/display: Convert helpers Kconfig symbols to depends on To: Jani Nikula Cc: Maxime Ripard , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Lucas De Marchi , kernel test robot , linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_033750_413718_B50D604A X-CRM114-Status: GOOD ( 25.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSmFuaSwKCk9uIFR1ZSwgQXByIDksIDIwMjQgYXQgMTI6MDTigK9QTSBKYW5pIE5pa3VsYSA8 amFuaS5uaWt1bGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPiBPbiBUdWUsIDA5IEFwciAyMDI0 LCBHZWVydCBVeXR0ZXJob2V2ZW4gPGdlZXJ0QGxpbnV4LW02OGsub3JnPiB3cm90ZToKPiA+IFRo ZSB1c2VyIHNob3VsZCBub3QgbmVlZCB0byBrbm93IHdoaWNoIGhlbHBlcnMgYXJlIG5lZWRlZCBm b3IgdGhlIGRyaXZlcgo+ID4gaGUgaXMgaW50ZXJlc3RlZCBpbi4gIFdoZW4gYSBzeW1ib2wgc2Vs ZWN0cyBhbm90aGVyIHN5bWJvbCwgaXQgc2hvdWxkCj4gPiBqdXN0IG1ha2Ugc3VyZSB0aGUgZGVw ZW5kZW5jaWVzIG9mIHRoZSB0YXJnZXQgc3ltYm9sIGFyZSBtZXQuCj4KPiBJdCdzIHJlYWxseSBu b3QgImp1c3QgbWFrZSBzdXJlIi4gVGhpcyBsZWFkcyB0byBwZXJwZXR1YWwgaWxsZWdhbAo+IGNv bmZpZ3VyYXRpb25zLCBhbmQgZHVjdCB0YXBlIGZpeGVzLiBTZWxlY3Qgc2hvdWxkIG5vdCBiZSB1 c2VkIGZvcgo+IHZpc2libGUgc3ltYm9scyBvciBzeW1ib2xzIHdpdGggZGVwZW5kZW5jaWVzIFsx XS4KCkluIG90aGVyIHdvcmRzOiBub25lIG9mIHRoZXNlIGhlbHBlcnMgc2hvdWxkIGJlIHZpc2li bGUuLi4KCj4gV2hhdCB3ZSdkIG5lZWQgZm9yIHVzYWJpbGl0eSBpcyBub3QgbW9yZSBhYnVzZSBv ZiBzZWxlY3QsIGJ1dCByYXRoZXIgMSkKPiB3YXJuaW5ncyBmb3Igc2VsZWN0aW5nIHN5bWJvbHMg d2l0aCBkZXBlbmRlbmNpZXMsIGFuZCAyKSBhIHdheSB0byBlbmFibGUKCktjb25maWcgYWxyZWFk eSB3YXJucyBpZiBkZXBlbmRlbmNpZXMgb2Ygc2VsZWN0ZWQgc3ltYm9scyBhcmUgbm90IG1ldC4K Cj4gYSBrY29uZmlnIG9wdGlvbiB3aXRoIGFsbCBpdHMgZGVwZW5kZW5jaWVzLCByZWN1cnNpdmVs eS4gVGhpcyBpcyB3aGF0IHdlCj4gbGFjay4KCllvdSBjYW5ub3QgZm9yY2UtZW5hYmxlIGFsbCBk ZXBlbmRlbmNpZXMgb2YgdGhlIHRhcmdldCBzeW1ib2wsIGFzIHNvbWUKb2YgdGhlc2UgZGVwZW5k ZW5jaWVzIG1heSBiZSBpbXBvc3NpYmxlIHRvIG1lZXQgb24gdGhlIHN5c3RlbSB5b3UgYXJlCmNv bmZpZ3VyaW5nIGEga2VybmVsIGZvci4KClRoZSBjdXJyZW50IHByb3BlciB3YXkgaXMgdG8gYWRk IHRoZXNlIGRlcGVuZGVuY2llcyB0byB0aGUgc291cmNlCnN5bWJvbCwgd2hpY2ggaXMgd2hhdCB3 ZSBoYXZlIGJlZW4gZG9pbmcgZXZlcnl3aGVyZSBlbHNlLiAgQW5vdGhlcgpzb2x1dGlvbiBtYXkg YmUgdG8gdGVhY2ggS2NvbmZpZyB0byBpZ25vcmUgYW55IHN5bWJvbHMgdGhhdCBzZWxlY3QgYQpz eW1ib2wgd2l0aCB1bm1ldCBkZXBlbmRlbmNpZXMuCgpHcntvZXRqZSxlZXRpbmd9cywKCiAgICAg ICAgICAgICAgICAgICAgICAgIEdlZXJ0CgotLQpHZWVydCBVeXR0ZXJob2V2ZW4gLS0gVGhlcmUn cyBsb3RzIG9mIExpbnV4IGJleW9uZCBpYTMyIC0tIGdlZXJ0QGxpbnV4LW02OGsub3JnCgpJbiBw ZXJzb25hbCBjb252ZXJzYXRpb25zIHdpdGggdGVjaG5pY2FsIHBlb3BsZSwgSSBjYWxsIG15c2Vs ZiBhIGhhY2tlci4gQnV0CndoZW4gSSdtIHRhbGtpbmcgdG8gam91cm5hbGlzdHMgSSBqdXN0IHNh eSAicHJvZ3JhbW1lciIgb3Igc29tZXRoaW5nIGxpa2UgdGhhdC4KICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAtLSBMaW51cyBUb3J2YWxkcwoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=