From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5EBC1109 for ; Thu, 29 Sep 2022 09:00:53 +0000 (UTC) Received: by mail-qt1-f172.google.com with SMTP id w2so379837qtv.9 for ; Thu, 29 Sep 2022 02:00:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=Ir+IzupNAXvXvPBkZ1yh/qacu5xVXDJ2KC3L3ZMV+D4=; b=T1RmZXRk/wprRIfh5L3vkCXQfCOtF0V/Ciq1PvClEdV0L7Pd4kj6SyNw7bh3Je45CU 38Pik0FzFzjUVVC+C58UEf7eRN165qNUjyaU//qxzcFWC877GbLq0gsS3VukdY/bk6c7 tHFKtuxQsgoV2TTnsAgienOPfwhMpaDnb77hlVJOzvR19GsPDmWjkd2WY6IcsiKJ66iO IPV8y6+rbElMl4A6Qf55hY74sn4+dwG+n2kJnfQPd7+U5QMjPoGt/kNzwxoFwHS6BsBg 2agaRz8rZtgkl/MYXvhv7nd8gcgzY60ssP84WlpzJXfbr85CQwqOBcyufklZnxrmuBiz Nvag== X-Gm-Message-State: ACrzQf0QEir0QkL2lzdlovycYkEQI/JahB2AxXkYrIXZtNQCY5+HJ2Pf ++EuNoR5OIIgmEIgCdjAvmowzfPNX/nvYQ== X-Google-Smtp-Source: AMsMyM5wnGnQpv5ii4gn8+FtcJJi0w/CvXksKJa+sIfMrqO0Pr26q9cyGtkC202MeFQPIafXPibPgg== X-Received: by 2002:a05:622a:1743:b0:35b:a8d6:ff6e with SMTP id l3-20020a05622a174300b0035ba8d6ff6emr1438611qtk.269.1664442052449; Thu, 29 Sep 2022 02:00:52 -0700 (PDT) Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com. [209.85.219.170]) by smtp.gmail.com with ESMTPSA id s6-20020ae9de06000000b006cf36d46902sm5326206qkf.66.2022.09.29.02.00.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 02:00:52 -0700 (PDT) Received: by mail-yb1-f170.google.com with SMTP id e145so738471yba.11 for ; Thu, 29 Sep 2022 02:00:52 -0700 (PDT) X-Received: by 2002:a5b:104:0:b0:6b0:429:3fe9 with SMTP id 4-20020a5b0104000000b006b004293fe9mr2016091ybx.543.1664442041163; Thu, 29 Sep 2022 02:00:41 -0700 (PDT) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220923202822.2667581-1-keescook@chromium.org> <20220923202822.2667581-2-keescook@chromium.org> <202209281011.66DD717D@keescook> <874jwqfuh6.fsf@mpe.ellerman.id.au> In-Reply-To: <874jwqfuh6.fsf@mpe.ellerman.id.au> From: Geert Uytterhoeven Date: Thu, 29 Sep 2022 11:00:28 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 01/16] slab: Remove __malloc attribute from realloc functions To: Michael Ellerman Cc: Kees Cook , Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Marco Elver , linux-mm@kvack.org, "Ruhl, Michael J" , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Greg Kroah-Hartman , Nick Desaulniers , Alex Elder , Josef Bacik , David Sterba , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Jesse Brandeburg , Daniel Micay , Yonghong Song , Miguel Ojeda , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-fsdevel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, dev@openvswitch.org, x86@kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Michael, On Thu, Sep 29, 2022 at 10:36 AM Michael Ellerman wrot= e: > Kees Cook writes: > > On Wed, Sep 28, 2022 at 09:26:15AM +0200, Geert Uytterhoeven wrote: > >> On Fri, Sep 23, 2022 at 10:35 PM Kees Cook wro= te: > >> > The __malloc attribute should not be applied to "realloc" functions,= as > >> > the returned pointer may alias the storage of the prior pointer. Ins= tead > >> > of splitting __malloc from __alloc_size, which would be a huge amoun= t of > >> > churn, just create __realloc_size for the few cases where it is need= ed. > >> > > >> > Additionally removes the conditional test for __alloc_size__, which = is > >> > always defined now. > >> > > >> > Cc: Christoph Lameter > >> > Cc: Pekka Enberg > >> > Cc: David Rientjes > >> > Cc: Joonsoo Kim > >> > Cc: Andrew Morton > >> > Cc: Vlastimil Babka > >> > Cc: Roman Gushchin > >> > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > >> > Cc: Marco Elver > >> > Cc: linux-mm@kvack.org > >> > Signed-off-by: Kees Cook > >> > >> Thanks for your patch, which is now commit 63caa04ec60583b1 ("slab: > >> Remove __malloc attribute from realloc functions") in next-20220927. > >> > >> Noreply@ellerman.id.au reported all gcc8-based builds to fail > >> (e.g. [1], more at [2]): > >> > >> In file included from : > >> ./include/linux/percpu.h: In function =E2=80=98__alloc_reserved_pe= rcpu=E2=80=99: > >> ././include/linux/compiler_types.h:279:30: error: expected > >> declaration specifiers before =E2=80=98__alloc_size__=E2=80=99 > >> #define __alloc_size(x, ...) __alloc_size__(x, ## __VA_ARGS__) __= malloc > >> ^~~~~~~~~~~~~~ > >> ./include/linux/percpu.h:120:74: note: in expansion of macro =E2= =80=98__alloc_size=E2=80=99 > >> [...] > >> > >> It's building fine with e.g. gcc-9 (which is my usual m68k cross-compi= ler). > >> Reverting this commit on next-20220927 fixes the issue. > >> > >> [1] http://kisskb.ellerman.id.au/kisskb/buildresult/14803908/ > >> [2] http://kisskb.ellerman.id.au/kisskb/head/1bd8b75fe6adeaa89d02968bd= d811ffe708cf839/ > > > > Eek! Thanks for letting me know. I'm confused about this -- > > __alloc_size__ wasn't optional in compiler_attributes.h -- but obviousl= y > > I broke something! I'll go figure this out. > > This fixes it for me. Kees submitted a similar patch 20 minutes before: https://lore.kernel.org/all/20220929081642.1932200-1-keescook@chromium.org > --- a/include/linux/compiler_types.h > +++ b/include/linux/compiler_types.h > @@ -275,8 +275,13 @@ struct ftrace_likely_data { > * be performing a _reallocation_, as that may alias the existing pointe= r. > * For these, use __realloc_size(). > */ > -#define __alloc_size(x, ...) __alloc_size__(x, ## __VA_ARGS__) __mallo= c > -#define __realloc_size(x, ...) __alloc_size__(x, ## __VA_ARGS__) > +#ifdef __alloc_size__ > +# define __alloc_size(x, ...) __alloc_size__(x, ## __VA_ARGS__) __mallo= c > +# define __realloc_size(x, ...) __alloc_size__(x, ## __VA_ARGS__) > +#else > +# define __alloc_size(x, ...) __malloc > +# define __realloc_size(x, ...) > +#endif > > #ifndef asm_volatile_goto > #define asm_volatile_goto(x...) asm goto(x) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F096C04A95 for ; Thu, 29 Sep 2022 09:01:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 26C7710E3E3; Thu, 29 Sep 2022 09:01:37 +0000 (UTC) Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E31010E3C5 for ; Thu, 29 Sep 2022 09:00:53 +0000 (UTC) Received: by mail-qt1-f179.google.com with SMTP id f26so377456qto.11 for ; Thu, 29 Sep 2022 02:00:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=Ir+IzupNAXvXvPBkZ1yh/qacu5xVXDJ2KC3L3ZMV+D4=; b=mRNKXG1DYIBAv5Zr+278wDvrAVYA694k4aeEUbJA56K71lt1fGblm6nOuDe74jCyjW yDolEJ1euTLR7qa0wLNyQutMX2HdhIgwW8Nb87egiiVHpyqEZ+4fNR3KieIEl7OjTcJl gxPpdI7IwLih0aqN9Wx0jaooLbSJc1AjkHJxQHpOirMtScz7r+Thn1Fb4ZN62tURGgiN Mx4srrewOOdN4laMUEV3LDCQuGKSWm9BGw5JBjueTbPK5E1yNaAqW/iKnY7O1dzO9wD2 QIINfCLpnU5smSzuf0nhybCHQwcrcBJSIqBLCNcYNFj3ypKiI6E8dO6NNXl5QcyckwWy H3Xw== X-Gm-Message-State: ACrzQf14FypEIZ7OT+2wvrOklwgOZSX7N+ksGvcHVMiRM9CQiAgIon/e wasCQBR9fn0Cn/EZo9yyI7wqg/iy/aAHMw== X-Google-Smtp-Source: AMsMyM4y2zQnyrdbbqxficrjIMcxy6kWcOKZG6bOtFlLlsZnGgQmkMls9fRbkkE93LhuzpC5Zcbm0w== X-Received: by 2002:ac8:4e89:0:b0:35d:5856:919a with SMTP id 9-20020ac84e89000000b0035d5856919amr1402041qtp.647.1664442052054; Thu, 29 Sep 2022 02:00:52 -0700 (PDT) Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com. [209.85.219.175]) by smtp.gmail.com with ESMTPSA id s12-20020a05620a0bcc00b006ce7d9dea7asm5755476qki.13.2022.09.29.02.00.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 02:00:51 -0700 (PDT) Received: by mail-yb1-f175.google.com with SMTP id 4so767030ybe.2 for ; Thu, 29 Sep 2022 02:00:51 -0700 (PDT) X-Received: by 2002:a5b:104:0:b0:6b0:429:3fe9 with SMTP id 4-20020a5b0104000000b006b004293fe9mr2016091ybx.543.1664442041163; Thu, 29 Sep 2022 02:00:41 -0700 (PDT) MIME-Version: 1.0 References: <20220923202822.2667581-1-keescook@chromium.org> <20220923202822.2667581-2-keescook@chromium.org> <202209281011.66DD717D@keescook> <874jwqfuh6.fsf@mpe.ellerman.id.au> In-Reply-To: <874jwqfuh6.fsf@mpe.ellerman.id.au> From: Geert Uytterhoeven Date: Thu, 29 Sep 2022 11:00:28 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 01/16] slab: Remove __malloc attribute from realloc functions To: Michael Ellerman Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roman Gushchin , dri-devel@lists.freedesktop.org, "Ruhl, Michael J" , Eric Dumazet , linux-hardening@vger.kernel.org, Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christoph Lameter , Sumit Semwal , dev@openvswitch.org, x86@kernel.org, Jesse Brandeburg , intel-wired-lan@lists.osuosl.org, David Rientjes , Miguel Ojeda , Jakub Kicinski , Paolo Abeni , linux-media@vger.kernel.org, Marco Elver , llvm@lists.linux.dev, Kees Cook , Josef Bacik , linaro-mm-sig@lists.linaro.org, Yonghong Song , David Sterba , Joonsoo Kim , Vlastimil Babka , Alex Elder , linux-mm@kvack.org, Greg Kroah-Hartman , Nick Desaulniers , linux-kernel@vger.kernel.org, =?UTF-8?Q?Christian_K=C3=B6nig?= , Pekka Enberg , Daniel Micay , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , "David S. Miller" , linux-btrfs@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Michael, On Thu, Sep 29, 2022 at 10:36 AM Michael Ellerman wrot= e: > Kees Cook writes: > > On Wed, Sep 28, 2022 at 09:26:15AM +0200, Geert Uytterhoeven wrote: > >> On Fri, Sep 23, 2022 at 10:35 PM Kees Cook wro= te: > >> > The __malloc attribute should not be applied to "realloc" functions,= as > >> > the returned pointer may alias the storage of the prior pointer. Ins= tead > >> > of splitting __malloc from __alloc_size, which would be a huge amoun= t of > >> > churn, just create __realloc_size for the few cases where it is need= ed. > >> > > >> > Additionally removes the conditional test for __alloc_size__, which = is > >> > always defined now. > >> > > >> > Cc: Christoph Lameter > >> > Cc: Pekka Enberg > >> > Cc: David Rientjes > >> > Cc: Joonsoo Kim > >> > Cc: Andrew Morton > >> > Cc: Vlastimil Babka > >> > Cc: Roman Gushchin > >> > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > >> > Cc: Marco Elver > >> > Cc: linux-mm@kvack.org > >> > Signed-off-by: Kees Cook > >> > >> Thanks for your patch, which is now commit 63caa04ec60583b1 ("slab: > >> Remove __malloc attribute from realloc functions") in next-20220927. > >> > >> Noreply@ellerman.id.au reported all gcc8-based builds to fail > >> (e.g. [1], more at [2]): > >> > >> In file included from : > >> ./include/linux/percpu.h: In function =E2=80=98__alloc_reserved_pe= rcpu=E2=80=99: > >> ././include/linux/compiler_types.h:279:30: error: expected > >> declaration specifiers before =E2=80=98__alloc_size__=E2=80=99 > >> #define __alloc_size(x, ...) __alloc_size__(x, ## __VA_ARGS__) __= malloc > >> ^~~~~~~~~~~~~~ > >> ./include/linux/percpu.h:120:74: note: in expansion of macro =E2= =80=98__alloc_size=E2=80=99 > >> [...] > >> > >> It's building fine with e.g. gcc-9 (which is my usual m68k cross-compi= ler). > >> Reverting this commit on next-20220927 fixes the issue. > >> > >> [1] http://kisskb.ellerman.id.au/kisskb/buildresult/14803908/ > >> [2] http://kisskb.ellerman.id.au/kisskb/head/1bd8b75fe6adeaa89d02968bd= d811ffe708cf839/ > > > > Eek! Thanks for letting me know. I'm confused about this -- > > __alloc_size__ wasn't optional in compiler_attributes.h -- but obviousl= y > > I broke something! I'll go figure this out. > > This fixes it for me. Kees submitted a similar patch 20 minutes before: https://lore.kernel.org/all/20220929081642.1932200-1-keescook@chromium.org > --- a/include/linux/compiler_types.h > +++ b/include/linux/compiler_types.h > @@ -275,8 +275,13 @@ struct ftrace_likely_data { > * be performing a _reallocation_, as that may alias the existing pointe= r. > * For these, use __realloc_size(). > */ > -#define __alloc_size(x, ...) __alloc_size__(x, ## __VA_ARGS__) __mallo= c > -#define __realloc_size(x, ...) __alloc_size__(x, ## __VA_ARGS__) > +#ifdef __alloc_size__ > +# define __alloc_size(x, ...) __alloc_size__(x, ## __VA_ARGS__) __mallo= c > +# define __realloc_size(x, ...) __alloc_size__(x, ## __VA_ARGS__) > +#else > +# define __alloc_size(x, ...) __malloc > +# define __realloc_size(x, ...) > +#endif > > #ifndef asm_volatile_goto > #define asm_volatile_goto(x...) asm goto(x) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D91EFC6FA92 for ; Thu, 29 Sep 2022 09:00:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 620CF83F48; Thu, 29 Sep 2022 09:00:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 620CF83F48 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1664442058; bh=GPy8zZpxHBk1qgsu6fMJnnvl9Hk3ujBFaEoA7AJGIpo=; h=References:In-Reply-To:From:Date:To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=VGlp13bGT2QN97CJdwvhxQc+EcMfz/VJImr9Nk4quWkfrsfo4M7eX2V0RpxGz2Ey8 NpIlZw0ZkPGzheeP7CrKFY3Amj1nt45BUTkaL87Purp6B7zBjFjfj3sdzJwE/NlcXO IyHbWDlLwqBUWfHMNHbIr91cI60WoxcfYR5Ozii7iSTmn4I1ygslorGu6OCmaOJOqe pW+bo0DsGrjeY0JkM+l4xCSHvzVT4IjBiitMWNnn1VNAZqGaCehjdBzqoNgQ5B+wrC BNAiSEhwvMwqb4f+K2YDJGZ88TbP0U/YUkya5BVzxfg+AgToYF9aHgB1jjHYwPg5p1 lUfYew3KPs/pw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hxWnDHSBJP79; Thu, 29 Sep 2022 09:00:57 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 4AEBF83F3F; Thu, 29 Sep 2022 09:00:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4AEBF83F3F Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 776AA1BF2FA for ; Thu, 29 Sep 2022 09:00:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 51DD883F47 for ; Thu, 29 Sep 2022 09:00:55 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 51DD883F47 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0hmpwWHq_KuL for ; Thu, 29 Sep 2022 09:00:53 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A347883F3F Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by smtp1.osuosl.org (Postfix) with ESMTPS id A347883F3F for ; Thu, 29 Sep 2022 09:00:53 +0000 (UTC) Received: by mail-vs1-f46.google.com with SMTP id h1so800730vsr.11 for ; Thu, 29 Sep 2022 02:00:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=Ir+IzupNAXvXvPBkZ1yh/qacu5xVXDJ2KC3L3ZMV+D4=; b=MKWcyu5cAJsvjgsjodXCWPPWuGoNJ+7Hg+f2axUpNK5mVVgk/uHgILt7N/gse3+W/9 q2asJ/IzGd+znh1gukKl8K3yRi1auAFfOjsnFF5vXB0TZq3XRZm+/3y+kpWcn0AKQEES SXrMvnJ+P0D45i3JnFQlaZew6GNO4X+mPnjWFCJzygQz+uCcngLPbjCXlSpAHrrhidgc tT4of4nyGy3j4ffsysbFOytYM/qj8jD+7BEoadtNI2TLeyVnABZQBlLToaCe7C8Qi/Fz mHZwNaxAhz4jK0Z8pqJgFyKWgASYkAdPmRSQMEoZLVVZnaZ1yxlBpBEUiAnnVeoOc925 Gksg== X-Gm-Message-State: ACrzQf0m/3X28ABiCSKZPMQW2JctoNTYuqJ34SgE8w2oZkpbcvZouXWg R6107vj3lOloqlQwGFjJYU/oSIGd3C7djg== X-Google-Smtp-Source: AMsMyM7X0Xkvf074rcVvem9q2HHHIoFaegq9hTxFx8z5L+SN94d+q4nzA1aBOnG9q5nOEOh/kYO9Jw== X-Received: by 2002:a67:ae01:0:b0:398:7123:cc03 with SMTP id x1-20020a67ae01000000b003987123cc03mr680527vse.51.1664442052286; Thu, 29 Sep 2022 02:00:52 -0700 (PDT) Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com. [209.85.222.47]) by smtp.gmail.com with ESMTPSA id s136-20020a1f2c8e000000b0039459f3a585sm1366955vks.42.2022.09.29.02.00.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 02:00:52 -0700 (PDT) Received: by mail-ua1-f47.google.com with SMTP id a14so249053uat.13 for ; Thu, 29 Sep 2022 02:00:51 -0700 (PDT) X-Received: by 2002:a5b:104:0:b0:6b0:429:3fe9 with SMTP id 4-20020a5b0104000000b006b004293fe9mr2016091ybx.543.1664442041163; Thu, 29 Sep 2022 02:00:41 -0700 (PDT) MIME-Version: 1.0 References: <20220923202822.2667581-1-keescook@chromium.org> <20220923202822.2667581-2-keescook@chromium.org> <202209281011.66DD717D@keescook> <874jwqfuh6.fsf@mpe.ellerman.id.au> In-Reply-To: <874jwqfuh6.fsf@mpe.ellerman.id.au> From: Geert Uytterhoeven Date: Thu, 29 Sep 2022 11:00:28 +0200 X-Gmail-Original-Message-ID: Message-ID: To: Michael Ellerman Subject: Re: [Intel-wired-lan] [PATCH v2 01/16] slab: Remove __malloc attribute from realloc functions X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roman Gushchin , dri-devel@lists.freedesktop.org, "Ruhl, Michael J" , Eric Dumazet , linux-hardening@vger.kernel.org, Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christoph Lameter , Sumit Semwal , dev@openvswitch.org, x86@kernel.org, intel-wired-lan@lists.osuosl.org, David Rientjes , Miguel Ojeda , Jakub Kicinski , Paolo Abeni , linux-media@vger.kernel.org, Marco Elver , llvm@lists.linux.dev, Kees Cook , Josef Bacik , linaro-mm-sig@lists.linaro.org, Yonghong Song , David Sterba , Joonsoo Kim , Vlastimil Babka , Alex Elder , linux-mm@kvack.org, Greg Kroah-Hartman , Nick Desaulniers , linux-kernel@vger.kernel.org, =?UTF-8?Q?Christian_K=C3=B6nig?= , Pekka Enberg , Daniel Micay , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , "David S. Miller" , linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" SGkgTWljaGFlbCwKCk9uIFRodSwgU2VwIDI5LCAyMDIyIGF0IDEwOjM2IEFNIE1pY2hhZWwgRWxs ZXJtYW4gPG1wZUBlbGxlcm1hbi5pZC5hdT4gd3JvdGU6Cj4gS2VlcyBDb29rIDxrZWVzY29va0Bj aHJvbWl1bS5vcmc+IHdyaXRlczoKPiA+IE9uIFdlZCwgU2VwIDI4LCAyMDIyIGF0IDA5OjI2OjE1 QU0gKzAyMDAsIEdlZXJ0IFV5dHRlcmhvZXZlbiB3cm90ZToKPiA+PiBPbiBGcmksIFNlcCAyMywg MjAyMiBhdCAxMDozNSBQTSBLZWVzIENvb2sgPGtlZXNjb29rQGNocm9taXVtLm9yZz4gd3JvdGU6 Cj4gPj4gPiBUaGUgX19tYWxsb2MgYXR0cmlidXRlIHNob3VsZCBub3QgYmUgYXBwbGllZCB0byAi cmVhbGxvYyIgZnVuY3Rpb25zLCBhcwo+ID4+ID4gdGhlIHJldHVybmVkIHBvaW50ZXIgbWF5IGFs aWFzIHRoZSBzdG9yYWdlIG9mIHRoZSBwcmlvciBwb2ludGVyLiBJbnN0ZWFkCj4gPj4gPiBvZiBz cGxpdHRpbmcgX19tYWxsb2MgZnJvbSBfX2FsbG9jX3NpemUsIHdoaWNoIHdvdWxkIGJlIGEgaHVn ZSBhbW91bnQgb2YKPiA+PiA+IGNodXJuLCBqdXN0IGNyZWF0ZSBfX3JlYWxsb2Nfc2l6ZSBmb3Ig dGhlIGZldyBjYXNlcyB3aGVyZSBpdCBpcyBuZWVkZWQuCj4gPj4gPgo+ID4+ID4gQWRkaXRpb25h bGx5IHJlbW92ZXMgdGhlIGNvbmRpdGlvbmFsIHRlc3QgZm9yIF9fYWxsb2Nfc2l6ZV9fLCB3aGlj aCBpcwo+ID4+ID4gYWx3YXlzIGRlZmluZWQgbm93Lgo+ID4+ID4KPiA+PiA+IENjOiBDaHJpc3Rv cGggTGFtZXRlciA8Y2xAbGludXguY29tPgo+ID4+ID4gQ2M6IFBla2thIEVuYmVyZyA8cGVuYmVy Z0BrZXJuZWwub3JnPgo+ID4+ID4gQ2M6IERhdmlkIFJpZW50amVzIDxyaWVudGplc0Bnb29nbGUu Y29tPgo+ID4+ID4gQ2M6IEpvb25zb28gS2ltIDxpYW1qb29uc29vLmtpbUBsZ2UuY29tPgo+ID4+ ID4gQ2M6IEFuZHJldyBNb3J0b24gPGFrcG1AbGludXgtZm91bmRhdGlvbi5vcmc+Cj4gPj4gPiBD YzogVmxhc3RpbWlsIEJhYmthIDx2YmFia2FAc3VzZS5jej4KPiA+PiA+IENjOiBSb21hbiBHdXNo Y2hpbiA8cm9tYW4uZ3VzaGNoaW5AbGludXguZGV2Pgo+ID4+ID4gQ2M6IEh5ZW9uZ2dvbiBZb28g PDQyLmh5ZXlvb0BnbWFpbC5jb20+Cj4gPj4gPiBDYzogTWFyY28gRWx2ZXIgPGVsdmVyQGdvb2ds ZS5jb20+Cj4gPj4gPiBDYzogbGludXgtbW1Aa3ZhY2sub3JnCj4gPj4gPiBTaWduZWQtb2ZmLWJ5 OiBLZWVzIENvb2sgPGtlZXNjb29rQGNocm9taXVtLm9yZz4KPiA+Pgo+ID4+IFRoYW5rcyBmb3Ig eW91ciBwYXRjaCwgd2hpY2ggaXMgbm93IGNvbW1pdCA2M2NhYTA0ZWM2MDU4M2IxICgic2xhYjoK PiA+PiBSZW1vdmUgX19tYWxsb2MgYXR0cmlidXRlIGZyb20gcmVhbGxvYyBmdW5jdGlvbnMiKSBp biBuZXh0LTIwMjIwOTI3Lgo+ID4+Cj4gPj4gTm9yZXBseUBlbGxlcm1hbi5pZC5hdSByZXBvcnRl ZCBhbGwgZ2NjOC1iYXNlZCBidWlsZHMgdG8gZmFpbAo+ID4+IChlLmcuIFsxXSwgbW9yZSBhdCBb Ml0pOgo+ID4+Cj4gPj4gICAgIEluIGZpbGUgaW5jbHVkZWQgZnJvbSA8Y29tbWFuZC1saW5lPjoK PiA+PiAgICAgLi9pbmNsdWRlL2xpbnV4L3BlcmNwdS5oOiBJbiBmdW5jdGlvbiDigJhfX2FsbG9j X3Jlc2VydmVkX3BlcmNwdeKAmToKPiA+PiAgICAgLi8uL2luY2x1ZGUvbGludXgvY29tcGlsZXJf dHlwZXMuaDoyNzk6MzA6IGVycm9yOiBleHBlY3RlZAo+ID4+IGRlY2xhcmF0aW9uIHNwZWNpZmll cnMgYmVmb3JlIOKAmF9fYWxsb2Nfc2l6ZV9f4oCZCj4gPj4gICAgICAjZGVmaW5lIF9fYWxsb2Nf c2l6ZSh4LCAuLi4pIF9fYWxsb2Nfc2l6ZV9fKHgsICMjIF9fVkFfQVJHU19fKSBfX21hbGxvYwo+ ID4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fgo+ID4+ ICAgICAuL2luY2x1ZGUvbGludXgvcGVyY3B1Lmg6MTIwOjc0OiBub3RlOiBpbiBleHBhbnNpb24g b2YgbWFjcm8g4oCYX19hbGxvY19zaXpl4oCZCj4gPj4gICAgIFsuLi5dCj4gPj4KPiA+PiBJdCdz IGJ1aWxkaW5nIGZpbmUgd2l0aCBlLmcuIGdjYy05ICh3aGljaCBpcyBteSB1c3VhbCBtNjhrIGNy b3NzLWNvbXBpbGVyKS4KPiA+PiBSZXZlcnRpbmcgdGhpcyBjb21taXQgb24gbmV4dC0yMDIyMDky NyBmaXhlcyB0aGUgaXNzdWUuCj4gPj4KPiA+PiBbMV0gaHR0cDovL2tpc3NrYi5lbGxlcm1hbi5p ZC5hdS9raXNza2IvYnVpbGRyZXN1bHQvMTQ4MDM5MDgvCj4gPj4gWzJdIGh0dHA6Ly9raXNza2Iu ZWxsZXJtYW4uaWQuYXUva2lzc2tiL2hlYWQvMWJkOGI3NWZlNmFkZWFhODlkMDI5NjhiZGQ4MTFm ZmU3MDhjZjgzOS8KPiA+Cj4gPiBFZWshIFRoYW5rcyBmb3IgbGV0dGluZyBtZSBrbm93LiBJJ20g Y29uZnVzZWQgYWJvdXQgdGhpcyAtLQo+ID4gX19hbGxvY19zaXplX18gd2Fzbid0IG9wdGlvbmFs IGluIGNvbXBpbGVyX2F0dHJpYnV0ZXMuaCAtLSBidXQgb2J2aW91c2x5Cj4gPiBJIGJyb2tlIHNv bWV0aGluZyEgSSdsbCBnbyBmaWd1cmUgdGhpcyBvdXQuCj4KPiBUaGlzIGZpeGVzIGl0IGZvciBt ZS4KCktlZXMgc3VibWl0dGVkIGEgc2ltaWxhciBwYXRjaCAyMCBtaW51dGVzIGJlZm9yZToKaHR0 cHM6Ly9sb3JlLmtlcm5lbC5vcmcvYWxsLzIwMjIwOTI5MDgxNjQyLjE5MzIyMDAtMS1rZWVzY29v a0BjaHJvbWl1bS5vcmcKCj4gLS0tIGEvaW5jbHVkZS9saW51eC9jb21waWxlcl90eXBlcy5oCj4g KysrIGIvaW5jbHVkZS9saW51eC9jb21waWxlcl90eXBlcy5oCj4gQEAgLTI3NSw4ICsyNzUsMTMg QEAgc3RydWN0IGZ0cmFjZV9saWtlbHlfZGF0YSB7Cj4gICAqIGJlIHBlcmZvcm1pbmcgYSBfcmVh bGxvY2F0aW9uXywgYXMgdGhhdCBtYXkgYWxpYXMgdGhlIGV4aXN0aW5nIHBvaW50ZXIuCj4gICAq IEZvciB0aGVzZSwgdXNlIF9fcmVhbGxvY19zaXplKCkuCj4gICAqLwo+IC0jZGVmaW5lIF9fYWxs b2Nfc2l6ZSh4LCAuLi4pICAgX19hbGxvY19zaXplX18oeCwgIyMgX19WQV9BUkdTX18pIF9fbWFs bG9jCj4gLSNkZWZpbmUgX19yZWFsbG9jX3NpemUoeCwgLi4uKSBfX2FsbG9jX3NpemVfXyh4LCAj IyBfX1ZBX0FSR1NfXykKPiArI2lmZGVmIF9fYWxsb2Nfc2l6ZV9fCj4gKyMgZGVmaW5lIF9fYWxs b2Nfc2l6ZSh4LCAuLi4pICBfX2FsbG9jX3NpemVfXyh4LCAjIyBfX1ZBX0FSR1NfXykgX19tYWxs b2MKPiArIyBkZWZpbmUgX19yZWFsbG9jX3NpemUoeCwgLi4uKSAgICAgICAgX19hbGxvY19zaXpl X18oeCwgIyMgX19WQV9BUkdTX18pCj4gKyNlbHNlCj4gKyMgZGVmaW5lIF9fYWxsb2Nfc2l6ZSh4 LCAuLi4pICBfX21hbGxvYwo+ICsjIGRlZmluZSBfX3JlYWxsb2Nfc2l6ZSh4LCAuLi4pCj4gKyNl bmRpZgo+Cj4gICNpZm5kZWYgYXNtX3ZvbGF0aWxlX2dvdG8KPiAgI2RlZmluZSBhc21fdm9sYXRp bGVfZ290byh4Li4uKSBhc20gZ290byh4KQoKCkdye29ldGplLGVldGluZ31zLAoKICAgICAgICAg ICAgICAgICAgICAgICAgR2VlcnQKCi0tCkdlZXJ0IFV5dHRlcmhvZXZlbiAtLSBUaGVyZSdzIGxv dHMgb2YgTGludXggYmV5b25kIGlhMzIgLS0gZ2VlcnRAbGludXgtbTY4ay5vcmcKCkluIHBlcnNv bmFsIGNvbnZlcnNhdGlvbnMgd2l0aCB0ZWNobmljYWwgcGVvcGxlLCBJIGNhbGwgbXlzZWxmIGEg aGFja2VyLiBCdXQKd2hlbiBJJ20gdGFsa2luZyB0byBqb3VybmFsaXN0cyBJIGp1c3Qgc2F5ICJw cm9ncmFtbWVyIiBvciBzb21ldGhpbmcgbGlrZSB0aGF0LgogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIC0tIExpbnVzIFRvcnZhbGRzCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLXdpcmVkLWxhbiBtYWlsaW5nIGxpc3QKSW50ZWwtd2ly ZWQtbGFuQG9zdW9zbC5vcmcKaHR0cHM6Ly9saXN0cy5vc3Vvc2wub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtd2lyZWQtbGFuCg==