From: Geert Uytterhoeven <geert@linux-m68k.org> To: Sudeep Holla <sudeep.holla@arm.com> Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Catalin Marinas <catalin.marinas@arm.com>, Jeremy Linton <jeremy.linton@arm.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Hanjun Guo <hanjun.guo@linaro.org>, Will Deacon <will.deacon@arm.com> Subject: Re: [PATCH 1/3] Revert "arm64: topology: divorce MC scheduling domain from core_siblings" Date: Tue, 5 Jun 2018 16:09:52 +0200 [thread overview] Message-ID: <CAMuHMdVPRLt34SUDsbbHvEG2OzvbJoT6id7Rb_2j32=zb1TuKg@mail.gmail.com> (raw) In-Reply-To: <1528206938-2702-1-git-send-email-sudeep.holla@arm.com> Hi Sudeep, On Tue, Jun 5, 2018 at 3:55 PM, Sudeep Holla <sudeep.holla@arm.com> wrote: > This reverts commit 37c3ec2d810f87eac73822f76b30391a83bded19. > > Currently on ARM64 platforms, we don't update the CPU topology masks > on each hotplug operation. However, the updates to cpu_coregroup_mask I would add "leading to e.g. a system hang during system suspend." to avoid people thinking this is purely a small bookkeeping issue without any percussions. > done as part of ACPI PPTT support, in particular the commit being > reverted makes use of cpumask_of_node which returns the cpu_oneline_mask > instead of core_sibling as core_sibling masks are not updated for CPU > hotplug operations and the comparision to find NUMA in package or LLC > siblings fails. > > The original commit is technically correct and since it depends on the > not yet supported feature, let's revert this for now. We can put it back > once we have the support for CPU topology masks update on hotplug merged. > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will.deacon@arm.com> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: geert@linux-m68k.org (Geert Uytterhoeven) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] Revert "arm64: topology: divorce MC scheduling domain from core_siblings" Date: Tue, 5 Jun 2018 16:09:52 +0200 [thread overview] Message-ID: <CAMuHMdVPRLt34SUDsbbHvEG2OzvbJoT6id7Rb_2j32=zb1TuKg@mail.gmail.com> (raw) In-Reply-To: <1528206938-2702-1-git-send-email-sudeep.holla@arm.com> Hi Sudeep, On Tue, Jun 5, 2018 at 3:55 PM, Sudeep Holla <sudeep.holla@arm.com> wrote: > This reverts commit 37c3ec2d810f87eac73822f76b30391a83bded19. > > Currently on ARM64 platforms, we don't update the CPU topology masks > on each hotplug operation. However, the updates to cpu_coregroup_mask I would add "leading to e.g. a system hang during system suspend." to avoid people thinking this is purely a small bookkeeping issue without any percussions. > done as part of ACPI PPTT support, in particular the commit being > reverted makes use of cpumask_of_node which returns the cpu_oneline_mask > instead of core_sibling as core_sibling masks are not updated for CPU > hotplug operations and the comparision to find NUMA in package or LLC > siblings fails. > > The original commit is technically correct and since it depends on the > not yet supported feature, let's revert this for now. We can put it back > once we have the support for CPU topology masks update on hotplug merged. > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will.deacon@arm.com> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
next prev parent reply other threads:[~2018-06-05 14:09 UTC|newest] Thread overview: 185+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-11 23:57 [PATCH v9 00/12] Support PPTT for ARM64 Jeremy Linton 2018-05-11 23:57 ` Jeremy Linton 2018-05-11 23:57 ` Jeremy Linton 2018-05-11 23:57 ` [PATCH v9 01/12] drivers: base: cacheinfo: move cache_setup_of_node() Jeremy Linton 2018-05-11 23:57 ` Jeremy Linton 2018-05-11 23:57 ` Jeremy Linton 2018-05-11 23:57 ` [PATCH v9 02/12] drivers: base: cacheinfo: setup DT cache properties early Jeremy Linton 2018-05-11 23:57 ` Jeremy Linton 2018-05-11 23:57 ` Jeremy Linton 2018-05-11 23:57 ` Jeremy Linton 2018-05-15 17:15 ` Jeremy Linton 2018-05-15 17:15 ` Jeremy Linton 2018-05-15 17:15 ` Jeremy Linton 2018-05-15 19:32 ` Andy Shevchenko 2018-05-15 19:32 ` Andy Shevchenko 2018-05-15 19:32 ` Andy Shevchenko 2018-05-15 19:32 ` Andy Shevchenko 2018-05-16 10:56 ` Sudeep Holla 2018-05-16 10:56 ` Sudeep Holla 2018-05-16 10:56 ` Sudeep Holla 2018-05-16 10:56 ` Sudeep Holla 2018-05-17 15:47 ` Sudeep Holla 2018-05-17 15:47 ` Sudeep Holla 2018-05-17 15:47 ` Sudeep Holla 2018-05-17 15:47 ` Sudeep Holla 2018-05-18 21:50 ` Andy Shevchenko 2018-05-18 21:50 ` Andy Shevchenko 2018-05-18 21:50 ` Andy Shevchenko 2018-05-18 21:50 ` Andy Shevchenko 2018-05-21 9:27 ` Sudeep Holla 2018-05-21 9:27 ` Sudeep Holla 2018-05-21 9:27 ` Sudeep Holla 2018-05-21 9:27 ` Sudeep Holla 2018-05-21 10:15 ` Sudeep Holla 2018-05-21 10:15 ` Sudeep Holla 2018-05-21 10:15 ` Sudeep Holla 2018-05-21 10:15 ` Sudeep Holla 2018-05-21 10:32 ` [PATCH] drivers: base: cacheinfo: use OF property_read_u64 instead of get_property,read_number Sudeep Holla 2018-05-21 10:32 ` [PATCH] drivers: base: cacheinfo: use OF property_read_u64 instead of get_property, read_number Sudeep Holla 2018-05-21 12:53 ` [PATCH v2] drivers: base: cacheinfo: use OF property_read_u32 instead of get_property,read_number Sudeep Holla 2018-05-21 12:53 ` [PATCH v2] drivers: base: cacheinfo: use OF property_read_u32 instead of get_property, read_number Sudeep Holla 2018-06-05 16:21 ` [PATCH v2] drivers: base: cacheinfo: use OF property_read_u32 instead of get_property,read_number Andy Shevchenko 2018-06-05 16:21 ` Andy Shevchenko 2018-06-05 16:26 ` Sudeep Holla 2018-06-05 16:26 ` Sudeep Holla 2018-06-05 16:34 ` Andy Shevchenko 2018-06-05 16:34 ` Andy Shevchenko 2018-05-17 6:54 ` [PATCH v9 02/12] drivers: base: cacheinfo: setup DT cache properties early Greg KH 2018-05-17 6:54 ` Greg KH 2018-05-17 6:54 ` Greg KH 2018-05-17 9:08 ` Sudeep Holla 2018-05-17 9:08 ` Sudeep Holla 2018-05-17 9:08 ` Sudeep Holla 2018-05-17 9:35 ` Greg KH 2018-05-17 9:35 ` Greg KH 2018-05-17 9:35 ` Greg KH 2018-05-11 23:57 ` [PATCH v9 03/12] cacheinfo: rename of_node to fw_token Jeremy Linton 2018-05-11 23:57 ` Jeremy Linton 2018-05-11 23:57 ` Jeremy Linton 2018-05-11 23:57 ` [PATCH v9 04/12] arm64/acpi: Create arch specific cpu to acpi id helper Jeremy Linton 2018-05-11 23:57 ` Jeremy Linton 2018-05-11 23:57 ` Jeremy Linton 2018-05-14 14:41 ` Sudeep Holla 2018-05-14 14:41 ` Sudeep Holla 2018-05-14 14:41 ` Sudeep Holla 2018-05-11 23:58 ` [PATCH v9 05/12] ACPI/PPTT: Add Processor Properties Topology Table parsing Jeremy Linton 2018-05-11 23:58 ` Jeremy Linton 2018-05-11 23:58 ` Jeremy Linton 2018-05-12 10:09 ` Rafael J. Wysocki 2018-05-12 10:09 ` Rafael J. Wysocki 2018-05-12 10:09 ` Rafael J. Wysocki 2018-05-12 10:09 ` Rafael J. Wysocki 2018-05-15 21:42 ` Jeremy Linton 2018-05-15 21:42 ` Jeremy Linton 2018-05-15 21:42 ` Jeremy Linton 2018-05-15 21:42 ` Jeremy Linton 2018-05-16 8:24 ` Rafael J. Wysocki 2018-05-16 8:24 ` Rafael J. Wysocki 2018-05-16 8:24 ` Rafael J. Wysocki 2018-05-16 8:24 ` Rafael J. Wysocki 2018-05-11 23:58 ` [PATCH v9 06/12] ACPI: Enable PPTT support on ARM64 Jeremy Linton 2018-05-11 23:58 ` Jeremy Linton 2018-05-11 23:58 ` Jeremy Linton 2018-05-11 23:58 ` [PATCH v9 07/12] drivers: base cacheinfo: Add support for ACPI based firmware tables Jeremy Linton 2018-05-11 23:58 ` Jeremy Linton 2018-05-11 23:58 ` Jeremy Linton 2018-05-11 23:58 ` [PATCH v9 08/12] arm64: " Jeremy Linton 2018-05-11 23:58 ` Jeremy Linton 2018-05-11 23:58 ` Jeremy Linton 2018-05-11 23:58 ` [PATCH v9 09/12] arm64: topology: rename cluster_id Jeremy Linton 2018-05-11 23:58 ` Jeremy Linton 2018-05-11 23:58 ` Jeremy Linton 2018-05-11 23:58 ` [PATCH v9 10/12] arm64: topology: enable ACPI/PPTT based CPU topology Jeremy Linton 2018-05-11 23:58 ` Jeremy Linton 2018-05-11 23:58 ` Jeremy Linton 2018-05-11 23:58 ` [PATCH v9 11/12] ACPI: Add PPTT to injectable table list Jeremy Linton 2018-05-11 23:58 ` Jeremy Linton 2018-05-11 23:58 ` Jeremy Linton 2018-05-12 10:10 ` Rafael J. Wysocki 2018-05-12 10:10 ` Rafael J. Wysocki 2018-05-12 10:10 ` Rafael J. Wysocki 2018-05-12 10:10 ` Rafael J. Wysocki 2018-05-11 23:58 ` [PATCH v9 12/12] arm64: topology: divorce MC scheduling domain from core_siblings Jeremy Linton 2018-05-11 23:58 ` Jeremy Linton 2018-05-11 23:58 ` Jeremy Linton 2018-05-17 17:05 ` [PATCH v9 00/12] Support PPTT for ARM64 Catalin Marinas 2018-05-17 17:05 ` Catalin Marinas 2018-05-17 17:05 ` Catalin Marinas 2018-05-29 10:48 ` Geert Uytterhoeven 2018-05-29 10:48 ` Geert Uytterhoeven 2018-05-29 10:48 ` Geert Uytterhoeven 2018-05-29 10:48 ` Geert Uytterhoeven 2018-05-29 11:14 ` Sudeep Holla 2018-05-29 11:14 ` Sudeep Holla 2018-05-29 11:14 ` Sudeep Holla 2018-05-29 11:14 ` Sudeep Holla 2018-05-29 11:56 ` Geert Uytterhoeven 2018-05-29 11:56 ` Geert Uytterhoeven 2018-05-29 11:56 ` Geert Uytterhoeven 2018-05-29 11:56 ` Geert Uytterhoeven 2018-05-29 13:18 ` Sudeep Holla 2018-05-29 13:18 ` Sudeep Holla 2018-05-29 13:18 ` Sudeep Holla 2018-05-29 13:18 ` Sudeep Holla 2018-05-29 15:08 ` Will Deacon 2018-05-29 15:08 ` Will Deacon 2018-05-29 15:08 ` Will Deacon 2018-05-29 15:08 ` Will Deacon 2018-05-29 15:51 ` Geert Uytterhoeven 2018-05-29 15:51 ` Geert Uytterhoeven 2018-05-29 15:51 ` Geert Uytterhoeven 2018-05-29 15:51 ` Geert Uytterhoeven 2018-05-29 17:08 ` Robin Murphy 2018-05-29 17:08 ` Robin Murphy 2018-05-29 17:08 ` Robin Murphy 2018-05-29 17:08 ` Robin Murphy 2018-05-29 17:18 ` Geert Uytterhoeven 2018-05-29 17:18 ` Geert Uytterhoeven 2018-05-29 17:18 ` Geert Uytterhoeven 2018-05-29 17:18 ` Geert Uytterhoeven 2018-05-29 17:31 ` Sudeep Holla 2018-05-29 17:31 ` Sudeep Holla 2018-05-29 17:31 ` Sudeep Holla 2018-05-29 17:31 ` Sudeep Holla 2018-05-29 20:16 ` Will Deacon 2018-05-29 20:16 ` Will Deacon 2018-05-29 20:16 ` Will Deacon 2018-05-29 20:16 ` Will Deacon 2018-05-29 20:48 ` Jeremy Linton 2018-05-29 20:48 ` Jeremy Linton 2018-05-29 20:48 ` Jeremy Linton 2018-05-29 20:48 ` Jeremy Linton 2018-05-29 21:52 ` Jeremy Linton 2018-05-29 21:52 ` Jeremy Linton 2018-05-29 21:52 ` Jeremy Linton 2018-05-29 21:52 ` Jeremy Linton 2018-05-30 13:24 ` Sudeep Holla 2018-05-30 13:24 ` Sudeep Holla 2018-05-30 13:24 ` Sudeep Holla 2018-05-30 13:24 ` Sudeep Holla 2018-05-29 15:23 ` Jeremy Linton 2018-05-29 15:23 ` Jeremy Linton 2018-05-29 15:23 ` Jeremy Linton 2018-05-29 15:23 ` Jeremy Linton 2018-05-29 15:50 ` Geert Uytterhoeven 2018-05-29 15:50 ` Geert Uytterhoeven 2018-05-29 15:50 ` Geert Uytterhoeven 2018-05-29 15:50 ` Geert Uytterhoeven 2018-05-30 8:52 ` Morten Rasmussen 2018-05-30 8:52 ` Morten Rasmussen 2018-05-30 8:52 ` Morten Rasmussen 2018-05-30 8:52 ` Morten Rasmussen 2018-06-05 13:55 ` [PATCH 1/3] Revert "arm64: topology: divorce MC scheduling domain from core_siblings" Sudeep Holla 2018-06-05 13:55 ` Sudeep Holla 2018-06-05 13:55 ` [PATCH 2/3] ACPI / PPTT: fix build when CONFIG_ACPI_PPTT is not enabled Sudeep Holla 2018-06-05 13:55 ` Sudeep Holla 2018-06-05 13:55 ` [PATCH 3/3] arm64: disable ACPI PPTT support temporarily Sudeep Holla 2018-06-05 13:55 ` Sudeep Holla 2018-06-05 14:09 ` Geert Uytterhoeven [this message] 2018-06-05 14:09 ` [PATCH 1/3] Revert "arm64: topology: divorce MC scheduling domain from core_siblings" Geert Uytterhoeven 2018-06-05 14:12 ` Sudeep Holla 2018-06-05 14:12 ` Sudeep Holla 2018-06-04 15:12 ` [PATCH v9 00/12] Support PPTT for ARM64 Catalin Marinas 2018-06-04 15:12 ` Catalin Marinas 2018-06-04 15:12 ` Catalin Marinas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMuHMdVPRLt34SUDsbbHvEG2OzvbJoT6id7Rb_2j32=zb1TuKg@mail.gmail.com' \ --to=geert@linux-m68k.org \ --cc=catalin.marinas@arm.com \ --cc=hanjun.guo@linaro.org \ --cc=jeremy.linton@arm.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rjw@rjwysocki.net \ --cc=sudeep.holla@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.