From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAF9DC43217 for ; Tue, 28 Dec 2021 10:40:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236238AbhL1KkT (ORCPT ); Tue, 28 Dec 2021 05:40:19 -0500 Received: from mail-ua1-f47.google.com ([209.85.222.47]:35735 "EHLO mail-ua1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230112AbhL1KkS (ORCPT ); Tue, 28 Dec 2021 05:40:18 -0500 Received: by mail-ua1-f47.google.com with SMTP id v14so13690748uau.2; Tue, 28 Dec 2021 02:40:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QGprts+IMCcw2LRbyJoC20xYqdPz6LzpMb8Wjv374xM=; b=zfiJiXCGYSln8yAHVf3/5z9KThppDtc8CvzV0oIg6DwkWWdmvUJFH0jrRzd08RC5cE D0AHwvFXXupf/zQNOCbcjNm65Xc1ULotawmWB/ZEP78R+uHyMb60psQymqS+mJKgdkEh X3BlILhWZ79JvFZTxDcLAhB/1Ior3HvZfSUvr0oZS7bsN3tkKKLeaW0+A1M9VVidsv01 NVh3wxw3Qlea06MxHN/tjkeCDhTxBXTf/MyUcAkJR5k3ITPUBGFYPlfPPOJA1z3TsHNK n/JSJ69YTIatEGnuT1hBewT6srp9O31w+pTM2PUmnrsg5ffGfHAHy8xIW59KOuH+1nPr 3AbA== X-Gm-Message-State: AOAM532Xg3ANejAdu32eZBq3UqWQSK+co93fp1i6ZqnGqmtY5v2adGGy SsXcWKu9LXIgErY4jZd9vC7PCrFoO2PEiA== X-Google-Smtp-Source: ABdhPJzCaJ+N+2NLqZlv1RaH6z8hTjwhcOW3CvFnYvmv4MES0eqg5X7TLsBs565cgLrVdJgfzF+bTw== X-Received: by 2002:a05:6130:323:: with SMTP id ay35mr2572658uab.1.1640688016744; Tue, 28 Dec 2021 02:40:16 -0800 (PST) Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com. [209.85.222.52]) by smtp.gmail.com with ESMTPSA id x21sm3980474ual.11.2021.12.28.02.40.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Dec 2021 02:40:16 -0800 (PST) Received: by mail-ua1-f52.google.com with SMTP id t18so23784817uaj.1; Tue, 28 Dec 2021 02:40:16 -0800 (PST) X-Received: by 2002:a67:2e09:: with SMTP id u9mr5382186vsu.77.1640688015917; Tue, 28 Dec 2021 02:40:15 -0800 (PST) MIME-Version: 1.0 References: <20211227164317.4146918-1-schnelle@linux.ibm.com> <20211227164317.4146918-25-schnelle@linux.ibm.com> In-Reply-To: <20211227164317.4146918-25-schnelle@linux.ibm.com> From: Geert Uytterhoeven Date: Tue, 28 Dec 2021 11:40:04 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 24/32] scsi: Kconfig: add HAS_IOPORT dependencies To: Niklas Schnelle Cc: Arnd Bergmann , Bjorn Helgaas , John Garry , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , "James E.J. Bottomley" , "Martin K. Petersen" , Linux Kernel Mailing List , Linux-Arch , linux-pci , linux-riscv , linux-csky@vger.kernel.org, scsi Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Niklas, On Mon, Dec 27, 2021 at 5:53 PM Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. > > Co-developed-by: Arnd Bergmann > Signed-off-by: Arnd Bergmann > Signed-off-by: Niklas Schnelle Thanks for your patch! > --- a/drivers/scsi/Kconfig > +++ b/drivers/scsi/Kconfig > @@ -793,6 +793,7 @@ config SCSI_INIA100 > config SCSI_PPA > tristate "IOMEGA parallel port (ppa - older drives)" > depends on SCSI && PARPORT_PC > + depends on HAS_IOPORT This is not needed, [04/32] already added that dependency to PARPORT_PC. > help > This driver supports older versions of IOMEGA's parallel port ZIP > drive (a 100 MB removable media device). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4354BC433EF for ; Tue, 28 Dec 2021 10:40:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fxP1deVTaohagKLDXGblsuHl6nbSOl69rt7qPPBojBY=; b=BpwMEsItFGtjja NwHld+0I71GAXlUf9ernEXIaQCYdrPGe3gHr9UM10rXROx10QLqzb5C05k6ahH/WNOYwUQKunqiGr e4GSwmWvQPpip1nErfxRQa2U0FJEiLufYZiiH9Z5mZLv/8cNPG+nH5BBhT5S+/qhmW8R5L2pAJPli tVuTZEv8TmmWsE9JXlrBkLhuV7JSGZTSvgrdR2kV0h4ISt58WivuC0J2hXLfYSUGvKSfK0vkUvWT5 6+Y8dqLso4VQks9V+7Hid+yy3IN3PBwGkr/jyIMjVlzDznE1wrcwU1le+f4Gv4Q1KqGx6x4KHTjKF tZz51NsrM1Yu+9LUSMTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n29u1-000iqO-FA; Tue, 28 Dec 2021 10:40:21 +0000 Received: from mail-ua1-f46.google.com ([209.85.222.46]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n29ty-000ipJ-Uh for linux-riscv@lists.infradead.org; Tue, 28 Dec 2021 10:40:20 +0000 Received: by mail-ua1-f46.google.com with SMTP id i5so16284254uaq.10 for ; Tue, 28 Dec 2021 02:40:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QGprts+IMCcw2LRbyJoC20xYqdPz6LzpMb8Wjv374xM=; b=vXzpnnVNcvwy+hyX50y8oLoT/DxL1NiyMzqaWhxgONG7wh5AFDodLVMLVSSQtJJ1SF 1cujyJfsC8Vuwac9vePWddsb7UDQ65JainA+DkNzpMNwDvEozO7xQVAueW546HI6AsUl A5pk+UXn14KceH2h4Q+jJSmefZSeDezskt0rh4lNWt0qIPGbvXHUrxYjetPPrQqR49E/ xXpkOJqMkKg6Jdf43dJxl7iz/cCrO8bX2dzH5mwij0iVe/jstluGusuMb7V5YBB6bQDl bOfnsqyrTLZWI4quKj44gDgtWz7fNbbAThjqcfka1K2sjd4weoP1aduKoUn2oQY01MnD KT/w== X-Gm-Message-State: AOAM531W2k7CNxiJykn32ie68n39ySn7OUqnL3UC+w/ShYpkyAfgEepP nCxu4OqgX3OMNn9MK6f18q/ddhlb9ykYrA== X-Google-Smtp-Source: ABdhPJygT6snpbbyboUBtoetQJ2whVebj+Hs/76TP1+224uqKl0RT56g6hO6ih7v8CDTTS1mrm5diA== X-Received: by 2002:a67:f613:: with SMTP id k19mr5116865vso.31.1640688017191; Tue, 28 Dec 2021 02:40:17 -0800 (PST) Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com. [209.85.222.43]) by smtp.gmail.com with ESMTPSA id 46sm2138279uav.10.2021.12.28.02.40.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Dec 2021 02:40:16 -0800 (PST) Received: by mail-ua1-f43.google.com with SMTP id r15so31365990uao.3 for ; Tue, 28 Dec 2021 02:40:16 -0800 (PST) X-Received: by 2002:a67:2e09:: with SMTP id u9mr5382186vsu.77.1640688015917; Tue, 28 Dec 2021 02:40:15 -0800 (PST) MIME-Version: 1.0 References: <20211227164317.4146918-1-schnelle@linux.ibm.com> <20211227164317.4146918-25-schnelle@linux.ibm.com> In-Reply-To: <20211227164317.4146918-25-schnelle@linux.ibm.com> From: Geert Uytterhoeven Date: Tue, 28 Dec 2021 11:40:04 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 24/32] scsi: Kconfig: add HAS_IOPORT dependencies To: Niklas Schnelle Cc: Arnd Bergmann , Bjorn Helgaas , John Garry , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , "James E.J. Bottomley" , "Martin K. Petersen" , Linux Kernel Mailing List , Linux-Arch , linux-pci , linux-riscv , linux-csky@vger.kernel.org, scsi X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211228_024019_011843_A5502511 X-CRM114-Status: GOOD ( 19.52 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Niklas, On Mon, Dec 27, 2021 at 5:53 PM Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. > > Co-developed-by: Arnd Bergmann > Signed-off-by: Arnd Bergmann > Signed-off-by: Niklas Schnelle Thanks for your patch! > --- a/drivers/scsi/Kconfig > +++ b/drivers/scsi/Kconfig > @@ -793,6 +793,7 @@ config SCSI_INIA100 > config SCSI_PPA > tristate "IOMEGA parallel port (ppa - older drives)" > depends on SCSI && PARPORT_PC > + depends on HAS_IOPORT This is not needed, [04/32] already added that dependency to PARPORT_PC. > help > This driver supports older versions of IOMEGA's parallel port ZIP > drive (a 100 MB removable media device). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv