From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Wed, 27 May 2020 07:02:51 +0000 Subject: Re: [PATCH] media: omap3isp: Shuffle cacheflush.h and include mm.h Message-Id: List-Id: References: <20200515143646.3857579-7-hch@lst.de> <20200527043426.3242439-1-natechancellor@gmail.com> In-Reply-To: <20200527043426.3242439-1-natechancellor@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Nathan Chancellor Cc: Christoph Hellwig , "linux-ia64@vger.kernel.org" , Linux-sh list , Roman Zippel , "open list:BROADCOM NVRAM DRIVER" , Linux MM , sparclinux , linux-riscv@lists.infradead.org, Linux-Arch , linux-c6x-dev@linux-c6x.org, "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , "open list:TENSILICA XTENSA PORT (xtensa)" , Arnd Bergmann , alpha , linux-um , linux-m68k , Openrisc Hi Nathan, CC Laurent On Wed, May 27, 2020 at 6:37 AM Nathan Chancellor wrote: > After mm.h was removed from the asm-generic version of cacheflush.h, > s390 allyesconfig shows several warnings of the following nature: > > In file included from ./arch/s390/include/generated/asm/cacheflush.h:1, > from drivers/media/platform/omap3isp/isp.c:42: > ./include/asm-generic/cacheflush.h:16:42: warning: 'struct mm_struct' > declared inside parameter list will not be visible outside of this > definition or declaration > > cacheflush.h does not include mm.h nor does it include any forward > declaration of these structures hence the warning. To avoid this, > include mm.h explicitly in this file and shuffle cacheflush.h below it. > > Fixes: 19c0054597a0 ("asm-generic: don't include in cacheflush.h") > Signed-off-by: Nathan Chancellor Thanks for your patch! > I am aware the fixes tag is kind of irrelevant because that SHA will > change in the next linux-next revision and this will probably get folded > into the original patch anyways but still. > > The other solution would be to add forward declarations of these structs > to the top of cacheflush.h, I just chose to do what Christoph did in the > original patch. I am happy to do that instead if you all feel that is > better. That actually looks like a better solution to me, as it would address the problem for all users. > drivers/media/platform/omap3isp/isp.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index a4ee6b86663e..54106a768e54 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -39,8 +39,6 @@ > * Troy Laramy > */ > > -#include > - > #include > #include > #include > @@ -49,6 +47,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -58,6 +57,8 @@ > #include > #include > > +#include > + > #ifdef CONFIG_ARM_DMA_USE_IOMMU > #include > #endif Why does this file need at all? It doesn't call any of the flush_*() functions, and seems to compile fine without (on arm32). Perhaps it was included at the top intentionally, to override the definitions of copy_{to,from}_user_page()? Fortunately that doesn't seem to be the case, from a quick look at the assembler output. So let's just remove the #include instead? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A58A0C433E2 for ; Wed, 27 May 2020 07:03:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F748207ED for ; Wed, 27 May 2020 07:03:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729001AbgE0HDF (ORCPT ); Wed, 27 May 2020 03:03:05 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:37083 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726025AbgE0HDE (ORCPT ); Wed, 27 May 2020 03:03:04 -0400 Received: by mail-oi1-f193.google.com with SMTP id m67so10517784oif.4; Wed, 27 May 2020 00:03:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UmrgkNrS7YJyoX//CVVX8i/eCGz9CaA9GDfJeRj6hok=; b=rVkoQMULJ+OZ9x5kHBlqLqq5f6KYD2w/b0J2IyVB3B8JqMpW7sk7jWcZvEC5z4I2s5 /U9W/KEo/Y0TtJyaeao2lGFjLsMlHwKhCVKd1qhJhCmI2CQIjKHlv8PVmI2lUKM3QZRr 2D1V50FJZ4yZ/OeBxvwn0ssUHavgw4LuXbyG6F6NOPolLGAjObfPDMUaHo2Mvo84seuA FsRFyThXciFbJZqkE7uUHt5mAGaemkWh4a679yUz7gAb7MGqkY0h+vTo19twyS+wAfqW Gtn6fZ3nk46IIj9BzuRvbNyEk2QkxkVtDnw7461N395/Y8Ae32oTLe7aCgRAsV7yfGPi 8N+g== X-Gm-Message-State: AOAM530Bd2DKOIivzsOKO6SM1T90eRAGz073UiEVlgCtGaeKwl3Entoj gTl066CUVLamfgoBh6FVIykXMF9GUG6MNNZcXQ8= X-Google-Smtp-Source: ABdhPJyJItgq7CbQXJlF6MFLLk/+bu/fSz/XUZ+gwTEqMYOT9P6OwO82+92+P3alNyNfXtW65E6GNWlSoFsc0hwoXsQ= X-Received: by 2002:a05:6808:1:: with SMTP id u1mr1778697oic.54.1590562983010; Wed, 27 May 2020 00:03:03 -0700 (PDT) MIME-Version: 1.0 References: <20200515143646.3857579-7-hch@lst.de> <20200527043426.3242439-1-natechancellor@gmail.com> In-Reply-To: <20200527043426.3242439-1-natechancellor@gmail.com> From: Geert Uytterhoeven Date: Wed, 27 May 2020 09:02:51 +0200 Message-ID: Subject: Re: [PATCH] media: omap3isp: Shuffle cacheflush.h and include mm.h To: Nathan Chancellor Cc: Christoph Hellwig , "linux-ia64@vger.kernel.org" , Linux-sh list , Roman Zippel , "open list:BROADCOM NVRAM DRIVER" , Linux MM , sparclinux , linux-riscv@lists.infradead.org, Linux-Arch , linux-c6x-dev@linux-c6x.org, "open list:QUALCOMM HEXAGON..." , "the arch/x86 maintainers" , "open list:TENSILICA XTENSA PORT (xtensa)" , Arnd Bergmann , alpha , linux-um , linux-m68k , Openrisc , Linux ARM , Michal Simek , Linux Kernel Mailing List , Jessica Yu , Linux FS Devel , Andrew Morton , linuxppc-dev , Laurent Pinchart Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nathan, CC Laurent On Wed, May 27, 2020 at 6:37 AM Nathan Chancellor wrote: > After mm.h was removed from the asm-generic version of cacheflush.h, > s390 allyesconfig shows several warnings of the following nature: > > In file included from ./arch/s390/include/generated/asm/cacheflush.h:1, > from drivers/media/platform/omap3isp/isp.c:42: > ./include/asm-generic/cacheflush.h:16:42: warning: 'struct mm_struct' > declared inside parameter list will not be visible outside of this > definition or declaration > > cacheflush.h does not include mm.h nor does it include any forward > declaration of these structures hence the warning. To avoid this, > include mm.h explicitly in this file and shuffle cacheflush.h below it. > > Fixes: 19c0054597a0 ("asm-generic: don't include in cacheflush.h") > Signed-off-by: Nathan Chancellor Thanks for your patch! > I am aware the fixes tag is kind of irrelevant because that SHA will > change in the next linux-next revision and this will probably get folded > into the original patch anyways but still. > > The other solution would be to add forward declarations of these structs > to the top of cacheflush.h, I just chose to do what Christoph did in the > original patch. I am happy to do that instead if you all feel that is > better. That actually looks like a better solution to me, as it would address the problem for all users. > drivers/media/platform/omap3isp/isp.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index a4ee6b86663e..54106a768e54 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -39,8 +39,6 @@ > * Troy Laramy > */ > > -#include > - > #include > #include > #include > @@ -49,6 +47,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -58,6 +57,8 @@ > #include > #include > > +#include > + > #ifdef CONFIG_ARM_DMA_USE_IOMMU > #include > #endif Why does this file need at all? It doesn't call any of the flush_*() functions, and seems to compile fine without (on arm32). Perhaps it was included at the top intentionally, to override the definitions of copy_{to,from}_user_page()? Fortunately that doesn't seem to be the case, from a quick look at the assembler output. So let's just remove the #include instead? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH] media: omap3isp: Shuffle cacheflush.h and include mm.h Date: Wed, 27 May 2020 09:02:51 +0200 Message-ID: References: <20200515143646.3857579-7-hch@lst.de> <20200527043426.3242439-1-natechancellor@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20200527043426.3242439-1-natechancellor@gmail.com> Sender: linux-alpha-owner@vger.kernel.org To: Nathan Chancellor Cc: Christoph Hellwig , "linux-ia64@vger.kernel.org" , Linux-sh list , Roman Zippel , "open list:BROADCOM NVRAM DRIVER" , Linux MM , sparclinux , linux-riscv@lists.infradead.org, Linux-Arch , linux-c6x-dev@linux-c6x.org, "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , "open list:TENSILICA XTENSA PORT (xtensa)" , Arnd Bergmann , alpha , linux-um , linux-m68k , Openrisc List-Id: linux-arch.vger.kernel.org Hi Nathan, CC Laurent On Wed, May 27, 2020 at 6:37 AM Nathan Chancellor wrote: > After mm.h was removed from the asm-generic version of cacheflush.h, > s390 allyesconfig shows several warnings of the following nature: > > In file included from ./arch/s390/include/generated/asm/cacheflush.h:1, > from drivers/media/platform/omap3isp/isp.c:42: > ./include/asm-generic/cacheflush.h:16:42: warning: 'struct mm_struct' > declared inside parameter list will not be visible outside of this > definition or declaration > > cacheflush.h does not include mm.h nor does it include any forward > declaration of these structures hence the warning. To avoid this, > include mm.h explicitly in this file and shuffle cacheflush.h below it. > > Fixes: 19c0054597a0 ("asm-generic: don't include in cacheflush.h") > Signed-off-by: Nathan Chancellor Thanks for your patch! > I am aware the fixes tag is kind of irrelevant because that SHA will > change in the next linux-next revision and this will probably get folded > into the original patch anyways but still. > > The other solution would be to add forward declarations of these structs > to the top of cacheflush.h, I just chose to do what Christoph did in the > original patch. I am happy to do that instead if you all feel that is > better. That actually looks like a better solution to me, as it would address the problem for all users. > drivers/media/platform/omap3isp/isp.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index a4ee6b86663e..54106a768e54 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -39,8 +39,6 @@ > * Troy Laramy > */ > > -#include > - > #include > #include > #include > @@ -49,6 +47,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -58,6 +57,8 @@ > #include > #include > > +#include > + > #ifdef CONFIG_ARM_DMA_USE_IOMMU > #include > #endif Why does this file need at all? It doesn't call any of the flush_*() functions, and seems to compile fine without (on arm32). Perhaps it was included at the top intentionally, to override the definitions of copy_{to,from}_user_page()? Fortunately that doesn't seem to be the case, from a quick look at the assembler output. So let's just remove the #include instead? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 References: <20200515143646.3857579-7-hch@lst.de> <20200527043426.3242439-1-natechancellor@gmail.com> In-Reply-To: <20200527043426.3242439-1-natechancellor@gmail.com> From: Geert Uytterhoeven Date: Wed, 27 May 2020 09:02:51 +0200 Message-ID: Subject: Re: [PATCH] media: omap3isp: Shuffle cacheflush.h and include mm.h Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org To: Nathan Chancellor Cc: Christoph Hellwig , "linux-ia64@vger.kernel.org" , Linux-sh list , Roman Zippel , "open list:BROADCOM NVRAM DRIVER" , Linux MM , sparclinux , linux-riscv@lists.infradead.org, Linux-Arch , linux-c6x-dev@linux-c6x.org, "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , "open list:TENSILICA XTENSA PORT (xtensa)" , Arnd Bergmann , alpha , linux-um , linux-m68k , Openrisc , Linux ARM , Michal Simek , Linux Kernel Mailing List , Jessica Yu , Linux FS Devel , Andrew Morton , linuxppc-dev , Laurent Pinchart List-ID: Message-ID: <20200527070251.Ob0V6SJo8WQromGieV2RuWKC4pysqds13y2H_wVsiuQ@z> Hi Nathan, CC Laurent On Wed, May 27, 2020 at 6:37 AM Nathan Chancellor wrote: > After mm.h was removed from the asm-generic version of cacheflush.h, > s390 allyesconfig shows several warnings of the following nature: > > In file included from ./arch/s390/include/generated/asm/cacheflush.h:1, > from drivers/media/platform/omap3isp/isp.c:42: > ./include/asm-generic/cacheflush.h:16:42: warning: 'struct mm_struct' > declared inside parameter list will not be visible outside of this > definition or declaration > > cacheflush.h does not include mm.h nor does it include any forward > declaration of these structures hence the warning. To avoid this, > include mm.h explicitly in this file and shuffle cacheflush.h below it. > > Fixes: 19c0054597a0 ("asm-generic: don't include in cacheflush.h") > Signed-off-by: Nathan Chancellor Thanks for your patch! > I am aware the fixes tag is kind of irrelevant because that SHA will > change in the next linux-next revision and this will probably get folded > into the original patch anyways but still. > > The other solution would be to add forward declarations of these structs > to the top of cacheflush.h, I just chose to do what Christoph did in the > original patch. I am happy to do that instead if you all feel that is > better. That actually looks like a better solution to me, as it would address the problem for all users. > drivers/media/platform/omap3isp/isp.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index a4ee6b86663e..54106a768e54 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -39,8 +39,6 @@ > * Troy Laramy > */ > > -#include > - > #include > #include > #include > @@ -49,6 +47,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -58,6 +57,8 @@ > #include > #include > > +#include > + > #ifdef CONFIG_ARM_DMA_USE_IOMMU > #include > #endif Why does this file need at all? It doesn't call any of the flush_*() functions, and seems to compile fine without (on arm32). Perhaps it was included at the top intentionally, to override the definitions of copy_{to,from}_user_page()? Fortunately that doesn't seem to be the case, from a quick look at the assembler output. So let's just remove the #include instead? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D584C433DF for ; Wed, 27 May 2020 07:03:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AE2A207CB for ; Wed, 27 May 2020 07:03:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Mdyk/KXr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AE2A207CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To: Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UmrgkNrS7YJyoX//CVVX8i/eCGz9CaA9GDfJeRj6hok=; b=Mdyk/KXrOY5V09+VUyL/313st VSrl2YrBv3NwFUrq2sf0T2SJKdmyNXEc+z2/dSAS+2yvw7Po7hw5ADDZJaWb3tCqPtUAtHIH3CmgY 7XTGhHV1c1wdUIl0EkLJlqrzb8qCE4eFrpI4bShNUtce08tcaUELQL1yHxCqZ9EXeSbAl+kfRB+CZ ZVlPwlwk20wpAbWwsnhRyqFFIe3c6ycxVdQZbV2y5bFlyyWGqxgYAd4hF5+3T8r+SsnUroByqkrh4 fhZeKnor/YZjTt6bs2vv8hzTIo31qRyh44xs6FH0cqkw8u1N5yVNVerCyTsoiNSb5PhRp1NLUr127 2PuwrGyjA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdq5j-00037J-2X; Wed, 27 May 2020 07:03:07 +0000 Received: from mail-oi1-f193.google.com ([209.85.167.193]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdq5g-00036o-88; Wed, 27 May 2020 07:03:05 +0000 Received: by mail-oi1-f193.google.com with SMTP id j145so20931957oib.5; Wed, 27 May 2020 00:03:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UmrgkNrS7YJyoX//CVVX8i/eCGz9CaA9GDfJeRj6hok=; b=YGQW+jtSlyfD12rn3ejmQBn4B4Qm2W/IixEOH9fkscSemUeCSazCA03iFXHgz77y2i xlm/rhznCGzo9SyRtAqAz/bBp8kRPgkcRfVBSPomdw1tEROmx4+9aQJ09Jml3hiOsY1A /5QxI7iMiM3RGAEi7DtjkBvkNBhasbOtWpmtWx4rvbpb3kAHK3cNEivNZKaZodZKPXiA ek4BiCdagtpg18aXajhq5ioPoEjR/rj68wcjK/HT2UAdsqcFi6DZyOWWF08CYYgbnfeF r4ouMAKBX0jVkNtyxmi/miivF1FP5uiEHzxjH9heiNgqkXWuGu+S7cDnSzaLVTA/4rXa yVHg== X-Gm-Message-State: AOAM530ZAEARIur0LjbexSg4WNby3YcuGrUWIABzYipu5aVeIa2A2e3B +q2K1n+cVgaOh1XVKRl/7UlVokXreuQwMzp+mbk= X-Google-Smtp-Source: ABdhPJyJItgq7CbQXJlF6MFLLk/+bu/fSz/XUZ+gwTEqMYOT9P6OwO82+92+P3alNyNfXtW65E6GNWlSoFsc0hwoXsQ= X-Received: by 2002:a05:6808:1:: with SMTP id u1mr1778697oic.54.1590562983010; Wed, 27 May 2020 00:03:03 -0700 (PDT) MIME-Version: 1.0 References: <20200515143646.3857579-7-hch@lst.de> <20200527043426.3242439-1-natechancellor@gmail.com> In-Reply-To: <20200527043426.3242439-1-natechancellor@gmail.com> From: Geert Uytterhoeven Date: Wed, 27 May 2020 09:02:51 +0200 Message-ID: Subject: Re: [PATCH] media: omap3isp: Shuffle cacheflush.h and include mm.h To: Nathan Chancellor Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200527_000304_288651_07AF27E7 X-CRM114-Status: GOOD ( 19.87 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-ia64@vger.kernel.org" , Linux-sh list , Roman Zippel , Linux Kernel Mailing List , Linux MM , Laurent Pinchart , sparclinux , linux-riscv@lists.infradead.org, Christoph Hellwig , Linux-Arch , linux-c6x-dev@linux-c6x.org, "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , "open list:TENSILICA XTENSA PORT \(xtensa\)" , Arnd Bergmann , alpha , linux-um , linux-m68k , Openrisc , Linux ARM , Michal Simek , "open list:BROADCOM NVRAM DRIVER" , Jessica Yu , Linux FS Devel , Andrew Morton , linuxppc-dev Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org Hi Nathan, CC Laurent On Wed, May 27, 2020 at 6:37 AM Nathan Chancellor wrote: > After mm.h was removed from the asm-generic version of cacheflush.h, > s390 allyesconfig shows several warnings of the following nature: > > In file included from ./arch/s390/include/generated/asm/cacheflush.h:1, > from drivers/media/platform/omap3isp/isp.c:42: > ./include/asm-generic/cacheflush.h:16:42: warning: 'struct mm_struct' > declared inside parameter list will not be visible outside of this > definition or declaration > > cacheflush.h does not include mm.h nor does it include any forward > declaration of these structures hence the warning. To avoid this, > include mm.h explicitly in this file and shuffle cacheflush.h below it. > > Fixes: 19c0054597a0 ("asm-generic: don't include in cacheflush.h") > Signed-off-by: Nathan Chancellor Thanks for your patch! > I am aware the fixes tag is kind of irrelevant because that SHA will > change in the next linux-next revision and this will probably get folded > into the original patch anyways but still. > > The other solution would be to add forward declarations of these structs > to the top of cacheflush.h, I just chose to do what Christoph did in the > original patch. I am happy to do that instead if you all feel that is > better. That actually looks like a better solution to me, as it would address the problem for all users. > drivers/media/platform/omap3isp/isp.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index a4ee6b86663e..54106a768e54 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -39,8 +39,6 @@ > * Troy Laramy > */ > > -#include > - > #include > #include > #include > @@ -49,6 +47,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -58,6 +57,8 @@ > #include > #include > > +#include > + > #ifdef CONFIG_ARM_DMA_USE_IOMMU > #include > #endif Why does this file need at all? It doesn't call any of the flush_*() functions, and seems to compile fine without (on arm32). Perhaps it was included at the top intentionally, to override the definitions of copy_{to,from}_user_page()? Fortunately that doesn't seem to be the case, from a quick look at the assembler output. So let's just remove the #include instead? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A80E3C433DF for ; Wed, 27 May 2020 07:03:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5994D207ED for ; Wed, 27 May 2020 07:03:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5994D207ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C5900800B8; Wed, 27 May 2020 03:03:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0A4B80010; Wed, 27 May 2020 03:03:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF7DF800B8; Wed, 27 May 2020 03:03:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0142.hostedemail.com [216.40.44.142]) by kanga.kvack.org (Postfix) with ESMTP id A3EA180010 for ; Wed, 27 May 2020 03:03:04 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6788D824556B for ; Wed, 27 May 2020 07:03:04 +0000 (UTC) X-FDA: 76861607088.11.grain52_230e25626d50 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 4C46B180F8B82 for ; Wed, 27 May 2020 07:03:04 +0000 (UTC) X-HE-Tag: grain52_230e25626d50 X-Filterd-Recvd-Size: 6341 Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 May 2020 07:03:03 +0000 (UTC) Received: by mail-oi1-f195.google.com with SMTP id b3so20851730oib.13 for ; Wed, 27 May 2020 00:03:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UmrgkNrS7YJyoX//CVVX8i/eCGz9CaA9GDfJeRj6hok=; b=ovKdRvTivx63lPekxZihX/z7xn8t74HV08Z5VXfw+6W4mm8X07vqFFgngkvsvb5P1Q O9Cx0rGH9qC/nlg3D+FuPdrBAV6BhNgQy7E2nuQLd94pkFeWDAv7sR1wuhWIjgBDMzZJ DaYW6GJbxjMO7J+A0zHoC9zqSRWAw6/1S3eGyVpbEnOVFU6YtJ2h7op6u73bkdDQzEK3 tv45fzSfnmtHsuQ9jTpcDI77wK9DIjPXgyFbjmur7IBuQ3pSp9UWjcWtcNm3ehDmMDSj ILoaL4KoXgcLP1Pc5pORBkqa2Sy1rNcgX8QoPBzjpwaSJLXtsT1CsNgnRMXowpIho35C PXaQ== X-Gm-Message-State: AOAM532g8YhzNHHnN/KPA/N+Z0TrZ1FVL51VjyCI4WD27XF24tNTbyKo NZf2laUKfuUEi6ni0fG/5743A6iZQM4v5ug36nk= X-Google-Smtp-Source: ABdhPJyJItgq7CbQXJlF6MFLLk/+bu/fSz/XUZ+gwTEqMYOT9P6OwO82+92+P3alNyNfXtW65E6GNWlSoFsc0hwoXsQ= X-Received: by 2002:a05:6808:1:: with SMTP id u1mr1778697oic.54.1590562983010; Wed, 27 May 2020 00:03:03 -0700 (PDT) MIME-Version: 1.0 References: <20200515143646.3857579-7-hch@lst.de> <20200527043426.3242439-1-natechancellor@gmail.com> In-Reply-To: <20200527043426.3242439-1-natechancellor@gmail.com> From: Geert Uytterhoeven Date: Wed, 27 May 2020 09:02:51 +0200 Message-ID: Subject: Re: [PATCH] media: omap3isp: Shuffle cacheflush.h and include mm.h To: Nathan Chancellor Cc: Christoph Hellwig , "linux-ia64@vger.kernel.org" , Linux-sh list , Roman Zippel , "open list:BROADCOM NVRAM DRIVER" , Linux MM , sparclinux , linux-riscv@lists.infradead.org, Linux-Arch , linux-c6x-dev@linux-c6x.org, "open list:QUALCOMM HEXAGON..." , "the arch/x86 maintainers" , "open list:TENSILICA XTENSA PORT (xtensa)" , Arnd Bergmann , alpha , linux-um , linux-m68k , Openrisc , Linux ARM , Michal Simek , Linux Kernel Mailing List , Jessica Yu , Linux FS Devel , Andrew Morton , linuxppc-dev , Laurent Pinchart Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4C46B180F8B82 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Nathan, CC Laurent On Wed, May 27, 2020 at 6:37 AM Nathan Chancellor wrote: > After mm.h was removed from the asm-generic version of cacheflush.h, > s390 allyesconfig shows several warnings of the following nature: > > In file included from ./arch/s390/include/generated/asm/cacheflush.h:1, > from drivers/media/platform/omap3isp/isp.c:42: > ./include/asm-generic/cacheflush.h:16:42: warning: 'struct mm_struct' > declared inside parameter list will not be visible outside of this > definition or declaration > > cacheflush.h does not include mm.h nor does it include any forward > declaration of these structures hence the warning. To avoid this, > include mm.h explicitly in this file and shuffle cacheflush.h below it. > > Fixes: 19c0054597a0 ("asm-generic: don't include in cacheflush.h") > Signed-off-by: Nathan Chancellor Thanks for your patch! > I am aware the fixes tag is kind of irrelevant because that SHA will > change in the next linux-next revision and this will probably get folded > into the original patch anyways but still. > > The other solution would be to add forward declarations of these structs > to the top of cacheflush.h, I just chose to do what Christoph did in the > original patch. I am happy to do that instead if you all feel that is > better. That actually looks like a better solution to me, as it would address the problem for all users. > drivers/media/platform/omap3isp/isp.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index a4ee6b86663e..54106a768e54 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -39,8 +39,6 @@ > * Troy Laramy > */ > > -#include > - > #include > #include > #include > @@ -49,6 +47,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -58,6 +57,8 @@ > #include > #include > > +#include > + > #ifdef CONFIG_ARM_DMA_USE_IOMMU > #include > #endif Why does this file need at all? It doesn't call any of the flush_*() functions, and seems to compile fine without (on arm32). Perhaps it was included at the top intentionally, to override the definitions of copy_{to,from}_user_page()? Fortunately that doesn't seem to be the case, from a quick look at the assembler output. So let's just remove the #include instead? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62A50C433E1 for ; Wed, 27 May 2020 07:03:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 341AF207ED for ; Wed, 27 May 2020 07:03:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="knM4HZMS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 341AF207ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pj0kiF9DOJTNqXrSbzlNkdrNmEDNqdLJ9qwnV/BgOMk=; b=knM4HZMSY1vTt9 TEzsLOA4szqbJGCv4l+auW5K/IxERoY298IUNhnhzX2QDfXzHcUY1iX2BGwpm35D5wuQn/zy0WM/W dF/wAjsgm28B+8gzgGAGvw3u40IgmURSexmc3j3lUm4/O2oWhMXfZmw90AZ1siDHh7LpRSzbsg7xz A5UkodbcN/3aHKP8Er7NoX+NcUZr3r/rbLUzRsIN0w2nYhvEBt1yaQfgGKCkxSxass01cV7oECGjb gqSSG5Jci+qBd91/wvldDQZWG4VS4G4X7LpptwWPBF9sR7uSpx8tr8yiWGMDADvdMGvLXaLlZ0ND+ Ub4BjRwkvhojLKPrHfkA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdq5k-00038b-MX; Wed, 27 May 2020 07:03:08 +0000 Received: from mail-oi1-f193.google.com ([209.85.167.193]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdq5g-00036o-88; Wed, 27 May 2020 07:03:05 +0000 Received: by mail-oi1-f193.google.com with SMTP id j145so20931957oib.5; Wed, 27 May 2020 00:03:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UmrgkNrS7YJyoX//CVVX8i/eCGz9CaA9GDfJeRj6hok=; b=YGQW+jtSlyfD12rn3ejmQBn4B4Qm2W/IixEOH9fkscSemUeCSazCA03iFXHgz77y2i xlm/rhznCGzo9SyRtAqAz/bBp8kRPgkcRfVBSPomdw1tEROmx4+9aQJ09Jml3hiOsY1A /5QxI7iMiM3RGAEi7DtjkBvkNBhasbOtWpmtWx4rvbpb3kAHK3cNEivNZKaZodZKPXiA ek4BiCdagtpg18aXajhq5ioPoEjR/rj68wcjK/HT2UAdsqcFi6DZyOWWF08CYYgbnfeF r4ouMAKBX0jVkNtyxmi/miivF1FP5uiEHzxjH9heiNgqkXWuGu+S7cDnSzaLVTA/4rXa yVHg== X-Gm-Message-State: AOAM530ZAEARIur0LjbexSg4WNby3YcuGrUWIABzYipu5aVeIa2A2e3B +q2K1n+cVgaOh1XVKRl/7UlVokXreuQwMzp+mbk= X-Google-Smtp-Source: ABdhPJyJItgq7CbQXJlF6MFLLk/+bu/fSz/XUZ+gwTEqMYOT9P6OwO82+92+P3alNyNfXtW65E6GNWlSoFsc0hwoXsQ= X-Received: by 2002:a05:6808:1:: with SMTP id u1mr1778697oic.54.1590562983010; Wed, 27 May 2020 00:03:03 -0700 (PDT) MIME-Version: 1.0 References: <20200515143646.3857579-7-hch@lst.de> <20200527043426.3242439-1-natechancellor@gmail.com> In-Reply-To: <20200527043426.3242439-1-natechancellor@gmail.com> From: Geert Uytterhoeven Date: Wed, 27 May 2020 09:02:51 +0200 Message-ID: Subject: Re: [PATCH] media: omap3isp: Shuffle cacheflush.h and include mm.h To: Nathan Chancellor X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200527_000304_288651_07AF27E7 X-CRM114-Status: GOOD ( 19.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-ia64@vger.kernel.org" , Linux-sh list , Roman Zippel , Linux Kernel Mailing List , Linux MM , Laurent Pinchart , sparclinux , linux-riscv@lists.infradead.org, Christoph Hellwig , Linux-Arch , linux-c6x-dev@linux-c6x.org, "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , "open list:TENSILICA XTENSA PORT \(xtensa\)" , Arnd Bergmann , alpha , linux-um , linux-m68k , Openrisc , Linux ARM , Michal Simek , "open list:BROADCOM NVRAM DRIVER" , Jessica Yu , Linux FS Devel , Andrew Morton , linuxppc-dev Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nathan, CC Laurent On Wed, May 27, 2020 at 6:37 AM Nathan Chancellor wrote: > After mm.h was removed from the asm-generic version of cacheflush.h, > s390 allyesconfig shows several warnings of the following nature: > > In file included from ./arch/s390/include/generated/asm/cacheflush.h:1, > from drivers/media/platform/omap3isp/isp.c:42: > ./include/asm-generic/cacheflush.h:16:42: warning: 'struct mm_struct' > declared inside parameter list will not be visible outside of this > definition or declaration > > cacheflush.h does not include mm.h nor does it include any forward > declaration of these structures hence the warning. To avoid this, > include mm.h explicitly in this file and shuffle cacheflush.h below it. > > Fixes: 19c0054597a0 ("asm-generic: don't include in cacheflush.h") > Signed-off-by: Nathan Chancellor Thanks for your patch! > I am aware the fixes tag is kind of irrelevant because that SHA will > change in the next linux-next revision and this will probably get folded > into the original patch anyways but still. > > The other solution would be to add forward declarations of these structs > to the top of cacheflush.h, I just chose to do what Christoph did in the > original patch. I am happy to do that instead if you all feel that is > better. That actually looks like a better solution to me, as it would address the problem for all users. > drivers/media/platform/omap3isp/isp.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index a4ee6b86663e..54106a768e54 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -39,8 +39,6 @@ > * Troy Laramy > */ > > -#include > - > #include > #include > #include > @@ -49,6 +47,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -58,6 +57,8 @@ > #include > #include > > +#include > + > #ifdef CONFIG_ARM_DMA_USE_IOMMU > #include > #endif Why does this file need at all? It doesn't call any of the flush_*() functions, and seems to compile fine without (on arm32). Perhaps it was included at the top intentionally, to override the definitions of copy_{to,from}_user_page()? Fortunately that doesn't seem to be the case, from a quick look at the assembler output. So let's just remove the #include instead? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Wed, 27 May 2020 09:02:51 +0200 Subject: [OpenRISC] [PATCH] media: omap3isp: Shuffle cacheflush.h and include mm.h In-Reply-To: <20200527043426.3242439-1-natechancellor@gmail.com> References: <20200515143646.3857579-7-hch@lst.de> <20200527043426.3242439-1-natechancellor@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: openrisc@lists.librecores.org Hi Nathan, CC Laurent On Wed, May 27, 2020 at 6:37 AM Nathan Chancellor wrote: > After mm.h was removed from the asm-generic version of cacheflush.h, > s390 allyesconfig shows several warnings of the following nature: > > In file included from ./arch/s390/include/generated/asm/cacheflush.h:1, > from drivers/media/platform/omap3isp/isp.c:42: > ./include/asm-generic/cacheflush.h:16:42: warning: 'struct mm_struct' > declared inside parameter list will not be visible outside of this > definition or declaration > > cacheflush.h does not include mm.h nor does it include any forward > declaration of these structures hence the warning. To avoid this, > include mm.h explicitly in this file and shuffle cacheflush.h below it. > > Fixes: 19c0054597a0 ("asm-generic: don't include in cacheflush.h") > Signed-off-by: Nathan Chancellor Thanks for your patch! > I am aware the fixes tag is kind of irrelevant because that SHA will > change in the next linux-next revision and this will probably get folded > into the original patch anyways but still. > > The other solution would be to add forward declarations of these structs > to the top of cacheflush.h, I just chose to do what Christoph did in the > original patch. I am happy to do that instead if you all feel that is > better. That actually looks like a better solution to me, as it would address the problem for all users. > drivers/media/platform/omap3isp/isp.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index a4ee6b86663e..54106a768e54 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -39,8 +39,6 @@ > * Troy Laramy > */ > > -#include > - > #include > #include > #include > @@ -49,6 +47,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -58,6 +57,8 @@ > #include > #include > > +#include > + > #ifdef CONFIG_ARM_DMA_USE_IOMMU > #include > #endif Why does this file need at all? It doesn't call any of the flush_*() functions, and seems to compile fine without (on arm32). Perhaps it was included at the top intentionally, to override the definitions of copy_{to,from}_user_page()? Fortunately that doesn't seem to be the case, from a quick look at the assembler output. So let's just remove the #include instead? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds