All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	x86@kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/2] Add CONFIG_READABLE_ASM
Date: Thu, 12 Apr 2012 21:08:36 +0200	[thread overview]
Message-ID: <CAMuHMdVX28zeebzN6277B5p2b=9s-Q06i01o5AHPyXAuKMigGQ@mail.gmail.com> (raw)
In-Reply-To: <1332960678-11879-2-git-send-email-andi@firstfloor.org>

Hi Andi,

On Wed, Mar 28, 2012 at 20:51, Andi Kleen <andi@firstfloor.org> wrote:
> +ifdef CONFIG_READABLE_ASM
> +# Disable optimizations that make assembler listings hard to read.
> +# reorder blocks reorders the control in the function
> +# ipa clone creates specialized cloned functions
> +# partial inlining inlines only parts of functions
> +KBUILD_CFLAGS += $(call cc-option,-fno-reorder-blocks,) \
> +                 $(call cc-option,-fno-ipa-cp-clone,) \
> +                 $(call cc-option,-fno-partial-inlining)
> +endif

This (now in linux-next) causes m68k/allmodconfig to fail for me:

  CHK     include/linux/version.h
  CHK     include/generated/utsrelease.h
  CC      kernel/bounds.s
cc1: error: unrecognized command line option "-fno-ipa-cp-clone"

Somehow, "$(call cc-option,-fno-ipa-cp-clone,)" doesn't detect that my
toolchain (gcc version 4.1.2 20061115 (prerelease) (Ubuntu 4.1.1-21))
doesn't support this option.

I tried playing with the trailing comma (why do the first 2 tests have it,
and the 3rd one doesn't?), but that didn't make a difference.

linux-next builds (using a newer toolchain) don't show this.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  parent reply	other threads:[~2012-04-12 19:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-28 18:51 [PATCH 1/2] x86: Use -mno-avx when available Andi Kleen
2012-03-28 18:51 ` [PATCH 2/2] Add CONFIG_READABLE_ASM Andi Kleen
2012-03-30 17:41   ` [tip:x86/cleanups] debug: " tip-bot for Andi Kleen
2012-04-12 19:08   ` Geert Uytterhoeven [this message]
2012-04-12 19:36     ` [PATCH 2/2] " H. Peter Anvin
2012-04-12 19:42       ` Geert Uytterhoeven
2012-04-12 19:40     ` Sam Ravnborg
2012-04-12 19:47       ` Geert Uytterhoeven
2012-04-12 19:52         ` Sam Ravnborg
2012-04-12 19:57         ` Andi Kleen
2012-04-12 20:07           ` Sam Ravnborg
2012-04-12 20:17             ` Geert Uytterhoeven
2012-04-12 20:35               ` Sam Ravnborg
2012-05-08 19:36                 ` Geert Uytterhoeven
2012-05-12 20:23                   ` Geert Uytterhoeven
2012-05-12 20:25                     ` Sam Ravnborg
2012-03-30 17:16 ` [tip:x86/urgent] x86: Use -mno-avx when available tip-bot for Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdVX28zeebzN6277B5p2b=9s-Q06i01o5AHPyXAuKMigGQ@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH 2/2] Add CONFIG_READABLE_ASM' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.