From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:33297 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752778AbdIGIjT (ORCPT ); Thu, 7 Sep 2017 04:39:19 -0400 MIME-Version: 1.0 In-Reply-To: <931484ec-8830-0e63-98cb-9dd58ce35230@de.bosch.com> References: <20170906070507.26223-1-dirk.behme@de.bosch.com> <20170906070507.26223-3-dirk.behme@de.bosch.com> <931484ec-8830-0e63-98cb-9dd58ce35230@de.bosch.com> From: Geert Uytterhoeven Date: Thu, 7 Sep 2017 10:39:18 +0200 Message-ID: Subject: Re: [PATCH 2/8] spi: sh-msiof: Fix DMA transfer size check To: Dirk Behme Cc: Linux-Renesas , linux-spi , Geert Uytterhoeven , Hiromitsu Yamasaki Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Dirk, On Thu, Sep 7, 2017 at 10:33 AM, Dirk Behme wrote: > On 07.09.2017 10:31, Geert Uytterhoeven wrote: >> On Wed, Sep 6, 2017 at 9:05 AM, Dirk Behme >> wrote: >>> From: Hiromitsu Yamasaki >>> >>> DMA supports 32-bit words only, >>> even if BITLEN1 of SITMDR2 register is 16bit. >>> >>> Signed-off-by: Hiromitsu Yamasaki >>> Signed-off-by: Dirk Behme >>> --- >>> drivers/spi/spi-sh-msiof.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c >>> index 2b4d3a520176..f9300fdf41e5 100644 >>> --- a/drivers/spi/spi-sh-msiof.c >>> +++ b/drivers/spi/spi-sh-msiof.c >>> @@ -904,7 +904,7 @@ static int sh_msiof_transfer_one(struct spi_master >>> *master, >>> break; >>> copy32 = copy_bswap32; >>> } else if (bits <= 16) { >>> - if (l & 1) >>> + if (l & 3) >>> break; >>> copy32 = copy_wswap32; >>> } else { >> >> >> Looks OK, as l is in bytes, not 16-bit words. >> >> Reviewed-by: Geert Uytterhoeven > > What do you think about CCing this to -stable? Sounds OK. Have you tested this? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 2/8] spi: sh-msiof: Fix DMA transfer size check Date: Thu, 7 Sep 2017 10:39:18 +0200 Message-ID: References: <20170906070507.26223-1-dirk.behme@de.bosch.com> <20170906070507.26223-3-dirk.behme@de.bosch.com> <931484ec-8830-0e63-98cb-9dd58ce35230@de.bosch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Linux-Renesas , linux-spi , Geert Uytterhoeven , Hiromitsu Yamasaki To: Dirk Behme Return-path: In-Reply-To: <931484ec-8830-0e63-98cb-9dd58ce35230-V5te9oGctAVWk0Htik3J/w@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Hi Dirk, On Thu, Sep 7, 2017 at 10:33 AM, Dirk Behme wrote: > On 07.09.2017 10:31, Geert Uytterhoeven wrote: >> On Wed, Sep 6, 2017 at 9:05 AM, Dirk Behme >> wrote: >>> From: Hiromitsu Yamasaki >>> >>> DMA supports 32-bit words only, >>> even if BITLEN1 of SITMDR2 register is 16bit. >>> >>> Signed-off-by: Hiromitsu Yamasaki >>> Signed-off-by: Dirk Behme >>> --- >>> drivers/spi/spi-sh-msiof.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c >>> index 2b4d3a520176..f9300fdf41e5 100644 >>> --- a/drivers/spi/spi-sh-msiof.c >>> +++ b/drivers/spi/spi-sh-msiof.c >>> @@ -904,7 +904,7 @@ static int sh_msiof_transfer_one(struct spi_master >>> *master, >>> break; >>> copy32 = copy_bswap32; >>> } else if (bits <= 16) { >>> - if (l & 1) >>> + if (l & 3) >>> break; >>> copy32 = copy_wswap32; >>> } else { >> >> >> Looks OK, as l is in bytes, not 16-bit words. >> >> Reviewed-by: Geert Uytterhoeven > > What do you think about CCing this to -stable? Sounds OK. Have you tested this? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html