From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 712CDC433E4 for ; Wed, 15 Jul 2020 08:43:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B7E720657 for ; Wed, 15 Jul 2020 08:43:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729585AbgGOIns (ORCPT ); Wed, 15 Jul 2020 04:43:48 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:39018 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729466AbgGOIns (ORCPT ); Wed, 15 Jul 2020 04:43:48 -0400 Received: by mail-oi1-f196.google.com with SMTP id w17so1629890oie.6; Wed, 15 Jul 2020 01:43:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wBSjJT0ORrybEKumemGZpkTJ/Tv11w9vz0K05d4A6Os=; b=CbIvxwbN3InWD5iqe3TXYMPN0UDxbl8A+hNhBd1LmaJF2YeZOQcYUKRqFJcY8e1dm1 PTgb8OtSFnufGOJ879bfwEDEmsihs/vr96qon30UoDcplUgfYnoWg8ZcdKvLZZCBfm04 a9jZRhyDA5V2P5DntpD3xL5ezyYuDl3iHgiKBNbpHwg2TVPp4tgGTwYjUnJEQ1ZPfKVm JaG9E+JFFTGY0pgbrafVs0hPcLvaUUdqwKusV+2Ue8+9zUC3oZhffc6Q2Vqtx6joVDTU ww3nwTXqJVWdluxkJJ/+wZ0sf/cXHO3FDJ7UE5dJKdZpNk1yiZTQsbOWBdyuYY75zr7u v0ow== X-Gm-Message-State: AOAM532mPUm0wiPNiWb9PTI4QnH6d//rAT8s4nY6SkvEIA6tmqjyYrLe Qrsoh9WwHdVOIwrgzz0waV/UBVDb/0laCC7upnA= X-Google-Smtp-Source: ABdhPJw86hPfeV6CTJ8KN+UQ+NcI3bICPWChvBe3FWmE48Q4aabU0FIIinMm3s5aHvZ94WJeCrwGRqzFJIK4nhKEjXM= X-Received: by 2002:a05:6808:64a:: with SMTP id z10mr6957983oih.54.1594802626935; Wed, 15 Jul 2020 01:43:46 -0700 (PDT) MIME-Version: 1.0 References: <1567584941-13690-1-git-send-email-biju.das@bp.renesas.com> <1567584941-13690-2-git-send-email-biju.das@bp.renesas.com> In-Reply-To: <1567584941-13690-2-git-send-email-biju.das@bp.renesas.com> From: Geert Uytterhoeven Date: Wed, 15 Jul 2020 10:43:36 +0200 Message-ID: Subject: Re: [PATCH RESEND v7 1/3] dt-bindings: usb: hd3ss3220 device tree binding document To: Biju Das Cc: Rob Herring , Mark Rutland , Yoshihiro Shimoda , Greg Kroah-Hartman , Heikki Krogerus , Felipe Balbi , USB list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Simon Horman , Geert Uytterhoeven , Chris Paterson , Fabrizio Castro , Linux-Renesas , "Lad, Prabhakar" Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Biju, On Wed, Sep 4, 2019 at 10:22 AM Biju Das wrote: > Add device tree binding document for TI HD3SS3220 Type-C DRP port > controller driver. > > Signed-off-by: Biju Das > Reviewed-by: Rob Herring > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/ti,hd3ss3220.txt > @@ -0,0 +1,38 @@ > +TI HD3SS3220 TypeC DRP Port Controller. > + > +Required properties: > + - compatible: Must be "ti,hd3ss3220". > + - reg: I2C slave address, must be 0x47 or 0x67 based on ADDR pin. > + - interrupts: An interrupt specifier. > + > +Required sub-node: > + - connector: The "usb-c-connector" attached to the hd3ss3220 chip. The > + bindings of the connector node are specified in: > + > + Documentation/devicetree/bindings/connector/usb-connector.txt > + > +Example: > +hd3ss3220@47 { > + compatible = "ti,hd3ss3220"; > + reg = <0x47>; > + interrupt-parent = <&gpio6>; > + interrupts = <3 IRQ_TYPE_LEVEL_LOW>; > + > + connector { > + compatible = "usb-c-connector"; > + label = "USB-C"; > + data-role = "dual"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@1 { This does not comply with Documentation/devicetree/bindings/connector/usb-connector.yaml: connector: ports: 'port@0' is a required property > + reg = <1>; > + hd3ss3220_ep: endpoint { > + remote-endpoint = <&usb3_role_switch>; > + }; > + }; > + }; > + }; > +}; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds