Re: [PATCH] pinctrl: rza1: Switch to using "output-enable"

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Jacopo,

On Mon, Aug 24, 2020 at 10:26 AM Jacopo Mondi <jacopo@jmondi.org> wrote:
> On Fri, Aug 21, 2020 at 01:14:01PM +0200, Geert Uytterhoeven wrote:
> > For pins requiring software driven IO output operations, the RZ/A1 Pin
> > Controller uses either the "output-high" or "output-low" DT property to
> > enable the corresponding output buffer.  The actual line value doesn't
> > matter, as it is ignored.
> >
> > Commit 425562429d4f3b13 ("pinctrl: generic: Add output-enable property")
> > introduced a new DT property for this specific use case.
> >
> > Update the RZ/A1 Pin Controller DT bindings and driver to use this new
> > property instead.  Preserve backwards compatibility with old DTBs in the
> > driver, as this comes at a very small cost.
> >
> > Notes:
> >   - The DT binding examples already used the new property,
> >   - There are no upstream users of the old properties.
> >
>
> Did we introduce output-enable after the rza1 pinctrl and forgot to
> update ? Good catch anyway

"output-enable" was introduced in response to early review comments
on the rza1 pinctrl driver, and both changes went upstream through
the same sh-pfc pull request.  Seems like part of the update was just
forgotten.

> Great! For both parts:
> Acked-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds