All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [RFC PATCH 4/4] arm64: dts: renesas: falcon-cpu: add SPI flash via RPC
Date: Thu, 23 Sep 2021 11:02:45 +0200	[thread overview]
Message-ID: <CAMuHMdVb9Jr=AVXdE-_N3_6SS6E8K-mFvQzSuXNhXDmEyhgqYw@mail.gmail.com> (raw)
In-Reply-To: <20210913065317.2297-5-wsa+renesas@sang-engineering.com>

On Mon, Sep 13, 2021 at 8:53 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> Comments: The BSP used 40 MHz as the spi-max-frequency. But it is the
> same SPI flash chip as on other R-Car Gen3 boards, so I took the max
> value from there, 50MHz. It worked so far.

There could be a trace spec violation causing possible corruption at 50 MHz.
I think it would be best to verify this with Renesas.

> Probably the boot partition could be described more precisely and split
> up into further partitions. Do we want that? So far, I kept what the BSP
> is using.

It depends: what do you see on the board you're testing on?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2021-09-23  9:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13  6:53 [RFC PATCH 0/4] r8a779a0: add RPC support Wolfram Sang
2021-09-13  6:53 ` [RFC PATCH 1/4] clk: renesas: cpg-lib: move RPC clock registration to the library Wolfram Sang
2021-09-23  8:26   ` Geert Uytterhoeven
2021-09-13  6:53 ` [RFC PATCH 2/4] clk: renesas: r8a779a0: Add RPC support Wolfram Sang
2021-09-23  8:37   ` Geert Uytterhoeven
2021-09-13  6:53 ` [RFC PATCH 3/4] arm64: dts: renesas: r8a779a0: Add RPC node Wolfram Sang
2021-09-23  8:56   ` Geert Uytterhoeven
2021-09-13  6:53 ` [RFC PATCH 4/4] arm64: dts: renesas: falcon-cpu: add SPI flash via RPC Wolfram Sang
2021-09-23  9:02   ` Geert Uytterhoeven [this message]
2021-09-28  9:26   ` Geert Uytterhoeven
2021-09-28  9:39     ` Wolfram Sang
2021-09-28  9:45       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdVb9Jr=AVXdE-_N3_6SS6E8K-mFvQzSuXNhXDmEyhgqYw@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.