[PATCH v2 0/5] r8a7796 I2C integration

[PATCH v2 0/5] r8a7796 I2C integration

[Ulrich Hecht]

Hi!

This revision is based on renesas-devel-20161024-v4.9-rc2.  It adds the
Reviewed-bys and the entries for SYS-DMAC2 in the applicable I2C nodes.  I
have also made sure it works with 64-bit memory enabled.

CU
Uli


Changes since v1:
- added sys-dmac2 entries to i2c0-2
- added Reviewed-bys
- dropped "i2c: rcar: add support for r8a7796 (R-Car M3-W)" (picked up)


Ulrich Hecht (5):
  clk: renesas: r8a7796: Add I2C clocks
  pinctrl: sh-pfc: r8a7796: add I2C pin support
  arm64: renesas: r8a7796: add I2C support
  arm64: renesas: r8a7796: Enable I2C DMA
  arm64: renesas: r8a7796: salvator-x: enable I2C

 arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts |  12 +++
 arch/arm64/boot/dts/renesas/r8a7796.dtsi           | 111 +++++++++++++++++++++
 drivers/clk/renesas/r8a7796-cpg-mssr.c             |   7 ++
 drivers/pinctrl/sh-pfc/pfc-r8a7796.c               |  77 ++++++++++++++
 4 files changed, 207 insertions(+)

-- 
2.7.4

[PATCH v2 1/5] clk: renesas: r8a7796: Add I2C clocks

[Ulrich Hecht]

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/clk/renesas/r8a7796-cpg-mssr.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c b/drivers/clk/renesas/r8a7796-cpg-mssr.c
index c02fe34..d851c42 100644
--- a/drivers/clk/renesas/r8a7796-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c
@@ -133,6 +133,13 @@ static const struct mssr_mod_clk r8a7796_mod_clks[] __initconst = {
 	DEF_MOD("gpio2",		 910,	R8A7796_CLK_S3D4),
 	DEF_MOD("gpio1",		 911,	R8A7796_CLK_S3D4),
 	DEF_MOD("gpio0",		 912,	R8A7796_CLK_S3D4),
+	DEF_MOD("i2c6",			 918,	R8A7796_CLK_S0D6),
+	DEF_MOD("i2c5",			 919,	R8A7796_CLK_S0D6),
+	DEF_MOD("i2c4",			 927,	R8A7796_CLK_S0D6),
+	DEF_MOD("i2c3",			 928,	R8A7796_CLK_S0D6),
+	DEF_MOD("i2c2",			 929,	R8A7796_CLK_S3D2),
+	DEF_MOD("i2c1",			 930,	R8A7796_CLK_S3D2),
+	DEF_MOD("i2c0",			 931,	R8A7796_CLK_S3D2),
 };
 
 static const unsigned int r8a7796_crit_mod_clks[] __initconst = {
-- 
2.7.4

[PATCH v2 2/5] pinctrl: sh-pfc: r8a7796: add I2C pin support

[Ulrich Hecht]

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/pinctrl/sh-pfc/pfc-r8a7796.c | 77 ++++++++++++++++++++++++++++++++++++
 1 file changed, 77 insertions(+)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
index dc9b671..42db745 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
@@ -1490,6 +1490,57 @@ static const struct sh_pfc_pin pinmux_pins[] = {
 	PINMUX_GPIO_GP_ALL(),
 };
 
+/* - I2C -------------------------------------------------------------------- */
+static const unsigned int i2c1_a_pins[] = {
+	/* SDA, SCL */
+	RCAR_GP_PIN(5, 11), RCAR_GP_PIN(5, 10),
+};
+static const unsigned int i2c1_a_mux[] = {
+	SDA1_A_MARK, SCL1_A_MARK,
+};
+static const unsigned int i2c1_b_pins[] = {
+	/* SDA, SCL */
+	RCAR_GP_PIN(5, 24), RCAR_GP_PIN(5, 23),
+};
+static const unsigned int i2c1_b_mux[] = {
+	SDA1_B_MARK, SCL1_B_MARK,
+};
+static const unsigned int i2c2_a_pins[] = {
+	/* SDA, SCL */
+	RCAR_GP_PIN(5, 0), RCAR_GP_PIN(5, 4),
+};
+static const unsigned int i2c2_a_mux[] = {
+	SDA2_A_MARK, SCL2_A_MARK,
+};
+static const unsigned int i2c2_b_pins[] = {
+	/* SDA, SCL */
+	RCAR_GP_PIN(3, 13), RCAR_GP_PIN(3, 12),
+};
+static const unsigned int i2c2_b_mux[] = {
+	SDA2_B_MARK, SCL2_B_MARK,
+};
+static const unsigned int i2c6_a_pins[] = {
+	/* SDA, SCL */
+	RCAR_GP_PIN(1, 8), RCAR_GP_PIN(1, 11),
+};
+static const unsigned int i2c6_a_mux[] = {
+	SDA6_A_MARK, SCL6_A_MARK,
+};
+static const unsigned int i2c6_b_pins[] = {
+	/* SDA, SCL */
+	RCAR_GP_PIN(1, 26), RCAR_GP_PIN(1, 25),
+};
+static const unsigned int i2c6_b_mux[] = {
+	SDA6_B_MARK, SCL6_B_MARK,
+};
+static const unsigned int i2c6_c_pins[] = {
+	/* SDA, SCL */
+	RCAR_GP_PIN(0, 15), RCAR_GP_PIN(0, 14),
+};
+static const unsigned int i2c6_c_mux[] = {
+	SDA6_C_MARK, SCL6_C_MARK,
+};
+
 /* - SCIF0 ------------------------------------------------------------------ */
 static const unsigned int scif0_data_pins[] = {
 	/* RX, TX */
@@ -1912,6 +1963,13 @@ static const unsigned int sdhi3_ds_mux[] = {
 };
 
 static const struct sh_pfc_pin_group pinmux_groups[] = {
+	SH_PFC_PIN_GROUP(i2c1_a),
+	SH_PFC_PIN_GROUP(i2c1_b),
+	SH_PFC_PIN_GROUP(i2c2_a),
+	SH_PFC_PIN_GROUP(i2c2_b),
+	SH_PFC_PIN_GROUP(i2c6_a),
+	SH_PFC_PIN_GROUP(i2c6_b),
+	SH_PFC_PIN_GROUP(i2c6_c),
 	SH_PFC_PIN_GROUP(scif0_data),
 	SH_PFC_PIN_GROUP(scif0_clk),
 	SH_PFC_PIN_GROUP(scif0_ctrl),
@@ -1969,6 +2027,22 @@ static const struct sh_pfc_pin_group pinmux_groups[] = {
 	SH_PFC_PIN_GROUP(sdhi3_ds),
 };
 
+static const char * const i2c1_groups[] = {
+	"i2c1_a",
+	"i2c1_b",
+};
+
+static const char * const i2c2_groups[] = {
+	"i2c2_a",
+	"i2c2_b",
+};
+
+static const char * const i2c6_groups[] = {
+	"i2c6_a",
+	"i2c6_b",
+	"i2c6_c",
+};
+
 static const char * const scif0_groups[] = {
 	"scif0_data",
 	"scif0_clk",
@@ -2058,6 +2132,9 @@ static const char * const sdhi3_groups[] = {
 };
 
 static const struct sh_pfc_function pinmux_functions[] = {
+	SH_PFC_FUNCTION(i2c1),
+	SH_PFC_FUNCTION(i2c2),
+	SH_PFC_FUNCTION(i2c6),
 	SH_PFC_FUNCTION(scif0),
 	SH_PFC_FUNCTION(scif1),
 	SH_PFC_FUNCTION(scif2),
-- 
2.7.4

[PATCH v2 3/5] arm64: renesas: r8a7796: add I2C support

[Ulrich Hecht]

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 94 ++++++++++++++++++++++++++++++++
 1 file changed, 94 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 18973a3..3e6661bb 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -17,6 +17,16 @@
 	#address-cells = <2>;
 	#size-cells = <2>;
 
+	aliases {
+		i2c0 = &i2c0;
+		i2c1 = &i2c1;
+		i2c2 = &i2c2;
+		i2c3 = &i2c3;
+		i2c4 = &i2c4;
+		i2c5 = &i2c5;
+		i2c6 = &i2c6;
+	};
+
 	psci {
 		compatible = "arm,psci-0.2";
 		method = "smc";
@@ -239,6 +249,90 @@
 			#power-domain-cells = <1>;
 		};
 
+		i2c0: i2c@e6500000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "renesas,i2c-r8a7796";
+			reg = <0 0xe6500000 0 0x40>;
+			interrupts = <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 931>;
+			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			i2c-scl-internal-delay-ns = <110>;
+			status = "disabled";
+		};
+
+		i2c1: i2c@e6508000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "renesas,i2c-r8a7796";
+			reg = <0 0xe6508000 0 0x40>;
+			interrupts = <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 930>;
+			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			i2c-scl-internal-delay-ns = <6>;
+			status = "disabled";
+		};
+
+		i2c2: i2c@e6510000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "renesas,i2c-r8a7796";
+			reg = <0 0xe6510000 0 0x40>;
+			interrupts = <GIC_SPI 286 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 929>;
+			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			i2c-scl-internal-delay-ns = <6>;
+			status = "disabled";
+		};
+
+		i2c3: i2c@e66d0000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "renesas,i2c-r8a7796";
+			reg = <0 0xe66d0000 0 0x40>;
+			interrupts = <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 928>;
+			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			i2c-scl-internal-delay-ns = <110>;
+			status = "disabled";
+		};
+
+		i2c4: i2c@e66d8000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "renesas,i2c-r8a7796";
+			reg = <0 0xe66d8000 0 0x40>;
+			interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 927>;
+			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			i2c-scl-internal-delay-ns = <110>;
+			status = "disabled";
+		};
+
+		i2c5: i2c@e66e0000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "renesas,i2c-r8a7796";
+			reg = <0 0xe66e0000 0 0x40>;
+			interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 919>;
+			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			i2c-scl-internal-delay-ns = <110>;
+			status = "disabled";
+		};
+
+		i2c6: i2c@e66e8000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "renesas,i2c-r8a7796";
+			reg = <0 0xe66e8000 0 0x40>;
+			interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 918>;
+			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			i2c-scl-internal-delay-ns = <6>;
+			status = "disabled";
+		};
+
 		scif2: serial@e6e88000 {
 			compatible = "renesas,scif-r8a7796",
 				     "renesas,rcar-gen3-scif", "renesas,scif";
-- 
2.7.4

[PATCH v2 4/5] arm64: renesas: r8a7796: Enable I2C DMA

[Ulrich Hecht]

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 3e6661bb..b72d5e9 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -257,6 +257,9 @@
 			interrupts = <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&cpg CPG_MOD 931>;
 			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			dmas = <&dmac1 0x91>, <&dmac1 0x90>,
+			       <&dmac2 0x91>, <&dmac2 0x90>;
+			dma-names = "tx", "rx", "tx", "rx";
 			i2c-scl-internal-delay-ns = <110>;
 			status = "disabled";
 		};
@@ -269,6 +272,9 @@
 			interrupts = <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&cpg CPG_MOD 930>;
 			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			dmas = <&dmac1 0x93>, <&dmac1 0x92>,
+			       <&dmac2 0x93>, <&dmac2 0x92>;
+			dma-names = "tx", "rx", "tx", "rx";
 			i2c-scl-internal-delay-ns = <6>;
 			status = "disabled";
 		};
@@ -281,6 +287,9 @@
 			interrupts = <GIC_SPI 286 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&cpg CPG_MOD 929>;
 			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			dmas = <&dmac1 0x95>, <&dmac1 0x94>,
+			       <&dmac2 0x95>, <&dmac2 0x94>;
+			dma-names = "tx", "rx", "tx", "rx";
 			i2c-scl-internal-delay-ns = <6>;
 			status = "disabled";
 		};
@@ -293,6 +302,8 @@
 			interrupts = <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&cpg CPG_MOD 928>;
 			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			dmas = <&dmac0 0x97>, <&dmac0 0x96>;
+			dma-names = "tx", "rx";
 			i2c-scl-internal-delay-ns = <110>;
 			status = "disabled";
 		};
@@ -305,6 +316,8 @@
 			interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&cpg CPG_MOD 927>;
 			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			dmas = <&dmac0 0x99>, <&dmac0 0x98>;
+			dma-names = "tx", "rx";
 			i2c-scl-internal-delay-ns = <110>;
 			status = "disabled";
 		};
@@ -317,6 +330,8 @@
 			interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&cpg CPG_MOD 919>;
 			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			dmas = <&dmac0 0x9b>, <&dmac0 0x9a>;
+			dma-names = "tx", "rx";
 			i2c-scl-internal-delay-ns = <110>;
 			status = "disabled";
 		};
@@ -329,6 +344,8 @@
 			interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&cpg CPG_MOD 918>;
 			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			dmas = <&dmac0 0x9d>, <&dmac0 0x9c>;
+			dma-names = "tx", "rx";
 			i2c-scl-internal-delay-ns = <6>;
 			status = "disabled";
 		};
-- 
2.7.4

[PATCH v2 5/5] arm64: renesas: r8a7796: salvator-x: enable I2C

[Ulrich Hecht]

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
index 8255c56..e48de7c 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
@@ -111,6 +111,11 @@
 		function = "scif_clk";
 	};
 
+	i2c2_pins: i2c2 {
+		groups = "i2c2_a";
+		function = "i2c2";
+	};
+
 	sdhi0_pins: sd0 {
 		groups = "sdhi0_data4", "sdhi0_ctrl";
 		function = "sdhi0";
@@ -209,6 +214,13 @@
 	status = "okay";
 };
 
+&i2c2 {
+	pinctrl-0 = <&i2c2_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
+
 &wdt0 {
 	timeout-sec = <60>;
 	status = "okay";
-- 
2.7.4

Re: [PATCH v2 4/5] arm64: renesas: r8a7796: Enable I2C DMA

[Geert Uytterhoeven]

On Wed, Oct 26, 2016 at 4:14 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 0/5] r8a7796 I2C integration

[Wolfram Sang]

Hi Uli,

> This revision is based on renesas-devel-20161024-v4.9-rc2.  It adds the
> Reviewed-bys and the entries for SYS-DMAC2 in the applicable I2C nodes.  I
> have also made sure it works with 64-bit memory enabled.

I am currently on the road, will check them on Monday.

Thanks!

   Wolfram

Re: [PATCH v2 0/5] r8a7796 I2C integration

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]


> This revision is based on renesas-devel-20161024-v4.9-rc2.  It adds the
> Reviewed-bys and the entries for SYS-DMAC2 in the applicable I2C nodes.  I
> have also made sure it works with 64-bit memory enabled.


I'd like to test, but: can you tell me which branches are needed to test
DMA? Or is there a complete branch available somewhere? Or could you
update the branch of this feature which is pulled in by renesas-drivers?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH v2 0/5] r8a7796 I2C integration

[Ulrich Hecht]

On Mon, Oct 31, 2016 at 12:46 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>
>> This revision is based on renesas-devel-20161024-v4.9-rc2.  It adds the
>> Reviewed-bys and the entries for SYS-DMAC2 in the applicable I2C nodes.  I
>> have also made sure it works with 64-bit memory enabled.
>
> I'd like to test, but: can you tell me which branches are needed to test
> DMA? Or is there a complete branch available somewhere? Or could you
> update the branch of this feature which is pulled in by renesas-drivers?

Thank you. Please check branch r8a7796-dmac-v2 at
https://github.com/uli/kernel.git, that should contain everything you
need.

CU
Uli

Re: [PATCH v2 0/5] r8a7796 I2C integration

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]


> This revision is based on renesas-devel-20161024-v4.9-rc2.  It adds the
> Reviewed-bys and the entries for SYS-DMAC2 in the applicable I2C nodes.  I
> have also made sure it works with 64-bit memory enabled.

Tested the whole series with I2C2 and I2C4 (manually activated) with DMA
and without. Dumping memory, changing some registers, scanning the bus -
all seems to work.

Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH v2 0/5] r8a7796 I2C integration

[Geert Uytterhoeven]

On Thu, Nov 3, 2016 at 5:06 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Thank you. Please check branch r8a7796-dmac-v2 at
> https://github.com/uli/kernel.git, that should contain everything you
> need.

FWIW, git://github.com/uli/kernel.git is much faster.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 0/5] r8a7796 I2C integration

[Simon Horman]

On Wed, Oct 26, 2016 at 04:14:04PM +0200, Ulrich Hecht wrote:
> Hi!
> 
> This revision is based on renesas-devel-20161024-v4.9-rc2.  It adds the
> Reviewed-bys and the entries for SYS-DMAC2 in the applicable I2C nodes.  I
> have also made sure it works with 64-bit memory enabled.
> 
> CU
> Uli
> 
> 
> Changes since v1:
> - added sys-dmac2 entries to i2c0-2
> - added Reviewed-bys
> - dropped "i2c: rcar: add support for r8a7796 (R-Car M3-W)" (picked up)
> 
> 
> Ulrich Hecht (5):
>   clk: renesas: r8a7796: Add I2C clocks
>   pinctrl: sh-pfc: r8a7796: add I2C pin support
>   arm64: renesas: r8a7796: add I2C support
>   arm64: renesas: r8a7796: Enable I2C DMA
>   arm64: renesas: r8a7796: salvator-x: enable I2C

Thanks Ulrich,

I have queued up the "arm64" patches for v4.10.

Re: [PATCH v2 5/5] arm64: renesas: r8a7796: salvator-x: enable I2C

[Geert Uytterhoeven]

On Wed, Oct 26, 2016 at 4:14 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> index 8255c56..e48de7c 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> @@ -111,6 +111,11 @@
>                 function = "scif_clk";
>         };
>
> +       i2c2_pins: i2c2 {
> +               groups = "i2c2_a";
> +               function = "i2c2";
> +       };
> +
>         sdhi0_pins: sd0 {
>                 groups = "sdhi0_data4", "sdhi0_ctrl";
>                 function = "sdhi0";

BTW, do we have a policy about (alphabetical) ordering?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 5/5] arm64: renesas: r8a7796: salvator-x: enable I2C

[Simon Horman]

On Mon, Nov 07, 2016 at 07:53:04PM +0100, Geert Uytterhoeven wrote:
> On Wed, Oct 26, 2016 at 4:14 PM, Ulrich Hecht
> <ulrich.hecht+renesas@gmail.com> wrote:
> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >  arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> > index 8255c56..e48de7c 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> > @@ -111,6 +111,11 @@
> >                 function = "scif_clk";
> >         };
> >
> > +       i2c2_pins: i2c2 {
> > +               groups = "i2c2_a";
> > +               function = "i2c2";
> > +       };
> > +
> >         sdhi0_pins: sd0 {
> >                 groups = "sdhi0_data4", "sdhi0_ctrl";
> >                 function = "sdhi0";
> 
> BTW, do we have a policy about (alphabetical) ordering?

FWIW I think we should aim to have notes sorted by a) base address and
b) alphabetically.

Re: [PATCH v2 5/5] arm64: renesas: r8a7796: salvator-x: enable I2C

[Geert Uytterhoeven]

Hi Simon,

On Tue, Nov 8, 2016 at 11:02 AM, Simon Horman <horms@verge.net.au> wrote:
> On Mon, Nov 07, 2016 at 07:53:04PM +0100, Geert Uytterhoeven wrote:
>> On Wed, Oct 26, 2016 at 4:14 PM, Ulrich Hecht
>> <ulrich.hecht+renesas@gmail.com> wrote:
>> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
>> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> > ---
>> >  arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 12 ++++++++++++
>> >  1 file changed, 12 insertions(+)
>> >
>> > diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
>> > index 8255c56..e48de7c 100644
>> > --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
>> > +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
>> > @@ -111,6 +111,11 @@
>> >                 function = "scif_clk";
>> >         };
>> >
>> > +       i2c2_pins: i2c2 {
>> > +               groups = "i2c2_a";
>> > +               function = "i2c2";
>> > +       };
>> > +
>> >         sdhi0_pins: sd0 {
>> >                 groups = "sdhi0_data4", "sdhi0_ctrl";
>> >                 function = "sdhi0";
>>
>> BTW, do we have a policy about (alphabetical) ordering?
>
> FWIW I think we should aim to have notes sorted by a) base address and
> b) alphabetically.

I think "nodes" comes first, before "notes" ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 5/5] arm64: renesas: r8a7796: salvator-x: enable I2C

[Simon Horman]

On Tue, Nov 08, 2016 at 11:07:58AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Tue, Nov 8, 2016 at 11:02 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Mon, Nov 07, 2016 at 07:53:04PM +0100, Geert Uytterhoeven wrote:
> >> On Wed, Oct 26, 2016 at 4:14 PM, Ulrich Hecht
> >> <ulrich.hecht+renesas@gmail.com> wrote:
> >> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> >> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >> > ---
> >> >  arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 12 ++++++++++++
> >> >  1 file changed, 12 insertions(+)
> >> >
> >> > diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> >> > index 8255c56..e48de7c 100644
> >> > --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> >> > +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> >> > @@ -111,6 +111,11 @@
> >> >                 function = "scif_clk";
> >> >         };
> >> >
> >> > +       i2c2_pins: i2c2 {
> >> > +               groups = "i2c2_a";
> >> > +               function = "i2c2";
> >> > +       };
> >> > +
> >> >         sdhi0_pins: sd0 {
> >> >                 groups = "sdhi0_data4", "sdhi0_ctrl";
> >> >                 function = "sdhi0";
> >>
> >> BTW, do we have a policy about (alphabetical) ordering?
> >
> > FWIW I think we should aim to have notes sorted by a) base address and
> > b) alphabetically.
> 
> I think "nodes" comes first, before "notes" ;-)

Yes, that's the spirit.

Re: [PATCH v2 0/5] r8a7796 I2C integration

[Geert Uytterhoeven]

Hi Uli,

On Thu, Nov 3, 2016 at 5:06 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> On Mon, Oct 31, 2016 at 12:46 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>>
>>> This revision is based on renesas-devel-20161024-v4.9-rc2.  It adds the
>>> Reviewed-bys and the entries for SYS-DMAC2 in the applicable I2C nodes.  I
>>> have also made sure it works with 64-bit memory enabled.
>>
>> I'd like to test, but: can you tell me which branches are needed to test
>> DMA? Or is there a complete branch available somewhere? Or could you
>> update the branch of this feature which is pulled in by renesas-drivers?
>
> Thank you. Please check branch r8a7796-dmac-v2 at
> https://github.com/uli/kernel.git, that should contain everything you
> need.

Dropped from renesas-drivers, as this branch is based on a very old tree
(v4.9-rc2), and many (not all!) commits have found their way upstream.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds