From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH v2 3/3 pci/next] PCI: rcar: Add gen3 fallback compatibility string for pcie-rcar Date: Sat, 3 Dec 2016 12:19:39 +0100 Message-ID: References: <1480675020-26346-1-git-send-email-horms+renesas@verge.net.au> <1480675020-26346-4-git-send-email-horms+renesas@verge.net.au> <20161202215016.GA21497@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20161202215016.GA21497-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Simon Horman Cc: Bjorn Helgaas , Phil Edworthy , Magnus Damm , linux-pci , Linux-Renesas , Rob Herring , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Fri, Dec 2, 2016 at 10:50 PM, Simon Horman wrote: > On Fri, Dec 02, 2016 at 11:37:00AM +0100, Simon Horman wrote: >> --- a/drivers/pci/host/pcie-rcar.c >> +++ b/drivers/pci/host/pcie-rcar.c >> @@ -1078,6 +1078,8 @@ static const struct of_device_id rcar_pcie_of_match[] = { >> { .compatible = "renesas,pcie-rcar-gen2", >> .data = rcar_pcie_hw_init_gen2 }, >> { .compatible = "renesas,pcie-r8a7795", .data = rcar_pcie_hw_init }, >> + { .compatible = "renesas,pcie-rcar-gen3", >> + .data = rcar_pcie_hw_init_hw_init }, > > It looks like I failed to compile-test this. > > s/rcar_pcie_hw_init_hw_init/rcar_pcie_hw_init/ Bummer, and my tired eyes didn't notice... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f195.google.com ([209.85.223.195]:36721 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbcLCLUT (ORCPT ); Sat, 3 Dec 2016 06:20:19 -0500 MIME-Version: 1.0 In-Reply-To: <20161202215016.GA21497@verge.net.au> References: <1480675020-26346-1-git-send-email-horms+renesas@verge.net.au> <1480675020-26346-4-git-send-email-horms+renesas@verge.net.au> <20161202215016.GA21497@verge.net.au> From: Geert Uytterhoeven Date: Sat, 3 Dec 2016 12:19:39 +0100 Message-ID: Subject: Re: [PATCH v2 3/3 pci/next] PCI: rcar: Add gen3 fallback compatibility string for pcie-rcar To: Simon Horman Cc: Bjorn Helgaas , Phil Edworthy , Magnus Damm , linux-pci , Linux-Renesas , Rob Herring , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Fri, Dec 2, 2016 at 10:50 PM, Simon Horman wrote: > On Fri, Dec 02, 2016 at 11:37:00AM +0100, Simon Horman wrote: >> --- a/drivers/pci/host/pcie-rcar.c >> +++ b/drivers/pci/host/pcie-rcar.c >> @@ -1078,6 +1078,8 @@ static const struct of_device_id rcar_pcie_of_match[] = { >> { .compatible = "renesas,pcie-rcar-gen2", >> .data = rcar_pcie_hw_init_gen2 }, >> { .compatible = "renesas,pcie-r8a7795", .data = rcar_pcie_hw_init }, >> + { .compatible = "renesas,pcie-rcar-gen3", >> + .data = rcar_pcie_hw_init_hw_init }, > > It looks like I failed to compile-test this. > > s/rcar_pcie_hw_init_hw_init/rcar_pcie_hw_init/ Bummer, and my tired eyes didn't notice... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds