From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A2E3C432BE for ; Mon, 9 Aug 2021 12:57:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 297B461002 for ; Mon, 9 Aug 2021 12:57:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233855AbhHIM6G (ORCPT ); Mon, 9 Aug 2021 08:58:06 -0400 Received: from mail-vk1-f179.google.com ([209.85.221.179]:34401 "EHLO mail-vk1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233342AbhHIM6F (ORCPT ); Mon, 9 Aug 2021 08:58:05 -0400 Received: by mail-vk1-f179.google.com with SMTP id x11so3908034vke.1; Mon, 09 Aug 2021 05:57:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8YyANyuZR7fYPTEivb2A77rPthj74HCMJFLYlpLjhb4=; b=JHl0Wpqlw4+rEhyCZiZudmmLXovJ/7qPMEnQkSaj8VsXg9iw+C2fE/OkqbZ5Gn7NSj 3pybdxret/bV1eP8imGReJ6cU1IAWwPdrw9wTuJHD+wGwd5aKb6VGkw+uwY2IWHxNuEb NPzGjrQubxTwtoS57ffsILhp6zo7tdTZQwoabU3+IKrWAY9+F0SM8lBPiCpPK6TcigJA pjW43kReh1p+cEUM7UZ0Qsk1kMl9SE8axGdZNsY3YREdQD40Z+/5X4/RSZokNwv83bhf IxUyjRoM+lq3fFyfAIvqrsIpo+1yWxQpKz2DfVqR4mVc+R+vh2jIdawCNgQpsIIERDv0 5qrA== X-Gm-Message-State: AOAM5302/2M5VnsZ2Ab2F/nmk0JQLqMfuCdW9WkPee/9dmHeKZw7wbrO RrSVeaiGUesKcaRg2c5L64dwBgp9qscSq74DbsY= X-Google-Smtp-Source: ABdhPJy3oD8kwL2fKgjd1+x6oD9DrDy3lnCulPeZeuWofPVdmbjqf9lmI9L+WnkYPGr3ewE9j3BxXIRigNiej0QJHFk= X-Received: by 2002:a1f:fc03:: with SMTP id a3mr13722921vki.1.1628513864509; Mon, 09 Aug 2021 05:57:44 -0700 (PDT) MIME-Version: 1.0 References: <20210806102930.3024-1-biju.das.jz@bp.renesas.com> <20210806102930.3024-3-biju.das.jz@bp.renesas.com> In-Reply-To: <20210806102930.3024-3-biju.das.jz@bp.renesas.com> From: Geert Uytterhoeven Date: Mon, 9 Aug 2021 14:57:33 +0200 Message-ID: Subject: Re: [PATCH v4 2/3] ASoC: dt-bindings: sound: renesas,rz-ssi: Update slave dma channel configuration parameters To: Biju Das Cc: Rob Herring , Liam Girdwood , Mark Brown , Vinod Koul , Chris Brandt , Kuninori Morimoto , ALSA Development Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Geert Uytterhoeven , Chris Paterson , Biju Das , Prabhakar Mahadev Lad , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Biju, On Fri, Aug 6, 2021 at 12:29 PM Biju Das wrote: > The DMAC driver on RZ/G2L expects the slave channel configuration > to be passed in dmas property. > This patch updates the example node to include the encoded slave > channel configuration. > > Fixes: 5df6dfbb6de815ba3a("ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support") > Signed-off-by: Biju Das > Reviewed-by: Lad Prabhakar > v3->v4: > * Updated bindings as the DMAC driver on RZ/G2L expects the > slave channel configuration to be passed in dmas property. Thanks for the update! > --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > @@ -93,8 +93,8 @@ examples: > clock-names = "ssi", "ssi_sfr", "audio_clk1", "audio_clk2"; > power-domains = <&cpg>; > resets = <&cpg R9A07G044_SSI0_RST_M2_REG>; > - dmas = <&dmac 0x255>, > - <&dmac 0x256>; > + dmas = <&dmac 0x2655>, > + <&dmac 0x2656>; > dma-names = "tx", "rx"; > #sound-dai-cells = <0>; > }; I think it would be good to describe the expected format in the description for the dmas property, so the DTS writer knows what the numerical values in the example really mean. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B9A9C4338F for ; Mon, 9 Aug 2021 12:58:51 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 417D560FF2 for ; Mon, 9 Aug 2021 12:58:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 417D560FF2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 075F41654; Mon, 9 Aug 2021 14:57:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 075F41654 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1628513927; bh=ueBx1XiTTSoX2V8nAwCAcCjOSy+RD7PTqFtRmtso9rM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=C27JLMCq6BEyFDJosxR8HJlRh/34o9KfTjAnVvEdmFClvyeChWRu8crHMQQQ0vTVV FmHFuMR9+Yp512SB9WOqlSqd9Xjj7b9r0kVQRK5Zn+v0Rz4lBR6kteJhL8IIho02XR 1k6ZsPfW8Xdde3LNmOmrXUyzYxtabkYYqJ3t/WGA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3F079F80105; Mon, 9 Aug 2021 14:57:56 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 378B1F802D2; Mon, 9 Aug 2021 14:57:54 +0200 (CEST) Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com [209.85.221.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1ABF2F800FD for ; Mon, 9 Aug 2021 14:57:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1ABF2F800FD Received: by mail-vk1-f179.google.com with SMTP id q3so3892407vkd.2 for ; Mon, 09 Aug 2021 05:57:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8YyANyuZR7fYPTEivb2A77rPthj74HCMJFLYlpLjhb4=; b=O1XAJnFTSVmdK38IvLrP3TX61Od+t2gh5weesoyY4jfXyF/6lza0Gasfy/gDS5EL6n GJYYtHQgDicYYS5k6oU5sl/oZ05688XyhF3dmeg0j/X2w/BwZ4ThLSWUFB5jJrVc3HJ3 BoEt97pAJTR8hkyIog7NvNGThupN+TrrXoAuP5Wl7i8gmzr59ijbSHW72ZTvnhgKItVW SR0bb/i3mu23kJRp068cZ0OCf6FhZBslXeEdt3wmEOgzAwQ76olAag0ApTSrBv2lCNOc d+UV1ZvlVFZRLCLwsIkM8fRvZJa+5Ta9CZPsuY5jRngYGK1Oa5qNfEZOuNd7PF1YnMuU A/Qw== X-Gm-Message-State: AOAM533qtIisJTKVKxxmHNdSOy0QWreWcmXW+7DvZHgjv4VasaaLafVJ ctlhjviDTfl9JG+3g5gt9tKo/+b1Ld2MHcYNmTs= X-Google-Smtp-Source: ABdhPJy3oD8kwL2fKgjd1+x6oD9DrDy3lnCulPeZeuWofPVdmbjqf9lmI9L+WnkYPGr3ewE9j3BxXIRigNiej0QJHFk= X-Received: by 2002:a1f:fc03:: with SMTP id a3mr13722921vki.1.1628513864509; Mon, 09 Aug 2021 05:57:44 -0700 (PDT) MIME-Version: 1.0 References: <20210806102930.3024-1-biju.das.jz@bp.renesas.com> <20210806102930.3024-3-biju.das.jz@bp.renesas.com> In-Reply-To: <20210806102930.3024-3-biju.das.jz@bp.renesas.com> From: Geert Uytterhoeven Date: Mon, 9 Aug 2021 14:57:33 +0200 Message-ID: Subject: Re: [PATCH v4 2/3] ASoC: dt-bindings: sound: renesas,rz-ssi: Update slave dma channel configuration parameters To: Biju Das Content-Type: text/plain; charset="UTF-8" Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , ALSA Development Mailing List , Geert Uytterhoeven , Kuninori Morimoto , Prabhakar Mahadev Lad , Liam Girdwood , Rob Herring , Biju Das , Linux-Renesas , Vinod Koul , Mark Brown , Chris Paterson , Chris Brandt X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Biju, On Fri, Aug 6, 2021 at 12:29 PM Biju Das wrote: > The DMAC driver on RZ/G2L expects the slave channel configuration > to be passed in dmas property. > This patch updates the example node to include the encoded slave > channel configuration. > > Fixes: 5df6dfbb6de815ba3a("ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support") > Signed-off-by: Biju Das > Reviewed-by: Lad Prabhakar > v3->v4: > * Updated bindings as the DMAC driver on RZ/G2L expects the > slave channel configuration to be passed in dmas property. Thanks for the update! > --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > @@ -93,8 +93,8 @@ examples: > clock-names = "ssi", "ssi_sfr", "audio_clk1", "audio_clk2"; > power-domains = <&cpg>; > resets = <&cpg R9A07G044_SSI0_RST_M2_REG>; > - dmas = <&dmac 0x255>, > - <&dmac 0x256>; > + dmas = <&dmac 0x2655>, > + <&dmac 0x2656>; > dma-names = "tx", "rx"; > #sound-dai-cells = <0>; > }; I think it would be good to describe the expected format in the description for the dmas property, so the DTS writer knows what the numerical values in the example really mean. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds