From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5173FC61DA7 for ; Fri, 27 Jan 2023 10:30:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231522AbjA0KaB (ORCPT ); Fri, 27 Jan 2023 05:30:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231564AbjA0K3u (ORCPT ); Fri, 27 Jan 2023 05:29:50 -0500 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2D5C13503; Fri, 27 Jan 2023 02:29:47 -0800 (PST) Received: by mail-oi1-f182.google.com with SMTP id i9so3856357oif.4; Fri, 27 Jan 2023 02:29:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PKruyQW1tJheLO2piiCDKl7s1j50V272W4MEFdOhqCA=; b=00+WBZEp5E7eC76VI9EsDKRtz4ugATiY6ovgMMg5+8PzQAlrpPfvIdodehUMGd0n86 qtdHuIn6Hf9dWrjaQ6ZXLe3g2cBht7i0u4e6MnjVp+XmHtqNlbiaeFhg9m/DZURgXkeJ 5zRTt4mI7f3XZGXeXo9/u97SvmTw6OhV3sYHc4ds7vtxk9S7DZYkdiloDTZNHRRNN0dr opf8/Kd/An02cPK3pPj5ctk9gz47BfZ8sNfNRf7FaqcuvTBI/IG7ZRGFcQtVilWyf4yG hOhmcLcAvIneUWFdTCV02nxnhIKcTXyjnuCRQOKkUcxaJgDoI2mgfvTAXoqIUy9GQxVx bulw== X-Gm-Message-State: AO0yUKWwdXt3Yvo6SNRiUw3mgR9xlU24cMNk8GWoIVDNxPyOsmCtQ8IG rZKRGhSSFZqcpwLknwe8DMGj5Nw3r69cLA== X-Google-Smtp-Source: AK7set+qty1T48p73vD/2rNItlz11TA6XIf8lynjnYUo1pcyPxbsdPj1v3HWUIOWXFa6e7SRbVsIfA== X-Received: by 2002:a05:6808:d1:b0:35e:7595:30df with SMTP id t17-20020a05680800d100b0035e759530dfmr2415966oic.9.1674815387051; Fri, 27 Jan 2023 02:29:47 -0800 (PST) Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com. [209.85.210.47]) by smtp.gmail.com with ESMTPSA id f66-20020aca3845000000b0036acbbf9fbasm1399943oia.46.2023.01.27.02.29.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jan 2023 02:29:46 -0800 (PST) Received: by mail-ot1-f47.google.com with SMTP id g21-20020a9d6495000000b0068bb336141dso98981otl.11; Fri, 27 Jan 2023 02:29:46 -0800 (PST) X-Received: by 2002:a0d:f281:0:b0:508:2f2c:8e5f with SMTP id b123-20020a0df281000000b005082f2c8e5fmr772773ywf.384.1674815376246; Fri, 27 Jan 2023 02:29:36 -0800 (PST) MIME-Version: 1.0 References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-9-saravanak@google.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 27 Jan 2023 11:29:24 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 08/11] driver core: fw_devlink: Make cycle detection more robust To: Andy Shevchenko Cc: Saravana Kannan , Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi Andy, On Fri, Jan 27, 2023 at 11:10 AM Andy Shevchenko wrote: > On Fri, Jan 27, 2023 at 10:52:02AM +0100, Geert Uytterhoeven wrote: > > On Fri, Jan 27, 2023 at 10:43 AM Andy Shevchenko > > wrote: > > > On Thu, Jan 26, 2023 at 04:11:35PM -0800, Saravana Kannan wrote: > > > > + * Check if @sup_handle or any of its ancestors or suppliers direct/indirectly > > > > + * depend on @con. This function can detect multiple cyles between @sup_handle > > > > > > A single space is enough. > > > > It's very common to write two spaces after a full stop. See e.g.: git grep "\. [^ ] > > When joining two sentences on separate lines in vim using SHIFT-J, > > vim will make sure there are two spaces. > > But is this consistent with all kernel doc comments in the core.c? Probably there are inconsistencies... (Aren't there everywhere?) > I'm fine with either as long as it's consistent. At least the kerneldoc source will look similar to the PDF output (LaTeX inserts more space after a full stop automatically ;-). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5752C38142 for ; Fri, 27 Jan 2023 10:30:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PzBCD+/zg2GYz1tJfNz9DWloTtaf1fM0619h4n3iuK8=; b=pEWI8mh5aTYZ7v 75tDWehw4bA7Q6rLCDdhi7EJBd+Fdz9Q3sxMFmwbGqi7MZJPMOapj11ycywRJTH+Cck8GA5YZIwtz e8tCwkqJ7qLiecQDOsZpXb1ZhZtjmz0u9tsiMOWPGrmcKLzq7mgJ/mTptdVOToH1IDOOnz89ja85M zy7jWSVY9NUqbTuNKL3+aY2Kmw6o+gkB22rgNFKbOWPvpkzQ456kIR2Egmr1ys6FI8UaZmHKYkhQD BsszytVrdq6Er5ZGMYSBesUL7T+9+XuWHwsUapyrDtsZgNYodlH9jsX4M2fMgEEkrcFyVP+LB7BqA ZXe0dx36NdpQ6qznmJMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLLzV-00DwjM-N4; Fri, 27 Jan 2023 10:29:53 +0000 Received: from mail-ot1-f48.google.com ([209.85.210.48]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLLzR-00Dwiw-Ki for linux-arm-kernel@lists.infradead.org; Fri, 27 Jan 2023 10:29:51 +0000 Received: by mail-ot1-f48.google.com with SMTP id a1-20020a056830008100b006864df3b1f8so1972473oto.3 for ; Fri, 27 Jan 2023 02:29:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PKruyQW1tJheLO2piiCDKl7s1j50V272W4MEFdOhqCA=; b=aJrzqONB+3QKFKCoo7lGY3d9rF/fz7HwoVGj10qGAxuqZ5rPOOm+KX2dp/b/O0iNP0 kQFvyw4BqWx2IL+V7wCZJ+7Q/cY2JjTfZWDBIWSkZyHjIFcUKKR0IXOPPAKU+JjB/+UY 2Tm4ycDZbKm8eD87MuUuq7tmJPXW0zZb2CWVPWX+pkM99rfxM/obEIH7QI2EpIP1oSKu oOKlsoVDshFNyivCfinJkgaboey50YArQvtBAki+8gPz8+MkOm99alMWZuIwp3J77E5R 6NFmH6VSkL9cMSI7fn9DWulAny94smM6F87MPl3gZ2UMaQN8DtqyHXWeN70InbMrjww3 L9CA== X-Gm-Message-State: AO0yUKU8I6KkvIiHy8noTGcczBNq3hm+OhWBGh7Rgy+xluuWkG3iKu3d jIHL87LIclDRNX/0DrxZ8sWQL653XQTYhg== X-Google-Smtp-Source: AK7set/CtyfvGSGqFoqjkT+biA6WRB9CT7i8LR1xld1mjLaD02nQHo/9rVhYfPGqBxQewG95/w+n/A== X-Received: by 2002:a9d:7615:0:b0:684:dbfd:f239 with SMTP id k21-20020a9d7615000000b00684dbfdf239mr2160781otl.9.1674815387675; Fri, 27 Jan 2023 02:29:47 -0800 (PST) Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com. [209.85.210.50]) by smtp.gmail.com with ESMTPSA id n13-20020a4ad40d000000b00511e01623bbsm1563995oos.7.2023.01.27.02.29.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jan 2023 02:29:47 -0800 (PST) Received: by mail-ot1-f50.google.com with SMTP id n24-20020a0568301e9800b006865671a9d5so1963922otr.6 for ; Fri, 27 Jan 2023 02:29:47 -0800 (PST) X-Received: by 2002:a0d:f281:0:b0:508:2f2c:8e5f with SMTP id b123-20020a0df281000000b005082f2c8e5fmr772773ywf.384.1674815376246; Fri, 27 Jan 2023 02:29:36 -0800 (PST) MIME-Version: 1.0 References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-9-saravanak@google.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 27 Jan 2023 11:29:24 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 08/11] driver core: fw_devlink: Make cycle detection more robust To: Andy Shevchenko Cc: Saravana Kannan , Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230127_022949_704683_A6C60B1F X-CRM114-Status: GOOD ( 27.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy, On Fri, Jan 27, 2023 at 11:10 AM Andy Shevchenko wrote: > On Fri, Jan 27, 2023 at 10:52:02AM +0100, Geert Uytterhoeven wrote: > > On Fri, Jan 27, 2023 at 10:43 AM Andy Shevchenko > > wrote: > > > On Thu, Jan 26, 2023 at 04:11:35PM -0800, Saravana Kannan wrote: > > > > + * Check if @sup_handle or any of its ancestors or suppliers direct/indirectly > > > > + * depend on @con. This function can detect multiple cyles between @sup_handle > > > > > > A single space is enough. > > > > It's very common to write two spaces after a full stop. See e.g.: git grep "\. [^ ] > > When joining two sentences on separate lines in vim using SHIFT-J, > > vim will make sure there are two spaces. > > But is this consistent with all kernel doc comments in the core.c? Probably there are inconsistencies... (Aren't there everywhere?) > I'm fine with either as long as it's consistent. At least the kerneldoc source will look similar to the PDF output (LaTeX inserts more space after a full stop automatically ;-). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel