Re: b4: introducing b4 shazam (like b4 am -o- | git am)

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Rob,

On Wed, Sep 29, 2021 at 3:39 PM Rob Herring <robh@kernel.org> wrote:
> On Tue, Sep 28, 2021 at 1:23 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Fri, Sep 24, 2021 at 11:08 PM Konstantin Ryabitsev
> > <konstantin@linuxfoundation.org> wrote:
> > > On Thu, Sep 23, 2021 at 10:51:21AM +0200, Geert Uytterhoeven wrote:
> > > > Note that with -s, the Link: tag appears below my Sob, while
> > > > b4 am + git am -s adds my Sob below the Link: tag.
> > >
> > > Unfortunately, I can't control this beyond reversing this for everyone. The
> > > only other alternative is setting up b4.shazam.am-flags variable for what to
> > > pass to "git am" -- which may be a good idea anyway.
> >
> > The current behavior of b4 shazam does obfuscate the patch trail.
>
> Is there a defined right order for Link and committer's Sob? Either we
> have to define what that is for b4 to implement or b4 has to be
> configurable. If the committer != author, then Link followed by Sob
> makes sense. But what about committing your own patches? If you

Yes.

> strictly follow the patch trail, you'd end up with your Sob twice:
> Sob, Link, Sob. In these cases, I've been putting Link last and a
> single Sob.

Same here.  I do not add a duplicate SoB in that case, and the Link
tag will be last.

BTW, I also do not add my own Acked-by and Reviewed-by tags
to patches it commit myself.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds