From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B185C54E4A for ; Tue, 12 May 2020 15:12:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2B3F20674 for ; Tue, 12 May 2020 15:12:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730429AbgELPMG convert rfc822-to-8bit (ORCPT ); Tue, 12 May 2020 11:12:06 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:34124 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725888AbgELPMF (ORCPT ); Tue, 12 May 2020 11:12:05 -0400 Received: by mail-oi1-f194.google.com with SMTP id c12so17511131oic.1; Tue, 12 May 2020 08:12:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=HzlyqNlSRCN2hpflyNPf3oc5CNOSPNV0Q0m7tMpCbzI=; b=fJcbu0BQuzEcnOtdzNiBYbyA4sWDft1nEIwiaXzlbnSJ4VGxRIi6UjcCr02OXTPSTa IwhPsUCkF7ZBd9/lP1vUYadDjo1RvcGz7lvrh0i57UjzLSLJppNCa0mH2kMv8pP5w+6s ZHkg/w45zAYGLfTWu2pg+cxgNq0Q4L5e66WhF+ClnGRqnRwWT78RjUBxWC5j1pa4e/CT jpl+5R8/c9MjghWeqTmMbYvWeIf9UHQADnMiPXWSPCcZPuh5wsjqpgHtPce5/uPU/Nru 1guwi3z5kVMhZZwcULjzCppIBk9ldIcIdoggm6OyKJDEE3yfn/wsxzN2HWQnCO4oUW6f gvbw== X-Gm-Message-State: AGi0PuZeHGSVnYQiamPJGuND8jVkICTAtNAEud1vT5W89TeQkFV4mzs1 KaS4rmzdP4H1cVFa7BVOrIKvUFm8spH2CstmxEA= X-Google-Smtp-Source: APiQypI8wlhO/mByPRRQWUkC2gMabCbPzFePjOCfbVR2cRo00ZIARfxutyIyWa6LKjtHIoxcreDrSMCgGeitz8vBDRI= X-Received: by 2002:aca:895:: with SMTP id 143mr22811576oii.153.1589296324268; Tue, 12 May 2020 08:12:04 -0700 (PDT) MIME-Version: 1.0 References: <20200511224430.HDJjRC68z%akpm@linux-foundation.org> <3b612c3e-ce52-ba92-eb02-0fa7fd38819f@infradead.org> In-Reply-To: <3b612c3e-ce52-ba92-eb02-0fa7fd38819f@infradead.org> From: Geert Uytterhoeven Date: Tue, 12 May 2020 17:11:53 +0200 Message-ID: Subject: Re: mmotm 2020-05-11-15-43 uploaded (mm/memcontrol.c, huge pages) To: Randy Dunlap Cc: Andrew Morton , Mark Brown , Linux FS Devel , Linux Kernel Mailing List , Linux MM , Linux-Next , Michal Hocko , mm-commits@vger.kernel.org, Stephen Rothwell , Johannes Weiner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 12, 2020 at 6:44 AM Randy Dunlap wrote: > On 5/11/20 3:44 PM, Andrew Morton wrote: > > The mm-of-the-moment snapshot 2020-05-11-15-43 has been uploaded to > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for mm-of-the-moment: > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > > This is a snapshot of my -mm patch queue. Uploaded at random hopefully > > more than once a week. > > > > You will need quilt to apply these patches to the latest Linus release (5.x > > or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in > > http://ozlabs.org/~akpm/mmotm/series > > > > The file broken-out.tar.gz contains two datestamp files: .DATE and > > .DATE-yyyy-mm-dd-hh-mm-ss. Both contain the string yyyy-mm-dd-hh-mm-ss, > > followed by the base kernel version against which this patch series is to > > be applied. > > > > This tree is partially included in linux-next. To see which patches are > > included in linux-next, consult the `series' file. Only the patches > > within the #NEXT_PATCHES_START/#NEXT_PATCHES_END markers are included in > > linux-next. > > > > > > A full copy of the full kernel tree with the linux-next and mmotm patches > > already applied is available through git within an hour of the mmotm > > release. Individual mmotm releases are tagged. The master branch always > > points to the latest release, so it's constantly rebasing. > > > > https://github.com/hnaz/linux-mm > > > > The directory http://www.ozlabs.org/~akpm/mmots/ (mm-of-the-second) > > contains daily snapshots of the -mm tree. It is updated more frequently > > than mmotm, and is untested. > > > > A git copy of this tree is also available at > > > > https://github.com/hnaz/linux-mm > > on x86_64: > > In file included from ../arch/x86/include/asm/atomic.h:5:0, > from ../include/linux/atomic.h:7, > from ../include/linux/page_counter.h:5, > from ../mm/memcontrol.c:25: > ../mm/memcontrol.c: In function ‘memcg_stat_show’: > ../include/linux/compiler.h:394:38: error: call to ‘__compiletime_assert_383’ declared with attribute error: BUILD_BUG failed > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > ^ > ../include/linux/compiler.h:375:4: note: in definition of macro ‘__compiletime_assert’ > prefix ## suffix(); \ > ^~~~~~ > ../include/linux/compiler.h:394:2: note: in expansion of macro ‘_compiletime_assert’ > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > ^~~~~~~~~~~~~~~~~~~ > ../include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’ > #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) > ^~~~~~~~~~~~~~~~~~ > ../include/linux/build_bug.h:59:21: note: in expansion of macro ‘BUILD_BUG_ON_MSG’ > #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed") > ^~~~~~~~~~~~~~~~ > ../include/linux/huge_mm.h:319:28: note: in expansion of macro ‘BUILD_BUG’ > #define HPAGE_PMD_SHIFT ({ BUILD_BUG(); 0; }) > ^~~~~~~~~ > ../include/linux/huge_mm.h:115:26: note: in expansion of macro ‘HPAGE_PMD_SHIFT’ > #define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) > ^~~~~~~~~~~~~~~ > ../include/linux/huge_mm.h:116:26: note: in expansion of macro ‘HPAGE_PMD_ORDER’ > #define HPAGE_PMD_NR (1< ^~~~~~~~~~~~~~~ > ../mm/memcontrol.c:3746:10: note: in expansion of macro ‘HPAGE_PMD_NR’ > nr *= HPAGE_PMD_NR; > ^~~~~~~~~~~~ > CC arch/x86/kernel/jump_label.o > ../mm/memcontrol.c: In function ‘memory_stat_format’: > ../include/linux/compiler.h:394:38: error: call to ‘__compiletime_assert_356’ declared with attribute error: BUILD_BUG failed > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > ^ > ../include/linux/compiler.h:375:4: note: in definition of macro ‘__compiletime_assert’ > prefix ## suffix(); \ > ^~~~~~ > ../include/linux/compiler.h:394:2: note: in expansion of macro ‘_compiletime_assert’ > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > ^~~~~~~~~~~~~~~~~~~ > ../include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’ > #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) > ^~~~~~~~~~~~~~~~~~ > ../include/linux/build_bug.h:59:21: note: in expansion of macro ‘BUILD_BUG_ON_MSG’ > #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed") > ^~~~~~~~~~~~~~~~ > ../include/linux/huge_mm.h:319:28: note: in expansion of macro ‘BUILD_BUG’ > #define HPAGE_PMD_SHIFT ({ BUILD_BUG(); 0; }) > ^~~~~~~~~ > ../include/linux/huge_mm.h:115:26: note: in expansion of macro ‘HPAGE_PMD_SHIFT’ > #define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) > ^~~~~~~~~~~~~~~ > ../include/linux/huge_mm.h:116:26: note: in expansion of macro ‘HPAGE_PMD_ORDER’ > #define HPAGE_PMD_NR (1< ^~~~~~~~~~~~~~~ > ../mm/memcontrol.c:1405:10: note: in expansion of macro ‘HPAGE_PMD_NR’ > HPAGE_PMD_NR * PAGE_SIZE); > ^~~~~~~~~~~~ > > > > Full randconfig file is attached. > > This might be relevant to mm-memcontrol-switch-to-native-nr_anon_thps-counter.patch noreply@ellerman.id.au pointed me to a similar failure for m68k/allmodconfig: http://kisskb.ellerman.id.au/kisskb/buildresult/14236262/ I've bisected it to 157f1f1385447604 ("mm: memcontrol: switch to native NR_ANON_THPS counter"). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 427E5C54E8E for ; Tue, 12 May 2020 15:12:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0485C206D6 for ; Tue, 12 May 2020 15:12:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0485C206D6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 81BAD9000C5; Tue, 12 May 2020 11:12:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CD1F900036; Tue, 12 May 2020 11:12:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BA8E9000C5; Tue, 12 May 2020 11:12:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id 5444F900036 for ; Tue, 12 May 2020 11:12:06 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9B10B181AEF1E for ; Tue, 12 May 2020 15:12:05 +0000 (UTC) X-FDA: 76808407410.26.guide44_2f530088b4e0d X-HE-Tag: guide44_2f530088b4e0d X-Filterd-Recvd-Size: 9074 Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 May 2020 15:12:05 +0000 (UTC) Received: by mail-oi1-f196.google.com with SMTP id o24so18519830oic.0 for ; Tue, 12 May 2020 08:12:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=HzlyqNlSRCN2hpflyNPf3oc5CNOSPNV0Q0m7tMpCbzI=; b=g/A8wTzJvP/KF5RzaLKtLi/sHsstDd5qn4AHQ403RfFecrpwtBtzP29JZwN8dTnMrm QZc5XsR7pL955umvxslKKvFQXRw2QJsz67eQfj+C2VyPolcwAsCghq74da8D27BQFUFP uxMvtsy8Ecite+RAGenfVbO3IoQBdpcNmCkttZCCff1plRtrSYp2AfFAOpNE8NF4b2SM ArreRlPyFzNoG2yrs8PEvZKjMspDBzb7bIBXrrvZCqKEbJ7VFl5GKgf9ngYF1kgzgFQs q8rD0C7SUNfiWCWnR1fiOqY8w5RDXzc9nge1q370LWHoV7EqnHS6VPpaq0aTx2g+AnUn HNbA== X-Gm-Message-State: AGi0Pua+Qv3yC83u7spZs/h5e5FEhfqJmVIYmRykN97jibER/2BXxcTj tVttwkTsHfj71Gg6oBbPSMG+tuji18ipLk4cg4c= X-Google-Smtp-Source: APiQypI8wlhO/mByPRRQWUkC2gMabCbPzFePjOCfbVR2cRo00ZIARfxutyIyWa6LKjtHIoxcreDrSMCgGeitz8vBDRI= X-Received: by 2002:aca:895:: with SMTP id 143mr22811576oii.153.1589296324268; Tue, 12 May 2020 08:12:04 -0700 (PDT) MIME-Version: 1.0 References: <20200511224430.HDJjRC68z%akpm@linux-foundation.org> <3b612c3e-ce52-ba92-eb02-0fa7fd38819f@infradead.org> In-Reply-To: <3b612c3e-ce52-ba92-eb02-0fa7fd38819f@infradead.org> From: Geert Uytterhoeven Date: Tue, 12 May 2020 17:11:53 +0200 Message-ID: Subject: Re: mmotm 2020-05-11-15-43 uploaded (mm/memcontrol.c, huge pages) To: Randy Dunlap Cc: Andrew Morton , Mark Brown , Linux FS Devel , Linux Kernel Mailing List , Linux MM , Linux-Next , Michal Hocko , mm-commits@vger.kernel.org, Stephen Rothwell , Johannes Weiner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 12, 2020 at 6:44 AM Randy Dunlap wrote: > On 5/11/20 3:44 PM, Andrew Morton wrote: > > The mm-of-the-moment snapshot 2020-05-11-15-43 has been uploaded to > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for mm-of-the-moment: > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > > This is a snapshot of my -mm patch queue. Uploaded at random hopefully > > more than once a week. > > > > You will need quilt to apply these patches to the latest Linus release = (5.x > > or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated= in > > http://ozlabs.org/~akpm/mmotm/series > > > > The file broken-out.tar.gz contains two datestamp files: .DATE and > > .DATE-yyyy-mm-dd-hh-mm-ss. Both contain the string yyyy-mm-dd-hh-mm-ss= , > > followed by the base kernel version against which this patch series is = to > > be applied. > > > > This tree is partially included in linux-next. To see which patches ar= e > > included in linux-next, consult the `series' file. Only the patches > > within the #NEXT_PATCHES_START/#NEXT_PATCHES_END markers are included i= n > > linux-next. > > > > > > A full copy of the full kernel tree with the linux-next and mmotm patch= es > > already applied is available through git within an hour of the mmotm > > release. Individual mmotm releases are tagged. The master branch alwa= ys > > points to the latest release, so it's constantly rebasing. > > > > https://github.com/hnaz/linux-mm > > > > The directory http://www.ozlabs.org/~akpm/mmots/ (mm-of-the-second) > > contains daily snapshots of the -mm tree. It is updated more frequentl= y > > than mmotm, and is untested. > > > > A git copy of this tree is also available at > > > > https://github.com/hnaz/linux-mm > > on x86_64: > > In file included from ../arch/x86/include/asm/atomic.h:5:0, > from ../include/linux/atomic.h:7, > from ../include/linux/page_counter.h:5, > from ../mm/memcontrol.c:25: > ../mm/memcontrol.c: In function =E2=80=98memcg_stat_show=E2=80=99: > ../include/linux/compiler.h:394:38: error: call to =E2=80=98__compiletime= _assert_383=E2=80=99 declared with attribute error: BUILD_BUG failed > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > ^ > ../include/linux/compiler.h:375:4: note: in definition of macro =E2=80=98= __compiletime_assert=E2=80=99 > prefix ## suffix(); \ > ^~~~~~ > ../include/linux/compiler.h:394:2: note: in expansion of macro =E2=80=98_= compiletime_assert=E2=80=99 > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > ^~~~~~~~~~~~~~~~~~~ > ../include/linux/build_bug.h:39:37: note: in expansion of macro =E2=80=98= compiletime_assert=E2=80=99 > #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) > ^~~~~~~~~~~~~~~~~~ > ../include/linux/build_bug.h:59:21: note: in expansion of macro =E2=80=98= BUILD_BUG_ON_MSG=E2=80=99 > #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed") > ^~~~~~~~~~~~~~~~ > ../include/linux/huge_mm.h:319:28: note: in expansion of macro =E2=80=98B= UILD_BUG=E2=80=99 > #define HPAGE_PMD_SHIFT ({ BUILD_BUG(); 0; }) > ^~~~~~~~~ > ../include/linux/huge_mm.h:115:26: note: in expansion of macro =E2=80=98H= PAGE_PMD_SHIFT=E2=80=99 > #define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) > ^~~~~~~~~~~~~~~ > ../include/linux/huge_mm.h:116:26: note: in expansion of macro =E2=80=98H= PAGE_PMD_ORDER=E2=80=99 > #define HPAGE_PMD_NR (1< ^~~~~~~~~~~~~~~ > ../mm/memcontrol.c:3746:10: note: in expansion of macro =E2=80=98HPAGE_PM= D_NR=E2=80=99 > nr *=3D HPAGE_PMD_NR; > ^~~~~~~~~~~~ > CC arch/x86/kernel/jump_label.o > ../mm/memcontrol.c: In function =E2=80=98memory_stat_format=E2=80=99: > ../include/linux/compiler.h:394:38: error: call to =E2=80=98__compiletime= _assert_356=E2=80=99 declared with attribute error: BUILD_BUG failed > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > ^ > ../include/linux/compiler.h:375:4: note: in definition of macro =E2=80=98= __compiletime_assert=E2=80=99 > prefix ## suffix(); \ > ^~~~~~ > ../include/linux/compiler.h:394:2: note: in expansion of macro =E2=80=98_= compiletime_assert=E2=80=99 > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > ^~~~~~~~~~~~~~~~~~~ > ../include/linux/build_bug.h:39:37: note: in expansion of macro =E2=80=98= compiletime_assert=E2=80=99 > #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) > ^~~~~~~~~~~~~~~~~~ > ../include/linux/build_bug.h:59:21: note: in expansion of macro =E2=80=98= BUILD_BUG_ON_MSG=E2=80=99 > #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed") > ^~~~~~~~~~~~~~~~ > ../include/linux/huge_mm.h:319:28: note: in expansion of macro =E2=80=98B= UILD_BUG=E2=80=99 > #define HPAGE_PMD_SHIFT ({ BUILD_BUG(); 0; }) > ^~~~~~~~~ > ../include/linux/huge_mm.h:115:26: note: in expansion of macro =E2=80=98H= PAGE_PMD_SHIFT=E2=80=99 > #define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) > ^~~~~~~~~~~~~~~ > ../include/linux/huge_mm.h:116:26: note: in expansion of macro =E2=80=98H= PAGE_PMD_ORDER=E2=80=99 > #define HPAGE_PMD_NR (1< ^~~~~~~~~~~~~~~ > ../mm/memcontrol.c:1405:10: note: in expansion of macro =E2=80=98HPAGE_PM= D_NR=E2=80=99 > HPAGE_PMD_NR * PAGE_SIZE); > ^~~~~~~~~~~~ > > > > Full randconfig file is attached. > > This might be relevant to mm-memcontrol-switch-to-native-nr_anon_thps-cou= nter.patch noreply@ellerman.id.au pointed me to a similar failure for m68k/allmodconfi= g: http://kisskb.ellerman.id.au/kisskb/buildresult/14236262/ I've bisected it to 157f1f1385447604 ("mm: memcontrol: switch to native NR_ANON_THPS counter"). Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds