All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: renesas: add full-pwr-cycle-in-suspend into eMMC nodes
Date: Fri, 17 Jul 2020 09:12:48 +0200	[thread overview]
Message-ID: <CAMuHMdVzO=wwTyYhHj2Cg3g_rRQCHQ_97DVH8zXAkg_ki5ZHhw@mail.gmail.com> (raw)
In-Reply-To: <TY2PR01MB3692CD5627D9848ADDA88BF0D87C0@TY2PR01MB3692.jpnprd01.prod.outlook.com>

Hi Shimoda-san,

On Fri, Jul 17, 2020 at 7:44 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> > From: Geert Uytterhoeven, Sent: Wednesday, July 15, 2020 6:05 PM
> > On Fri, Jul 10, 2020 at 2:03 PM Yoshihiro Shimoda
> > <yoshihiro.shimoda.uh@renesas.com> wrote:
> > > Add full-pwr-cycle-in-suspend property to do a graceful shutdown of
> > > the eMMC device in system suspend.
> > >
> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >
> > Thanks for your patch!
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > i.e. will queue in renesas-devel for v5.9.
>
> Thanks!
>
> > >  arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts   | 1 +
> > >  arch/arm64/boot/dts/renesas/salvator-common.dtsi | 1 +
> >
> > I assume we need this on other boards, too?
> > At least ULCB uses the BD9571 PMIC, and has a similar PSCI s2ram
> > implementation as Salvator-X(S) and Ebisu.
>
> I think so. And, I also thin ULCB+KF should not have this because
> it doesn't support Suspend-to-RAM. But, what do you think?

How come ULCB+KF doesn't support s2ram?
Isn't KingFisher just an extension board for ULCB?
Does it require a firmware upgrade?

> JFYI, I could such environment if I added the property into ulcb.dtsi
> and added "/delete-property/" into ulcb-kf.dtsi.

Iff that's the case, that's a valid solution.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2020-07-17  7:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-10 12:03 [PATCH] arm64: dts: renesas: add full-pwr-cycle-in-suspend into eMMC nodes Yoshihiro Shimoda
2020-07-15  9:04 ` Geert Uytterhoeven
2020-07-17  5:44   ` Yoshihiro Shimoda
2020-07-17  7:12     ` Geert Uytterhoeven [this message]
2020-07-17  8:29       ` Yoshihiro Shimoda
2020-07-17  8:35         ` Geert Uytterhoeven
2020-07-17 10:01           ` Yoshihiro Shimoda
2020-07-17 10:07             ` Geert Uytterhoeven
2020-07-17 12:33               ` Yoshihiro Shimoda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdVzO=wwTyYhHj2Cg3g_rRQCHQ_97DVH8zXAkg_ki5ZHhw@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.