From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 1/2] pinctrl: sh-pfc: r8a7790: initialize TDSEL register
Date: Thu, 8 Nov 2018 20:44:23 +0100 [thread overview]
Message-ID: <CAMuHMdVzOet6RXn+iU1Ru0EP3nOK6tbVmZLs=kpjxodz1cfZCQ@mail.gmail.com> (raw)
In-Reply-To: <20181028212457.1017-2-wsa+renesas@sang-engineering.com>
On Sun, Oct 28, 2018 at 10:25 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Documentation says that some bits in TDSEL must be set (ch 5.3.39 in R-Car H2
> v0.91). However, the reset value of the register is 0, so software has to do
> it. Add this to the kernel driver to ensure this is really done independent of
> firmware versions.
>
> This is needed for some SD cards supporting SDR104 transfer mode. For
> me, TDSEL was not initialized by the firmware and I had problems with
> the card when re-inserting it.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2018-11-09 5:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-28 21:24 [PATCH 0/2] pinctrl: sh-pfc: gen2: initialize TDSEL register Wolfram Sang
2018-10-28 21:24 ` [PATCH 1/2] pinctrl: sh-pfc: r8a7790: " Wolfram Sang
2018-10-30 13:55 ` Simon Horman
2018-10-31 1:19 ` Marek Vasut
2018-11-08 19:44 ` Geert Uytterhoeven [this message]
2018-10-28 21:24 ` [PATCH 2/2] pinctrl: sh-pfc: r8a7794: " Wolfram Sang
2018-10-30 13:55 ` Simon Horman
2018-10-31 1:19 ` Marek Vasut
2018-11-08 19:46 ` Geert Uytterhoeven
2018-11-08 20:00 ` [PATCH 0/2] pinctrl: sh-pfc: gen2: " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVzOet6RXn+iU1Ru0EP3nOK6tbVmZLs=kpjxodz1cfZCQ@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.