From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Mon, 31 Aug 2015 12:47:52 +0000 Subject: Re: [PATCH v8 04/07] arm64: renesas: r8a7795 dtsi: Add all SCIF nodes Message-Id: List-Id: References: <20150831062952.24004.17072.sendpatchset@little-apple> In-Reply-To: <20150831062952.24004.17072.sendpatchset@little-apple> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Hi Magnus, On Mon, Aug 31, 2015 at 8:29 AM, Magnus Damm wrote: > --- 0014/arch/arm64/boot/dts/renesas/r8a7795.dtsi > +++ work/arch/arm64/boot/dts/renesas/r8a7795.dtsi 2015-08-29 18:25:06.922366518 +0900 > @@ -241,6 +246,34 @@ > R8A7795_CLK_PLL3 R8A7795_CLK_PLL4 > >; > #power-domain-cells = <0>; > + > + mstp2_clks: mstp2_clks@e6150138 { With the "clock-output-names" dropped, I think the node should be called "mstp2" (without "_clks") suffix. > + compatible > + "renesas,r8a7795-mstp-clocks", > + "renesas,cpg-mstp-clocks"; > + reg = <0 0xe6150138 0 4>, > + <0 0xe6150040 0 4>; > + clocks = <&s3d4_clk>, <&s3d4_clk>, > + <&s3d4_clk>, <&s3d4_clk>, > + <&s3d4_clk>; > + #clock-cells = <1>; > + clock-indices = < > + R8A7795_CLK_SCIF5 > + R8A7795_CLK_SCIF4 > + R8A7795_CLK_SCIF3 > + R8A7795_CLK_SCIF1 > + R8A7795_CLK_SCIF0 > + >; > + }; > + > + mstp3_clks: mstp3_clks@e615013c { Likewise. > + compatible = "renesas,r8a7795-mstp-clocks", > + "renesas,cpg-mstp-clocks"; > + reg = <0 0xe615013c 0 4>, <0 0xe6150048 0 4>; > + clocks = <&s3d4_clk>; > + #clock-cells = <1>; > + clock-indices = ; Sample (part of) /sys/kernel/debug/clk/clk_summary output: s3 1 1 0 0 0 s3d4 1 2 0 0 0 mstp3_clks.10 2 2 0 0 0 I think "mstp3.10" looks nicer than "mstp3_clks.10". Note that before we had "scif2". Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds