From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C7A8C47089 for ; Thu, 27 May 2021 11:51:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8083C613CA for ; Thu, 27 May 2021 11:51:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234333AbhE0LxY (ORCPT ); Thu, 27 May 2021 07:53:24 -0400 Received: from mail-vs1-f53.google.com ([209.85.217.53]:46926 "EHLO mail-vs1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233633AbhE0LxU (ORCPT ); Thu, 27 May 2021 07:53:20 -0400 Received: by mail-vs1-f53.google.com with SMTP id q6so193958vsp.13; Thu, 27 May 2021 04:51:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MM60L9FmmGnYkH2rt7ny47piYs431Ioz2GCSUlGaeqE=; b=CIYR31ckj4nJRttIoy4DKFw1Njvey2COxtYXcDavbYawdCcYGkSHpR2hycwhj2gpcs BmDu4cETa9Z4gti8ttZhemjYAalipQJp7HnSZ6h5j24yspIQ8MarrDsW484JodGUV2+3 ma0MG2lojQg0uUtOm4nWIeF/tPZQAmA8UJSKVbWt+cs7d20PDvu8AcY0JbAH/GwTjjK0 dIsXEC0lMVWTxrpN0ZKiJ26ntzWEVih5OYg5Zs2faO8f46I98G7cVQPO6Z3oS3JAdl2K OG9IIxOjvqVCOmNdRLWrKZ5izHdlD3l9pKOF9ANk1t6Q1yOApLdFKJnohfpZdLtL6ksf 5AwQ== X-Gm-Message-State: AOAM5330oIqisu4/A0Ncl/qQeRzSwL0JVwOIacKufBuHPBqie1WD4XjX XDiFIMjvUigPYdDNfpwzOeKc04IqNal45NLLfs8= X-Google-Smtp-Source: ABdhPJxdT6Go/4lKzNa9clhVsl87svarjZxvF1z+VMaXuZrbE7cM9wmKD1Qd9B5Cem0E3381sUR0AvU66boLwv5/ucM= X-Received: by 2002:a67:8713:: with SMTP id j19mr1815177vsd.3.1622116306388; Thu, 27 May 2021 04:51:46 -0700 (PDT) MIME-Version: 1.0 References: <20210514192218.13022-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210514192218.13022-12-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Thu, 27 May 2021 13:51:34 +0200 Message-ID: Subject: Re: [PATCH 11/16] dt-bindings: clock: renesas: Document RZ/G2L SoC CPG driver To: "Lad, Prabhakar" Cc: Lad Prabhakar , Rob Herring , Magnus Damm , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Catalin Marinas , Will Deacon , Jiri Slaby , Philipp Zabel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux-Renesas , linux-clk , "open list:SERIAL DRIVERS" , Linux ARM , Biju Das Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Prabhakar, On Fri, May 21, 2021 at 8:43 PM Lad, Prabhakar wrote: > On Fri, May 21, 2021 at 4:04 PM Geert Uytterhoeven wrote: > > On Fri, May 14, 2021 at 9:23 PM Lad Prabhakar > > wrote: > > > Document the device tree bindings of the Renesas RZ/G2L SoC clock > > > driver in Documentation/devicetree/bindings/clock/renesas,rzg2l-cpg.yaml. > > > > > > Signed-off-by: Lad Prabhakar > > > Reviewed-by: Biju Das > > > > Thanks for your patch! > > > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/clock/renesas,rzg2l-cpg.yaml > > > @@ -0,0 +1,80 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: "http://devicetree.org/schemas/clock/renesas,rzg2l-cpg.yaml#" > > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > > + > > > +title: Renesas RZ/G2L Clock Pulse Generator / Module Stop and Software Reset > > > > (Module Standby Mode > > > + > > > +maintainers: > > > + - Geert Uytterhoeven > > > + > > > +description: | > > > + On Renesas RZ/G2L SoC, the CPG (Clock Pulse Generator) and MSTP > > > + (Module Stop and Software Reset) share the same register block. > > > + > > > + They provide the following functionalities: > > > + - The CPG block generates various core clocks, > > > + - The MSTP block provides two functions: > > > + 1. Module Stop, providing a Clock Domain to control the clock supply > > > + to individual SoC devices, > > > + 2. Reset Control, to perform a software reset of individual SoC devices. > > > + > > > +properties: > > > + compatible: > > > + const: renesas,r9a07g044l-cpg # RZ/G2L > > > > renesas,r9a07g044-cpg? > > > As some IP blocks present in RZ/G2L aren't present in RZ/G2LC clock > handling will differ so as a result SoC specific compatible string is > added. The RZ/G2L Hardware User's Manual Rev. 0.41 doesn't mention any differences between the CPG on RZ/G2L and RZ/G2LC. So I think it's safe to have a single driver for both members. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E23CC47089 for ; Thu, 27 May 2021 11:54:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 125CA6103E for ; Thu, 27 May 2021 11:54:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 125CA6103E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aE6Y417vxhBxs1Z2H9mZSkdEuIGQXG39CdHy4uYg3fQ=; b=sgNndLgokgWaKb RoiJbCSkP91srsXHn2Y2dZIGdaNELVYtuwTk6f//PGfti91r4XdKq2TK7nxWNKri5EE5a8EZ4taXf Ds3iNRUq4PzcYV5/v5ziLgG96wIJejHcwd69bk6/jmR2wJX9JXkLuBl+4Rm1idfhmXouV1xD3E8wv VT42p+bAcgoljseNI0KEQtoIIoj4STf9+RKXBdNDro2I1Ohkm8OFZ4w+zz2OF45cjqoeBG/cHZ2CY qFyKG08Hs+aZmO1QsTaCtLm6heU67WE3h0ayuagmzoFllmLa/Mn/gd5W5uOOwJRoNBe663jy9OgSm KFBdYDjYv33lKXaKfdlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmEYb-005TYN-LU; Thu, 27 May 2021 11:52:09 +0000 Received: from mail-vs1-f48.google.com ([209.85.217.48]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmEYF-005TLY-Q6 for linux-arm-kernel@lists.infradead.org; Thu, 27 May 2021 11:51:49 +0000 Received: by mail-vs1-f48.google.com with SMTP id n1so201267vsr.10 for ; Thu, 27 May 2021 04:51:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MM60L9FmmGnYkH2rt7ny47piYs431Ioz2GCSUlGaeqE=; b=OsBbyjY1byeEEDFotBKBXRBf52ZoYwpNkH09rxYKpMMuLV9LOhtI/VOrX3fkXSkRfv FE9q0FUQI4xvTjBdFnFGQajbsX8A+gP5jpXRBtT8nifgiJ1POCyIL+/NHTuTEmbuUJli 5LJwMkIQGf1UBvrqD9NopAOyvCa9ghy9UsB+C2N1Fx9DUrvfNGjGT1PpwRqIz3IkNoku +QvYOi1oVQeOXZuRGWnPuFNHxB4KlE04mPXRGYnKiJb8bwCBW5tB/HH/dRpyshsEosWp hiqbiJPua4OREzuALXufpeBH36imudT19C5hbcgdRfMk2PxwaOjo6yl9+YIk+KfwJp59 C2Sw== X-Gm-Message-State: AOAM5330HJlyyzed4drwT0LBhAnCouxzhEITNWC6oeG8J6STh/PMk/Fl 7ODtRZDF6fjZEfu0F/Ql22qsADE+VriCWES3PscV9sVNHsg= X-Google-Smtp-Source: ABdhPJxdT6Go/4lKzNa9clhVsl87svarjZxvF1z+VMaXuZrbE7cM9wmKD1Qd9B5Cem0E3381sUR0AvU66boLwv5/ucM= X-Received: by 2002:a67:8713:: with SMTP id j19mr1815177vsd.3.1622116306388; Thu, 27 May 2021 04:51:46 -0700 (PDT) MIME-Version: 1.0 References: <20210514192218.13022-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210514192218.13022-12-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Thu, 27 May 2021 13:51:34 +0200 Message-ID: Subject: Re: [PATCH 11/16] dt-bindings: clock: renesas: Document RZ/G2L SoC CPG driver To: "Lad, Prabhakar" Cc: Lad Prabhakar , Rob Herring , Magnus Damm , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Catalin Marinas , Will Deacon , Jiri Slaby , Philipp Zabel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux-Renesas , linux-clk , "open list:SERIAL DRIVERS" , Linux ARM , Biju Das X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_045147_890026_E07C508D X-CRM114-Status: GOOD ( 30.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Prabhakar, On Fri, May 21, 2021 at 8:43 PM Lad, Prabhakar wrote: > On Fri, May 21, 2021 at 4:04 PM Geert Uytterhoeven wrote: > > On Fri, May 14, 2021 at 9:23 PM Lad Prabhakar > > wrote: > > > Document the device tree bindings of the Renesas RZ/G2L SoC clock > > > driver in Documentation/devicetree/bindings/clock/renesas,rzg2l-cpg.yaml. > > > > > > Signed-off-by: Lad Prabhakar > > > Reviewed-by: Biju Das > > > > Thanks for your patch! > > > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/clock/renesas,rzg2l-cpg.yaml > > > @@ -0,0 +1,80 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: "http://devicetree.org/schemas/clock/renesas,rzg2l-cpg.yaml#" > > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > > + > > > +title: Renesas RZ/G2L Clock Pulse Generator / Module Stop and Software Reset > > > > (Module Standby Mode > > > + > > > +maintainers: > > > + - Geert Uytterhoeven > > > + > > > +description: | > > > + On Renesas RZ/G2L SoC, the CPG (Clock Pulse Generator) and MSTP > > > + (Module Stop and Software Reset) share the same register block. > > > + > > > + They provide the following functionalities: > > > + - The CPG block generates various core clocks, > > > + - The MSTP block provides two functions: > > > + 1. Module Stop, providing a Clock Domain to control the clock supply > > > + to individual SoC devices, > > > + 2. Reset Control, to perform a software reset of individual SoC devices. > > > + > > > +properties: > > > + compatible: > > > + const: renesas,r9a07g044l-cpg # RZ/G2L > > > > renesas,r9a07g044-cpg? > > > As some IP blocks present in RZ/G2L aren't present in RZ/G2LC clock > handling will differ so as a result SoC specific compatible string is > added. The RZ/G2L Hardware User's Manual Rev. 0.41 doesn't mention any differences between the CPG on RZ/G2L and RZ/G2LC. So I think it's safe to have a single driver for both members. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel