From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f176.google.com (mail-vk1-f176.google.com [209.85.221.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EB082C8B for ; Thu, 4 Nov 2021 07:58:29 +0000 (UTC) Received: by mail-vk1-f176.google.com with SMTP id p22so883300vke.7 for ; Thu, 04 Nov 2021 00:58:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C0VeHDwd0st+efSBfafTGRGInECO+leW6YfH2krS5v8=; b=owvViRpmyD9mQpmnzlITdd+gGCFQq9MHNHEVoYjzThkIWmNSTDk1TO4FGbig0WygBl +P1xbTRkLQHcJv+crlbvxjwWmFLfEb7t3BBT7aRMPhLcaN/d+N2FdiMf/hkquIkfmv8d L602iwVpxQ2W8lgAUEq3cLePt8/U4sXOTiGfhQfq+PP40hJq6MegxIbI9Q3SZNrU3Z6R aND/xzGYP6B+c6kLhfZmRhlU5enmZEII66WkKGV2slsu8DahBX7+5akdS5jl9TWIIsNN 6JAQOJB+FFGpDLsPv4rqVOG9GP2IlRTSAg3dW1lYXWCVMZPWB/7aJ3ViWeqPr6EV6nYV AAIQ== X-Gm-Message-State: AOAM532rx3OwjDoUjm15uii0aJ3PanS06MY8Zzje/lf3M/uBGj/jhhdo HqEhnSaZXLZXcNTHxyPek6OgKPyjA7TLjA== X-Google-Smtp-Source: ABdhPJzskNGzNvdeyRrwicH+3utQzOLXW6XvW7uwbBppdXT5ckt6zlA7/HgRvbdVYnzAanIQIp5MVg== X-Received: by 2002:a1f:2906:: with SMTP id p6mr33695090vkp.19.1636012708678; Thu, 04 Nov 2021 00:58:28 -0700 (PDT) Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com. [209.85.222.44]) by smtp.gmail.com with ESMTPSA id y24sm530203uaq.17.2021.11.04.00.58.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Nov 2021 00:58:28 -0700 (PDT) Received: by mail-ua1-f44.google.com with SMTP id i6so9248711uae.6 for ; Thu, 04 Nov 2021 00:58:27 -0700 (PDT) X-Received: by 2002:a05:6102:b13:: with SMTP id b19mr10910538vst.50.1636012707755; Thu, 04 Nov 2021 00:58:27 -0700 (PDT) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210913071251.GA15235@gondor.apana.org.au> <20210917002619.GA6407@gondor.apana.org.au> <20211001055058.GA6081@gondor.apana.org.au> <20211003002801.GA5435@gondor.apana.org.au> <20211019132802.GA14233@gondor.apana.org.au> In-Reply-To: From: Geert Uytterhoeven Date: Thu, 4 Nov 2021 08:58:16 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] crypto: api - Do not create test larvals if manager is disabled To: Damien Le Moal Cc: Herbert Xu , Nathan Chancellor , Linux Crypto Mailing List , Vladis Dronov , Simo Sorce , Eric Biggers , "llvm@lists.linux.dev" , kernel test robot , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Hi Damien, On Thu, Nov 4, 2021 at 8:29 AM Damien Le Moal wrote: > On 2021/11/03 0:41, Geert Uytterhoeven wrote: > > On Tue, 19 Oct 2021, Herbert Xu wrote: > >> On Tue, Oct 05, 2021 at 07:33:28PM -0700, Nathan Chancellor wrote: > >>> I assume this is the diff you mean? This does not resolve the issue. My > >>> apologies if I am slow to respond, I am on vacation until the middle of > >>> next week. > >> > >> Sorry for the delay. The kernel robot figured out the problem > >> for me. It's the crypto_alg_tested call that causes api.c to > >> depend on algapi.c. This call is only invoked in the case where > >> the crypto manager is turned off. We could instead simply make > >> test larvals disappear in that case. > >> > >> ---8<--- > >> The delayed boot-time testing patch created a dependency loop > >> between api.c and algapi.c because it added a crypto_alg_tested > >> call to the former when the crypto manager is disabled. > >> > >> We could instead avoid creating the test larvals if the crypto > >> manager is disabled. This avoids the dependency loop as well > >> as saving some unnecessary work, albeit in a very unlikely case. > >> > >> Reported-by: Nathan Chancellor > >> Reported-by: Naresh Kamboju > >> Reported-by: kernel test robot > >> Fixes: adad556efcdd ("crypto: api - Fix built-in testing dependency failures") > >> Signed-off-by: Herbert Xu > > > > Thanks for your patch, which is now commit cad439fc040efe5f > > ("crypto: api - Do not create test larvals if manager is disabled"). > > > > I have bisected a failure to mount the root file system on k210 to this > > commit. > > > > Dmesg before/after: > > > > mmcblk0: mmc0:0000 SA04G 3.68 GiB > > random: fast init done > > mmcblk0: p1 > > -EXT4-fs (mmcblk0p1): mounted filesystem with ordered data mode. Opts: (null). Quota mode: disabled. > > -VFS: Mounted root (ext4 filesystem) readonly on device 179:1. > > +EXT4-fs (mmcblk0p1): Cannot load crc32c driver. > > +VFS: Cannot open root device "mmcblk0p1" or unknown-block(179,1): error -80 > > p1 exist as the message 2 lines above shows. And since the mount error is -80 > (ELIBBAD), it is really all about crypto. Since the default k210 config compile > everything in-kernel (no modules), it should work. Was crc32c compiled as a > module ? If yes, then the k210 will need to be booted with U-Boot and use a real > initrd, which likely will all end-up in a no memory situation. ext4 in itself > will consume way too much memory... Everything is built-in, including crc32c. It worked fine, until the commit referenced. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds