From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument Date: Wed, 8 Jan 2020 09:07:54 +0100 Message-ID: References: <1578415992-24054-1-git-send-email-krzk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1578415992-24054-1-git-send-email-krzk@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org To: Krzysztof Kozlowski Cc: Rich Felker , Jiri Slaby , "Michael S. Tsirkin" , David Airlie , Benjamin Herrenschmidt , Jason Wang , DRI Development , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , netdev , Paul Mackerras , Linux-Arch , Dave Jiang , Yoshinori Sato , Michael Ellerman , Helge Deller , Linux-sh list , Alexey Brodkin , Ben Skeggs , nouveau@lists.freedesktop.org, Dave Airlie , Matt Turner , arcml List-Id: linux-arch.vger.kernel.org Hi Krzysztof, On Tue, Jan 7, 2020 at 5:53 PM Krzysztof Kozlowski wrote: > The ioread8/16/32() and others have inconsistent interface among the > architectures: some taking address as const, some not. > > It seems there is nothing really stopping all of them to take > pointer to const. Shouldn't all of them take const volatile __iomem pointers? It seems the "volatile" is missing from all but the implementations in include/asm-generic/io.h. > Patchset was really tested on all affected architectures. > Build testing is in progress - I hope auto-builders will point any issues. > > > Todo > ==== > Convert also string versions (ioread16_rep() etc) if this aproach looks OK. > > > Merging > ======= > The first 5 patches - iomap, alpha, sh, parisc and powerpc - should probably go > via one tree, or even squashed into one. Yes, they should be squashed, cfr. Arnd's comment. I also wouldn't bother doing the updates in patches 6-10. The rest looks good to me. Thanks a lot! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F1BDC00523 for ; Wed, 8 Jan 2020 08:10:02 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A659206DA for ; Wed, 8 Jan 2020 08:10:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A659206DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47t23V4SWnzDqQc for ; Wed, 8 Jan 2020 19:09:58 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.167.195; helo=mail-oi1-f195.google.com; envelope-from=geert.uytterhoeven@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47t21V2fJczDqQc for ; Wed, 8 Jan 2020 19:08:09 +1100 (AEDT) Received: by mail-oi1-f195.google.com with SMTP id z64so1904652oia.4 for ; Wed, 08 Jan 2020 00:08:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X9lAK3bszh6tWp/dVwz4gJZ7NIZBKvl8mgEWhJz1N9U=; b=EG8lqStbKNvb//psBiQcj4C82+DhLIFWUVddDdFbb3/RfYfCwbU6PiSbl1JDGDxN2n 8hzAc3I+7fokM9oMYDLacpBcHn3KPJXvMT3QCR81n2Ll3lesZ7jAJCCshlhtN857fMPN dnJnFilI7mc9/2QR9Eu9l2555IhXB7rYEe60aJNSF67x4oN6piupCULyA35k5KP/x2HE 5O20eMdrB5SEM8B2U0IjmTNCEmGJTFNpOPPc4Pa1SgVL8AMhO6ONy6w112ll1yDx99e2 Iv0KmaGj4pbI27Zp13fOExkx8MHQ16QbPpBfwTqUocFmsM1Evi96x48FwlmQktatexmk LqBg== X-Gm-Message-State: APjAAAUWbIWZHBMQmEMczAuD7MesJtaMMO2sCMQtFzHhsSVXPxKm1oSx h4jVWaLUH6tU++GlbFalgiD+lJfz6r4Z2xXtqQI= X-Google-Smtp-Source: APXvYqyHxa8fgIJDObTLOZ73RoRUdvNM74muiuZsOkTaJvwYlT+0s8R5nYIen4AoxoDKsD4fs/oquvfeWacJQ1YKaqA= X-Received: by 2002:aca:1a06:: with SMTP id a6mr1987025oia.148.1578470885935; Wed, 08 Jan 2020 00:08:05 -0800 (PST) MIME-Version: 1.0 References: <1578415992-24054-1-git-send-email-krzk@kernel.org> In-Reply-To: <1578415992-24054-1-git-send-email-krzk@kernel.org> From: Geert Uytterhoeven Date: Wed, 8 Jan 2020 09:07:54 +0100 Message-ID: Subject: Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument To: Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Jiri Slaby , "Michael S. Tsirkin" , David Airlie , Jason Wang , DRI Development , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , netdev , Paul Mackerras , Linux-Arch , Dave Jiang , Yoshinori Sato , Helge Deller , Linux-sh list , Alexey Brodkin , Ben Skeggs , nouveau@lists.freedesktop.org, Dave Airlie , Matt Turner , arcml , Nick Kossifidis , Allen Hubbe , Arnd Bergmann , alpha , Ivan Kokshaysky , Thomas Gleixner , Mauro Carvalho Chehab , Kalle Valo , Richard Henderson , Parisc List , Vineet Gupta , linux-wireless , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , Jon Mason , linux-ntb@googlegroups.com, Andrew Morton , Linux Media Mailing List , linuxppc-dev , "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Krzysztof, On Tue, Jan 7, 2020 at 5:53 PM Krzysztof Kozlowski wrote: > The ioread8/16/32() and others have inconsistent interface among the > architectures: some taking address as const, some not. > > It seems there is nothing really stopping all of them to take > pointer to const. Shouldn't all of them take const volatile __iomem pointers? It seems the "volatile" is missing from all but the implementations in include/asm-generic/io.h. > Patchset was really tested on all affected architectures. > Build testing is in progress - I hope auto-builders will point any issues. > > > Todo > ==== > Convert also string versions (ioread16_rep() etc) if this aproach looks OK. > > > Merging > ======= > The first 5 patches - iomap, alpha, sh, parisc and powerpc - should probably go > via one tree, or even squashed into one. Yes, they should be squashed, cfr. Arnd's comment. I also wouldn't bother doing the updates in patches 6-10. The rest looks good to me. Thanks a lot! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88CB8C00523 for ; Wed, 8 Jan 2020 08:08:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F67C206DA for ; Wed, 8 Jan 2020 08:08:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qIqmTleJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F67C206DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NmNbrDybQH/TayL/gZi5OhAHVvtf4Grw8wOTKtohyN8=; b=qIqmTleJ63Odpy QR2CZxEHiT8IM4ctllNA4KYSSlGRqnAtPkaAClY98EasYKSw0+1O/zwXzQfk6lxZnkEgOlBuZ75qH 13LXcqrj/Em2fkzCq6ksEXRynw9ivHK9fagwknF3Ymg4moOYlDO6/vGQcr4BIR14/0xaVHR2AAOd0 OWEWXyL2kIwkPk0wMRjgY+5AlWrLcffACZKgI42HKJRIgfY0aw7o8NJcLKeEqSzDVYyK1tVTUH2jt W+DN91vNqY4oaqRe7Hfwc+VEYvD/c2mwXT+c5LMpciDYDuqCcjiMWijYCM5DtbU8VSaoiIK+zNmA+ tORebYox7IOzPe5AqlYg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ip6Nt-0006TV-Fq; Wed, 08 Jan 2020 08:08:09 +0000 Received: from mail-oi1-f194.google.com ([209.85.167.194]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ip6Nr-0006SF-5S for linux-snps-arc@lists.infradead.org; Wed, 08 Jan 2020 08:08:08 +0000 Received: by mail-oi1-f194.google.com with SMTP id d62so1863815oia.11 for ; Wed, 08 Jan 2020 00:08:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X9lAK3bszh6tWp/dVwz4gJZ7NIZBKvl8mgEWhJz1N9U=; b=SF9DFe8xn88pRlLJ07hIzeNlv1fSY7da6jIwZQIKvGSVgKbhaZeBO//qdA0bm+j5Ks 18B91ktpjmrNLDCQI+JibU5ADIVvazssVe1W0QCz8EPEDKT7tn5CQF1UKPuO2dKIC3jZ sMr+RK4ca585mH+uHIFUsyz94ZLl4AwSDSApGcNT2QMb5gVbKU7PYMrBFiNPZLZ2LXSV dXj6af/zsxdlfoVJsycQMEqGRFr6+7UQ8PdxrjH3/qQXfnNx7QtWZKVVGgyBbjrWtoyP ldCt8o33Io2CgUKfrFc7iylSu2byOBTr+C9jWZZio0sL9gv/kGkCyzl0qfb/Y6sAIhRV XBDw== X-Gm-Message-State: APjAAAUeFmqCRIO5C+6obeuNZYt3OtNhhGH0F5vtN0RydgTA/nVdRv8O PjIdcanU7pqX2IoCCb2ochYR3/86MV11sr09yug= X-Google-Smtp-Source: APXvYqyHxa8fgIJDObTLOZ73RoRUdvNM74muiuZsOkTaJvwYlT+0s8R5nYIen4AoxoDKsD4fs/oquvfeWacJQ1YKaqA= X-Received: by 2002:aca:1a06:: with SMTP id a6mr1987025oia.148.1578470885935; Wed, 08 Jan 2020 00:08:05 -0800 (PST) MIME-Version: 1.0 References: <1578415992-24054-1-git-send-email-krzk@kernel.org> In-Reply-To: <1578415992-24054-1-git-send-email-krzk@kernel.org> From: Geert Uytterhoeven Date: Wed, 8 Jan 2020 09:07:54 +0100 Message-ID: Subject: Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument To: Krzysztof Kozlowski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200108_000807_209622_FFC8CDB4 X-CRM114-Status: GOOD ( 11.54 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Jiri Slaby , "Michael S. Tsirkin" , David Airlie , Benjamin Herrenschmidt , Jason Wang , DRI Development , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , netdev , Paul Mackerras , Linux-Arch , Dave Jiang , Yoshinori Sato , Michael Ellerman , Helge Deller , Linux-sh list , Alexey Brodkin , Ben Skeggs , nouveau@lists.freedesktop.org, Dave Airlie , Matt Turner , arcml , Nick Kossifidis , Allen Hubbe , Arnd Bergmann , alpha , Ivan Kokshaysky , Thomas Gleixner , Mauro Carvalho Chehab , Kalle Valo , Richard Henderson , Parisc List , Vineet Gupta , linux-wireless , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , Jon Mason , linux-ntb@googlegroups.com, Andrew Morton , Linux Media Mailing List , linuxppc-dev , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On Tue, Jan 7, 2020 at 5:53 PM Krzysztof Kozlowski wrote: > The ioread8/16/32() and others have inconsistent interface among the > architectures: some taking address as const, some not. > > It seems there is nothing really stopping all of them to take > pointer to const. Shouldn't all of them take const volatile __iomem pointers? It seems the "volatile" is missing from all but the implementations in include/asm-generic/io.h. > Patchset was really tested on all affected architectures. > Build testing is in progress - I hope auto-builders will point any issues. > > > Todo > ==== > Convert also string versions (ioread16_rep() etc) if this aproach looks OK. > > > Merging > ======= > The first 5 patches - iomap, alpha, sh, parisc and powerpc - should probably go > via one tree, or even squashed into one. Yes, they should be squashed, cfr. Arnd's comment. I also wouldn't bother doing the updates in patches 6-10. The rest looks good to me. Thanks a lot! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ECAEC00523 for ; Wed, 8 Jan 2020 08:08:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B151206DA for ; Wed, 8 Jan 2020 08:08:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B151206DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D60DC89BC0; Wed, 8 Jan 2020 08:08:07 +0000 (UTC) Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id A37D489BC0; Wed, 8 Jan 2020 08:08:06 +0000 (UTC) Received: by mail-oi1-f195.google.com with SMTP id c77so1886042oib.7; Wed, 08 Jan 2020 00:08:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X9lAK3bszh6tWp/dVwz4gJZ7NIZBKvl8mgEWhJz1N9U=; b=NnkJS9Gugads9XC1oieJkiwxm7xAdqSCphczdbjNQWq/+lT1DLz/xziibWAgU4DFQK Px2eS0TQX8l3hEklAQnXcUKkfegivrflg91ZYlWqBGDSFKNRmjgi+dDI7tWeG/cICOsU 3c5J2Jc0sPP8xtWld/XAuSaCR2q0/jz/TEmAKHVMqRwr3vXs9GyuDJ9Tzu6rg8edzbXh HLQ7sJWzVTeDtIj5PYDsqDQoZwiAKbcA7VdAOomM6N2MxFOrIVSy2TUY7TVHtMx7ZIVD 79YU9sjqE6u0Vf0tKOwOYdFX6OtCcxRDTlHpGsJsVtx40M/cjMMXHEKRJiEAR1G4Xcxz oT3Q== X-Gm-Message-State: APjAAAXpEbN82XfHgdNLBAStGa+FLrkDVoIR6L385GuYsp0xKkqo3TZb dwk+AIgcyviCkhwMNZu86mKJkiH/qdhUlmQuerQ= X-Google-Smtp-Source: APXvYqyHxa8fgIJDObTLOZ73RoRUdvNM74muiuZsOkTaJvwYlT+0s8R5nYIen4AoxoDKsD4fs/oquvfeWacJQ1YKaqA= X-Received: by 2002:aca:1a06:: with SMTP id a6mr1987025oia.148.1578470885935; Wed, 08 Jan 2020 00:08:05 -0800 (PST) MIME-Version: 1.0 References: <1578415992-24054-1-git-send-email-krzk@kernel.org> In-Reply-To: <1578415992-24054-1-git-send-email-krzk@kernel.org> From: Geert Uytterhoeven Date: Wed, 8 Jan 2020 09:07:54 +0100 Message-ID: Subject: Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument To: Krzysztof Kozlowski X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Jiri Slaby , "Michael S. Tsirkin" , David Airlie , Jason Wang , DRI Development , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , netdev , Paul Mackerras , Linux-Arch , Dave Jiang , Yoshinori Sato , Michael Ellerman , Helge Deller , Linux-sh list , Alexey Brodkin , Ben Skeggs , nouveau@lists.freedesktop.org, Dave Airlie , Matt Turner , arcml , Nick Kossifidis , Allen Hubbe , Arnd Bergmann , alpha , Ivan Kokshaysky , Thomas Gleixner , Mauro Carvalho Chehab , Kalle Valo , Richard Henderson , Parisc List , Vineet Gupta , linux-wireless , Linux Kernel Mailing List , Luis Chamberlain , Jon Mason , linux-ntb@googlegroups.com, Andrew Morton , Linux Media Mailing List , linuxppc-dev , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Krzysztof, On Tue, Jan 7, 2020 at 5:53 PM Krzysztof Kozlowski wrote: > The ioread8/16/32() and others have inconsistent interface among the > architectures: some taking address as const, some not. > > It seems there is nothing really stopping all of them to take > pointer to const. Shouldn't all of them take const volatile __iomem pointers? It seems the "volatile" is missing from all but the implementations in include/asm-generic/io.h. > Patchset was really tested on all affected architectures. > Build testing is in progress - I hope auto-builders will point any issues. > > > Todo > ==== > Convert also string versions (ioread16_rep() etc) if this aproach looks OK. > > > Merging > ======= > The first 5 patches - iomap, alpha, sh, parisc and powerpc - should probably go > via one tree, or even squashed into one. Yes, they should be squashed, cfr. Arnd's comment. I also wouldn't bother doing the updates in patches 6-10. The rest looks good to me. Thanks a lot! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com. [209.85.167.193]) by gmr-mx.google.com with ESMTPS id e14si161676otr.1.2020.01.08.00.08.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2020 00:08:06 -0800 (PST) Received: by mail-oi1-f193.google.com with SMTP id l136so1912335oig.1 for ; Wed, 08 Jan 2020 00:08:06 -0800 (PST) MIME-Version: 1.0 References: <1578415992-24054-1-git-send-email-krzk@kernel.org> In-Reply-To: <1578415992-24054-1-git-send-email-krzk@kernel.org> From: Geert Uytterhoeven Date: Wed, 8 Jan 2020 09:07:54 +0100 Message-ID: Subject: Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument Content-Type: text/plain; charset="UTF-8" To: Krzysztof Kozlowski Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Alexey Brodkin , Vineet Gupta , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Yoshinori Sato , Rich Felker , Dave Airlie , David Airlie , Daniel Vetter , Ben Skeggs , Mauro Carvalho Chehab , Jiri Slaby , Nick Kossifidis , Luis Chamberlain , Kalle Valo , "David S. Miller" , Dave Jiang , Jon Mason , Allen Hubbe , "Michael S. Tsirkin" , Jason Wang , Arnd Bergmann , Andrew Morton , Thomas Gleixner , alpha , Linux Kernel Mailing List , arcml , Parisc List , linuxppc-dev , Linux-sh list , DRI Development , nouveau@lists.freedesktop.org, Linux Media Mailing List , linux-wireless , netdev , linux-ntb@googlegroups.com, virtualization@lists.linux-foundation.org, Linux-Arch List-ID: Hi Krzysztof, On Tue, Jan 7, 2020 at 5:53 PM Krzysztof Kozlowski wrote: > The ioread8/16/32() and others have inconsistent interface among the > architectures: some taking address as const, some not. > > It seems there is nothing really stopping all of them to take > pointer to const. Shouldn't all of them take const volatile __iomem pointers? It seems the "volatile" is missing from all but the implementations in include/asm-generic/io.h. > Patchset was really tested on all affected architectures. > Build testing is in progress - I hope auto-builders will point any issues. > > > Todo > ==== > Convert also string versions (ioread16_rep() etc) if this aproach looks OK. > > > Merging > ======= > The first 5 patches - iomap, alpha, sh, parisc and powerpc - should probably go > via one tree, or even squashed into one. Yes, they should be squashed, cfr. Arnd's comment. I also wouldn't bother doing the updates in patches 6-10. The rest looks good to me. Thanks a lot! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds