From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3741C4360C for ; Fri, 27 Sep 2019 12:07:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 892B6217D7 for ; Fri, 27 Sep 2019 12:07:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726295AbfI0MHE (ORCPT ); Fri, 27 Sep 2019 08:07:04 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:39184 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726087AbfI0MHE (ORCPT ); Fri, 27 Sep 2019 08:07:04 -0400 Received: by mail-ot1-f68.google.com with SMTP id s22so2004291otr.6; Fri, 27 Sep 2019 05:07:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cQUfrwmtNA9Ew4P666b0rG4KYFsmfzKC7caBKHjOR7A=; b=W8m7ZyTGJpiwmlRZmZ50KewVLpzrTP30eCAjEzzjxm+ZZqmaD1BOr7p/JnXzwbIPF5 ZSq1LJlq/M7fIkHxYqgONpuZ3Klcbc5tvYqStqygxJMVPzptIBtl9n29cGC8K2zkkMGI PJ3eqLa0zvQZI6asqQhedG5Ts9ZVkbssR0bxb1NgB3GjgzwKMaQuT+Kvh/SP/UZU3pZV 5as1G7n2v11N/6D7B0BQPUCcwQNsmQvqofnZPkBq/qcCX/1xmynzy5lbeU+3lJFL5yHn hBBd4H1Vm72CrYJh7dWZq7vC1fpXCCMRGJpCN43UkfyfOjGcE5fdglKbBFx0YuY3geCF iYCA== X-Gm-Message-State: APjAAAVC/IidycCFW872z0OG4HINA9fmSfqG9i+kEGafZWcQ3vGjoIoP q35s5hsv2oIHuPmwiCnPMgVAiMU6mTCkkigXo6Wh37dD2Vs= X-Google-Smtp-Source: APXvYqw91liXfST0dl+4xdw5CaXGSUDfkMlGkTAUpJkjnVji/bz+InlrkHEmdtczbDZxYDCO2f1/2hhRB9TstrUR0lk= X-Received: by 2002:a9d:404d:: with SMTP id o13mr2952804oti.39.1569586023005; Fri, 27 Sep 2019 05:07:03 -0700 (PDT) MIME-Version: 1.0 References: <1568725530-55241-1-git-send-email-biju.das@bp.renesas.com> <1568725530-55241-2-git-send-email-biju.das@bp.renesas.com> In-Reply-To: <1568725530-55241-2-git-send-email-biju.das@bp.renesas.com> From: Geert Uytterhoeven Date: Fri, 27 Sep 2019 14:06:51 +0200 Message-ID: Subject: Re: [PATCH 1/4] arm64: dts: renesas: Initial r8a774b1 SoC device tree To: Biju Das Cc: Rob Herring , Mark Rutland , Simon Horman , Geert Uytterhoeven , Magnus Damm , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Chris Paterson , Fabrizio Castro Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Biju, On Tue, Sep 17, 2019 at 3:12 PM Biju Das wrote: > Basic support for the RZ/G2N (R8A774B1) SoC. Added placeholders > to avoid compilation error with the common platform code. > > Signed-off-by: Biju Das Thanks for your patch! > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi > + avb: ethernet@e6800000 { > + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>; According to the documentation, RZ/G2N does not have the stream buffer, so the second register block should be omitted. > + /* placeholder */ > + }; The rest looks OK, so with the above fixed: Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds