From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAAC8C48BE5 for ; Wed, 23 Jun 2021 12:53:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BEA0F6108E for ; Wed, 23 Jun 2021 12:53:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230392AbhFWM4E (ORCPT ); Wed, 23 Jun 2021 08:56:04 -0400 Received: from mail-vs1-f49.google.com ([209.85.217.49]:43757 "EHLO mail-vs1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230019AbhFWM4D (ORCPT ); Wed, 23 Jun 2021 08:56:03 -0400 Received: by mail-vs1-f49.google.com with SMTP id v12so1348047vsg.10; Wed, 23 Jun 2021 05:53:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P76n6RiaHARTNJx4hBu1PTQcMcnpO5X4D5Pt6jdXVrM=; b=eDBklfAVBLqKexaYWEmmuFD2OtT1H9r5A3Okg4gP9Zov2k33ovQyvKgyK0paZ5uO1F Qqzb7DxIXZ/hUkZ068qd/qvo9vRlONzTnUY0uAkx8RP/qdmrE1fiw6sLQb+FR/EXtNcZ 2N74pyu6bwZPyss4/s6RhkCK+OccS5H/EUYy+2YKXoUaEulj/Mg+VFS7BN6fZDR++I2i HF4pGhQ7ptrxllxSTSRRx5QjK98FPSKLUcQRSYXH4avwrai0htexj5jI79Y1FL/wnyHe ybEpV10vHXVCkHJDTuP8VQ6KHpES7vOgX9YMSSAvi0DDQQYD4xJfQPKu+/TLf3VpMdoS KYag== X-Gm-Message-State: AOAM531RAl91xu3vqPC4HUKcSR1cCCqcW0VJk0Q+x4zHpkQnr4s8koPx qyCGbl6MVurW5HEpCv7JdKxmqDyMW4nxt7tY2qg= X-Google-Smtp-Source: ABdhPJzQtwkx6Vol4T8y0aFn6deUBrbclNdnvtkKHC32EZvJE81p6+UAva6S9Ij1VyIOK4AEw4OeUADP2euokpub3lI= X-Received: by 2002:a67:ba0c:: with SMTP id l12mr1120114vsn.40.1624452824812; Wed, 23 Jun 2021 05:53:44 -0700 (PDT) MIME-Version: 1.0 References: <20210622231146.3208404-1-kieran.bingham@ideasonboard.com> In-Reply-To: <20210622231146.3208404-1-kieran.bingham@ideasonboard.com> From: Geert Uytterhoeven Date: Wed, 23 Jun 2021 14:53:33 +0200 Message-ID: Subject: Re: [PATCH] dt-bindings: display: renesas,du: Provide bindings for r8a779a0 To: Kieran Bingham Cc: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Rob Herring , "open list:DRM DRIVERS FOR RENESAS" , "open list:DRM DRIVERS FOR RENESAS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kieran, On Wed, Jun 23, 2021 at 1:11 AM Kieran Bingham wrote: > From: Kieran Bingham > > Extend the Renesas DU display bindings to support the r8a779a0 V3U. > > Signed-off-by: Kieran Bingham Thanks for your patch! > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml > @@ -39,6 +39,7 @@ properties: > - renesas,du-r8a77980 # for R-Car V3H compatible DU > - renesas,du-r8a77990 # for R-Car E3 compatible DU > - renesas,du-r8a77995 # for R-Car D3 compatible DU > + - renesas,du-r8a779a0 # for R-Car V3U compatible DU > > reg: > maxItems: 1 > @@ -774,6 +775,57 @@ allOf: > - reset-names > - renesas,vsps > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,du-r8a779a0 > + then: > + properties: > + clocks: > + items: > + - description: Functional clock for DU0 > + - description: Functional clock for DU1 > + > + clock-names: > + items: > + - const: du.0 > + - const: du.1 The hardware block has only a single function clock for both channels, like on R-Car H1. And what about DU_DOTCLKIN? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 497F0C49EA4 for ; Wed, 23 Jun 2021 12:53:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED5566108E for ; Wed, 23 Jun 2021 12:53:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED5566108E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6DE3A6E0E6; Wed, 23 Jun 2021 12:53:47 +0000 (UTC) Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF1186E0E6 for ; Wed, 23 Jun 2021 12:53:45 +0000 (UTC) Received: by mail-vs1-f46.google.com with SMTP id z15so1339015vsn.13 for ; Wed, 23 Jun 2021 05:53:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P76n6RiaHARTNJx4hBu1PTQcMcnpO5X4D5Pt6jdXVrM=; b=Sgq90GXE5ePpgJnKEN+4XCslIstEzPBay9d+zz9ImZ8Ji67i4ujzgGymZUW17b3QjR gNBHTwBfUBb0UB92qkRit8UaqfJR5Cd6wy6WRPhMzwbKy1zI/0uBRSPH6LlFwDA/LVOv WmKhv0eGkYWGc8jSZImkWQ2xES0xPt546Rzd/+4jvX/GrG+NflnBXh/mYkdAK4QuzeXE jcuKaSytocM+b+/Bz/BBxM8L29lpm0z5qTXPr5JGJmYARine9/Lk1N++gvuJzT4vBYy2 STlSOLkkDTXDia9ohDkjJlreGPlQGPB/aNf96K336xvYUD5BBDO7NhnQPsk51M38ZXhD ZHLg== X-Gm-Message-State: AOAM532j43LW6uJDxvtEgTEyf1t3p4fxmeuKveuEWU3Ug4DH60DkKVNT ZajPyfnq8sd1ip4i//QTUXBPJGOjqbTopNG9YRg= X-Google-Smtp-Source: ABdhPJzQtwkx6Vol4T8y0aFn6deUBrbclNdnvtkKHC32EZvJE81p6+UAva6S9Ij1VyIOK4AEw4OeUADP2euokpub3lI= X-Received: by 2002:a67:ba0c:: with SMTP id l12mr1120114vsn.40.1624452824812; Wed, 23 Jun 2021 05:53:44 -0700 (PDT) MIME-Version: 1.0 References: <20210622231146.3208404-1-kieran.bingham@ideasonboard.com> In-Reply-To: <20210622231146.3208404-1-kieran.bingham@ideasonboard.com> From: Geert Uytterhoeven Date: Wed, 23 Jun 2021 14:53:33 +0200 Message-ID: Subject: Re: [PATCH] dt-bindings: display: renesas, du: Provide bindings for r8a779a0 To: Kieran Bingham Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , David Airlie , Kieran Bingham , open list , "open list:DRM DRIVERS FOR RENESAS" , "open list:DRM DRIVERS FOR RENESAS" , Rob Herring , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Kieran, On Wed, Jun 23, 2021 at 1:11 AM Kieran Bingham wrote: > From: Kieran Bingham > > Extend the Renesas DU display bindings to support the r8a779a0 V3U. > > Signed-off-by: Kieran Bingham Thanks for your patch! > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml > @@ -39,6 +39,7 @@ properties: > - renesas,du-r8a77980 # for R-Car V3H compatible DU > - renesas,du-r8a77990 # for R-Car E3 compatible DU > - renesas,du-r8a77995 # for R-Car D3 compatible DU > + - renesas,du-r8a779a0 # for R-Car V3U compatible DU > > reg: > maxItems: 1 > @@ -774,6 +775,57 @@ allOf: > - reset-names > - renesas,vsps > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,du-r8a779a0 > + then: > + properties: > + clocks: > + items: > + - description: Functional clock for DU0 > + - description: Functional clock for DU1 > + > + clock-names: > + items: > + - const: du.0 > + - const: du.1 The hardware block has only a single function clock for both channels, like on R-Car H1. And what about DU_DOTCLKIN? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds