From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44340539B for ; Thu, 1 Jun 2023 07:40:24 +0000 (UTC) Received: by mail-yb1-f175.google.com with SMTP id 3f1490d57ef6-bad0c4f6f50so942368276.1 for ; Thu, 01 Jun 2023 00:40:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685605223; x=1688197223; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+Vy5gwXbACIYw+FA/+yi3OHDGD1kIURAtfeea/c7peI=; b=h36Q8eNTxIwQI2cmaeuLbD7I1/obYfdOMvvlA5InQ6qJg+S/Op4GR9IvhitW+vF/rQ L4A25EqpSguQk6i65xULtVhJ0BfhPPEjMAKEs158IAZlUHgUtgmmHh3DnvAetjX5OZeA LiFCCtjYlrP1IfWEoonXPLoCqYxjSDIx+SQaE+XvsF34QmjsZT+5Uij2EIHEnSDG+m+I lP9JURqCX0DXWDYqx3Ia8G/F9LBIHiY9KEWh2O2FUJ8n1uU9ojGq/7hjiUApB767V8R7 CTJXjIT/cvzip8HP0+kLZEsyEwHwtpWztnV8sc5DwmrY/aByde0y1CBnw8O6WWtC2w3v PxjA== X-Gm-Message-State: AC+VfDyJzab4bzgi+WNmp+CWCMLa6kUNdh0WB/sxdcj27cmeZjsQkXKh fDNzZJr7uKVnKIHN1A4WKN7zCbAC7++u6g== X-Google-Smtp-Source: ACHHUZ79dHgCSgqGQ4Na0kndWgK28jx5OSMLezi+MKhHowPsBj3/83awE/Gxua0NU69s0OrSY93rtA== X-Received: by 2002:a25:160a:0:b0:ba1:24a5:55ae with SMTP id 10-20020a25160a000000b00ba124a555aemr1086189ybw.24.1685605222719; Thu, 01 Jun 2023 00:40:22 -0700 (PDT) Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com. [209.85.128.178]) by smtp.gmail.com with ESMTPSA id k13-20020a25e80d000000b00bad59725e11sm3419827ybd.57.2023.06.01.00.40.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 00:40:21 -0700 (PDT) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-55db055b412so28189737b3.0 for ; Thu, 01 Jun 2023 00:40:21 -0700 (PDT) X-Received: by 2002:a81:a041:0:b0:565:9f61:c771 with SMTP id x62-20020a81a041000000b005659f61c771mr1176431ywg.9.1685605221248; Thu, 01 Jun 2023 00:40:21 -0700 (PDT) Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230531213032.25338-1-vishal.moola@gmail.com> <20230531213032.25338-26-vishal.moola@gmail.com> In-Reply-To: <20230531213032.25338-26-vishal.moola@gmail.com> From: Geert Uytterhoeven Date: Thu, 1 Jun 2023 09:40:07 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 25/34] m68k: Convert various functions to use ptdescs To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Vishal, On Wed, May 31, 2023 at 11:32=E2=80=AFPM Vishal Moola (Oracle) wrote: > As part of the conversions to replace pgtable constructor/destructors wit= h > ptdesc equivalents, convert various page table functions to use ptdescs. > > Some of the functions use the *get*page*() helper functions. Convert > these to use pagetable_alloc() and ptdesc_address() instead to help > standardize page tables further. > > Signed-off-by: Vishal Moola (Oracle) Thanks for your patch! > --- a/arch/m68k/include/asm/mcf_pgalloc.h > +++ b/arch/m68k/include/asm/mcf_pgalloc.h > @@ -7,20 +7,19 @@ > > extern inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte) > { > - free_page((unsigned long) pte); > + pagetable_free(virt_to_ptdesc(pte)); > } > > extern const char bad_pmd_string[]; > > extern inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm) > { > - unsigned long page =3D __get_free_page(GFP_DMA); > + struct ptdesc *ptdesc =3D pagetable_alloc(GFP_DMA | __GFP_ZERO, 0= ); > > - if (!page) > + if (!ptdesc) > return NULL; > > - memset((void *)page, 0, PAGE_SIZE); > - return (pte_t *) (page); > + return (pte_t *) (ptdesc_address(ptdesc)); No need to cast "void *" when returning a different pointer type. > } > > extern inline pmd_t *pmd_alloc_kernel(pgd_t *pgd, unsigned long address) > @@ -35,36 +34,36 @@ extern inline pmd_t *pmd_alloc_kernel(pgd_t *pgd, uns= igned long address) > static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pgta= ble, > unsigned long address) > { > - struct page *page =3D virt_to_page(pgtable); > + struct ptdesc *ptdesc =3D virt_to_ptdesc(pgtable); > > - pgtable_pte_page_dtor(page); > - __free_page(page); > + pagetable_pte_dtor(ptdesc); > + pagetable_free(ptdesc); > } > > static inline pgtable_t pte_alloc_one(struct mm_struct *mm) > { > - struct page *page =3D alloc_pages(GFP_DMA, 0); > + struct ptdesc *ptdesc =3D pagetable_alloc(GFP_DMA, 0); > pte_t *pte; > > - if (!page) > + if (!ptdesc) > return NULL; > - if (!pgtable_pte_page_ctor(page)) { > - __free_page(page); > + if (!pagetable_pte_ctor(ptdesc)) { > + pagetable_free(ptdesc); > return NULL; > } > > - pte =3D page_address(page); > - clear_page(pte); > + pte =3D ptdesc_address(ptdesc); > + pagetable_clear(pte); > > return pte; > } > > static inline void pte_free(struct mm_struct *mm, pgtable_t pgtable) > { > - struct page *page =3D virt_to_page(pgtable); > + struct ptdesc *ptdesc =3D virt_to_ptdesc(ptdesc); virt_to_ptdesc(pgtable) (You can build this using m5475evb_defconfig) > > - pgtable_pte_page_dtor(page); > - __free_page(page); > + pagetable_pte_dtor(ptdesc); > + pagetable_free(ptdesc); > } > > /* > @@ -75,16 +74,18 @@ static inline void pte_free(struct mm_struct *mm, pgt= able_t pgtable) > > static inline void pgd_free(struct mm_struct *mm, pgd_t *pgd) > { > - free_page((unsigned long) pgd); > + pagetable_free(virt_to_ptdesc(pgd)); > } > > static inline pgd_t *pgd_alloc(struct mm_struct *mm) > { > pgd_t *new_pgd; > + struct ptdesc *ptdesc =3D pagetable_alloc(GFP_DMA | GFP_NOWARN, 0= ); > > - new_pgd =3D (pgd_t *)__get_free_page(GFP_DMA | __GFP_NOWARN); > - if (!new_pgd) > + if (!ptdesc) > return NULL; > + new_pgd =3D (pgd_t *) ptdesc_address(ptdesc); No need to cast "void *" when assigning to a different pointer type. > + > memcpy(new_pgd, swapper_pg_dir, PTRS_PER_PGD * sizeof(pgd_t)); > memset(new_pgd, 0, PAGE_OFFSET >> PGDIR_SHIFT); > return new_pgd; The rest LGTM. Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 194E7C77B7E for ; Thu, 1 Jun 2023 07:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RLSsp/Gx5LyZDkeuJ6ltx+oDJgpCKVEiixkiFcXKg8I=; b=U/tH8emsqGoS9U V6zelfTtGRV3YN2WAg2rOmPcwRlVfS7QtRNglsV4WTrhbzE1X4xM1fyTqBk3Ou1qul80XKd8h4IyC AcvzHmzxXFgbWL0jUD+qdLhDhMrr9lSX9EW5MjtmTAny4Gy1lA4G/NNJBxjoYS3W19sHDeJlEsYB+ c3x49+qaZzMlaHhzYBuFLOAs9mkp8sD+CXRbJZZGXI8/9NZ2LGal38ROBDCS+aYcQHYtUiFNiaW8u CHMzmhJ1sWXyQu5JCWG+8jpw3O/gHFrp4sAgzlrk+4iENfUy6Vb+t8wOyq8AoB7k9ijTJ07McTBf2 pYSg6VBb/5k/gtk9MYwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4cv6-002OYS-33; Thu, 01 Jun 2023 07:40:28 +0000 Received: from mail-yb1-f173.google.com ([209.85.219.173]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4cv3-002OWw-2d; Thu, 01 Jun 2023 07:40:27 +0000 Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-b9a6eec8611so2796966276.0; Thu, 01 Jun 2023 00:40:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685605223; x=1688197223; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+Vy5gwXbACIYw+FA/+yi3OHDGD1kIURAtfeea/c7peI=; b=Og1BMkE+MdVNKGYR889UmaINLrKoVpqswfthtZva/a43xln1E7O8tSXxdS9QGmUy/C zLrCyuHaOXm38RhXjDQYr7bYjWObBKi+RvnZfR3IS+IpETutXH181gU9Jme9aGFDso0Q w4qAa1uBhXBoKbB17MQ0VMr+2a+3ZZRSIfZZeAjITIhWkrtCpCdPUXdUHOYdbrIQUeqq qoTWF/ALeXwB8FhUiVI3D8uT/U41Yklq9DszHM3jb28/km7r+Lj7DNK12pyoovIDiTgW AA17Fg616/DjG7iCPf/4OXWWXM0fqC+iSpiIMFD1U9rXEDxP2BpAEXy80lQoe3udG77w ikbg== X-Gm-Message-State: AC+VfDxkLB/gcpOd7PMn9MvE4PwagtOTBb1BUecZvoCuBg2idLfds5Zy gPkxsOHObApqqKqEsjjUtxbunNlf0GckmQ== X-Google-Smtp-Source: ACHHUZ4Fh46CkVkR2qVNo7i5ve8QHdHdiK/ASMK9WDk5k0+4ab/xjYPoSDXKratkbKUonYzA3+X+2w== X-Received: by 2002:a25:ce81:0:b0:ba7:a55f:9091 with SMTP id x123-20020a25ce81000000b00ba7a55f9091mr1234545ybe.6.1685605223575; Thu, 01 Jun 2023 00:40:23 -0700 (PDT) Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com. [209.85.219.180]) by smtp.gmail.com with ESMTPSA id m205-20020a2571d6000000b00ba87bc06fe5sm4803250ybc.52.2023.06.01.00.40.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 00:40:21 -0700 (PDT) Received: by mail-yb1-f180.google.com with SMTP id 3f1490d57ef6-ba8cd61ee2dso2770657276.1; Thu, 01 Jun 2023 00:40:21 -0700 (PDT) X-Received: by 2002:a81:a041:0:b0:565:9f61:c771 with SMTP id x62-20020a81a041000000b005659f61c771mr1176431ywg.9.1685605221248; Thu, 01 Jun 2023 00:40:21 -0700 (PDT) MIME-Version: 1.0 References: <20230531213032.25338-1-vishal.moola@gmail.com> <20230531213032.25338-26-vishal.moola@gmail.com> In-Reply-To: <20230531213032.25338-26-vishal.moola@gmail.com> From: Geert Uytterhoeven Date: Thu, 1 Jun 2023 09:40:07 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 25/34] m68k: Convert various functions to use ptdescs To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230601_004025_853284_85980B1A X-CRM114-Status: GOOD ( 22.92 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org SGkgVmlzaGFsLAoKT24gV2VkLCBNYXkgMzEsIDIwMjMgYXQgMTE6MzLigK9QTSBWaXNoYWwgTW9v bGEgKE9yYWNsZSkKPHZpc2hhbC5tb29sYUBnbWFpbC5jb20+IHdyb3RlOgo+IEFzIHBhcnQgb2Yg dGhlIGNvbnZlcnNpb25zIHRvIHJlcGxhY2UgcGd0YWJsZSBjb25zdHJ1Y3Rvci9kZXN0cnVjdG9y cyB3aXRoCj4gcHRkZXNjIGVxdWl2YWxlbnRzLCBjb252ZXJ0IHZhcmlvdXMgcGFnZSB0YWJsZSBm dW5jdGlvbnMgdG8gdXNlIHB0ZGVzY3MuCj4KPiBTb21lIG9mIHRoZSBmdW5jdGlvbnMgdXNlIHRo ZSAqZ2V0KnBhZ2UqKCkgaGVscGVyIGZ1bmN0aW9ucy4gQ29udmVydAo+IHRoZXNlIHRvIHVzZSBw YWdldGFibGVfYWxsb2MoKSBhbmQgcHRkZXNjX2FkZHJlc3MoKSBpbnN0ZWFkIHRvIGhlbHAKPiBz dGFuZGFyZGl6ZSBwYWdlIHRhYmxlcyBmdXJ0aGVyLgo+Cj4gU2lnbmVkLW9mZi1ieTogVmlzaGFs IE1vb2xhIChPcmFjbGUpIDx2aXNoYWwubW9vbGFAZ21haWwuY29tPgoKVGhhbmtzIGZvciB5b3Vy IHBhdGNoIQoKPiAtLS0gYS9hcmNoL202OGsvaW5jbHVkZS9hc20vbWNmX3BnYWxsb2MuaAo+ICsr KyBiL2FyY2gvbTY4ay9pbmNsdWRlL2FzbS9tY2ZfcGdhbGxvYy5oCj4gQEAgLTcsMjAgKzcsMTkg QEAKPgo+ICBleHRlcm4gaW5saW5lIHZvaWQgcHRlX2ZyZWVfa2VybmVsKHN0cnVjdCBtbV9zdHJ1 Y3QgKm1tLCBwdGVfdCAqcHRlKQo+ICB7Cj4gLSAgICAgICBmcmVlX3BhZ2UoKHVuc2lnbmVkIGxv bmcpIHB0ZSk7Cj4gKyAgICAgICBwYWdldGFibGVfZnJlZSh2aXJ0X3RvX3B0ZGVzYyhwdGUpKTsK PiAgfQo+Cj4gIGV4dGVybiBjb25zdCBjaGFyIGJhZF9wbWRfc3RyaW5nW107Cj4KPiAgZXh0ZXJu IGlubGluZSBwdGVfdCAqcHRlX2FsbG9jX29uZV9rZXJuZWwoc3RydWN0IG1tX3N0cnVjdCAqbW0p Cj4gIHsKPiAtICAgICAgIHVuc2lnbmVkIGxvbmcgcGFnZSA9IF9fZ2V0X2ZyZWVfcGFnZShHRlBf RE1BKTsKPiArICAgICAgIHN0cnVjdCBwdGRlc2MgKnB0ZGVzYyA9IHBhZ2V0YWJsZV9hbGxvYyhH RlBfRE1BIHwgX19HRlBfWkVSTywgMCk7Cj4KPiAtICAgICAgIGlmICghcGFnZSkKPiArICAgICAg IGlmICghcHRkZXNjKQo+ICAgICAgICAgICAgICAgICByZXR1cm4gTlVMTDsKPgo+IC0gICAgICAg bWVtc2V0KCh2b2lkICopcGFnZSwgMCwgUEFHRV9TSVpFKTsKPiAtICAgICAgIHJldHVybiAocHRl X3QgKikgKHBhZ2UpOwo+ICsgICAgICAgcmV0dXJuIChwdGVfdCAqKSAocHRkZXNjX2FkZHJlc3Mo cHRkZXNjKSk7CgpObyBuZWVkIHRvIGNhc3QgInZvaWQgKiIgd2hlbiByZXR1cm5pbmcgYSBkaWZm ZXJlbnQgcG9pbnRlciB0eXBlLgoKPiAgfQo+Cj4gIGV4dGVybiBpbmxpbmUgcG1kX3QgKnBtZF9h bGxvY19rZXJuZWwocGdkX3QgKnBnZCwgdW5zaWduZWQgbG9uZyBhZGRyZXNzKQo+IEBAIC0zNSwz NiArMzQsMzYgQEAgZXh0ZXJuIGlubGluZSBwbWRfdCAqcG1kX2FsbG9jX2tlcm5lbChwZ2RfdCAq cGdkLCB1bnNpZ25lZCBsb25nIGFkZHJlc3MpCj4gIHN0YXRpYyBpbmxpbmUgdm9pZCBfX3B0ZV9m cmVlX3RsYihzdHJ1Y3QgbW11X2dhdGhlciAqdGxiLCBwZ3RhYmxlX3QgcGd0YWJsZSwKPiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBhZGRyZXNzKQo+ICB7 Cj4gLSAgICAgICBzdHJ1Y3QgcGFnZSAqcGFnZSA9IHZpcnRfdG9fcGFnZShwZ3RhYmxlKTsKPiAr ICAgICAgIHN0cnVjdCBwdGRlc2MgKnB0ZGVzYyA9IHZpcnRfdG9fcHRkZXNjKHBndGFibGUpOwo+ Cj4gLSAgICAgICBwZ3RhYmxlX3B0ZV9wYWdlX2R0b3IocGFnZSk7Cj4gLSAgICAgICBfX2ZyZWVf cGFnZShwYWdlKTsKPiArICAgICAgIHBhZ2V0YWJsZV9wdGVfZHRvcihwdGRlc2MpOwo+ICsgICAg ICAgcGFnZXRhYmxlX2ZyZWUocHRkZXNjKTsKPiAgfQo+Cj4gIHN0YXRpYyBpbmxpbmUgcGd0YWJs ZV90IHB0ZV9hbGxvY19vbmUoc3RydWN0IG1tX3N0cnVjdCAqbW0pCj4gIHsKPiAtICAgICAgIHN0 cnVjdCBwYWdlICpwYWdlID0gYWxsb2NfcGFnZXMoR0ZQX0RNQSwgMCk7Cj4gKyAgICAgICBzdHJ1 Y3QgcHRkZXNjICpwdGRlc2MgPSBwYWdldGFibGVfYWxsb2MoR0ZQX0RNQSwgMCk7Cj4gICAgICAg ICBwdGVfdCAqcHRlOwo+Cj4gLSAgICAgICBpZiAoIXBhZ2UpCj4gKyAgICAgICBpZiAoIXB0ZGVz YykKPiAgICAgICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4gLSAgICAgICBpZiAoIXBndGFibGVf cHRlX3BhZ2VfY3RvcihwYWdlKSkgewo+IC0gICAgICAgICAgICAgICBfX2ZyZWVfcGFnZShwYWdl KTsKPiArICAgICAgIGlmICghcGFnZXRhYmxlX3B0ZV9jdG9yKHB0ZGVzYykpIHsKPiArICAgICAg ICAgICAgICAgcGFnZXRhYmxlX2ZyZWUocHRkZXNjKTsKPiAgICAgICAgICAgICAgICAgcmV0dXJu IE5VTEw7Cj4gICAgICAgICB9Cj4KPiAtICAgICAgIHB0ZSA9IHBhZ2VfYWRkcmVzcyhwYWdlKTsK PiAtICAgICAgIGNsZWFyX3BhZ2UocHRlKTsKPiArICAgICAgIHB0ZSA9IHB0ZGVzY19hZGRyZXNz KHB0ZGVzYyk7Cj4gKyAgICAgICBwYWdldGFibGVfY2xlYXIocHRlKTsKPgo+ICAgICAgICAgcmV0 dXJuIHB0ZTsKPiAgfQo+Cj4gIHN0YXRpYyBpbmxpbmUgdm9pZCBwdGVfZnJlZShzdHJ1Y3QgbW1f c3RydWN0ICptbSwgcGd0YWJsZV90IHBndGFibGUpCj4gIHsKPiAtICAgICAgIHN0cnVjdCBwYWdl ICpwYWdlID0gdmlydF90b19wYWdlKHBndGFibGUpOwo+ICsgICAgICAgc3RydWN0IHB0ZGVzYyAq cHRkZXNjID0gdmlydF90b19wdGRlc2MocHRkZXNjKTsKCnZpcnRfdG9fcHRkZXNjKHBndGFibGUp CgooWW91IGNhbiBidWlsZCB0aGlzIHVzaW5nIG01NDc1ZXZiX2RlZmNvbmZpZykKCj4KPiAtICAg ICAgIHBndGFibGVfcHRlX3BhZ2VfZHRvcihwYWdlKTsKPiAtICAgICAgIF9fZnJlZV9wYWdlKHBh Z2UpOwo+ICsgICAgICAgcGFnZXRhYmxlX3B0ZV9kdG9yKHB0ZGVzYyk7Cj4gKyAgICAgICBwYWdl dGFibGVfZnJlZShwdGRlc2MpOwo+ICB9Cj4KPiAgLyoKPiBAQCAtNzUsMTYgKzc0LDE4IEBAIHN0 YXRpYyBpbmxpbmUgdm9pZCBwdGVfZnJlZShzdHJ1Y3QgbW1fc3RydWN0ICptbSwgcGd0YWJsZV90 IHBndGFibGUpCj4KPiAgc3RhdGljIGlubGluZSB2b2lkIHBnZF9mcmVlKHN0cnVjdCBtbV9zdHJ1 Y3QgKm1tLCBwZ2RfdCAqcGdkKQo+ICB7Cj4gLSAgICAgICBmcmVlX3BhZ2UoKHVuc2lnbmVkIGxv bmcpIHBnZCk7Cj4gKyAgICAgICBwYWdldGFibGVfZnJlZSh2aXJ0X3RvX3B0ZGVzYyhwZ2QpKTsK PiAgfQo+Cj4gIHN0YXRpYyBpbmxpbmUgcGdkX3QgKnBnZF9hbGxvYyhzdHJ1Y3QgbW1fc3RydWN0 ICptbSkKPiAgewo+ICAgICAgICAgcGdkX3QgKm5ld19wZ2Q7Cj4gKyAgICAgICBzdHJ1Y3QgcHRk ZXNjICpwdGRlc2MgPSBwYWdldGFibGVfYWxsb2MoR0ZQX0RNQSB8IEdGUF9OT1dBUk4sIDApOwo+ Cj4gLSAgICAgICBuZXdfcGdkID0gKHBnZF90ICopX19nZXRfZnJlZV9wYWdlKEdGUF9ETUEgfCBf X0dGUF9OT1dBUk4pOwo+IC0gICAgICAgaWYgKCFuZXdfcGdkKQo+ICsgICAgICAgaWYgKCFwdGRl c2MpCj4gICAgICAgICAgICAgICAgIHJldHVybiBOVUxMOwo+ICsgICAgICAgbmV3X3BnZCA9IChw Z2RfdCAqKSBwdGRlc2NfYWRkcmVzcyhwdGRlc2MpOwoKTm8gbmVlZCB0byBjYXN0ICJ2b2lkICoi IHdoZW4gYXNzaWduaW5nIHRvIGEgZGlmZmVyZW50IHBvaW50ZXIgdHlwZS4KCj4gKwo+ICAgICAg ICAgbWVtY3B5KG5ld19wZ2QsIHN3YXBwZXJfcGdfZGlyLCBQVFJTX1BFUl9QR0QgKiBzaXplb2Yo cGdkX3QpKTsKPiAgICAgICAgIG1lbXNldChuZXdfcGdkLCAwLCBQQUdFX09GRlNFVCA+PiBQR0RJ Ul9TSElGVCk7Cj4gICAgICAgICByZXR1cm4gbmV3X3BnZDsKClRoZSByZXN0IExHVE0uCgpHcntv ZXRqZSxlZXRpbmd9cywKCiAgICAgICAgICAgICAgICAgICAgICAgIEdlZXJ0CgotLSAKR2VlcnQg VXl0dGVyaG9ldmVuIC0tIFRoZXJlJ3MgbG90cyBvZiBMaW51eCBiZXlvbmQgaWEzMiAtLSBnZWVy dEBsaW51eC1tNjhrLm9yZwoKSW4gcGVyc29uYWwgY29udmVyc2F0aW9ucyB3aXRoIHRlY2huaWNh bCBwZW9wbGUsIEkgY2FsbCBteXNlbGYgYSBoYWNrZXIuIEJ1dAp3aGVuIEknbSB0YWxraW5nIHRv IGpvdXJuYWxpc3RzIEkganVzdCBzYXkgInByb2dyYW1tZXIiIG9yIHNvbWV0aGluZyBsaWtlIHRo YXQuCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLS0gTGludXMgVG9ydmFsZHMKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2 IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6101C7EE23 for ; Thu, 1 Jun 2023 07:40:57 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QWyjh30Jqz3f1K for ; Thu, 1 Jun 2023 17:40:56 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.219.174; helo=mail-yb1-f174.google.com; envelope-from=geert.uytterhoeven@gmail.com; receiver=) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QWyj53DwBz30QQ for ; Thu, 1 Jun 2023 17:40:24 +1000 (AEST) Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-b9a6eec8611so2796915276.0 for ; Thu, 01 Jun 2023 00:40:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685605222; x=1688197222; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+Vy5gwXbACIYw+FA/+yi3OHDGD1kIURAtfeea/c7peI=; b=P9tAyHkIbF0oa5RnrWe4U5qsIP3UEnP2Yxq9dEh+kQZ2mbaq+YmnAHY1WSDs0Va7kC XH9ZXwFK4avWo9UaHuL9ZhRGbdmWuiLRmhnlmZ/y1zJk0H1uW3L8yq3Pg+M6tsh+EW9Y TQtkvd+1n7+wJ5aVtDmyTfecKA2al98DlpSZlo20adFWeEIGGHfhEwkpK+2CunyC+evY 3L5vbNg9bfaPZFGmhmeE0OHac5l7R7ObgLj6lOEx0J/GeNXUoJzOg4gkDcYCy+V9vjM9 wq2cUfxY8rUN/8eLLjLem4hpy0arvtBg2Pxy8jciTr3jon3YYWTI4cTPMqZNv3iqZCHN klBg== X-Gm-Message-State: AC+VfDwtHWOm81NRLKaLg+FTQeRdqE7yjVOdgnZdLhU/HKx3Fk6JgldA hGMetqKH2qIIvGQDp675XCzwL679oLWVPw== X-Google-Smtp-Source: ACHHUZ5hFvr31Qq95vn4LMCDSzlMZdpSICH2xUWAAW1FpZGs9YIXex9kog5DApnlHEkI11BjnSDqcQ== X-Received: by 2002:a0d:db4f:0:b0:565:85b0:c128 with SMTP id d76-20020a0ddb4f000000b0056585b0c128mr1248119ywe.6.1685605222200; Thu, 01 Jun 2023 00:40:22 -0700 (PDT) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com. [209.85.219.179]) by smtp.gmail.com with ESMTPSA id z5-20020a818905000000b00545a08184bbsm6028099ywf.75.2023.06.01.00.40.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 00:40:21 -0700 (PDT) Received: by mail-yb1-f179.google.com with SMTP id 3f1490d57ef6-ba8cd61ee2dso2770655276.1 for ; Thu, 01 Jun 2023 00:40:21 -0700 (PDT) X-Received: by 2002:a81:a041:0:b0:565:9f61:c771 with SMTP id x62-20020a81a041000000b005659f61c771mr1176431ywg.9.1685605221248; Thu, 01 Jun 2023 00:40:21 -0700 (PDT) MIME-Version: 1.0 References: <20230531213032.25338-1-vishal.moola@gmail.com> <20230531213032.25338-26-vishal.moola@gmail.com> In-Reply-To: <20230531213032.25338-26-vishal.moola@gmail.com> From: Geert Uytterhoeven Date: Thu, 1 Jun 2023 09:40:07 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 25/34] m68k: Convert various functions to use ptdescs To: "Vishal Moola (Oracle)" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, linux-mips@vger.kernel.org, linux-csky@vger.kernel.org, linux-mm@kvack.org, linux-m68k@lists.linux-m68k.org, Matthew Wilcox , loongarch@lists.linux.dev, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Vishal, On Wed, May 31, 2023 at 11:32=E2=80=AFPM Vishal Moola (Oracle) wrote: > As part of the conversions to replace pgtable constructor/destructors wit= h > ptdesc equivalents, convert various page table functions to use ptdescs. > > Some of the functions use the *get*page*() helper functions. Convert > these to use pagetable_alloc() and ptdesc_address() instead to help > standardize page tables further. > > Signed-off-by: Vishal Moola (Oracle) Thanks for your patch! > --- a/arch/m68k/include/asm/mcf_pgalloc.h > +++ b/arch/m68k/include/asm/mcf_pgalloc.h > @@ -7,20 +7,19 @@ > > extern inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte) > { > - free_page((unsigned long) pte); > + pagetable_free(virt_to_ptdesc(pte)); > } > > extern const char bad_pmd_string[]; > > extern inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm) > { > - unsigned long page =3D __get_free_page(GFP_DMA); > + struct ptdesc *ptdesc =3D pagetable_alloc(GFP_DMA | __GFP_ZERO, 0= ); > > - if (!page) > + if (!ptdesc) > return NULL; > > - memset((void *)page, 0, PAGE_SIZE); > - return (pte_t *) (page); > + return (pte_t *) (ptdesc_address(ptdesc)); No need to cast "void *" when returning a different pointer type. > } > > extern inline pmd_t *pmd_alloc_kernel(pgd_t *pgd, unsigned long address) > @@ -35,36 +34,36 @@ extern inline pmd_t *pmd_alloc_kernel(pgd_t *pgd, uns= igned long address) > static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pgta= ble, > unsigned long address) > { > - struct page *page =3D virt_to_page(pgtable); > + struct ptdesc *ptdesc =3D virt_to_ptdesc(pgtable); > > - pgtable_pte_page_dtor(page); > - __free_page(page); > + pagetable_pte_dtor(ptdesc); > + pagetable_free(ptdesc); > } > > static inline pgtable_t pte_alloc_one(struct mm_struct *mm) > { > - struct page *page =3D alloc_pages(GFP_DMA, 0); > + struct ptdesc *ptdesc =3D pagetable_alloc(GFP_DMA, 0); > pte_t *pte; > > - if (!page) > + if (!ptdesc) > return NULL; > - if (!pgtable_pte_page_ctor(page)) { > - __free_page(page); > + if (!pagetable_pte_ctor(ptdesc)) { > + pagetable_free(ptdesc); > return NULL; > } > > - pte =3D page_address(page); > - clear_page(pte); > + pte =3D ptdesc_address(ptdesc); > + pagetable_clear(pte); > > return pte; > } > > static inline void pte_free(struct mm_struct *mm, pgtable_t pgtable) > { > - struct page *page =3D virt_to_page(pgtable); > + struct ptdesc *ptdesc =3D virt_to_ptdesc(ptdesc); virt_to_ptdesc(pgtable) (You can build this using m5475evb_defconfig) > > - pgtable_pte_page_dtor(page); > - __free_page(page); > + pagetable_pte_dtor(ptdesc); > + pagetable_free(ptdesc); > } > > /* > @@ -75,16 +74,18 @@ static inline void pte_free(struct mm_struct *mm, pgt= able_t pgtable) > > static inline void pgd_free(struct mm_struct *mm, pgd_t *pgd) > { > - free_page((unsigned long) pgd); > + pagetable_free(virt_to_ptdesc(pgd)); > } > > static inline pgd_t *pgd_alloc(struct mm_struct *mm) > { > pgd_t *new_pgd; > + struct ptdesc *ptdesc =3D pagetable_alloc(GFP_DMA | GFP_NOWARN, 0= ); > > - new_pgd =3D (pgd_t *)__get_free_page(GFP_DMA | __GFP_NOWARN); > - if (!new_pgd) > + if (!ptdesc) > return NULL; > + new_pgd =3D (pgd_t *) ptdesc_address(ptdesc); No need to cast "void *" when assigning to a different pointer type. > + > memcpy(new_pgd, swapper_pg_dir, PTRS_PER_PGD * sizeof(pgd_t)); > memset(new_pgd, 0, PAGE_OFFSET >> PGDIR_SHIFT); > return new_pgd; The rest LGTM. Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2922C7EE23 for ; Thu, 1 Jun 2023 07:40:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7qKxjtMgQL2ITeRAWb2pZykKeSW+uiaQs178aw8AKIU=; b=DCwmasAN8/qsPU +ScWHEZ96zCw0S9rO9U19qG86XqyM3qo7n4pCUZHETzZSWU7s7ljqN5u2uZR+ooDukj1ilD9S00j2 IgnZoB0BB4AXKTWqdugPNYhSallHDhXul0As3EFFI0Gll9r01lpUaBxm1xoR9rJTDnR715Vc0IbzF QmB/YwJLHPkCwYFFXhI8iJJ6z8l3yAEANoEexGk+sQGBu5HN+zPgijQE2DnxHN/b7Mi/wtt1pB5GJ eZ4Syn5rDa+RT8f/UZtAVmic15hkyoL32+F1fpHX12N2YzfLVbSrftmJSWYmLZdik3TvJk7Ozb+E4 QRD2HJlTLEOkFLgnvYqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4cv6-002OY4-1C; Thu, 01 Jun 2023 07:40:28 +0000 Received: from mail-yb1-f173.google.com ([209.85.219.173]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4cv3-002OWw-2d; Thu, 01 Jun 2023 07:40:27 +0000 Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-b9a6eec8611so2796966276.0; Thu, 01 Jun 2023 00:40:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685605223; x=1688197223; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+Vy5gwXbACIYw+FA/+yi3OHDGD1kIURAtfeea/c7peI=; b=Og1BMkE+MdVNKGYR889UmaINLrKoVpqswfthtZva/a43xln1E7O8tSXxdS9QGmUy/C zLrCyuHaOXm38RhXjDQYr7bYjWObBKi+RvnZfR3IS+IpETutXH181gU9Jme9aGFDso0Q w4qAa1uBhXBoKbB17MQ0VMr+2a+3ZZRSIfZZeAjITIhWkrtCpCdPUXdUHOYdbrIQUeqq qoTWF/ALeXwB8FhUiVI3D8uT/U41Yklq9DszHM3jb28/km7r+Lj7DNK12pyoovIDiTgW AA17Fg616/DjG7iCPf/4OXWWXM0fqC+iSpiIMFD1U9rXEDxP2BpAEXy80lQoe3udG77w ikbg== X-Gm-Message-State: AC+VfDxkLB/gcpOd7PMn9MvE4PwagtOTBb1BUecZvoCuBg2idLfds5Zy gPkxsOHObApqqKqEsjjUtxbunNlf0GckmQ== X-Google-Smtp-Source: ACHHUZ4Fh46CkVkR2qVNo7i5ve8QHdHdiK/ASMK9WDk5k0+4ab/xjYPoSDXKratkbKUonYzA3+X+2w== X-Received: by 2002:a25:ce81:0:b0:ba7:a55f:9091 with SMTP id x123-20020a25ce81000000b00ba7a55f9091mr1234545ybe.6.1685605223575; Thu, 01 Jun 2023 00:40:23 -0700 (PDT) Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com. [209.85.219.180]) by smtp.gmail.com with ESMTPSA id m205-20020a2571d6000000b00ba87bc06fe5sm4803250ybc.52.2023.06.01.00.40.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 00:40:21 -0700 (PDT) Received: by mail-yb1-f180.google.com with SMTP id 3f1490d57ef6-ba8cd61ee2dso2770657276.1; Thu, 01 Jun 2023 00:40:21 -0700 (PDT) X-Received: by 2002:a81:a041:0:b0:565:9f61:c771 with SMTP id x62-20020a81a041000000b005659f61c771mr1176431ywg.9.1685605221248; Thu, 01 Jun 2023 00:40:21 -0700 (PDT) MIME-Version: 1.0 References: <20230531213032.25338-1-vishal.moola@gmail.com> <20230531213032.25338-26-vishal.moola@gmail.com> In-Reply-To: <20230531213032.25338-26-vishal.moola@gmail.com> From: Geert Uytterhoeven Date: Thu, 1 Jun 2023 09:40:07 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 25/34] m68k: Convert various functions to use ptdescs To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230601_004025_853284_85980B1A X-CRM114-Status: GOOD ( 22.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVmlzaGFsLAoKT24gV2VkLCBNYXkgMzEsIDIwMjMgYXQgMTE6MzLigK9QTSBWaXNoYWwgTW9v bGEgKE9yYWNsZSkKPHZpc2hhbC5tb29sYUBnbWFpbC5jb20+IHdyb3RlOgo+IEFzIHBhcnQgb2Yg dGhlIGNvbnZlcnNpb25zIHRvIHJlcGxhY2UgcGd0YWJsZSBjb25zdHJ1Y3Rvci9kZXN0cnVjdG9y cyB3aXRoCj4gcHRkZXNjIGVxdWl2YWxlbnRzLCBjb252ZXJ0IHZhcmlvdXMgcGFnZSB0YWJsZSBm dW5jdGlvbnMgdG8gdXNlIHB0ZGVzY3MuCj4KPiBTb21lIG9mIHRoZSBmdW5jdGlvbnMgdXNlIHRo ZSAqZ2V0KnBhZ2UqKCkgaGVscGVyIGZ1bmN0aW9ucy4gQ29udmVydAo+IHRoZXNlIHRvIHVzZSBw YWdldGFibGVfYWxsb2MoKSBhbmQgcHRkZXNjX2FkZHJlc3MoKSBpbnN0ZWFkIHRvIGhlbHAKPiBz dGFuZGFyZGl6ZSBwYWdlIHRhYmxlcyBmdXJ0aGVyLgo+Cj4gU2lnbmVkLW9mZi1ieTogVmlzaGFs IE1vb2xhIChPcmFjbGUpIDx2aXNoYWwubW9vbGFAZ21haWwuY29tPgoKVGhhbmtzIGZvciB5b3Vy IHBhdGNoIQoKPiAtLS0gYS9hcmNoL202OGsvaW5jbHVkZS9hc20vbWNmX3BnYWxsb2MuaAo+ICsr KyBiL2FyY2gvbTY4ay9pbmNsdWRlL2FzbS9tY2ZfcGdhbGxvYy5oCj4gQEAgLTcsMjAgKzcsMTkg QEAKPgo+ICBleHRlcm4gaW5saW5lIHZvaWQgcHRlX2ZyZWVfa2VybmVsKHN0cnVjdCBtbV9zdHJ1 Y3QgKm1tLCBwdGVfdCAqcHRlKQo+ICB7Cj4gLSAgICAgICBmcmVlX3BhZ2UoKHVuc2lnbmVkIGxv bmcpIHB0ZSk7Cj4gKyAgICAgICBwYWdldGFibGVfZnJlZSh2aXJ0X3RvX3B0ZGVzYyhwdGUpKTsK PiAgfQo+Cj4gIGV4dGVybiBjb25zdCBjaGFyIGJhZF9wbWRfc3RyaW5nW107Cj4KPiAgZXh0ZXJu IGlubGluZSBwdGVfdCAqcHRlX2FsbG9jX29uZV9rZXJuZWwoc3RydWN0IG1tX3N0cnVjdCAqbW0p Cj4gIHsKPiAtICAgICAgIHVuc2lnbmVkIGxvbmcgcGFnZSA9IF9fZ2V0X2ZyZWVfcGFnZShHRlBf RE1BKTsKPiArICAgICAgIHN0cnVjdCBwdGRlc2MgKnB0ZGVzYyA9IHBhZ2V0YWJsZV9hbGxvYyhH RlBfRE1BIHwgX19HRlBfWkVSTywgMCk7Cj4KPiAtICAgICAgIGlmICghcGFnZSkKPiArICAgICAg IGlmICghcHRkZXNjKQo+ICAgICAgICAgICAgICAgICByZXR1cm4gTlVMTDsKPgo+IC0gICAgICAg bWVtc2V0KCh2b2lkICopcGFnZSwgMCwgUEFHRV9TSVpFKTsKPiAtICAgICAgIHJldHVybiAocHRl X3QgKikgKHBhZ2UpOwo+ICsgICAgICAgcmV0dXJuIChwdGVfdCAqKSAocHRkZXNjX2FkZHJlc3Mo cHRkZXNjKSk7CgpObyBuZWVkIHRvIGNhc3QgInZvaWQgKiIgd2hlbiByZXR1cm5pbmcgYSBkaWZm ZXJlbnQgcG9pbnRlciB0eXBlLgoKPiAgfQo+Cj4gIGV4dGVybiBpbmxpbmUgcG1kX3QgKnBtZF9h bGxvY19rZXJuZWwocGdkX3QgKnBnZCwgdW5zaWduZWQgbG9uZyBhZGRyZXNzKQo+IEBAIC0zNSwz NiArMzQsMzYgQEAgZXh0ZXJuIGlubGluZSBwbWRfdCAqcG1kX2FsbG9jX2tlcm5lbChwZ2RfdCAq cGdkLCB1bnNpZ25lZCBsb25nIGFkZHJlc3MpCj4gIHN0YXRpYyBpbmxpbmUgdm9pZCBfX3B0ZV9m cmVlX3RsYihzdHJ1Y3QgbW11X2dhdGhlciAqdGxiLCBwZ3RhYmxlX3QgcGd0YWJsZSwKPiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBhZGRyZXNzKQo+ICB7 Cj4gLSAgICAgICBzdHJ1Y3QgcGFnZSAqcGFnZSA9IHZpcnRfdG9fcGFnZShwZ3RhYmxlKTsKPiAr ICAgICAgIHN0cnVjdCBwdGRlc2MgKnB0ZGVzYyA9IHZpcnRfdG9fcHRkZXNjKHBndGFibGUpOwo+ Cj4gLSAgICAgICBwZ3RhYmxlX3B0ZV9wYWdlX2R0b3IocGFnZSk7Cj4gLSAgICAgICBfX2ZyZWVf cGFnZShwYWdlKTsKPiArICAgICAgIHBhZ2V0YWJsZV9wdGVfZHRvcihwdGRlc2MpOwo+ICsgICAg ICAgcGFnZXRhYmxlX2ZyZWUocHRkZXNjKTsKPiAgfQo+Cj4gIHN0YXRpYyBpbmxpbmUgcGd0YWJs ZV90IHB0ZV9hbGxvY19vbmUoc3RydWN0IG1tX3N0cnVjdCAqbW0pCj4gIHsKPiAtICAgICAgIHN0 cnVjdCBwYWdlICpwYWdlID0gYWxsb2NfcGFnZXMoR0ZQX0RNQSwgMCk7Cj4gKyAgICAgICBzdHJ1 Y3QgcHRkZXNjICpwdGRlc2MgPSBwYWdldGFibGVfYWxsb2MoR0ZQX0RNQSwgMCk7Cj4gICAgICAg ICBwdGVfdCAqcHRlOwo+Cj4gLSAgICAgICBpZiAoIXBhZ2UpCj4gKyAgICAgICBpZiAoIXB0ZGVz YykKPiAgICAgICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4gLSAgICAgICBpZiAoIXBndGFibGVf cHRlX3BhZ2VfY3RvcihwYWdlKSkgewo+IC0gICAgICAgICAgICAgICBfX2ZyZWVfcGFnZShwYWdl KTsKPiArICAgICAgIGlmICghcGFnZXRhYmxlX3B0ZV9jdG9yKHB0ZGVzYykpIHsKPiArICAgICAg ICAgICAgICAgcGFnZXRhYmxlX2ZyZWUocHRkZXNjKTsKPiAgICAgICAgICAgICAgICAgcmV0dXJu IE5VTEw7Cj4gICAgICAgICB9Cj4KPiAtICAgICAgIHB0ZSA9IHBhZ2VfYWRkcmVzcyhwYWdlKTsK PiAtICAgICAgIGNsZWFyX3BhZ2UocHRlKTsKPiArICAgICAgIHB0ZSA9IHB0ZGVzY19hZGRyZXNz KHB0ZGVzYyk7Cj4gKyAgICAgICBwYWdldGFibGVfY2xlYXIocHRlKTsKPgo+ICAgICAgICAgcmV0 dXJuIHB0ZTsKPiAgfQo+Cj4gIHN0YXRpYyBpbmxpbmUgdm9pZCBwdGVfZnJlZShzdHJ1Y3QgbW1f c3RydWN0ICptbSwgcGd0YWJsZV90IHBndGFibGUpCj4gIHsKPiAtICAgICAgIHN0cnVjdCBwYWdl ICpwYWdlID0gdmlydF90b19wYWdlKHBndGFibGUpOwo+ICsgICAgICAgc3RydWN0IHB0ZGVzYyAq cHRkZXNjID0gdmlydF90b19wdGRlc2MocHRkZXNjKTsKCnZpcnRfdG9fcHRkZXNjKHBndGFibGUp CgooWW91IGNhbiBidWlsZCB0aGlzIHVzaW5nIG01NDc1ZXZiX2RlZmNvbmZpZykKCj4KPiAtICAg ICAgIHBndGFibGVfcHRlX3BhZ2VfZHRvcihwYWdlKTsKPiAtICAgICAgIF9fZnJlZV9wYWdlKHBh Z2UpOwo+ICsgICAgICAgcGFnZXRhYmxlX3B0ZV9kdG9yKHB0ZGVzYyk7Cj4gKyAgICAgICBwYWdl dGFibGVfZnJlZShwdGRlc2MpOwo+ICB9Cj4KPiAgLyoKPiBAQCAtNzUsMTYgKzc0LDE4IEBAIHN0 YXRpYyBpbmxpbmUgdm9pZCBwdGVfZnJlZShzdHJ1Y3QgbW1fc3RydWN0ICptbSwgcGd0YWJsZV90 IHBndGFibGUpCj4KPiAgc3RhdGljIGlubGluZSB2b2lkIHBnZF9mcmVlKHN0cnVjdCBtbV9zdHJ1 Y3QgKm1tLCBwZ2RfdCAqcGdkKQo+ICB7Cj4gLSAgICAgICBmcmVlX3BhZ2UoKHVuc2lnbmVkIGxv bmcpIHBnZCk7Cj4gKyAgICAgICBwYWdldGFibGVfZnJlZSh2aXJ0X3RvX3B0ZGVzYyhwZ2QpKTsK PiAgfQo+Cj4gIHN0YXRpYyBpbmxpbmUgcGdkX3QgKnBnZF9hbGxvYyhzdHJ1Y3QgbW1fc3RydWN0 ICptbSkKPiAgewo+ICAgICAgICAgcGdkX3QgKm5ld19wZ2Q7Cj4gKyAgICAgICBzdHJ1Y3QgcHRk ZXNjICpwdGRlc2MgPSBwYWdldGFibGVfYWxsb2MoR0ZQX0RNQSB8IEdGUF9OT1dBUk4sIDApOwo+ Cj4gLSAgICAgICBuZXdfcGdkID0gKHBnZF90ICopX19nZXRfZnJlZV9wYWdlKEdGUF9ETUEgfCBf X0dGUF9OT1dBUk4pOwo+IC0gICAgICAgaWYgKCFuZXdfcGdkKQo+ICsgICAgICAgaWYgKCFwdGRl c2MpCj4gICAgICAgICAgICAgICAgIHJldHVybiBOVUxMOwo+ICsgICAgICAgbmV3X3BnZCA9IChw Z2RfdCAqKSBwdGRlc2NfYWRkcmVzcyhwdGRlc2MpOwoKTm8gbmVlZCB0byBjYXN0ICJ2b2lkICoi IHdoZW4gYXNzaWduaW5nIHRvIGEgZGlmZmVyZW50IHBvaW50ZXIgdHlwZS4KCj4gKwo+ICAgICAg ICAgbWVtY3B5KG5ld19wZ2QsIHN3YXBwZXJfcGdfZGlyLCBQVFJTX1BFUl9QR0QgKiBzaXplb2Yo cGdkX3QpKTsKPiAgICAgICAgIG1lbXNldChuZXdfcGdkLCAwLCBQQUdFX09GRlNFVCA+PiBQR0RJ Ul9TSElGVCk7Cj4gICAgICAgICByZXR1cm4gbmV3X3BnZDsKClRoZSByZXN0IExHVE0uCgpHcntv ZXRqZSxlZXRpbmd9cywKCiAgICAgICAgICAgICAgICAgICAgICAgIEdlZXJ0CgotLSAKR2VlcnQg VXl0dGVyaG9ldmVuIC0tIFRoZXJlJ3MgbG90cyBvZiBMaW51eCBiZXlvbmQgaWEzMiAtLSBnZWVy dEBsaW51eC1tNjhrLm9yZwoKSW4gcGVyc29uYWwgY29udmVyc2F0aW9ucyB3aXRoIHRlY2huaWNh bCBwZW9wbGUsIEkgY2FsbCBteXNlbGYgYSBoYWNrZXIuIEJ1dAp3aGVuIEknbSB0YWxraW5nIHRv IGpvdXJuYWxpc3RzIEkganVzdCBzYXkgInByb2dyYW1tZXIiIG9yIHNvbWV0aGluZyBsaWtlIHRo YXQuCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLS0gTGludXMgVG9ydmFsZHMKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA4A9C77B7E for ; Thu, 1 Jun 2023 07:40:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YzpJISYKS4lDEQIU+xFmXPjuawpccnUOVKk0FP5LepU=; b=Z6hRPRF/bNI+QX 4ufS8tYvhAPv/rEleG9bva2m0jX1iIE//PjcYJdQWDUptDdzSo0Pj++aIRPl84MwxlEjh855BaJM1 X1KP5j+wyNJ4JRpi1lY9x8mlo9uHyPesMiTlHRQtOUAwrwoTZ26VedvqeXOkT/6hmqtEcDJLJxARy qRK9NTk5Z6X9PLtagggmpE4WyRQqiNM03+QTUVLEZdCjVl+cAY70fbeofsRs5sFpQAw0mj2YY99xx ZB8/wft95ePNC2P1mzJ3AM0t+yuQZ92bZDAzTtdP6JV9yn2Rg6fVEXiwDDRZgePFoz8moDVNhpXGg 91FrwgtdYjTxxalOMAMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4cv7-002OYa-1c; Thu, 01 Jun 2023 07:40:29 +0000 Received: from mail-yb1-f173.google.com ([209.85.219.173]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4cv3-002OWw-2d; Thu, 01 Jun 2023 07:40:27 +0000 Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-b9a6eec8611so2796966276.0; Thu, 01 Jun 2023 00:40:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685605223; x=1688197223; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+Vy5gwXbACIYw+FA/+yi3OHDGD1kIURAtfeea/c7peI=; b=Og1BMkE+MdVNKGYR889UmaINLrKoVpqswfthtZva/a43xln1E7O8tSXxdS9QGmUy/C zLrCyuHaOXm38RhXjDQYr7bYjWObBKi+RvnZfR3IS+IpETutXH181gU9Jme9aGFDso0Q w4qAa1uBhXBoKbB17MQ0VMr+2a+3ZZRSIfZZeAjITIhWkrtCpCdPUXdUHOYdbrIQUeqq qoTWF/ALeXwB8FhUiVI3D8uT/U41Yklq9DszHM3jb28/km7r+Lj7DNK12pyoovIDiTgW AA17Fg616/DjG7iCPf/4OXWWXM0fqC+iSpiIMFD1U9rXEDxP2BpAEXy80lQoe3udG77w ikbg== X-Gm-Message-State: AC+VfDxkLB/gcpOd7PMn9MvE4PwagtOTBb1BUecZvoCuBg2idLfds5Zy gPkxsOHObApqqKqEsjjUtxbunNlf0GckmQ== X-Google-Smtp-Source: ACHHUZ4Fh46CkVkR2qVNo7i5ve8QHdHdiK/ASMK9WDk5k0+4ab/xjYPoSDXKratkbKUonYzA3+X+2w== X-Received: by 2002:a25:ce81:0:b0:ba7:a55f:9091 with SMTP id x123-20020a25ce81000000b00ba7a55f9091mr1234545ybe.6.1685605223575; Thu, 01 Jun 2023 00:40:23 -0700 (PDT) Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com. [209.85.219.180]) by smtp.gmail.com with ESMTPSA id m205-20020a2571d6000000b00ba87bc06fe5sm4803250ybc.52.2023.06.01.00.40.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 00:40:21 -0700 (PDT) Received: by mail-yb1-f180.google.com with SMTP id 3f1490d57ef6-ba8cd61ee2dso2770657276.1; Thu, 01 Jun 2023 00:40:21 -0700 (PDT) X-Received: by 2002:a81:a041:0:b0:565:9f61:c771 with SMTP id x62-20020a81a041000000b005659f61c771mr1176431ywg.9.1685605221248; Thu, 01 Jun 2023 00:40:21 -0700 (PDT) MIME-Version: 1.0 References: <20230531213032.25338-1-vishal.moola@gmail.com> <20230531213032.25338-26-vishal.moola@gmail.com> In-Reply-To: <20230531213032.25338-26-vishal.moola@gmail.com> From: Geert Uytterhoeven Date: Thu, 1 Jun 2023 09:40:07 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 25/34] m68k: Convert various functions to use ptdescs To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230601_004025_853284_85980B1A X-CRM114-Status: GOOD ( 22.92 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org SGkgVmlzaGFsLAoKT24gV2VkLCBNYXkgMzEsIDIwMjMgYXQgMTE6MzLigK9QTSBWaXNoYWwgTW9v bGEgKE9yYWNsZSkKPHZpc2hhbC5tb29sYUBnbWFpbC5jb20+IHdyb3RlOgo+IEFzIHBhcnQgb2Yg dGhlIGNvbnZlcnNpb25zIHRvIHJlcGxhY2UgcGd0YWJsZSBjb25zdHJ1Y3Rvci9kZXN0cnVjdG9y cyB3aXRoCj4gcHRkZXNjIGVxdWl2YWxlbnRzLCBjb252ZXJ0IHZhcmlvdXMgcGFnZSB0YWJsZSBm dW5jdGlvbnMgdG8gdXNlIHB0ZGVzY3MuCj4KPiBTb21lIG9mIHRoZSBmdW5jdGlvbnMgdXNlIHRo ZSAqZ2V0KnBhZ2UqKCkgaGVscGVyIGZ1bmN0aW9ucy4gQ29udmVydAo+IHRoZXNlIHRvIHVzZSBw YWdldGFibGVfYWxsb2MoKSBhbmQgcHRkZXNjX2FkZHJlc3MoKSBpbnN0ZWFkIHRvIGhlbHAKPiBz dGFuZGFyZGl6ZSBwYWdlIHRhYmxlcyBmdXJ0aGVyLgo+Cj4gU2lnbmVkLW9mZi1ieTogVmlzaGFs IE1vb2xhIChPcmFjbGUpIDx2aXNoYWwubW9vbGFAZ21haWwuY29tPgoKVGhhbmtzIGZvciB5b3Vy IHBhdGNoIQoKPiAtLS0gYS9hcmNoL202OGsvaW5jbHVkZS9hc20vbWNmX3BnYWxsb2MuaAo+ICsr KyBiL2FyY2gvbTY4ay9pbmNsdWRlL2FzbS9tY2ZfcGdhbGxvYy5oCj4gQEAgLTcsMjAgKzcsMTkg QEAKPgo+ICBleHRlcm4gaW5saW5lIHZvaWQgcHRlX2ZyZWVfa2VybmVsKHN0cnVjdCBtbV9zdHJ1 Y3QgKm1tLCBwdGVfdCAqcHRlKQo+ICB7Cj4gLSAgICAgICBmcmVlX3BhZ2UoKHVuc2lnbmVkIGxv bmcpIHB0ZSk7Cj4gKyAgICAgICBwYWdldGFibGVfZnJlZSh2aXJ0X3RvX3B0ZGVzYyhwdGUpKTsK PiAgfQo+Cj4gIGV4dGVybiBjb25zdCBjaGFyIGJhZF9wbWRfc3RyaW5nW107Cj4KPiAgZXh0ZXJu IGlubGluZSBwdGVfdCAqcHRlX2FsbG9jX29uZV9rZXJuZWwoc3RydWN0IG1tX3N0cnVjdCAqbW0p Cj4gIHsKPiAtICAgICAgIHVuc2lnbmVkIGxvbmcgcGFnZSA9IF9fZ2V0X2ZyZWVfcGFnZShHRlBf RE1BKTsKPiArICAgICAgIHN0cnVjdCBwdGRlc2MgKnB0ZGVzYyA9IHBhZ2V0YWJsZV9hbGxvYyhH RlBfRE1BIHwgX19HRlBfWkVSTywgMCk7Cj4KPiAtICAgICAgIGlmICghcGFnZSkKPiArICAgICAg IGlmICghcHRkZXNjKQo+ICAgICAgICAgICAgICAgICByZXR1cm4gTlVMTDsKPgo+IC0gICAgICAg bWVtc2V0KCh2b2lkICopcGFnZSwgMCwgUEFHRV9TSVpFKTsKPiAtICAgICAgIHJldHVybiAocHRl X3QgKikgKHBhZ2UpOwo+ICsgICAgICAgcmV0dXJuIChwdGVfdCAqKSAocHRkZXNjX2FkZHJlc3Mo cHRkZXNjKSk7CgpObyBuZWVkIHRvIGNhc3QgInZvaWQgKiIgd2hlbiByZXR1cm5pbmcgYSBkaWZm ZXJlbnQgcG9pbnRlciB0eXBlLgoKPiAgfQo+Cj4gIGV4dGVybiBpbmxpbmUgcG1kX3QgKnBtZF9h bGxvY19rZXJuZWwocGdkX3QgKnBnZCwgdW5zaWduZWQgbG9uZyBhZGRyZXNzKQo+IEBAIC0zNSwz NiArMzQsMzYgQEAgZXh0ZXJuIGlubGluZSBwbWRfdCAqcG1kX2FsbG9jX2tlcm5lbChwZ2RfdCAq cGdkLCB1bnNpZ25lZCBsb25nIGFkZHJlc3MpCj4gIHN0YXRpYyBpbmxpbmUgdm9pZCBfX3B0ZV9m cmVlX3RsYihzdHJ1Y3QgbW11X2dhdGhlciAqdGxiLCBwZ3RhYmxlX3QgcGd0YWJsZSwKPiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBhZGRyZXNzKQo+ICB7 Cj4gLSAgICAgICBzdHJ1Y3QgcGFnZSAqcGFnZSA9IHZpcnRfdG9fcGFnZShwZ3RhYmxlKTsKPiAr ICAgICAgIHN0cnVjdCBwdGRlc2MgKnB0ZGVzYyA9IHZpcnRfdG9fcHRkZXNjKHBndGFibGUpOwo+ Cj4gLSAgICAgICBwZ3RhYmxlX3B0ZV9wYWdlX2R0b3IocGFnZSk7Cj4gLSAgICAgICBfX2ZyZWVf cGFnZShwYWdlKTsKPiArICAgICAgIHBhZ2V0YWJsZV9wdGVfZHRvcihwdGRlc2MpOwo+ICsgICAg ICAgcGFnZXRhYmxlX2ZyZWUocHRkZXNjKTsKPiAgfQo+Cj4gIHN0YXRpYyBpbmxpbmUgcGd0YWJs ZV90IHB0ZV9hbGxvY19vbmUoc3RydWN0IG1tX3N0cnVjdCAqbW0pCj4gIHsKPiAtICAgICAgIHN0 cnVjdCBwYWdlICpwYWdlID0gYWxsb2NfcGFnZXMoR0ZQX0RNQSwgMCk7Cj4gKyAgICAgICBzdHJ1 Y3QgcHRkZXNjICpwdGRlc2MgPSBwYWdldGFibGVfYWxsb2MoR0ZQX0RNQSwgMCk7Cj4gICAgICAg ICBwdGVfdCAqcHRlOwo+Cj4gLSAgICAgICBpZiAoIXBhZ2UpCj4gKyAgICAgICBpZiAoIXB0ZGVz YykKPiAgICAgICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4gLSAgICAgICBpZiAoIXBndGFibGVf cHRlX3BhZ2VfY3RvcihwYWdlKSkgewo+IC0gICAgICAgICAgICAgICBfX2ZyZWVfcGFnZShwYWdl KTsKPiArICAgICAgIGlmICghcGFnZXRhYmxlX3B0ZV9jdG9yKHB0ZGVzYykpIHsKPiArICAgICAg ICAgICAgICAgcGFnZXRhYmxlX2ZyZWUocHRkZXNjKTsKPiAgICAgICAgICAgICAgICAgcmV0dXJu IE5VTEw7Cj4gICAgICAgICB9Cj4KPiAtICAgICAgIHB0ZSA9IHBhZ2VfYWRkcmVzcyhwYWdlKTsK PiAtICAgICAgIGNsZWFyX3BhZ2UocHRlKTsKPiArICAgICAgIHB0ZSA9IHB0ZGVzY19hZGRyZXNz KHB0ZGVzYyk7Cj4gKyAgICAgICBwYWdldGFibGVfY2xlYXIocHRlKTsKPgo+ICAgICAgICAgcmV0 dXJuIHB0ZTsKPiAgfQo+Cj4gIHN0YXRpYyBpbmxpbmUgdm9pZCBwdGVfZnJlZShzdHJ1Y3QgbW1f c3RydWN0ICptbSwgcGd0YWJsZV90IHBndGFibGUpCj4gIHsKPiAtICAgICAgIHN0cnVjdCBwYWdl ICpwYWdlID0gdmlydF90b19wYWdlKHBndGFibGUpOwo+ICsgICAgICAgc3RydWN0IHB0ZGVzYyAq cHRkZXNjID0gdmlydF90b19wdGRlc2MocHRkZXNjKTsKCnZpcnRfdG9fcHRkZXNjKHBndGFibGUp CgooWW91IGNhbiBidWlsZCB0aGlzIHVzaW5nIG01NDc1ZXZiX2RlZmNvbmZpZykKCj4KPiAtICAg ICAgIHBndGFibGVfcHRlX3BhZ2VfZHRvcihwYWdlKTsKPiAtICAgICAgIF9fZnJlZV9wYWdlKHBh Z2UpOwo+ICsgICAgICAgcGFnZXRhYmxlX3B0ZV9kdG9yKHB0ZGVzYyk7Cj4gKyAgICAgICBwYWdl dGFibGVfZnJlZShwdGRlc2MpOwo+ICB9Cj4KPiAgLyoKPiBAQCAtNzUsMTYgKzc0LDE4IEBAIHN0 YXRpYyBpbmxpbmUgdm9pZCBwdGVfZnJlZShzdHJ1Y3QgbW1fc3RydWN0ICptbSwgcGd0YWJsZV90 IHBndGFibGUpCj4KPiAgc3RhdGljIGlubGluZSB2b2lkIHBnZF9mcmVlKHN0cnVjdCBtbV9zdHJ1 Y3QgKm1tLCBwZ2RfdCAqcGdkKQo+ICB7Cj4gLSAgICAgICBmcmVlX3BhZ2UoKHVuc2lnbmVkIGxv bmcpIHBnZCk7Cj4gKyAgICAgICBwYWdldGFibGVfZnJlZSh2aXJ0X3RvX3B0ZGVzYyhwZ2QpKTsK PiAgfQo+Cj4gIHN0YXRpYyBpbmxpbmUgcGdkX3QgKnBnZF9hbGxvYyhzdHJ1Y3QgbW1fc3RydWN0 ICptbSkKPiAgewo+ICAgICAgICAgcGdkX3QgKm5ld19wZ2Q7Cj4gKyAgICAgICBzdHJ1Y3QgcHRk ZXNjICpwdGRlc2MgPSBwYWdldGFibGVfYWxsb2MoR0ZQX0RNQSB8IEdGUF9OT1dBUk4sIDApOwo+ Cj4gLSAgICAgICBuZXdfcGdkID0gKHBnZF90ICopX19nZXRfZnJlZV9wYWdlKEdGUF9ETUEgfCBf X0dGUF9OT1dBUk4pOwo+IC0gICAgICAgaWYgKCFuZXdfcGdkKQo+ICsgICAgICAgaWYgKCFwdGRl c2MpCj4gICAgICAgICAgICAgICAgIHJldHVybiBOVUxMOwo+ICsgICAgICAgbmV3X3BnZCA9IChw Z2RfdCAqKSBwdGRlc2NfYWRkcmVzcyhwdGRlc2MpOwoKTm8gbmVlZCB0byBjYXN0ICJ2b2lkICoi IHdoZW4gYXNzaWduaW5nIHRvIGEgZGlmZmVyZW50IHBvaW50ZXIgdHlwZS4KCj4gKwo+ICAgICAg ICAgbWVtY3B5KG5ld19wZ2QsIHN3YXBwZXJfcGdfZGlyLCBQVFJTX1BFUl9QR0QgKiBzaXplb2Yo cGdkX3QpKTsKPiAgICAgICAgIG1lbXNldChuZXdfcGdkLCAwLCBQQUdFX09GRlNFVCA+PiBQR0RJ Ul9TSElGVCk7Cj4gICAgICAgICByZXR1cm4gbmV3X3BnZDsKClRoZSByZXN0IExHVE0uCgpHcntv ZXRqZSxlZXRpbmd9cywKCiAgICAgICAgICAgICAgICAgICAgICAgIEdlZXJ0CgotLSAKR2VlcnQg VXl0dGVyaG9ldmVuIC0tIFRoZXJlJ3MgbG90cyBvZiBMaW51eCBiZXlvbmQgaWEzMiAtLSBnZWVy dEBsaW51eC1tNjhrLm9yZwoKSW4gcGVyc29uYWwgY29udmVyc2F0aW9ucyB3aXRoIHRlY2huaWNh bCBwZW9wbGUsIEkgY2FsbCBteXNlbGYgYSBoYWNrZXIuIEJ1dAp3aGVuIEknbSB0YWxraW5nIHRv IGpvdXJuYWxpc3RzIEkganVzdCBzYXkgInByb2dyYW1tZXIiIG9yIHNvbWV0aGluZyBsaWtlIHRo YXQuCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLS0gTGludXMgVG9ydmFsZHMKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXVtIG1h aWxpbmcgbGlzdApsaW51eC11bUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtdW0K From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH v3 25/34] m68k: Convert various functions to use ptdescs Date: Thu, 1 Jun 2023 09:40:07 +0200 Message-ID: References: <20230531213032.25338-1-vishal.moola@gmail.com> <20230531213032.25338-26-vishal.moola@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: base64 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RLSsp/Gx5LyZDkeuJ6ltx+oDJgpCKVEiixkiFcXKg8I=; b=U/tH8emsqGoS9U V6zelfTtGRV3YN2WAg2rOmPcwRlVfS7QtRNglsV4WTrhbzE1X4xM1fyTqBk3Ou1qul80XKd8h4IyC AcvzHmzxXFgbWL0jUD+qdLhDhMrr9lSX9EW5MjtmTAny4Gy1lA4G/NNJBxjoYS3W19sHDeJlEsYB+ c3x49+qaZzMlaHhzYBuFLOAs9mkp8sD+CXRbJZZGXI8/9NZ2LGal38ROBDCS+aYcQHYtUiFNiaW8u CHMzmhJ1sWXyQu5JCWG+8jpw3O/gHFrp4sAgzlrk+4iENfUy6Vb+t8wOyq8AoB7k9ijTJ07McTBf2 pYSg6VBb/5k/gtk9MYwA==; In-Reply-To: <20230531213032.25338-26-vishal.moola@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+glpr-linux-riscv=m.gmane-mx.org@lists.infradead.org Content-Type: text/plain; charset="windows-1252" To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org SGkgVmlzaGFsLAoKT24gV2VkLCBNYXkgMzEsIDIwMjMgYXQgMTE6MzLigK9QTSBWaXNoYWwgTW9v bGEgKE9yYWNsZSkKPHZpc2hhbC5tb29sYUBnbWFpbC5jb20+IHdyb3RlOgo+IEFzIHBhcnQgb2Yg dGhlIGNvbnZlcnNpb25zIHRvIHJlcGxhY2UgcGd0YWJsZSBjb25zdHJ1Y3Rvci9kZXN0cnVjdG9y cyB3aXRoCj4gcHRkZXNjIGVxdWl2YWxlbnRzLCBjb252ZXJ0IHZhcmlvdXMgcGFnZSB0YWJsZSBm dW5jdGlvbnMgdG8gdXNlIHB0ZGVzY3MuCj4KPiBTb21lIG9mIHRoZSBmdW5jdGlvbnMgdXNlIHRo ZSAqZ2V0KnBhZ2UqKCkgaGVscGVyIGZ1bmN0aW9ucy4gQ29udmVydAo+IHRoZXNlIHRvIHVzZSBw YWdldGFibGVfYWxsb2MoKSBhbmQgcHRkZXNjX2FkZHJlc3MoKSBpbnN0ZWFkIHRvIGhlbHAKPiBz dGFuZGFyZGl6ZSBwYWdlIHRhYmxlcyBmdXJ0aGVyLgo+Cj4gU2lnbmVkLW9mZi1ieTogVmlzaGFs IE1vb2xhIChPcmFjbGUpIDx2aXNoYWwubW9vbGFAZ21haWwuY29tPgoKVGhhbmtzIGZvciB5b3Vy IHBhdGNoIQoKPiAtLS0gYS9hcmNoL202OGsvaW5jbHVkZS9hc20vbWNmX3BnYWxsb2MuaAo+ICsr KyBiL2FyY2gvbTY4ay9pbmNsdWRlL2FzbS9tY2ZfcGdhbGxvYy5oCj4gQEAgLTcsMjAgKzcsMTkg QEAKPgo+ICBleHRlcm4gaW5saW5lIHZvaWQgcHRlX2ZyZWVfa2VybmVsKHN0cnVjdCBtbV9zdHJ1 Y3QgKm1tLCBwdGVfdCAqcHRlKQo+ICB7Cj4gLSAgICAgICBmcmVlX3BhZ2UoKHVuc2lnbmVkIGxv bmcpIHB0ZSk7Cj4gKyAgICAgICBwYWdldGFibGVfZnJlZSh2aXJ0X3RvX3B0ZGVzYyhwdGUpKTsK PiAgfQo+Cj4gIGV4dGVybiBjb25zdCBjaGFyIGJhZF9wbWRfc3RyaW5nW107Cj4KPiAgZXh0ZXJu IGlubGluZSBwdGVfdCAqcHRlX2FsbG9jX29uZV9rZXJuZWwoc3RydWN0IG1tX3N0cnVjdCAqbW0p Cj4gIHsKPiAtICAgICAgIHVuc2lnbmVkIGxvbmcgcGFnZSA9IF9fZ2V0X2ZyZWVfcGFnZShHRlBf RE1BKTsKPiArICAgICAgIHN0cnVjdCBwdGRlc2MgKnB0ZGVzYyA9IHBhZ2V0YWJsZV9hbGxvYyhH RlBfRE1BIHwgX19HRlBfWkVSTywgMCk7Cj4KPiAtICAgICAgIGlmICghcGFnZSkKPiArICAgICAg IGlmICghcHRkZXNjKQo+ICAgICAgICAgICAgICAgICByZXR1cm4gTlVMTDsKPgo+IC0gICAgICAg bWVtc2V0KCh2b2lkICopcGFnZSwgMCwgUEFHRV9TSVpFKTsKPiAtICAgICAgIHJldHVybiAocHRl X3QgKikgKHBhZ2UpOwo+ICsgICAgICAgcmV0dXJuIChwdGVfdCAqKSAocHRkZXNjX2FkZHJlc3Mo cHRkZXNjKSk7CgpObyBuZWVkIHRvIGNhc3QgInZvaWQgKiIgd2hlbiByZXR1cm5pbmcgYSBkaWZm ZXJlbnQgcG9pbnRlciB0eXBlLgoKPiAgfQo+Cj4gIGV4dGVybiBpbmxpbmUgcG1kX3QgKnBtZF9h bGxvY19rZXJuZWwocGdkX3QgKnBnZCwgdW5zaWduZWQgbG9uZyBhZGRyZXNzKQo+IEBAIC0zNSwz NiArMzQsMzYgQEAgZXh0ZXJuIGlubGluZSBwbWRfdCAqcG1kX2FsbG9jX2tlcm5lbChwZ2RfdCAq cGdkLCB1bnNpZ25lZCBsb25nIGFkZHJlc3MpCj4gIHN0YXRpYyBpbmxpbmUgdm9pZCBfX3B0ZV9m cmVlX3RsYihzdHJ1Y3QgbW11X2dhdGhlciAqdGxiLCBwZ3RhYmxlX3QgcGd0YWJsZSwKPiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBhZGRyZXNzKQo+ICB7 Cj4gLSAgICAgICBzdHJ1Y3QgcGFnZSAqcGFnZSA9IHZpcnRfdG9fcGFnZShwZ3RhYmxlKTsKPiAr ICAgICAgIHN0cnVjdCBwdGRlc2MgKnB0ZGVzYyA9IHZpcnRfdG9fcHRkZXNjKHBndGFibGUpOwo+ Cj4gLSAgICAgICBwZ3RhYmxlX3B0ZV9wYWdlX2R0b3IocGFnZSk7Cj4gLSAgICAgICBfX2ZyZWVf cGFnZShwYWdlKTsKPiArICAgICAgIHBhZ2V0YWJsZV9wdGVfZHRvcihwdGRlc2MpOwo+ICsgICAg ICAgcGFnZXRhYmxlX2ZyZWUocHRkZXNjKTsKPiAgfQo+Cj4gIHN0YXRpYyBpbmxpbmUgcGd0YWJs ZV90IHB0ZV9hbGxvY19vbmUoc3RydWN0IG1tX3N0cnVjdCAqbW0pCj4gIHsKPiAtICAgICAgIHN0 cnVjdCBwYWdlICpwYWdlID0gYWxsb2NfcGFnZXMoR0ZQX0RNQSwgMCk7Cj4gKyAgICAgICBzdHJ1 Y3QgcHRkZXNjICpwdGRlc2MgPSBwYWdldGFibGVfYWxsb2MoR0ZQX0RNQSwgMCk7Cj4gICAgICAg ICBwdGVfdCAqcHRlOwo+Cj4gLSAgICAgICBpZiAoIXBhZ2UpCj4gKyAgICAgICBpZiAoIXB0ZGVz YykKPiAgICAgICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4gLSAgICAgICBpZiAoIXBndGFibGVf cHRlX3BhZ2VfY3RvcihwYWdlKSkgewo+IC0gICAgICAgICAgICAgICBfX2ZyZWVfcGFnZShwYWdl KTsKPiArICAgICAgIGlmICghcGFnZXRhYmxlX3B0ZV9jdG9yKHB0ZGVzYykpIHsKPiArICAgICAg ICAgICAgICAgcGFnZXRhYmxlX2ZyZWUocHRkZXNjKTsKPiAgICAgICAgICAgICAgICAgcmV0dXJu IE5VTEw7Cj4gICAgICAgICB9Cj4KPiAtICAgICAgIHB0ZSA9IHBhZ2VfYWRkcmVzcyhwYWdlKTsK PiAtICAgICAgIGNsZWFyX3BhZ2UocHRlKTsKPiArICAgICAgIHB0ZSA9IHB0ZGVzY19hZGRyZXNz KHB0ZGVzYyk7Cj4gKyAgICAgICBwYWdldGFibGVfY2xlYXIocHRlKTsKPgo+ICAgICAgICAgcmV0 dXJuIHB0ZTsKPiAgfQo+Cj4gIHN0YXRpYyBpbmxpbmUgdm9pZCBwdGVfZnJlZShzdHJ1Y3QgbW1f c3RydWN0ICptbSwgcGd0YWJsZV90IHBndGFibGUpCj4gIHsKPiAtICAgICAgIHN0cnVjdCBwYWdl ICpwYWdlID0gdmlydF90b19wYWdlKHBndGFibGUpOwo+ICsgICAgICAgc3RydWN0IHB0ZGVzYyAq cHRkZXNjID0gdmlydF90b19wdGRlc2MocHRkZXNjKTsKCnZpcnRfdG9fcHRkZXNjKHBndGFibGUp CgooWW91IGNhbiBidWlsZCB0aGlzIHVzaW5nIG01NDc1ZXZiX2RlZmNvbmZpZykKCj4KPiAtICAg ICAgIHBndGFibGVfcHRlX3BhZ2VfZHRvcihwYWdlKTsKPiAtICAgICAgIF9fZnJlZV9wYWdlKHBh Z2UpOwo+ICsgICAgICAgcGFnZXRhYmxlX3B0ZV9kdG9yKHB0ZGVzYyk7Cj4gKyAgICAgICBwYWdl dGFibGVfZnJlZShwdGRlc2MpOwo+ICB9Cj4KPiAgLyoKPiBAQCAtNzUsMTYgKzc0LDE4IEBAIHN0 YXRpYyBpbmxpbmUgdm9pZCBwdGVfZnJlZShzdHJ1Y3QgbW1fc3RydWN0ICptbSwgcGd0YWJsZV90 IHBndGFibGUpCj4KPiAgc3RhdGljIGlubGluZSB2b2lkIHBnZF9mcmVlKHN0cnVjdCBtbV9zdHJ1 Y3QgKm1tLCBwZ2RfdCAqcGdkKQo+ICB7Cj4gLSAgICAgICBmcmVlX3BhZ2UoKHVuc2lnbmVkIGxv bmcpIHBnZCk7Cj4gKyAgICAgICBwYWdldGFibGVfZnJlZSh2aXJ0X3RvX3B0ZGVzYyhwZ2QpKTsK PiAgfQo+Cj4gIHN0YXRpYyBpbmxpbmUgcGdkX3QgKnBnZF9hbGxvYyhzdHJ1Y3QgbW1fc3RydWN0 ICptbSkKPiAgewo+ICAgICAgICAgcGdkX3QgKm5ld19wZ2Q7Cj4gKyAgICAgICBzdHJ1Y3QgcHRk ZXNjICpwdGRlc2MgPSBwYWdldGFibGVfYWxsb2MoR0ZQX0RNQSB8IEdGUF9OT1dBUk4sIDApOwo+ Cj4gLSAgICAgICBuZXdfcGdkID0gKHBnZF90ICopX19nZXRfZnJlZV9wYWdlKEdGUF9ETUEgfCBf X0dGUF9OT1dBUk4pOwo+IC0gICAgICAgaWYgKCFuZXdfcGdkKQo+ICsgICAgICAgaWYgKCFwdGRl c2MpCj4gICAgICAgICAgICAgICAgIHJldHVybiBOVUxMOwo+ICsgICAgICAgbmV3X3BnZCA9IChw Z2RfdCAqKSBwdGRlc2NfYWRkcmVzcyhwdGRlc2MpOwoKTm8gbmVlZCB0byBjYXN0ICJ2b2lkICoi IHdoZW4gYXNzaWduaW5nIHRvIGEgZGlmZmVyZW50IHBvaW50ZXIgdHlwZS4KCj4gKwo+ICAgICAg ICAgbWVtY3B5KG5ld19wZ2QsIHN3YXBwZXJfcGdfZGlyLCBQVFJTX1BFUl9QR0QgKiBzaXplb2Yo cGdkX3QpKTsKPiAgICAgICAgIG1lbXNldChuZXdfcGdkLCAwLCBQQUdFX09GRlNFVCA+PiBQR0RJ Ul9TSElGVCk7Cj4gICAgICAgICByZXR1cm4gbmV3X3BnZDsKClRoZSByZXN0IExHVE0uCgpHcntv ZXRqZSxlZXRpbmd9cywKCiAgICAgICAgICAgICAgICAgICAgICAgIEdlZXJ0CgotLSAKR2VlcnQg VXl0dGVyaG9ldmVuIC0tIFRoZXJlJ3MgbG90cyBvZiBMaW51eCBiZXlvbmQgaWEzMiAtLSBnZWVy dEBsaW51eC1tNjhrLm9yZwoKSW4gcGVyc29uYWwgY29udmVyc2F0aW9ucyB3aXRoIHRlY2huaWNh bCBwZW9wbGUsIEkgY2FsbCBteXNlbGYgYSBoYWNrZXIuIEJ1dAp3aGVuIEknbSB0YWxraW5nIHRv IGpvdXJuYWxpc3RzIEkganVzdCBzYXkgInByb2dyYW1tZXIiIG9yIHNvbWV0aGluZyBsaWtlIHRo YXQuCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLS0gTGludXMgVG9ydmFsZHMKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2 IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK