All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: John Ogness <john.ogness@linutronix.de>
Cc: Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH next v3 07/15] printk: introduce CONSOLE_LOG_MAX for improved multi-line support
Date: Tue, 2 Mar 2021 14:54:45 +0100	[thread overview]
Message-ID: <CAMuHMdWDPjU1q6QnBJ2D7k4pt2XZyGMbKJuifTOb8SJB1uio7Q@mail.gmail.com> (raw)
In-Reply-To: <20210225202438.28985-8-john.ogness@linutronix.de>

Hi John,

On Thu, Feb 25, 2021 at 9:30 PM John Ogness <john.ogness@linutronix.de> wrote:
> Instead of using "LOG_LINE_MAX + PREFIX_MAX" for temporary buffer
> sizes, introduce CONSOLE_LOG_MAX. This represents the maximum size
> that is allowed to be printed to the console for a single record.
>
> Rather than setting CONSOLE_LOG_MAX to "LOG_LINE_MAX + PREFIX_MAX"
> (1024), increase it to 4096. With a larger buffer size, multi-line
> records that are nearly LOG_LINE_MAX in length will have a better
> chance of being fully printed. (When formatting a record for the
> console, each line of a multi-line record is prepended with a copy
> of the prefix.)
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
> Reviewed-by: Petr Mladek <pmladek@suse.com>

Thanks for your patch!

This increases kernel size by more than 3 KiB, which affects small
devices (e.g. SoCs with 10 MiB of SRAM inside).
Who is printing such long lines to the console?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2021-03-02 16:30 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 20:24 [PATCH next v3 00/15] printk: remove logbuf_lock John Ogness
2021-02-25 20:24 ` John Ogness
2021-02-25 20:24 ` John Ogness
2021-02-25 20:24 ` John Ogness
2021-02-25 20:24 ` [PATCH next v3 01/15] um: synchronize kmsg_dumper John Ogness
2021-02-25 20:24   ` John Ogness
2021-03-01 16:16   ` Petr Mladek
2021-03-01 16:16     ` Petr Mladek
2021-03-01 16:57     ` Petr Mladek
2021-03-01 16:57       ` Petr Mladek
2021-03-02  8:06       ` John Ogness
2021-03-02  8:06         ` John Ogness
2021-03-02 10:12         ` Petr Mladek
2021-03-02 10:12           ` Petr Mladek
2021-02-25 20:24 ` [PATCH next v3 02/15] mtd: mtdoops: " John Ogness
2021-02-25 20:24   ` John Ogness
2021-03-01 12:13   ` Petr Mladek
2021-03-01 12:13     ` Petr Mladek
2021-03-02 10:45     ` John Ogness
2021-03-02 10:45       ` John Ogness
2021-03-02 12:48       ` Petr Mladek
2021-03-02 12:48         ` Petr Mladek
2021-02-25 20:24 ` [PATCH next v3 03/15] printk: limit second loop of syslog_print_all John Ogness
2021-02-25 20:24 ` [PATCH next v3 04/15] printk: kmsg_dump: remove unused fields John Ogness
2021-02-25 20:24 ` [PATCH next v3 05/15] printk: refactor kmsg_dump_get_buffer() John Ogness
2021-02-25 20:24 ` [PATCH next v3 06/15] printk: consolidate kmsg_dump_get_buffer/syslog_print_all code John Ogness
2021-02-25 20:24 ` [PATCH next v3 07/15] printk: introduce CONSOLE_LOG_MAX for improved multi-line support John Ogness
2021-03-02 13:54   ` Geert Uytterhoeven [this message]
2021-03-02 13:58     ` Geert Uytterhoeven
2021-03-02 14:34       ` John Ogness
2021-02-25 20:24 ` [PATCH next v3 08/15] printk: use seqcount_latch for clear_seq John Ogness
2021-02-25 20:24 ` [PATCH next v3 09/15] printk: use atomic64_t for devkmsg_user.seq John Ogness
2021-02-25 20:24 ` [PATCH next v3 10/15] printk: add syslog_lock John Ogness
2021-03-01 17:07   ` Petr Mladek
2021-02-25 20:24 ` [PATCH next v3 11/15] printk: kmsg_dumper: remove @active field John Ogness
2021-02-25 20:24   ` John Ogness
2021-03-01 17:09   ` Petr Mladek
2021-03-01 17:09     ` Petr Mladek
2021-02-25 20:24 ` [PATCH next v3 12/15] printk: introduce a kmsg_dump iterator John Ogness
2021-02-25 20:24   ` John Ogness
2021-02-25 20:24   ` John Ogness
2021-02-25 20:24   ` John Ogness
2021-02-25 21:59   ` Kees Cook
2021-02-25 21:59     ` Kees Cook
2021-02-25 21:59     ` Kees Cook
2021-02-26  2:57   ` kernel test robot
2021-02-26  7:59   ` John Ogness
2021-02-26  7:59     ` John Ogness
2021-02-26  7:59     ` John Ogness
2021-02-26  7:59     ` John Ogness
2021-02-26  7:59     ` John Ogness
2021-03-01 18:07   ` Petr Mladek
2021-03-01 18:07     ` Petr Mladek
2021-03-01 18:07     ` Petr Mladek
2021-03-01 18:07     ` Petr Mladek
2021-03-02 13:20     ` John Ogness
2021-03-02 13:20       ` John Ogness
2021-03-02 13:20       ` John Ogness
2021-03-02 13:55       ` Petr Mladek
2021-03-02 13:55         ` Petr Mladek
2021-03-02 13:55         ` Petr Mladek
2021-02-25 20:24 ` [PATCH next v3 13/15] printk: remove logbuf_lock John Ogness
2021-03-02 12:15   ` Petr Mladek
2021-02-25 20:24 ` [PATCH next v3 14/15] printk: kmsg_dump: remove _nolock() variants John Ogness
2021-02-25 20:24   ` John Ogness
2021-02-25 20:24 ` [PATCH next v3 15/15] printk: console: remove unnecessary safe buffer usage John Ogness

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdWDPjU1q6QnBJ2D7k4pt2XZyGMbKJuifTOb8SJB1uio7Q@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.