From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Sun, 13 Dec 2015 10:58:32 +0000 Subject: Re: [PATCH 07/10] drivers/pci: make host/pcie-rcar.c explicitly non-modular Message-Id: List-Id: References: <1449970917-12633-1-git-send-email-paul.gortmaker@windriver.com> <1449970917-12633-8-git-send-email-paul.gortmaker@windriver.com> In-Reply-To: <1449970917-12633-8-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paul Gortmaker , Phil Edworthy Cc: "linux-kernel@vger.kernel.org" , Simon Horman , Bjorn Helgaas , linux-pci , Linux-sh list CC MODULE_AUTHOR On Sun, Dec 13, 2015 at 2:41 AM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/pci/host/Kconfig:config PCI_RCAR_GEN2_PCIE > drivers/pci/host/Kconfig: bool "Renesas R-Car PCIe controller" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > We don't have to disallow a driver unbind, since that is already > done for us in this driver. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > was (or is now) contained at the top of the file in the comments. > > Cc: Simon Horman > Cc: Bjorn Helgaas > Cc: linux-pci@vger.kernel.org > Cc: linux-sh@vger.kernel.org > Signed-off-by: Paul Gortmaker > --- > drivers/pci/host/pcie-rcar.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c > index f4fa6c537448..2c619277d265 100644 > --- a/drivers/pci/host/pcie-rcar.c > +++ b/drivers/pci/host/pcie-rcar.c > @@ -7,6 +7,8 @@ > * arch/sh/drivers/pci/ops-sh7786.c > * Copyright (C) 2009 - 2011 Paul Mundt > * > + * Module Author: Phil Edworthy > + * > * This file is licensed under the terms of the GNU General Public > * License version 2. This program is licensed "as is" without any > * warranty of any kind, whether express or implied. > @@ -18,7 +20,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > #include > @@ -921,7 +923,6 @@ static const struct of_device_id rcar_pcie_of_match[] = { > { .compatible = "renesas,pcie-r8a7791", .data = rcar_pcie_hw_init }, > {}, > }; > -MODULE_DEVICE_TABLE(of, rcar_pcie_of_match); > > static int rcar_pcie_probe(struct platform_device *pdev) > { > @@ -1007,8 +1008,4 @@ static struct platform_driver rcar_pcie_driver = { > }, > .probe = rcar_pcie_probe, > }; > -module_platform_driver(rcar_pcie_driver); > - > -MODULE_AUTHOR("Phil Edworthy "); > -MODULE_DESCRIPTION("Renesas R-Car PCIe driver"); > -MODULE_LICENSE("GPL v2"); > +builtin_platform_driver(rcar_pcie_driver); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751802AbbLMK6f (ORCPT ); Sun, 13 Dec 2015 05:58:35 -0500 Received: from mail-ob0-f170.google.com ([209.85.214.170]:33031 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbbLMK6d (ORCPT ); Sun, 13 Dec 2015 05:58:33 -0500 MIME-Version: 1.0 In-Reply-To: <1449970917-12633-8-git-send-email-paul.gortmaker@windriver.com> References: <1449970917-12633-1-git-send-email-paul.gortmaker@windriver.com> <1449970917-12633-8-git-send-email-paul.gortmaker@windriver.com> Date: Sun, 13 Dec 2015 11:58:32 +0100 X-Google-Sender-Auth: w6p7eoxg-cuyUnhLTojONC4kVVI Message-ID: Subject: Re: [PATCH 07/10] drivers/pci: make host/pcie-rcar.c explicitly non-modular From: Geert Uytterhoeven To: Paul Gortmaker , Phil Edworthy Cc: "linux-kernel@vger.kernel.org" , Simon Horman , Bjorn Helgaas , linux-pci , Linux-sh list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CC MODULE_AUTHOR On Sun, Dec 13, 2015 at 2:41 AM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/pci/host/Kconfig:config PCI_RCAR_GEN2_PCIE > drivers/pci/host/Kconfig: bool "Renesas R-Car PCIe controller" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > We don't have to disallow a driver unbind, since that is already > done for us in this driver. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > was (or is now) contained at the top of the file in the comments. > > Cc: Simon Horman > Cc: Bjorn Helgaas > Cc: linux-pci@vger.kernel.org > Cc: linux-sh@vger.kernel.org > Signed-off-by: Paul Gortmaker > --- > drivers/pci/host/pcie-rcar.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c > index f4fa6c537448..2c619277d265 100644 > --- a/drivers/pci/host/pcie-rcar.c > +++ b/drivers/pci/host/pcie-rcar.c > @@ -7,6 +7,8 @@ > * arch/sh/drivers/pci/ops-sh7786.c > * Copyright (C) 2009 - 2011 Paul Mundt > * > + * Module Author: Phil Edworthy > + * > * This file is licensed under the terms of the GNU General Public > * License version 2. This program is licensed "as is" without any > * warranty of any kind, whether express or implied. > @@ -18,7 +20,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > #include > @@ -921,7 +923,6 @@ static const struct of_device_id rcar_pcie_of_match[] = { > { .compatible = "renesas,pcie-r8a7791", .data = rcar_pcie_hw_init }, > {}, > }; > -MODULE_DEVICE_TABLE(of, rcar_pcie_of_match); > > static int rcar_pcie_probe(struct platform_device *pdev) > { > @@ -1007,8 +1008,4 @@ static struct platform_driver rcar_pcie_driver = { > }, > .probe = rcar_pcie_probe, > }; > -module_platform_driver(rcar_pcie_driver); > - > -MODULE_AUTHOR("Phil Edworthy "); > -MODULE_DESCRIPTION("Renesas R-Car PCIe driver"); > -MODULE_LICENSE("GPL v2"); > +builtin_platform_driver(rcar_pcie_driver); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds