From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add CAN-FD support Date: Fri, 4 May 2018 09:52:38 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sergei Shtylyov Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Magnus Damm , Catalin Marinas , Will Deacon , Rob Herring , Linux-Renesas , Simon Horman , Linux ARM List-Id: devicetree@vger.kernel.org Hi Sergei, On Fri, Apr 27, 2018 at 9:12 PM, Sergei Shtylyov wrote: > Define the generic R8A77980 part of the CAN-FD device node. > > Based on the original (and large) patch by Vladimir Barinov. > > Signed-off-by: Vladimir Barinov > Signed-off-by: Sergei Shtylyov Thanks for your patch! > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi = > @@ -170,6 +177,30 @@ > status = "disabled"; > }; > > + canfd: can@e66c0000 { > + compatible = "renesas,r8a77980-canfd", > + "renesas,rcar-gen3-canfd"; > + reg = <0 0xe66c0000 0 0x8000>; > + interrupts = , > + ; > + clocks = <&cpg CPG_MOD 914>, > + <&cpg CPG_CORE R8A77980_CLK_CANFD>, > + <&can_clk>; > + clock-names = "fck", "canfd", "can_clk"; > + assigned-clocks = <&cpg CPG_CORE R8A77980_CLK_CANFD>; > + assigned-clock-rates = <40000000>; > + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; You forgot the resets property. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f195.google.com ([209.85.217.195]:40514 "EHLO mail-ua0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbeEDHwk (ORCPT ); Fri, 4 May 2018 03:52:40 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Geert Uytterhoeven Date: Fri, 4 May 2018 09:52:38 +0200 Message-ID: Subject: Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add CAN-FD support To: Sergei Shtylyov Cc: Simon Horman , Rob Herring , Catalin Marinas , Will Deacon , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Magnus Damm , Mark Rutland , Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Sergei, On Fri, Apr 27, 2018 at 9:12 PM, Sergei Shtylyov wrote: > Define the generic R8A77980 part of the CAN-FD device node. > > Based on the original (and large) patch by Vladimir Barinov. > > Signed-off-by: Vladimir Barinov > Signed-off-by: Sergei Shtylyov Thanks for your patch! > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi = > @@ -170,6 +177,30 @@ > status = "disabled"; > }; > > + canfd: can@e66c0000 { > + compatible = "renesas,r8a77980-canfd", > + "renesas,rcar-gen3-canfd"; > + reg = <0 0xe66c0000 0 0x8000>; > + interrupts = , > + ; > + clocks = <&cpg CPG_MOD 914>, > + <&cpg CPG_CORE R8A77980_CLK_CANFD>, > + <&can_clk>; > + clock-names = "fck", "canfd", "can_clk"; > + assigned-clocks = <&cpg CPG_CORE R8A77980_CLK_CANFD>; > + assigned-clock-rates = <40000000>; > + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; You forgot the resets property. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: geert@linux-m68k.org (Geert Uytterhoeven) Date: Fri, 4 May 2018 09:52:38 +0200 Subject: [PATCH 1/2] arm64: dts: renesas: r8a77980: add CAN-FD support In-Reply-To: References: Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Sergei, On Fri, Apr 27, 2018 at 9:12 PM, Sergei Shtylyov wrote: > Define the generic R8A77980 part of the CAN-FD device node. > > Based on the original (and large) patch by Vladimir Barinov. > > Signed-off-by: Vladimir Barinov > Signed-off-by: Sergei Shtylyov Thanks for your patch! > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi = > @@ -170,6 +177,30 @@ > status = "disabled"; > }; > > + canfd: can at e66c0000 { > + compatible = "renesas,r8a77980-canfd", > + "renesas,rcar-gen3-canfd"; > + reg = <0 0xe66c0000 0 0x8000>; > + interrupts = , > + ; > + clocks = <&cpg CPG_MOD 914>, > + <&cpg CPG_CORE R8A77980_CLK_CANFD>, > + <&can_clk>; > + clock-names = "fck", "canfd", "can_clk"; > + assigned-clocks = <&cpg CPG_CORE R8A77980_CLK_CANFD>; > + assigned-clock-rates = <40000000>; > + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; You forgot the resets property. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds