From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83A93C433E7 for ; Wed, 15 Jul 2020 15:37:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E82C20672 for ; Wed, 15 Jul 2020 15:37:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726780AbgGOPhv (ORCPT ); Wed, 15 Jul 2020 11:37:51 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:38362 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726776AbgGOPhv (ORCPT ); Wed, 15 Jul 2020 11:37:51 -0400 Received: by mail-oi1-f196.google.com with SMTP id r8so2528421oij.5; Wed, 15 Jul 2020 08:37:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I8Y+iMIBLic68sY07uOSY3D6Exe00WfEOasrAyuGf+s=; b=R5R4eTBNNnULPKEihChFTlXSD6YrdiulPQmVnRnj+vWhmeMXYrXRqEG+ELNrSjgPoy 1Hp3uPM0zE8cB68YNXTGuXSNqAKSZU7HMuJZVk2Z1CPKlCnLEtLegMP69Z84h+/M6tTO LupIF3AkeWCDUL2jdYK2HxrOIpzoZ7wJs5D9LJhjv8ES9++UoWv8c7UEwj+YgKHefVsA 14Gwvsku/EnHZpRd1kn0HJUS/pjinvX0cBb/upw+JJ6K12Y1h9n+FOELkqNuLFYk25cD MeFWDsxzpXBKWhLXLdGNqo6rNkOGpKbp4vuggxv2sSYyyVaI44Tp/YYf1W+FVFx6xZ63 wtwA== X-Gm-Message-State: AOAM530dVXiYHHcQy0jetW+CBrXdCULVZ8xJEm1EmASjyZQw0ENZl8AH HZYKBWbNuSZnOwBniSEMjd1tGNuqrk/W879Pcqz+h6/C X-Google-Smtp-Source: ABdhPJwtSILuH3tg5zL3hnRRNwNcfF1BCTz0ZqeqvqknIQPVE78txAnKpBzVTonE0yDuNLifqFhnvTOvFPe5ntBqUoc= X-Received: by 2002:aca:ac10:: with SMTP id v16mr217670oie.153.1594827469906; Wed, 15 Jul 2020 08:37:49 -0700 (PDT) MIME-Version: 1.0 References: <1567584941-13690-1-git-send-email-biju.das@bp.renesas.com> <1567584941-13690-2-git-send-email-biju.das@bp.renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 15 Jul 2020 17:37:38 +0200 Message-ID: Subject: Re: [PATCH RESEND v7 1/3] dt-bindings: usb: hd3ss3220 device tree binding document To: Biju Das Cc: Biju Das , Prabhakar Mahadev Lad , Rob Herring , Mark Rutland , Yoshihiro Shimoda , Greg Kroah-Hartman , Heikki Krogerus , Felipe Balbi , USB list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Simon Horman , Geert Uytterhoeven , Chris Paterson , Fabrizio Castro , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Biju, On Wed, Jul 15, 2020 at 1:42 PM Biju Das wrote: > > Subject: Re: [PATCH RESEND v7 1/3] dt-bindings: usb: hd3ss3220 device tree > > binding document > > > > On Wed, Sep 4, 2019 at 10:22 AM Biju Das > > wrote: > > > Add device tree binding document for TI HD3SS3220 Type-C DRP port > > > controller driver. > > > > > > Signed-off-by: Biju Das > > > Reviewed-by: Rob Herring > > > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/usb/ti,hd3ss3220.txt > > > @@ -0,0 +1,38 @@ > > > +TI HD3SS3220 TypeC DRP Port Controller. > > > + > > > +Required properties: > > > + - compatible: Must be "ti,hd3ss3220". > > > + - reg: I2C slave address, must be 0x47 or 0x67 based on ADDR pin. > > > + - interrupts: An interrupt specifier. > > > + > > > +Required sub-node: > > > + - connector: The "usb-c-connector" attached to the hd3ss3220 chip. The > > > + bindings of the connector node are specified in: > > > + > > > + Documentation/devicetree/bindings/connector/usb-connector.txt > > > + > > > +Example: > > > +hd3ss3220@47 { > > > + compatible = "ti,hd3ss3220"; > > > + reg = <0x47>; > > > + interrupt-parent = <&gpio6>; > > > + interrupts = <3 IRQ_TYPE_LEVEL_LOW>; > > > + > > > + connector { > > > + compatible = "usb-c-connector"; > > > + label = "USB-C"; > > > + data-role = "dual"; > > > + > > > + ports { > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + port@1 { > > > > This does not comply with > > Documentation/devicetree/bindings/connector/usb-connector.yaml: > > > > connector: ports: 'port@0' is a required property > > But in RZ/G2E case, the connector is a SS capable connector. May be we need to update required property > as port@0 or port@1? Please let me know > > - required: > - - port@0 > + anyOf: > + - required: > + - port@0 > + - required: > + - port@1 May make sense. I'd like to defer to the USB experts, though. > > > + reg = <1>; > > > + hd3ss3220_ep: endpoint { > > > + remote-endpoint = <&usb3_role_switch>; > > > + }; > > > + }; > > > + }; > > > + }; > > > +}; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds