From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72C45CA9EBC for ; Fri, 25 Oct 2019 08:57:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5503021D71 for ; Fri, 25 Oct 2019 08:57:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438180AbfJYI5s (ORCPT ); Fri, 25 Oct 2019 04:57:48 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:35066 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726120AbfJYI5s (ORCPT ); Fri, 25 Oct 2019 04:57:48 -0400 Received: by mail-ot1-f67.google.com with SMTP id z6so1526366otb.2; Fri, 25 Oct 2019 01:57:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hNHqqS4Uc9aqlwR5IUsahyveCLTdtc01wm1P+k/r7h0=; b=uOH5WMqc0j/GBrfMhauo4B5kZSMX6KMnz0uJSYZZcc0i5RSUN73uGrYC0/Q/F21lyQ bOSBMDYd+OJFR/MMyYCONd+5cnzaYqqVWxXMtX3Smz/morDlG2SzXwTE9I/4sCA4L2ti MH/K8/4ucucscwF4oAx0KGfEZqRgTGg5kZ0G5L9cxjJIWfa1O9CE47/KBclZ7RNNe30D mM1hbIAexEbW6op8EsNBesfpF5+MF1ttj/F87P+9KSJM6pARV/AVnWcawmWnNRVCX3Xi 3JJUzHC+Rpiyxg4U2GIKVjOFGkYulR1WpIqRtDE7NNjWGD4BVEH46pNmMC7UPpXpMMeX LN2w== X-Gm-Message-State: APjAAAX1puTDH4ezYay+BE+FfBAsU87o3A2q7lCQN1Pa/nNowpDSDbr6 uRJiMqmcUb11GVdcTVSreFRNSs8XSIt0sqfvHPw= X-Google-Smtp-Source: APXvYqwXZ5hSYo/AaHShqXVhnQPKDDrnniy5ZvaPofKAgeVdRshvXovvQWZivoZJvC/1yJ44x0fPG9nRDYpCtv3h8RQ= X-Received: by 2002:a05:6830:1bc3:: with SMTP id v3mr951363ota.145.1571993865998; Fri, 25 Oct 2019 01:57:45 -0700 (PDT) MIME-Version: 1.0 References: <1571915821-1620-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1571915821-1620-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 25 Oct 2019 10:57:34 +0200 Message-ID: Subject: Re: [PATCH 2/3] clk: renesas: rcar-usb2-clock-sel: Add multiple clocks management To: Yoshihiro Shimoda Cc: Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Geert Uytterhoeven , linux-clk , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Shimoda-san, On Fri, Oct 25, 2019 at 10:44 AM Yoshihiro Shimoda wrote: > > From: Geert Uytterhoeven, Sent: Friday, October 25, 2019 4:47 PM > > On Fri, Oct 25, 2019 at 3:36 AM Yoshihiro Shimoda > > wrote: > > > > From: Geert Uytterhoeven, Sent: Thursday, October 24, 2019 8:35 PM > > > > > > > > --- a/drivers/clk/renesas/rcar-usb2-clock-sel.c > > > > > +++ b/drivers/clk/renesas/rcar-usb2-clock-sel.c > > > > > > > @@ -131,6 +156,14 @@ static int rcar_usb2_clock_sel_probe(struct platform_device *pdev) > > > > > pm_runtime_enable(dev); > > > > > pm_runtime_get_sync(dev); > > > > > > > > pm_runtime_get_sync() will have already enabled the first module clock listed in > > > > the DT "clocks" property. > > > > > > > > If you want the driver to manage all clocks itself, perhaps the PM Runtime > > > > calls should be dropped? > > > > > > I'm thinking PM Runtime calls are related to power domain control so that we cannot > > > drop it. Or, since the hardware is the Always-on domain, can we drop it anyway? > > > > That's right: if the hardware block ever ends up in a non-always-on > > power domain, > > you won't have a choice but to use PM Runtime. > > So, should I keep the PM Runtime calls? I think they're good to have. Just make sure the PM Runtime status matches the state of the other clocks. > # In such the case, I should add to describe power-domains property into > # the dt-binding doc though :) Indeed. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds